Joel Einbinder
7528f5f309
DevTools: Give argument hints for native function without names
...
Some native functions don't have names in their toString, so now
we use the identifier the user typed in as a fallback.
Change-Id: I79ad4e630a39ff23a109485ea5afded9d660d54e
Reviewed-on: https://chromium-review.googlesource.com/1063037
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org >
Commit-Queue: Joel Einbinder <einbinder@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#559392}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8c78c1f97014e7e249a522342890f0b9fbc2efba
2018-05-17 01:47:03 +00:00
Joel Einbinder
3f23eb2bdd
DevTools: Argument hints for native functions
...
Change-Id: Ia0e9f3c98735d64a1188b4373c90b7ef2684ea48
Reviewed-on: https://chromium-review.googlesource.com/1054582
Commit-Queue: Joel Einbinder <einbinder@chromium.org >
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org >
Reviewed-by: Erik Luo <luoe@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#558527}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a5be1a79f122d4496aa4a09ddfad0b475d878248
2018-05-14 23:27:51 +00:00
Joel Einbinder
2fc0fb7ea3
DevTools: Give argument hints in the console prompt
...
https://i.imgur.com/Y3OlPM2.png
Change-Id: Ic1d9ef1d47ff93ce77bfc3ae7173689bccf0cb2c
Reviewed-on: https://chromium-review.googlesource.com/1031096
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org >
Commit-Queue: Joel Einbinder <einbinder@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#557030}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 66bdf19b13c9a1dffbd47121101e0b8aedde3495
2018-05-09 00:43:10 +00:00
Erik Luo
ca67a057a0
Revert "DevTools: use autocomplete's possibleSideEffect to bypass throwOnSideEffect"
...
This reverts commit fcaafdd756b1aef4f8244474e37be9ee12c75284.
Reason for revert: we'd like to be more strict about side effects
Original change's description:
> DevTools: use autocomplete's possibleSideEffect to bypass throwOnSideEffect
>
> Allow Console to evaluate without throwOnSideEffect when the entire
> expression meets the same strict conditions used by JSAutocomplete.
>
> Bug: 810176
> Change-Id: If5c80250cd75d81eec1e495d0414903213fac930
> Reviewed-on: https://chromium-review.googlesource.com/1028934
> Commit-Queue: Erik Luo <luoe@chromium.org >
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org >
> Reviewed-by: Joel Einbinder <einbinder@chromium.org >
> Cr-Commit-Position: refs/heads/master@{#555142}
TBR=dgozman@chromium.org ,einbinder@chromium.org ,luoe@chromium.org
Change-Id: Iec31996445e98945a0a9a9b67e572d17bafdcbeb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 810176
Reviewed-on: https://chromium-review.googlesource.com/1039063
Reviewed-by: Erik Luo <luoe@chromium.org >
Commit-Queue: Erik Luo <luoe@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#555269}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 67c4b089fbb62cc5986b98129dadfab5f69fcc97
2018-05-02 01:16:09 +00:00
Erik Luo
2c8ab81db7
DevTools: use autocomplete's possibleSideEffect to bypass throwOnSideEffect
...
Allow Console to evaluate without throwOnSideEffect when the entire
expression meets the same strict conditions used by JSAutocomplete.
Bug: 810176
Change-Id: If5c80250cd75d81eec1e495d0414903213fac930
Reviewed-on: https://chromium-review.googlesource.com/1028934
Commit-Queue: Erik Luo <luoe@chromium.org >
Reviewed-by: Dmitry Gozman <dgozman@chromium.org >
Reviewed-by: Joel Einbinder <einbinder@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#555142}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fcaafdd756b1aef4f8244474e37be9ee12c75284
2018-05-01 19:26:52 +00:00
Joel Einbinder
e0dcbceb5a
DevTools: Use throwOnSideEffects in console autocomplete
...
This lets us give suggestions for expressions like: ({abc: 4 + 3}).
Change-Id: Ia46b2eadb7725753408eb694414344075d00153e
Reviewed-on: https://chromium-review.googlesource.com/1014308
Commit-Queue: Joel Einbinder <einbinder@chromium.org >
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#552547}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 00226e5a08d7c0d45e972668f5e9cb5b8911836d
2018-04-21 01:49:53 +00:00
Blink Reformat
4c46d0969f
The Great Blink mv for source files, part 2.
...
Move and rename files.
NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true
Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org >
Commit-Queue: Blink Reformat <blink-reformat@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00
Joel Einbinder
