- Collect DOM storages from all targets.
- Instantiate InspectorDOMStorage agent for local roots, make
it work with InspectedFrames.
- Add a test which dumps storage security origins.
- Do some origin checks on the frontend to avoid listing
"opaque" security origins which do not support storage.
- Check storage capabilities on the backend to avoid
crasing renderer later.
Bug: 850978, 844377
Change-Id: Ib4e2b444473638d896eb716fb7d9c587f5560335
Reviewed-on: https://chromium-review.googlesource.com/1096283
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#567024}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1600a1f6c38cc1e3e56d6ad5b48ca88f01ea8ab2
Previously CSS that was not correctly parsed would not appear in the
styles sidebar. If a mistake was made when editing CSS in the sidebar,
the property being edited could dissapear because it would no longer
be parsed correctly.
Bug: 813435
Change-Id: I20cb6b1e977545693c3f75171479d8e9041d83d9
Reviewed-on: https://chromium-review.googlesource.com/1089295
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#566196}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e328358f9e11cda5257454afba56dd2a7cd0b72
Due to recent changes in the behavior of Array.p.sort, it seems that
some devtools layout tests became flaky.
Making the timestamp sorting stable seems (emperically) to fix or at
least improve the flakiness.
Change-Id: Ife60b893d0bcb230301dce01f504b46eff9d43cf
Reviewed-on: https://chromium-review.googlesource.com/1092470
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Simon Zünd <szuend@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#565938}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e417adddd3d5ab324aa8f11fd11e46df835ef198
There's an extra timestamp was added to the timestamps array so we can
easily calculate deltas from the timestamps.
However that happens before it performs CPUProfileDataModel._sortSamples
which once timestamps happen to be not sorted starts reordering both
timestamps and samples arrays. That sometimes causes last timestamp
item to be moved along with a missing value in samples array
somewhere in the middle effectively adding an extra 'undefined' item
to the samples array.
BUG=850892
Change-Id: Ie0706dadb031803698e3f8700bd4a08523201bef
Reviewed-on: https://chromium-review.googlesource.com/1093441
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#565804}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fe5b5f754ea2c92750a8f9eb81118f3cfc96beee
To make type checks using closure we generate protocol_externs, for
each domain we generate Protocol.${domainName}Dispatcher @interface.
SDK.${domainName}Dispatcher uses @implements with generated interface,
closure compiler in this case forces us to have all interface method
implemented.
Problem: when we try to add new event for one of V8 domains, we can not
add this notification and its implementation in the same CL, so closure
blocks landing new events in V8 domains.
We can resolve this problem by using @extends instead of @implements
for V8 domains. In this case closure will still check that if we
override something - we override it properly but allow us to not
override all events.
I tried this approach for Page domain as well since it contains a lot
of unused by DevTools events but my attempt failed because we have
SDK.ScreenCaptureModel. It implements dispatcher and extends model,
unfortunately closure does not support multiple inheritance and to
use @extends here we should extract dispatcher from ScreenCaptureModel.
R=dgozman@chromium.org
Bug: chromium:848849
Change-Id: I14fa87b53aeaff5bd7daea7dd36a6917688841cf
Reviewed-on: https://chromium-review.googlesource.com/1082594
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563830}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 14157eee77965e191ec21af278bdcb2aecf9f08e
We used to sort async events having the same start time by end time.
That added a non-deterministic behavior causing some events being swapped
if their start time accidentally happens to be the same.
BUG=823837
Change-Id: I6068da8f8c9d2b7a0730003b19bf37fb2d3af590
Reviewed-on: https://chromium-review.googlesource.com/1073612
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562109}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1eda4c22b63a714e90ca8594ca796598eb1307c7
This incorporats with dgozman's comments in crrev.com/c/1004890
- Change "from SignedExchange" to "from signed-exchange" in NetworkRequestNode.
- Show the signed exchagne url as the initiator of certificate request.
- Show "from signed-exchange" in the headers tab of the inner request.
- Add "View request" link in the preview tab of signed exchange to show the inner request.
- Add "Learn more" link in the preview tab of signed exchange.
Bug: 830505
Change-Id: Ica7ae52e563efb283c600c812be196951a12a336
Reviewed-on: https://chromium-review.googlesource.com/1065558
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#560287}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4ac04d63b06db0e81a986691346f67ba8ad7f865
We are trying to show SignedExchange related information in DevTools.
https://bit.ly/2HXVbCU
This CL introduces a new DevTools event “signedExchangeReceived".
SignedExchange related information (SignedExchangeInfo) will be sent to
DevTools in this event.
SignedExchangeInfo will contain:
- The outer response not to show the internally generated redirect response.
- The signed exchange header information.
- The certificate information.
- The error messages if error occured.
This CL only introduces SignedExchangeInfo.outerResponse.
When the signed exchange request is a navigation request,
|devtools_navigation_token| can be used to find the matching request in
SDK.NetworkManager.
But when the signed exchange request is a prefetch request, the browser process
doesn't know the request id used in DevTools. So SDK.NetworkManager uses
|_inflightRequestsByURL| to find the matching request.
For navigation case, |devtools_navigation_token|, |url| and |report_raw_headers|
flags are passed from NavigationRequest through NavigationRequestInfo,
WebPackageRequestHandler, WebPackageLoader, SignedExchangeDevToolsProxy,
RenderFrameDevToolsAgentHost, NetworkHandler to SDK.NetworkManager in DevTools.
For prefetch case |url| and |report_raw_headers| are passed from
PrefetchURLLoader through WebPackagePrefetchHandler and WebPackageLoader.
Bug: 830505
Change-Id: I186debe50c283b1cdfb9ae268a06fea143edcc6d
Reviewed-on: https://chromium-review.googlesource.com/1027554
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#557238}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 32b51f112e484bf2d353ff1bc49d20d772a1c64b
'Store as global variable' path for LocalJSONObject (e.g. JSONView)
was not tested, and broke because:
- LocalJSONObject did not override unserializableValue()
- ToCallArgument returned instead of invoking unserializableValue()
Bug: 840313
Change-Id: I19c7e5eda2d788fdbba397e00af2eecfab7b2888
Reviewed-on: https://chromium-review.googlesource.com/1048105
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#556625}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c304c47ca16e77c6a39bc428600d2cf8249f9f90
Some source map does not contain entry exactly at the end of the line,
so our frontend fails to find a mapping and ignores current line.
This CL tunes sourcemap to return last mapping in the line if there is
no mapping with offset greater then passed column.
R=dgozman@chromium.org
Bug: chromium:836440
Change-Id: I0da57992ca2c94101084aef2ed21c5b5ba6edc0a
Reviewed-on: https://chromium-review.googlesource.com/1028510
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555626}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 21d0de4658af012ce154176229d8a23609bb1d02
We previously disabled ExecutionContext.p.evaluate() from running
with 'timeout' option while paused. Now that it is supported by
inspector-protocol, we can allow these evaluations to run.
Bug: 810176
Change-Id: Icf81da3d533c719a347f49b3ccd63106e30412c7
Reviewed-on: https://chromium-review.googlesource.com/1033995
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554672}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5f450ef832e7a3833c04f84a2c23f13ca893f57c
The Tracing format documentation does not make it clear if cat and args fields are mandatory.
There are writers in the wild that do not generate these fields. Also trace viewer is capable of reading files with the fields omitted.
Drive-by: do not spam user console with missing CPU profile samples.
Change-Id: I7ab58fc132c2abc565296465924edb8a4fd07d07
Reviewed-on: https://chromium-review.googlesource.com/1022183
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552913}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7f5762dbc3302d9a982c55ab5e8d2b4302233849
Dmitry Gozman