Commit Graph
5 Commits
Author SHA1 Message Date
Alexey Kozyatinskiy 2fe1f0a93a [DevTools] fixed crash on stepIntoAsync fetch
Network should not be intsrumented with JavaScript AsyncTask
instrumentation since it does not trigger JS execution explicitly.

R=pfeldman@chromium.org

Bug: chromium:840502
Change-Id: I07a939b7f583b0330fa40afb0326a40e58918547
Reviewed-on: https://chromium-review.googlesource.com/1049107
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#556673}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: af27f53e066caf431f7999c9069aca1c4f374f62
2018-05-08 03:23:39 +00:00
Joel Einbinder 8981ae8246 DevTools: Remove SourceFrame onTextEditorContentSet
onTextEditorContentSet is a legacy method from when SourceFrame had
many subclasses. Overriding setContent instead is simpler and makes
for a cleaner plugin story around dispose/ensure plugins.

As a drive-by, the currentSearchResultIndex getter was removed.

Change-Id: I7f467da9297288b9f654eaf1cdd73b8be281cbaa
Reviewed-on: https://chromium-review.googlesource.com/1020812
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553320}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1e760fbec07f32c51baadf82e967d2e21ae3650c
2018-04-24 22:28:04 +00:00
Joel Einbinder d5fcd15e71 DevTools: Cleanup DebuggerPlugin
This patch merges some variables together which were seperate inf
JavaScriptSourceFrame, takes @unrestricted off of the plugins, and
renames JavaScriptSourceFrame to DebuggerPlugin where appropriate in
tests.

Bug: 778043
Change-Id: If1d86f46afff1bf0af328090a15a5a1bc92726d7
Reviewed-on: https://chromium-review.googlesource.com/1015650
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552218}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ffc418d98575770088e992d1e88bcd95d6395bea
2018-04-20 00:41:09 +00:00
Joel Einbinder 52829ed75d DevTools: JavaScriptSourceFrame -> DebuggerPlugin
This moves JavaScriptSourceFrame into a plugin, and completes
the plugin initiative.

Bug: 778043
Change-Id: I5908cfe46650fd50524a08b2e402d8ac6ce77cc9
Reviewed-on: https://chromium-review.googlesource.com/889692
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551193}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0920b5eecf51ca3b520098d09ef65460acba3407
2018-04-17 00:47:45 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2.
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00