Commit Graph
16 Commits
Author SHA1 Message Date
Joel Einbinder 83fc76e621 DevTools: Follow Lighthouse's a11y suggestions
Running Lighthouse on DevTools lead to these changes:
 * Label our <select> toolbar items
 * Don't use tabIndex=1 for our canvas elements
 * Don't use li items in the network panel
 * add lang=en to our html tags

Change-Id: I9fef3d731dbbcbb56c3f73d81fd5669d65fa9827
Reviewed-on: https://chromium-review.googlesource.com/1093399
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#566195}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 237b755cd007b58b585ad34137353e11e2bc3ccd
2018-06-11 23:19:47 +00:00
Alexei Filippov ae88fa6125 DevTools: Fix timeline memory graph is empty right after recording.
BUG=849057

Change-Id: Id63654558ab18ae960dcdcc989939f521ea807c2
Reviewed-on: https://chromium-review.googlesource.com/1093423
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#565809}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d28dccea0d7bba1da1d54b6165e207ae4b5e802f
2018-06-09 01:09:28 +00:00
Erik Luo 6355f4d04a DevTools: make settings toolbar button always visible
- Settings gear icon in Console and Performance are always visible
- Console's 'N hidden' text is also always visible

Screenshot: https://imgur.com/a/NTxdNFb

Bug: none
Change-Id: I60d08361ab8ee52f4dd86020039e3e7d105667f4
Reviewed-on: https://chromium-review.googlesource.com/1080036
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563520}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0a643b4cd5ed6be2b661c08e100c6b8310c19e4b
2018-06-01 03:32:24 +00:00
Alexei Filippov e712dbc705 Reland "Reland "DevTools: Support CPU profiles in OOPIFs""
This is a reland of 250e7ef199a3aa19ed838120b9ab64c7b5fcfb55

Original change's description:
> Reland "DevTools: Support CPU profiles in OOPIFs"
>
> This is a reland of 91d5ec53554dafd2ab13ad1908ba47b16842468f
>
> Original change's description:
> > DevTools: Support CPU profiles in OOPIFs
> >
> > BUG=832313,820250
> >
> > Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf
> > Reviewed-on: https://chromium-review.googlesource.com/1011350
> > Commit-Queue: Alexei Filippov <alph@chromium.org>
> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553688}
>
> TBR=dgozman
>
> Bug: 832313, 820250
> Change-Id: I177e0d404b8efe595ddc680368b21c32160cd5de
> Reviewed-on: https://chromium-review.googlesource.com/1065230
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560049}

TBR=dgozman

Bug: 832313, 820250
Change-Id: I7eee078d51e23034ac8c08ce315949c4d78c7092
Reviewed-on: https://chromium-review.googlesource.com/1079729
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563032}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d0a2c26539a8a4e3a5352de72be82ade08fcdf24
2018-05-30 22:31:33 +00:00
calamity 270cd15c2f Revert "Reland "DevTools: Support CPU profiles in OOPIFs""
This reverts commit 250e7ef199a3aa19ed838120b9ab64c7b5fcfb55.

Reason for revert: oopif-performance-cpu-profiles.js failing
consistently in:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/7812

Original change's description:
> Reland "DevTools: Support CPU profiles in OOPIFs"
> 
> This is a reland of 91d5ec53554dafd2ab13ad1908ba47b16842468f
> 
> Original change's description:
> > DevTools: Support CPU profiles in OOPIFs
> >
> > BUG=832313,820250
> >
> > Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf
> > Reviewed-on: https://chromium-review.googlesource.com/1011350
> > Commit-Queue: Alexei Filippov <alph@chromium.org>
> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553688}
> 
> TBR=dgozman
> 
> Bug: 832313, 820250
> Change-Id: I177e0d404b8efe595ddc680368b21c32160cd5de
> Reviewed-on: https://chromium-review.googlesource.com/1065230
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560049}

TBR=dgozman@chromium.org,alph@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 832313, 820250
Change-Id: Idf9a6925438105817159658fd8fa19ba00d1b530
Reviewed-on: https://chromium-review.googlesource.com/1065539
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#560229}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 420d63a70103a202b12702a7339cea79e8ca44b8
2018-05-21 04:56:55 +00:00
Alexei Filippov 046d6f5936 Reland "DevTools: Support CPU profiles in OOPIFs"
This is a reland of 91d5ec53554dafd2ab13ad1908ba47b16842468f

Original change's description:
> DevTools: Support CPU profiles in OOPIFs
>
> BUG=832313,820250
>
> Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf
> Reviewed-on: https://chromium-review.googlesource.com/1011350
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553688}

TBR=dgozman

Bug: 832313, 820250
Change-Id: I177e0d404b8efe595ddc680368b21c32160cd5de
Reviewed-on: https://chromium-review.googlesource.com/1065230
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#560049}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 250e7ef199a3aa19ed838120b9ab64c7b5fcfb55
2018-05-18 21:32:24 +00:00
Alexei Filippov b5f5fe9be1 DevTools: Always show the main track on Perf panel
...even when there's no events in there.

BUG=843953

Change-Id: I9d5789428d58b89b791eb4c43325d1ef3e4b086f
Reviewed-on: https://chromium-review.googlesource.com/1065236
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#559999}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 195775fd3465dedf166e98df68e8639725c8b8a2
2018-05-18 19:52:36 +00:00
Alexei Filippov 45dbf9814a DevTools: Introduce FrameStartedLoading event
Show the navigation time mark on the timeline.

Change-Id: I1d8d832f40b17094f84ef1b1ae366beabe6016ec
Reviewed-on: https://chromium-review.googlesource.com/1036619
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555208}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3423647773befa7ffab8395f6edc6d7e3890ca16
2018-05-01 22:51:52 +00:00
Alexei Filippov 35f97d680f DevTools: Move visible events filter to TimelineModel
BUG=836030

Change-Id: I0a11b2dd04b21b06a33e0fd9e20c9cc299901c6f
Reviewed-on: https://chromium-review.googlesource.com/1032232
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554592}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b79085234f1897b39abeb8632008f5dd91c3f0fe
2018-04-28 01:02:31 +00:00
Alexei Filippov eddfd84c30 DevTools: Do not show screenshots overview bar if there's no screenshots
BUG=836030

Change-Id: I8c01d3186568ac162cc1be118dd8faf06fcee074
Reviewed-on: https://chromium-review.googlesource.com/1033327
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554591}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2d410ebf4ca97f812ca1c2da583397bd39813459
2018-04-28 01:01:13 +00:00
Max Morin ed07e57fa2 Revert "DevTools: Support CPU profiles in OOPIFs"
This reverts commit 91d5ec53554dafd2ab13ad1908ba47b16842468f.

Reason for revert: Failing test, crbug.com/832313

Original change's description:
> DevTools: Support CPU profiles in OOPIFs
> 
> BUG=832313,820250
> 
> Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf
> Reviewed-on: https://chromium-review.googlesource.com/1011350
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553688}

TBR=dgozman@chromium.org,alph@chromium.org

Change-Id: I895c77652fdb343f9fa19735575173367f77ef44
No-Presubmit: true
No-Tree-Checks: true
Bug: 832313, 820250
Reviewed-on: https://chromium-review.googlesource.com/1029973
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553987}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1cc61059c915c9b707a75671c5ae134a930ff993
2018-04-26 11:57:45 +00:00
Alexei Filippov d68f5f7602 DevTools: Support generic traces on Performance panel
Show all processes and threads for generic traces.

BUG=836030

Change-Id: Ib8486667328a726f771f888c0ccf6f2e269c37f8
Reviewed-on: https://chromium-review.googlesource.com/1025136
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553857}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4141778eb03a31a20d9e109f74faf2f756b4a8c4
2018-04-26 00:52:00 +00:00
Alexei Filippov c4b21f81b0 DevTools: Support CPU profiles in OOPIFs
BUG=832313,820250

Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf
Reviewed-on: https://chromium-review.googlesource.com/1011350
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553688}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 91d5ec53554dafd2ab13ad1908ba47b16842468f
2018-04-25 19:00:45 +00:00
Alexei Filippov a18531f640 DevTools: Fix timeline stop recording race.
The recording could have already being stopped by the time auto stop kicks in.

BUG=832332

Change-Id: Ia25f8b7c3fc9c0ba62956ed5d8286fdcc786cdee
Reviewed-on: https://chromium-review.googlesource.com/1011399
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550655}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4aa38134417e6af065b4063fe3cc599de9494c94
2018-04-13 16:59:50 +00:00
Alexei Filippov 2578eb00b5 DevTools: Store window zoom range in PerformanceModel.
Change-Id: I15f5cc61fb956d2be00887eccad96af09c441a44
Reviewed-on: https://chromium-review.googlesource.com/1003833
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549821}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 94942045f8a0d26994609c6c578170a6ebf5131b
2018-04-11 08:15:05 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2.
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00