Running Lighthouse on DevTools lead to these changes:
* Label our <select> toolbar items
* Don't use tabIndex=1 for our canvas elements
* Don't use li items in the network panel
* add lang=en to our html tags
Change-Id: I9fef3d731dbbcbb56c3f73d81fd5669d65fa9827
Reviewed-on: https://chromium-review.googlesource.com/1093399
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#566195}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 237b755cd007b58b585ad34137353e11e2bc3ccd
CodeMirror's 'scroll clipping' process re-measures scrollbars upon zoom to
ensure that its artificial scrollbar is hidden. It assumes that the vertical
scrollbar width is equal to horizontal scrollbar height, which is false.
This CL updates dark theme's custom scrollbar height to be the same as its
width.
Screenshot: https://imgur.com/a/eMUQiIt
Bug: 770633
Change-Id: Iddfcca8bc48ee414c0307d6d9e4035e2ed8771f9
Reviewed-on: https://chromium-review.googlesource.com/1083595
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564273}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 36d5b00c49c1adc54accc1e169951cabfda5ddb0
SuggestBox determines its preferred width by taking the character
length of the longest item, which includes whitespace. However,
whitespace is not preserved without 'white-space: pre', so
measurements are incorrect.
Screenshot: https://imgur.com/a/LcQEQ
Furthermore, preferred width measurements do not factor in the
scrollbar width.
Screenshot: https://imgur.com/a/x8MEF
Bug: 825386
Change-Id: I785dfca5d6a75832c62f41fa8140fb5f8c0dd3f1
Reviewed-on: https://chromium-review.googlesource.com/978937
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563129}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b43ea0045676c99221996b441a0bfcce9741fb47
Tooltips only show when the mouse target is visible/has offsetParent.
Elements using shadow DOM can have <content> elements in the event
path, which may be visible despite having no offsetParent.
Bug: 847387
Change-Id: Ie5dab99d27146787ad7b14bdf95c7932af1e712d
Reviewed-on: https://chromium-review.googlesource.com/1077328
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563062}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 48044f127f5994b33fcec580a15cc46664c8e54f
Changing an element from translucent to opaque can slightly change its
bounding box. Doing this on hover can cause the element to flicker.
Bug: 847384
Change-Id: Ib52cb28b39b561517c23bfc454d876b12e314ca6
Reviewed-on: https://chromium-review.googlesource.com/1076386
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562668}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fa718bcf8146558b23914cf301974249cd4efe07
The alert element must be visible for a screen reader to read it,
so we place it far off the left edge of the screen. However extremely
large text could cause it to overflow onto the page. This patch
limits the width of the element, and also limits the max text length
of the alerts for better performance.
Bug: 845766
Change-Id: I79aadcf863f09ebfdaf2bcb3ba579b891fec2351
Reviewed-on: https://chromium-review.googlesource.com/1067690
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#561490}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 803cc98e06aab21074f9f400df214e477e725b00
In StylesSidebarPane, the 3-dot 'More tools' icon reveals a toolbar on hover.
On 'mouseenter', we set 'display: none' on it, so the following 'mousemove'
determines its bounding rect as {x: 0, y: 0, w: 0, h: 0}, and shows a tooltip
in the top-left of DevTools.
This CL removes the unnecessary tooltip and checks that an element is visible
before showing the tooltip.
Bug: 829342
Change-Id: Ib0268f70dccbb1190916796e1ca6aadaec763e5f
Reviewed-on: https://chromium-review.googlesource.com/1067784
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#560738}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 67c89d4caa1ffd0b7d30d490e68ae9bd2dc1c544
This removes some features from UI.Fragment:
x-shadow
states
inline styles
It adds a simple helper method, UI.html which returns an element.
As a driveby, also fixes the jsdoc validator to parse spread operators.
Change-Id: I569f697bbe29530b7a494c75727dcf37769f8f05
Reviewed-on: https://chromium-review.googlesource.com/1050617
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#557049}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f16c32e015ddb7271389e6ede34cf49cce76bfbe
* Enter accepts the current suggestion in the console.
* History suggestions are not auto-selected. The user must use the
arrow keys or manually click to select them now.
Previously we worried about that the user would accidentally select a
suggestion in the console when they actually wanted to run the command
as is. Due to recent improvements in autocomplete, this is less of a
problem. Autocomplete showing up on an already complete expression
should be extremely rare. The only exception is history completions,
which are no longer autoselected.
Change-Id: Id9d567ae69f4c29c63e875a1f3285448adbd7ce3
Reviewed-on: https://chromium-review.googlesource.com/1026838
Reviewed-by: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555609}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ca3ac226e566791986bb6451bdfcb02d661c6eb8
This patch starts displaying color swatches in suggest box
next to css variables that compute to color value.
For this to be possible, the ColorSwatch and BezierSwatch were
moved under the ui/ module. The CSSShadowSwatch stayed in the
inline_editor/ for now because it has a dependency on
ShadowModel.
R=einbinder, dgozman
Change-Id: Ic29a13073dc8236d5ef9a2fe35adf6bcd927290b
Reviewed-on: https://chromium-review.googlesource.com/1026882
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553468}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b85cc4539f06a76af94addf2d193adaa4edc9b9d
Ingvar Stepanyan
