zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-01 01:38:07 +08:00
Code Issues Packages Projects Releases Wiki Activity
4,782 Commits 43 Branches 79 Tags
19a45dfd55a4768f90c027afdfd7642fa7caa982
Commit Graph
19 Commits
Author SHA1 Message Date
Michael Hablich 01f7fadf76 [Docs] Fix link to workflow.md 
R=yangguo@chromium.org

Change-Id: I17be027946da746655cbf553c2686299683e159d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2370638
Auto-Submit: Michael Hablich <hablich@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-08-24 09:47:17 +00:00
Mathias Bynens 5a8fc1fe06 Improve “merges and cherry-picks” docs 
Change-Id: If3cebd03cbf64142596525aa6ec4a76757d1408d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2370631
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
 2020-08-24 08:09:37 +00:00
Mathias Bynens 5c24d7381a Correct backmerge doc link 
The main README no longer has this information.

Change-Id: I36df75d0a90f6c65f96f8a89fcfb87409e8f06c9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2370629
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-08-24 07:44:57 +00:00
Peter Marshall 54a8a5a308 'themselves' in design guidelines 
Change-Id: I3e5cd29bf7bd94bab1160b9617f98a25ea38e281
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2354089
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-08-13 09:55:30 +00:00
Yang Guo a268369675 Fix image link in design_guidelines.md 
TBR=mathias@chromium.org

Change-Id: I59564eac36c029c6b83b5bb10bb46971e565aa7a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2249922
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-06-17 16:12:08 +00:00
Yang Guo 03e780ed1a Update and re-organize documentation 
R=mathias@chromium.org, tvanderlippe@chromium.org

Bug:chromium:1095988
Change-Id: I72a27a91b0e8c5455dc851d73b62c9b11594b450
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2249662
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-06-17 10:55:47 +00:00
Christy Chen 3fa95bc487 [Loc] Update localization documentation 
Add some FAQs for Loc V2.

Bug: 941561
Change-Id: I23ce46bc01d567f20764c7de8ccd5d7583e017b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2238608
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Christy Chen <chrche@microsoft.com>
 2020-06-12 00:16:15 +00:00
Mathias Bynens 22c55b7e85 Include Unconfirmed issues in triage guidelines 
“Unconfirmed” is a lower state than “Untriaged”. Untriaged issues
that also have the `TE-NeedsTriageHelp` label should be considered
when triaging.

Here are the relevant states with their descriptions as displayed
in Monorail:

1. Unconfirmed = New, has not been verified or reproduced
2. Untriaged = Confirmed, not reviewed for priority and assignment
3. Available = Triaged, but no owner assigned
4. Assigned = In someone's queue, but not started
5. Started = Work in progress

At the time of writing, 233 DevTools issues are in the Unconfirmed
state. 57 of those also have the `TE-NeedsTriageHelp` label.

Bug: chromium:1022301
Change-Id: Ia05a46e87139a4168c48e746e2cad855c4e1bbff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2232948
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2020-06-10 06:22:50 +00:00
Shane Clifford 750036ef90 msft-consider instructions added to TRIAGE_GUIDELINES 
This change adds to the TRIAGE_GUIDELINES FAQ section a note about
adding the msft-consider tag to issues that might best be handled
by Microsoft Edge DevTools team.

Change-Id: I4c66fd24c80b822955931acc86661ce21a653029
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2233225
Reviewed-by: Leo Lee <leolee@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Shane Clifford <shanejc@microsoft.com>
 2020-06-09 18:35:30 +00:00
Michael Hablich c73ffd7613 Add issue triage guidelines 
Bug:1022301
Change-Id: Ibb1e3adec0b4507b1b838a979871a0474a935f6f
R=yangguo@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2194878
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Michael Hablich <hablich@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2020-05-18 12:39:41 +00:00
Yang Guo b8584478dd More specific OWNERS where appropriate 
DISABLE_THIRD_PARTY_CHECK=no code change

Change-Id: I02f6ae91f7412c287ecf931e5681c1c882faa26c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2198956
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Shane Clifford <shanejc@microsoft.com>
Reviewed-by: Leo Lee <leolee@microsoft.com>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-05-14 06:52:14 +00:00
Liviu Rau 23283eb968 Doc update 
Change-Id: I0738f293ff9f6ffb0a1398f9d3f4497f40e55fe1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2104477
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
 2020-03-17 08:34:47 +00:00
Peter Marshall 51afe2e3cc [docs] Update l10n docs to fix some markup 
- Fix broken links
- Fix broken headers
- Change ticks from white to green on adding_strings.md
- Split apart good/bad examples for clarity

Change-Id: I547fc425658bf9dfe9fa4e06bfb6c6cbc1d42964
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2091446
Auto-Submit: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-03-06 12:01:53 +00:00
Mathias Bynens 23ee1aad0a Reconfigure lint rule w.r.t. quotes 
We prefer single quotes by default, but still want to allow double
quotes in cases where that helps avoid quote-escaping, and also want
to allow template literals in cases where string interpolation is
used. For example:

    const a = 'xxx';  // ok
    const b = "xxx";  // not ok, should use single quotes
    const c = "xxx'xxx";  // ok, double quotes avoid an escape sequence
    const d = `xxx`;  // not ok, frivolous use of template literal
    const e = `xxx ${42}`;  // ok

Per https://github.com/eslint/eslint/issues/12976, setting
the `allowTemplateLiterals` option for the `quotes` lint rule to
`false` gives us the desired behavior.

Note that the above lint rules are auto-fixed when running the linter;
there should be no need to manually make any changes to appease the
linter.

Per review feedback, this patch also removes the following escape
sequences for printable non-ASCII symbols:

- U+00D7 → ×
- U+2026 → …
- U+2019 → ’

Chromium CL temporarily updating test expectations:
https://chromium-review.googlesource.com/c/chromium/src/+/2083147

Cq-Depend: chromium:2083147
Bug: chromium:1057042
Change-Id: Id6bec3f96ca694d2fbc07dd8629fce305a58df8a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2082372
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
 2020-03-02 16:18:16 +00:00
Liviu Rau 2c4761856a [doc] Updated branches handling 
No-Try: true
Change-Id: Id43b77b3fe9bbab70007829781f4c2399274c39a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2031119
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-12 15:00:12 +00:00
Michael Hablich c36744bff1 [Docs] Add information on release management 
R=yangguo@chromium.org
BUG=1021467

Change-Id: If1f354d4cbdc9153964804980d17dba2883da1c6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1928918
Auto-Submit: Michael Hablich <hablich@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
 2019-11-21 11:56:34 +00:00
Michael Hablich 3f3aa545f7 [Docs] Fix email in design guidelines graphic 
TBR=yangguo@chromium.org,bmeurer@chromium.org

Change-Id: I855544c72aefa0c6af68989fd078f7a1fb09c1f3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1913265
Reviewed-by: Michael Hablich <hablich@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
 2019-11-13 17:28:21 +00:00
Michael Hablich 37becd02a0 [Docs] Add description about design review guidelines 
Change-Id: I203fd6e4a8c471398d20e6c7a615153f99806beb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1897675
Commit-Queue: Michael Hablich <hablich@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2019-11-12 22:07:40 +00:00
Christy Chen 882eb05270 DevTools: Add localization documentation in devtools/langpacks folder 
Port the localization documentation from wiki page https://github.com/ChromeDevTools/devtools-frontend/wiki/Localization to devtools/docs/langpacks/ for visibility.
The documentation includes the following topics:
-How to add a localizable string
-What are the localization APIs
-How to add descriptive information to GRDP messages
-How to prevent specific terms being localized

Bug: 941561
Change-Id: Ide16269d417d23142a042b92d2f25a2468839fa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740079
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Commit-Queue: Christy Chen <chrche@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701159}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 88dbc6732156fb21c53c4f365c54c27c3f322760
 2019-09-30 16:57:00 +00:00