zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-01 01:38:07 +08:00
Code Issues Packages Projects Releases Wiki Activity
4,161 Commits 43 Branches 79 Tags
2efbb1b8024a35b4fa4dfc2422d0b97582c96fc0
Commit Graph
56 Commits
Author SHA1 Message Date
Tim van der Lippe 8b21270f6e Add @types/codemirror 
They are used in the formatter_worker files

DISABLE_THIRD_PARTY_CHECK=Add node package
R=aerotwist@chromium.org,jacktfranklin@chromium.org

Bug: 1098730
Change-Id: I3c236386dfccd2c12b6379f8bbb5bc9232061734
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2294984
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-07-13 15:34:39 +00:00
Tim van der Lippe 432e6b2ee2 Update Lodash for NPM advisories 
This addresses the following advisory: https://www.npmjs.com/advisories/1523

DISABLE_THIRD_PARTY_CHECK=Npm update
R=mathias@chromium.org

Change-Id: I8850012c2e1e5926e08f230d8888d33f61691567
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2288698
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-07-10 08:00:58 +00:00
Peter Marshall 0b95ea162f Update Mocha to 8.0.1 
Breaking changes here https://github.com/mochajs/mocha/releases/tag/v8.0.0
seem fine.

DISABLE_THIRD_PARTY_CHECK=Update Mocha

Bug: chromium:1101784
Change-Id: Idc75c94f9a923e2b0ca13d1d1331540cb1c5d3a3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2279830
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
 2020-07-03 09:50:38 +00:00
Tim van der Lippe f171bbbae0 Add @rollup/plugin-commonjs to NPM dependencies 
DISABLE_THIRD_PARTY_CHECK=Add NPM dependency

R=vidorteg@microsoft.com

Change-Id: I3fb90b1f4c661125a1b71129fdc45c688dc018ff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2279833
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
 2020-07-02 17:56:00 +00:00
Tim van der Lippe c1e0cf3933 Update TypeScript to 4.0.0-beta 
DISABLE_THIRD_PARTY_CHECK=Update TypeScript
R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: Ie636e205ee3b06a6189872088a1fa962beddd980
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2273178
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-06-29 16:24:33 +00:00
Tim van der Lippe 7989857282 Add @types/estree to dependencies 
These types will be used in the formatter_worker/ which references
types like `ESTree.Node`

DISABLE_THIRD_PARTY_CHECK=New npm dependency
R=jacktfranklin@chromium.org

Bug: 1098730
Change-Id: I0d8868c5f528a8eb11431741b7c98f15dd3bc2ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2264119
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-06-24 16:03:29 +00:00
Tim van der Lippe 2a1ede5c26 Fix newline additions in package.json files in node_modules/ 
`manage_node_deps.py` was changed in
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2259834
to add line endings at the end of the package.json file

However, `npm run install-deps` was not rerun to add the line endings.
To prevent future CLs that add deps to include the line ending changes,
fix them in this CL.

R=mathias@chromium.org

Change-Id: Id4ee0003520c4aa0cb55494cdf64df57e31a86d7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2263952
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-06-24 12:59:49 +00:00
Mathias Bynens 779b5ea094 Roll Puppeteer v4.0.0 
DISABLE_THIRD_PARTY_CHECK=updating node_modules deps

Change-Id: I37d4670cf18e26e8caa8a5b1ca19c8f187244bac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2259851
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-06-23 12:40:26 +00:00
Mathias Bynens 8604a98e45 Add stylelint-config-standard dependency 
DISABLE_THIRD_PARTY_CHECK=updating node_modules deps

Bug: chromium:1083142
Change-Id: Ic4a2a914da2f739c304c1607aa17002548980e6d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2259834
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-06-23 09:29:46 +00:00
Mathias Bynens 79e2cf0633 Add stylelint dependency 
This also adds CC-BY-4.0 to the list of accepted licenses.

DISABLE_THIRD_PARTY_CHECK=update dependencies

Bug: chromium:1083142
Change-Id: I8612de2fba52dae32eeb71af79d5aacfde52142b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2220097
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-06-11 06:20:04 +00:00
Tim van der Lippe d79d79b838 Fix node_modules/OWNERS file after updating a dependency 
We were deleting the file, since we remove the whole `node_modules`
folder. Just like clang-format, we should add it back after
the installation process is completed.

DISABLE_THIRD_PARTY_CHECK=Fix OWNERS file
R=jacktfranklin@chromium.org

Change-Id: Ieb3366160f962db8c6af682d0b186ece941b1031
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2218014
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-05-27 15:33:16 +00:00
Jack Franklin 212c527f90 Upgrade to TypeScript 3.9.3 
I was hitting a bug in 3.9.2 with the breadcrumbs CL [1] that is fixed
in 3.9.3 via this PR [2]. (I've verified locally that it is fixed).

[1]: https://github.com/microsoft/TypeScript/issues/38535
[2]: https://github.com/microsoft/TypeScript/pull/38577

DISABLE_THIRD_PARTY_CHECK=typescript update


Change-Id: Ia874e5936a5bbf0bf26f751ab746976f71910f25
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2218013
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-27 15:13:36 +00:00
Tim van der Lippe 56977452bc Update http-proxy 
Required for https://npmjs.com/advisories/1486

DISABLE_THIRD_PARTY_CHECK=Node modules update
R=jacktfranklin@chromium.org

Change-Id: I22b44f7927d3c4966451e6f7a1690d022d02b587
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2215844
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-26 10:49:01 +00:00
Tim van der Lippe 97eeaf0176 Add rollup-plugin-terser 
DISABLE_THIRD_PARTY_CHECK=Add node_modules
R=jacktfranklin@chromium.org,aerotwist@chromium.org

Bug: 1084578
Change-Id: I70e03fa74f53960a17c884a2bac4027382d66525
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2208135
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-21 09:47:07 +00:00
Tim van der Lippe d0ed351152 Update TypeScript to 3.9.2 
DISABLE_THIRD_PARTY_CHECK=TypeScript update
R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: I14c8201cf46b78b73afdc4cd7d68c8c87a2cf697
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199124
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-05-14 10:14:34 +00:00
Yang Guo b8584478dd More specific OWNERS where appropriate 
DISABLE_THIRD_PARTY_CHECK=no code change

Change-Id: I02f6ae91f7412c287ecf931e5681c1c882faa26c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2198956
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Shane Clifford <shanejc@microsoft.com>
Reviewed-by: Leo Lee <leolee@microsoft.com>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-05-14 06:52:14 +00:00
Tim van der Lippe e8c1000fcd Update karma-mocha 
Required for https://npmjs.com/advisories/1179

The breaking change in 2.0.0 is to drop Node 8 [1], which we don't use.

[1]: https://github.com/karma-runner/karma-mocha/releases/tag/v2.0.0

DISABLE_THIRD_PARTY_CHECK=NPM update
R=jacktfranklin@chromium.org

Change-Id: If4aa30d0db598fbd27e0d194271391f3b840dabd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2193576
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-05-11 15:05:14 +00:00
Tim van der Lippe 00174b46b7 Update yargs 
Required for https://npmjs.com/advisories/1500

DISABLE_THIRD_PARTY_CHECK=NPM update
R=jacktfranklin@chromium.org

Change-Id: Ia051eb5fd1bda221ec58806e9218a99d77c19197
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2193575
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-11 12:51:20 +00:00
Tim van der Lippe c61473dabc Remove karma-typescript 
We now use the Karma + Ninja setup and therefore we can remove the
karma-typescript package which is now unused.

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Npm update

Bug: 1061125
Change-Id: Idf9e4f3247f5db271a7b8a43f932bec5a8d099d2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2192896
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-05-11 09:43:59 +00:00
Tim van der Lippe 40875028ce Update Puppeteer to v3.0.3 
DISABLE_THIRD_PARTY_CHECK=update Puppeteer

Also-By: tvanderlippe@chromium.org
Change-Id: I4ddb6a2b426bcde95f9b764790e88b560441225c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2187209
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-05-07 11:21:08 +00:00
Tim van der Lippe ef991621e0 Update Karma to 5.0.1 
The breaking changes listed in
https://github.com/karma-runner/karma/releases/tag/v5.0.0 do not
apply to us.

This should also include support for Edgium per
https://github.com/karma-runner/karma/pull/3440

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Update karma

Bug: 1068145
Change-Id: I7567b2db14dbf59aaf9c091220157bf55d155810
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2144050
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-15 08:03:17 +00:00
Tim van der Lippe 9f4406f5e2 Run npm audit fix to bump transitive dependencies 
This updates the package-lock.json to pickup the latest versions
of transitive dependencies that have the correct security fixes.

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Update node modules

Fixed: 1068145
Change-Id: Ie9f476981cca78dcd8a5f6b3a75e659f36094eb0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2144049
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-14 16:19:35 +00:00
Tim van der Lippe dfd18c4e75 Remove istanbul-diff from node_modules 
The package is unused at the moment. It was originally added in
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2024871
to enable karma-coverage support. However, istanbul-diff itself
is not required for that process, as we still generate the
karma-coverage report without it.

R=liviurau@chromium.org
DISABLE_THIRD_PARTY_CHECK=Remove istanbul-diff

Bug: 1068145
Change-Id: I38df9ebdfeb5232f013ea45b4a596239bfd63d7b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2137391
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-14 11:21:15 +00:00
Tim van der Lippe c27927c22e Remove esprima 
Esprima is an older parser that does not support modern JavaScript
features. Moreover, we are no longer this parser in either the
ESLint pipeline nor the localization pipeline. Therefore, we can
remove our mirror on GitHub and delete it from node_modules.

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Remove esprima

Change-Id: I372b66c973424752bcd487954504c20b2282d0d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2140940
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-09 11:42:50 +00:00
Tim van der Lippe 597193051b Use karma-coverage in favor of community-maintained packages 
We were using community-maintained for integrating Istanbul with
Karma. However, there appears to be an official karma-coverage
plugin that is maintained by the Karma team. Moreover, the latest
changes on that plugin have removed dependencies on packages
that have reported vulnerabilities.

Therefore, use karma-coverage and remove the old community-maintained
packages to significantly reduce the amount of vulnerable NPM
packages.

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Remove old community-maintained packages

Bug: 1068145
Change-Id: Ie81c185155db6598fc0cd05d9405670a0568c1c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2140942
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-09 11:34:20 +00:00
Tim van der Lippe 99190c9d94 Update Mocha to 7.1.1 
None of the breaking changes listed in
https://github.com/mochajs/mocha/releases/tag/v7.0.0
appear to be relevant for us.

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Update Mocha

Bug: 1068145
Change-Id: I4aec1e775595a0cfcfaa307a8aad7fc9abad22ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2137392
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-07 16:05:24 +00:00
Tim van der Lippe a4e6e7642d Update karma-typescript to 5.0.2 
There don't appear to be any relevant breaking changes in
https://github.com/monounity/karma-typescript/releases/tag/v5.0.0

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Update karma-typescript

Bug: 1068145
Change-Id: I780d8c572bbfc4253f3ff5e52a33c23733d4262a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2137388
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-07 14:47:34 +00:00
Tim van der Lippe fdbd42e2f8 Add eslint-import-plugin to node_modules 
Will be used to make sure no default exports are in DevTools.

The PRESUBMIT.py has been updated to skip running the formatting check
if node_modules files are affected, to workaround crbug.com/1068198.

DISABLE_THIRD_PARTY_CHECK=Add plugin to node_modules

Bug: 1068198
Change-Id: I04d4dc813daa01099f21d40edf47aaefcc0b045f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2135610
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-07 14:27:34 +00:00
Tim van der Lippe be2d34de7a Update Rollup to 2.3.3 
I have checked https://github.com/rollup/rollup/releases/tag/v2.0.0
and none of the breaking changes appear to be applicable to us.

I have manually confirmed that with this build on a production bundle
of DevTools, the output is okay and the build is working as intended.

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Update rollup

Bug: 1068145
Change-Id: I6a7ce6eaacb29fdfd1462642c976b81ce9c20e03
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2137385
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-06 13:56:18 +00:00
Tim van der Lippe c8f6ffd7c3 Update ESLint to 6.8.0 
Also update the PRESUBMIT linter configuration to make sure
it actually runs the linter when updating ESLint. Otherwise,
it would not properly do the full linter check.

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Update ESLint

Bug: 1068145
Change-Id: Ibf2de156366dc64c90ee1aced5537d2038e7a268
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2137384
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-06 13:52:18 +00:00
Tim van der Lippe 8fa65441f9 Add filesystem TypeScript types 
We use these types for all of our interactions with the local filesystem
API's and they don't normally ship with TypeScript library definitions.

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Add node_module

Bug: 1011811
Change-Id: I41ae8faf8cce289c86a6795ff76d8a10b5b3609d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2108760
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-18 17:58:39 +00:00
Jack Franklin 02d03f4ef2 Revert "Add tsickle as a node dep" 
This reverts commit 82dc0cef49.

Reason for revert: We don't think that we're going to use tsickle yet. Apologies - I made this CL a little hastily in hindsight.
Original change's description:
> Add tsickle as a node dep
> 
> We need it to convert from TypeScript to Closure to generate bridges
> whilst we migrate from Closure to TS.
> 
> DISABLE_THIRD_PARTY_CHECK=adding tsickle
> 
> Change-Id: I0bb28ecd6f5f6f131a59a02c8833aebd7ae92471
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107215
> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=tvanderlippe@chromium.org,jacktfranklin@chromium.org

Change-Id: Iee3631911650c03df4c18d07969b94b2d797cb5a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107530
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-03-18 11:15:28 +00:00
Jack Franklin 82dc0cef49 Add tsickle as a node dep 
We need it to convert from TypeScript to Closure to generate bridges
whilst we migrate from Closure to TS.

DISABLE_THIRD_PARTY_CHECK=adding tsickle

Change-Id: I0bb28ecd6f5f6f131a59a02c8833aebd7ae92471
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107215
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-17 11:40:19 +00:00
Tim van der Lippe 455069ae90 Add karma-sourcemap-loader to node_modules 
This will be used to load sourcemap files for TypeScript unittests.

R=aerotwist@chromium.org,jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Add node_module

Bug: 1061125
Change-Id: I13cfdbe078402b02563e7843595016a14bf93617
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2105436
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-16 16:40:16 +00:00
Tim van der Lippe 835724b419 Add eslint-plugin-rulesdir to node_modules 
This plugin needs to be used to write our own custom ESLint plugins that
live in our repository. It replaces the `rulesdir` CLI option, as the
solution of putting it in `.eslintrc.js` is compatible with code editor
plugins.

I also discovered that we were incorrectly running clang-format on
`node_modules`, as I recently fixed the PRESUBMIT. To make sure that
doens't happen again, add a `.clang-format` that disables the formatting
in that folder.

DISABLE_THIRD_PARTY_CHECK=Add new node_module

Bug: 1060123
Change-Id: Ib2c0d23f499604deeea51cb06192bce3a7aa89af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2096449
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-10 17:20:54 +00:00
Jack Franklin 9d8c9bf34d Remove Sinon and associated deps 
We thought we'd use Sinon for spying but we've since moved away from
that as an approach.

DISABLE_THIRD_PARTY_CHECK=removing sinon, changes expected

Change-Id: I47f652b6ba6d08b0d3e53dfc2a1a8ee79535901d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2091447
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-03-06 14:33:13 +00:00
Tim van der Lippe 62e4435627 Update TypeScript to 3.8.3 
This includes the fix for
https://github.com/microsoft/TypeScript/issues/36989 which was blocking
the typescript-ification of `host`.

R=szuend@chromium.org
DISABLE_THIRD_PARTY_CHECK=Update typescript

Bug: 1011811
Change-Id: I637861d247ce4b696b0177e0bd8cd31243a47f98
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2083148
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-02 18:16:46 +00:00
Tim van der Lippe 00e15811f5 Update TypeScript to 3.8.1RC 
This fixes an issue where property assignments to static methods (please
don't ask me why we have them) would erroneously omit the static method
from the declaration file.

This is fixed in the latest version of TypeScript, most likely as part
of https://github.com/microsoft/TypeScript/issues/36270

DISABLE_THIRD_PARTY_CHECK=Updating TypeScript

Bug: 1011811
Change-Id: I2744ef44c040fdf001f6b0be9e64a164510e0fea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2064668
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-20 12:04:17 +00:00
Paul Lewis ed36b86660 Updates node_modules to remove resemblejs 
DISABLE_THIRD_PARTY_CHECK=Updating node_modules requires changing package.json and manage_node_deps.py

Change-Id: I08d05d8c92e501baeb0780ee06cea9b12887ee57
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2056474
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-02-14 12:21:53 +00:00
Jack Franklin 8b9aa2fca6 Prefer eslint-mocha for linting .only in tests 
DISABLE_THIRD_PARTY_CHECK=new npm module causes package-lock change

We can get rid of a custom script and use ESLint for these rules.

Additionally this means editors will highlight the issue in the editor.

Change-Id: I552b52e7f07b4e7430b3f685dbc3b5fad36ffff2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2052167
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-02-12 18:12:22 +00:00
Paul Lewis ea0d7566dc [tests] Adds resemblejs and rimraf to node_modules 
This CL adds deps that are necessary for comparing images in node, which
will be part of screenshot testing.

DISABLE_THIRD_PARTY_CHECK=Changes to deps require updating package-lock.json

Change-Id: I3b6266e7a8a6042cb14f1f6bfa40ca5a921592f2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2050781
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-02-12 13:59:13 +00:00
Paul Lewis dac9b5e74f Adds karma-sinon to DEPS 
R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Changes to deps require updating package-lock.json

Change-Id: Ic83355b2d873f0690d4c357bdd42a4833946f594
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2050776
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-02-12 09:54:22 +00:00
Jack Franklin 1a165367ec Add @types/sinon as a dependency. 
Such that we get nice TS checks when using Sinon in our unit tests.

DISABLE_THIRD_PARTY_CHECK=the package-lock has to change when we install
a new NPM module.

Change-Id: I99d72b526028c473993ff7be8632100046b92681
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2050234
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-02-11 15:07:41 +00:00
Jack Franklin b5bbcc0078 Add sinonjs@8.1.1 dependency 
This will be used to build out mocking in the devtools frontend unit tests.

DISABLE_THIRD_PARTY_CHECK=message doesn't apply with this change (checked with aerotwist@).

Change-Id: Ie623b4fb35677c8c4a5e52d5e75180346da6e3fd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2050225
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-11 14:49:21 +00:00
Tim van der Lippe 912cec0c68 Add istanbul-diff to node_modules 
DISABLE_THIRD_PARTY_CHECK=Adding istanbul-diff to node_modules

Bug: chromium:1044881
Change-Id: Ia80f499622132ce9b2c0890147fecdd4530886c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2024871
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-01-28 15:21:23 +00:00
Tim van der Lippe 0c42b5bb12 Add recast to node_modules/ 
It will be used in a check to enforce license headers

DISABLE_THIRD_PARTY_CHECK=Adds recast to node_modules

Change-Id: I822a368d9ba22058ac2586ea3638089a2f5b1d18
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016746
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-23 13:38:45 +00:00
Tim van der Lippe e4974ddc4c Remove whitespace at the end of the package.json lines 
json.dump appears to add extraneous spaces before newline characters. By
specifying the separators option, we can remove these whitespaces,
reducing the diff noise. Solution taken from
https://stackoverflow.com/questions/16311562/python-json-without-whitespaces

DISABLE_THIRD_PARTY_CHECK=Fix whitespace in node_modules

Change-Id: I26556e5053f19a9021ad41779319bdfe3f8c2b6c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2013154
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-01-22 15:17:25 +00:00
Paul Lewis 7b1e0f41ab Adds Puppeteer types 
DISABLE_THIRD_PARTY_CHECK=Updates the deps list as well as the node_modules

Change-Id: Ia9a6d26a89d85c0ca24253892ec3aa2858fe034a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2009108
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-20 14:02:00 +00:00
Tim van der Lippe bcf142a3e1 Update TypeScript to latest version 
DISABLE_THIRD_PARTY_CHECK=Updates the deps list as well as the node_modules

Bug: 1011811
Change-Id: I09c38caa2b60f8f291695a908a3363dd870f5625
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2009109
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-01-20 11:58:10 +00:00
Tim van der Lippe f86acf8203 Remove Puppeteer installation 
We can set the PUPPETEER_SKIP_CHROMIUM_DOWNLOAD environment variable to
not install a local Chromium installation. Update the preinstall script
to verify that this variable is set. If you want to update the deps, you
can now run `npm run install-deps` to get the update.

DISABLE_THIRD_PARTY_CHECK=Fixing node_modules

Change-Id: I6d77a77f343f8869a17434e7b83951b6380444d0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2003319
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-16 13:32:46 +00:00