zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 04:26:32 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,243 Commits 43 Branches 79 Tags
30e0d8719a889cd2eb37812ae4facd0e8f91bbfe
Commit Graph
1227 Commits
Author SHA1 Message Date
Tim van der Lippe 30e0d8719a Update to TypeScript 4.6.2 
There was only 1 fix required in InspectorView where `DisplayNames.of`
can also return `undefined`. Default to "English" (which I don't think
can ever happen, but alas) is the safest option. Other than that, no
problems with the upgrade 🎉

DISABLE_THIRD_PARTY_CHECK=TypeScript fix
R=szuend@chromium.org

Fixed: 1304218
Change-Id: Ie3c61858259b325f465062aec9dbaf34492a6e00
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3509848
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-03-09 11:15:43 +00:00
Tim van der Lippe ece3c51ea2 Fix install deps script on Python 3 
We ran into "RuntimeError: OrderedDict mutated during iteration" when
running this script. The problem was that we were mutating the
`pkg_data` while also iterating over it. Per
https://stackoverflow.com/a/52549728 the fix is to copy the package data
and pop from there.

R=jacktfranklin@chromium.org

Bug: 1304218
Change-Id: Ibaeb3f1e26ca346c794984311c082bb2f9e672c9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3509847
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-03-08 15:43:11 +00:00
Jack Franklin 3ea21da3c7 Lint against image URLs containing Images/src 
Fixed: 1304152
Change-Id: If4e8928af76ab27ef9ea4584399419a4f94b91a9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3506656
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2022-03-08 15:19:00 +00:00
Liviu Rau 3f146240d2 Run deps scripts with vpython3 
+ drive-by imports cleanup

DISABLE_THIRD_PARTY_CHECK=Migrating multiple scripts to py3
Bug: 1292013
Change-Id: I6d004c6fd54253cc3694cf02cfe94731c7d2146d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3484199
Reviewed-by: Alexander Schulze <alexschulze@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
 2022-02-25 10:14:22 +00:00
Liviu Rau 3da5d4a22e Run build scripts with vpython3 
Bug: 1292013
Change-Id: Idf2e5de0b6ca3a296e5efd7952911783d6005e30
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3484196
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
 2022-02-25 10:12:14 +00:00
Alex Rudenko 4c118bf7b6 Fix typo in scripts/build/assert_third_party_readmes.py 
Bug: none
Change-Id: Ife8f1a210db1c501f7c1bb3674aee3f1a558a055
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3480035
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-02-22 13:58:47 +00:00
Tim van der Lippe 7961ea6fa9 Update build system guidance 
Remove references to the legacy closure compiler files and add
more guidance with respect to output locations and timestamps in
GN templates.

R=yangguo@chromium.org

Bug: none
Change-Id: I672d196c7f2ceebf6e057c60c4b1630ae2887d90
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3477111
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2022-02-21 16:22:08 +00:00
Simon Zünd db5dcc9f1a [e2e] Load DevTools on a different origin than the target page 
This CL changes e2e tests to load the DevTools frontend on the
'devtools-frontend.test' origin instead of using 'localhost'.
'localhost' is used by the target page. If we also load DevTools via
'localhost' than the two pages share window.localStorage and are
considered "same-origin", which hardly reflects reality.

To enable this CL, we have to change the hosted-mode server to set
some CORS headers. More specifically, we allow the DevTools frontend
to request arbitray resources from the hosted-mode server, while
target pages have to be explicit in their ".headers" or
".rawresponse" files.

The CL also rebaselines a couple of e2e test that expect exact
response sizes or expect exact response headers.

R=jacktfranklin@chromium.org, pfaffe@chromium.org

Bug: 1297458
Change-Id: Ie18069e2effcc53cfd10a19296dc5d5c74b40e17
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3467975
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-02-16 12:43:57 +00:00
Weizhong Xia 9e9e0ec7d9 Rename arg name --time-out-ms for rwt 
Change this to --timeout-ms to align with other parameter names,
e.g. --exit-after-n-crashes-or-timeouts, --skip-timeouts,
--initialize-webgpu-adapter-at-startup-timeout-ms.

Bug: 1095123
Change-Id: I9bdf511efeeef9eaf4b00dbba958e921f7d13834
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3457544
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Weizhong Xia <weizhong@google.com>
 2022-02-14 17:15:27 +00:00
Jack Franklin a08500377b Add --mocha-fgrep to unit tests 
This CL adds the ability to run:

```
npm run auto-unittest -- --mocha-fgrep=breadcrumb
```

To the Karma unit test suite to mirror the similar flag available in the
interactions and e2e test runner script. This is also why it's named
`fgrep`, as that's the same flag as used in the other script, and we
should be consistent.

Bug: none
Change-Id: Ic119f7186e0e97c83e00bf92a66d69181c931a8b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3452723
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-02-11 09:55:47 +00:00
Simon Zünd b7c0be6a85 [e2e] Enable caching in hosted mode server 
This CL sets the `Cache-Control` header, allowing Chrome binaries to
cache DevTools resources for up to an hour. While that sounds a lot,
keep in mind that different invocations use fresh Chrome profiles, so
the cache is implicitly cleared between test suite re-runs.

Running the e2e tests in test/e2e/application/ yielded:

With cache: https://pastebin.com/w7Nh2rYW
Without cache: https://pastebin.com/XVNRCdQm

Keep in mind that we collected the numbers against a "is_debug=true"
build. The difference for release builds might not be as pronounced.

R=jacktfranklin@chromium.org, pfaffe@chromium.org

Bug: None
Change-Id: I9f729f453eefad5867aaf144d12d81ead67a2506
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3447414
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-02-10 15:03:25 +00:00
Takuto Ikuta d0e51ea796 add test for esbuild plugin 
Fixed: 1293772
Change-Id: I0c12c27c66fcab491fac6869f282b3059e16ee9b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3439239
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-02-08 13:52:42 +00:00
Takuto Ikuta 5bfd102f96 use __dirname 
Bug: 1294413
Change-Id: I10fff9f43c9354e424d88f2a1eb47f9bc064f99b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3439243
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-02-07 12:18:16 +00:00
Takuto Ikuta 1595cda8b6 fix devtoolsRootPath for internal build 
See https://crbug.com/1294413#c5 for explanation.

Bug: 1294413
Change-Id: Id6461f1830b62eb9e5a14fccfd2229b6b64c8161
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3439235
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-02-07 11:00:53 +00:00
Tim van der Lippe 800d875627 Add build script tests 
You can run these tests with `npm run build-test`, while we also run
them as part of our PRESUBMIT if we make any changes to the build
folder.

R=yangguo@chromium.org
CC=tikuta@chromium.org

Bug: 1293772
Change-Id: Id3b02c83398d2346a4ec5a06f3b938d33070d4f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3439987
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-02-04 13:25:10 +00:00
Takuto Ikuta 4d1f2028c3 esbuild: do not relativize node's built-in modules 
This is followup of https://crrev.com/c/3430082.

This fixes error like
https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8823327185154097217/+/u/compile__with_patch_/raw_io.output_text_failure_summary_

Bug: 1278663
Cq-Include-Trybots: luci.devtools-frontend.try:devtools_frontend_linux_blink_light_rel_fastbuild,devtools_frontend_linux_dbg_fastbuild
Change-Id: Ibdb456f32a3ffa1a24998e2ee58190cb396945cc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3435628
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2022-02-03 10:57:51 +00:00
Johan Bay 8d8c684c22 Update roll_deps.py to also run javascript_natives/ script 
With this change, we also update the argument hints for javascript
functions defined in .idl files when we roll Chromium deps.

DISABLE_THIRD_PARTY_CHECK=changes to roll_deps.py and javascript_natives/
are related

Change-Id: I0544acbe82a0292e486cfb3fac47b683438c3759
Bug: 1255619
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3431347
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
 2022-02-02 18:18:51 +00:00
Johan Bay 986acd0681 Add dependencies for js signature generation to top-level node_modules 
This change makes it easier to run the script from directly
`roll_py.deps` without having to fetch the dependencies first. This also
makes it easier to track which dependencies our tooling have.

Change-Id: I1ce55074ee6a1fffa6f2a2f05a56d0d74b4aca90
Bug: 1255619
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3431346
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
 2022-02-02 17:33:42 +00:00
Takuto Ikuta 6621f46716 devtools_plugin: mark non-relative import as external 
This is to prevent error like
https://ci.chromium.org/ui/p/devtools-frontend/builders/try/devtools_frontend_linux_blink_light_rel_fastbuild/95/overview

Bug: 1278663
Cq-Include-Trybots: luci.devtools-frontend.try:devtools_frontend_linux_blink_light_rel_fastbuild,devtools_frontend_linux_dbg_fastbuild
Change-Id: I51ee2b52b88b9b52edf47edfd94c4a771540fd89
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3430082
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-02-02 13:21:01 +00:00
Simon Zünd 957496f839 Minify locale JSON files at build time 
This CL adds a new build rule "minify_json" that takes a list of JSON
files, minifies them, and puts the result into then "gen/" directory.

The i18n module uses the new rule to minify the locale JSON, reducing
the raw size per locale file 10-15%.

R=tvanderlippe@chromium.org

Fixed: 1293324
Change-Id: I0aabc5cdea7957334dfe21304e117dc23a563606
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3431345
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-02-02 13:19:01 +00:00
Johan Bay 0c881d5071 Add W3C to list of allowed licenses 
Change-Id: Iaffd76028079853ea30ec1b38ca34b14307bc09d
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3428457
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
 2022-02-02 10:56:51 +00:00
Takuto Ikuta 7f5fd554eb fix build errors 
This fixes build error when we disable typescript and when we build
puppeteer.

Bug: 1293019
Change-Id: Ia927344166f543846e6fc3351f1621cd03593a49
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3430599
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-02-02 10:45:11 +00:00
Takuto Ikuta 4aef68ea32 enable fast bundle when skip typecheck 
Use fast bundler if typecheck is skipped, assuming builders/developers
want to get result faster in such build config.

This will also remove the necessity of having devtools_fast_bundle
config from chromium CQ/CI's build.

This is step 6 of http://go/devtools-fast-bundle

Bug: 1278663
Cq-Include-Trybots: luci.devtools-frontend.try:devtools_frontend_linux_blink_light_rel_fastbuild,devtools_frontend_linux_dbg_fastbuild
Change-Id: I516b0af30c8c76c9382dfa09763d4efb8d1bdae7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3429380
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
 2022-02-01 13:03:00 +00:00
Takuto Ikuta 2548a6cd6c introduce devtools_fast_bundle build config 
Proposal: http://go/devtools-fast-bundle

This CL introduces build flag switching bundler from rollup.js to
esbuild by
* adding esbuild to npm without downloading binary packages
* making devtools_plugin for rollup.js re-usable to esbuild

On 24C/48T Z840 Linux machine, this shows following performance
difference by using
```
devtools_skip_typecheck = true
is_debug = false
```
as base build config.

esbuild (devtools_fast_bundle = true)
$ time ninja -C out/Default/
...
real    0m21.174s
user    2m47.513s
sys     0m38.549s

rollup.js (devtools_fast_bundle = false)
$ time ninja -C out/Default/
...
real    1m28.286s
user    30m19.220s
sys     5m36.392s


So esbuild is 3.2x faster and use only 9.6% of machine resouce
(user + sys) compared to rollup.js.

refs:
* https://esbuild.github.io/plugins/#on-resolve
* https://rollupjs.org/guide/en/#resolveid

Bug: 1278663
Cq-Include-Trybots: luci.devtools-frontend.try:devtools_frontend_linux_blink_light_rel_fastbuild,devtools_frontend_linux_dbg_fastbuild
Change-Id: If6b2e774f48091b0fe9c959e7ed1ed9bc2b0847c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3401984
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2022-02-01 12:49:12 +00:00
Takuto Ikuta cfcea4217a rename rollup to bundle 
rollup target will support esbuild, so I rename that to bundle.

Bug: 1278663
DISABLE_THIRD_PARTY_CHECK=parent CL has change for npm
Change-Id: I823f425e9ac5d599a3ddc3fd1fcd7e47cd18e3bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3419385
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2022-01-27 10:46:25 +00:00
Takuto Ikuta 9b3b13af90 extract devtools_plugin from rollup.config.js 
This is extracted from https://crrev.com/c/3401984/30

I'll use this from esbuild too.

Bug: 1278663
DISABLE_THIRD_PARTY_CHECK=parent CL has change for npm
Change-Id: Ia5f3410a2cb59e349e7a76250fbe35b354462a4c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3419384
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2022-01-27 10:44:05 +00:00
Takuto Ikuta 2e08a7d1fc npm: add esbuild 
This is extracted from https://crrev.com/c/3401984/30

Bug: 1278663
Change-Id: Icddd2af2ce157cc3877bcdc84653fb639f44c083
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3419383
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-27 10:33:05 +00:00
Johan Bay 49f681ae20 Update javascript_natives/index.js script 
This change also includes a manual run of the script to update
NativeFunctions.js.

Change-Id: I9ce1c4979674d9513cb7259e3e311e30b13de9ed
Bug: 1255619
Doc: https://goo.gle/devtools-js-argument-hints
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3399837
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
 2022-01-27 10:06:25 +00:00
Liviu Rau 547e711f3a Whitespace to trigger builders 
R=rubber-stamper@appspot.gserviceaccount.com

Bug: 1256412
No-Tree-Checks: true
Change-Id: I8394d6d313be32bdfbbc90c9f39a139b745ee76e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3416225
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Auto-Submit: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2022-01-26 14:24:02 +00:00
Takuto Ikuta afe8b8e716 fix isInChromiumDirectory 
Checkout of chromium directory may not have 'chromium'.
e.g.
https://ci.chromium.org/p/devtools-frontend/builders/try/devtools_frontend_linux_blink_light_rel
has chromium checkout under 'builder' dir.

Bug: 1278663
Change-Id: Icaef7e58ba93e30528ae23d352842abd3d0f3055
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3414935
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-26 10:44:45 +00:00
Takuto Ikuta 95a359d10c typescript: introduce devtools_skip_typecheck build flag 
This is experimental flag introducing esbuild for typescript transpiler.

I needed to modify some test code to pass tests with esbuild.

Bug: chromium:1278663
DISABLE_THIRD_PARTY_CHECK=need to add esbuild DEPS too
Change-Id: I661951fc4fd8f5e6a2a599e531638ab294f887f2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3330076
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2022-01-24 02:19:51 +00:00
Takuto Ikuta f342a5145f replace protocol.d.ts with protocol.ts 
This is to make const enum in protocol.d.ts works with esbuild in
unittest.

Without this, const enum usage from protocol.d.ts is not replaced with
esbuild. So I need to make protocol.d.ts actual TypeScript file and make
it has corresponding JavaScript file with defined enums.

I also need to tweak how protocol.js is imported to make build/test pass
in both tsc and esbuild with child CL.

Bug: 1278663
DISABLE_THIRD_PARTY_CHECK=change generated/ and importing files
Change-Id: Ic5f27633c85bbfe8647636beef9b8625f33eabdd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3367593
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2022-01-24 01:35:02 +00:00
Tim van der Lippe f2adc90457 Add Puppeteer to chrome://credits 
R=alexrudenko@chromium.org

Bug: 1282407
Change-Id: I489c47413bc22b4b44cf88a8225c9d908bf7e563
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3404101
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2022-01-20 14:16:01 +00:00
Eric Leese 30df387ba8 Better VSCode debugging support 
- Default build task is set up
 - Can launch unit tests and e2e tests under the debugger
 - When using JavaScript Debug Terminal, skip attaching to tsc as
   this slows down builds

Bug: None
Change-Id: I4cd627b186b799e148393008fef50fac647aa5a9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3366667
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
 2022-01-19 12:53:26 +00:00
Alex Rudenko b6331edcbd Update Puppeteer to v13.1.1 
This CL contains the result of running `scripts/deps/manage_node_deps.py`
after changing the version of Puppeteer to v13.1.1.

Bug: none
Change-Id: I13154143f1247dc836079f25676775227385c0fe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3397928
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2022-01-18 13:32:16 +00:00
Tim van der Lippe dcc95c9681 Fix licenses for about:credits 
This adds an additional_readme_paths.json file that specifies all
directories of third_party packages that we include in the DevTools
bundle. The file is used as part of Chromiums about:credits machinery to
list all licenses of all third_party software (accessible via
chrome://credits).

It also updates the names of the packages to use the full name, which is
used as header of the license.

To ensure that this file remains up-to-date, we also include a GN action
that verifies all third_party directories listed in our GRD are included
in the .json file.

Lastly, add the missing license for Puppeteer.

R=yangguo@chromium.org

Bug: 1282407
Change-Id: Ia3142ab5bbc79804c56bc754934b9aaf1d186d7f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3386943
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2022-01-17 12:49:00 +00:00
Tim van der Lippe 28af9fbe78 Reland "Do not overwrite generated files when contents remains the same" 
This reverts commit aaae6b021a.

Reason for revert: always check if tsconfig.json needs to be updated

Original change's description:
> Revert "Do not overwrite generated files when contents remains the same"
>
> This reverts commit c1e414725a.
>
> Reason for revert: Seems to be the cause for CQ compilation errors:
> https://ci.chromium.org/ui/p/devtools-frontend/builders/try/devtools_frontend_linux_blink_light_rel/19852/overview
>
> Original change's description:
> > Do not overwrite generated files when contents remains the same
> >
> > To ensure that build timestamps don't unnecessarily cause full rebuilds,
> > make sure that we only write the generated contents to a file (if it
> > exists already) if it would be the same. This ensures that the file
> > timestamps remain the same, which will lead GN to conclude that the
> > build action is a noop (which it is).
> >
> > On a new year, the file contents would actually be different, so it
> > would cause a proper rebuild. However, in all months between when the
> > timestamp changes, it won't cause is unnecessarily to rebuild all these
> > files, even though the year hasn't changed (but the timestamp it was
> > based on did).
> >
> > R=​jacktfranklin@chromium.org
> >
> > Bug: 1283883
> > Change-Id: I2bdc3a79de710236c1501b21fa505692336cfa82
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3377942
> > Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
>
> Bug: 1283883
> Change-Id: I938cfe20a7ecf6df6c7becc9fa73a3dcfebe457c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3380583
> Auto-Submit: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: 1283883
Change-Id: Iae23d721bdeb4c8af227903a38255ee9fc1bc49d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3386675
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-13 15:20:09 +00:00
Simon Zünd aaae6b021a Revert "Do not overwrite generated files when contents remains the same" 
This reverts commit c1e414725a.

Reason for revert: Seems to be the cause for CQ compilation errors:
https://ci.chromium.org/ui/p/devtools-frontend/builders/try/devtools_frontend_linux_blink_light_rel/19852/overview

Original change's description:
> Do not overwrite generated files when contents remains the same
>
> To ensure that build timestamps don't unnecessarily cause full rebuilds,
> make sure that we only write the generated contents to a file (if it
> exists already) if it would be the same. This ensures that the file
> timestamps remain the same, which will lead GN to conclude that the
> build action is a noop (which it is).
>
> On a new year, the file contents would actually be different, so it
> would cause a proper rebuild. However, in all months between when the
> timestamp changes, it won't cause is unnecessarily to rebuild all these
> files, even though the year hasn't changed (but the timestamp it was
> based on did).
>
> R=​jacktfranklin@chromium.org
>
> Bug: 1283883
> Change-Id: I2bdc3a79de710236c1501b21fa505692336cfa82
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3377942
> Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>

Bug: 1283883
Change-Id: I938cfe20a7ecf6df6c7becc9fa73a3dcfebe457c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3380583
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2022-01-11 09:29:14 +00:00
Tim van der Lippe c1e414725a Do not overwrite generated files when contents remains the same 
To ensure that build timestamps don't unnecessarily cause full rebuilds,
make sure that we only write the generated contents to a file (if it
exists already) if it would be the same. This ensures that the file
timestamps remain the same, which will lead GN to conclude that the
build action is a noop (which it is).

On a new year, the file contents would actually be different, so it
would cause a proper rebuild. However, in all months between when the
timestamp changes, it won't cause is unnecessarily to rebuild all these
files, even though the year hasn't changed (but the timestamp it was
based on did).

R=jacktfranklin@chromium.org

Bug: 1283883
Change-Id: I2bdc3a79de710236c1501b21fa505692336cfa82
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3377942
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-10 15:54:45 +00:00
Tim van der Lippe b693eb34d5 Update remaining NPM dependencies 
DISABLE_THIRD_PARTY_CHECK=NPM fix
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I41baa3294f88b7e4463fdc580c050932c5abe40e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372932
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-07 14:42:53 +00:00
Tim van der Lippe 4cb097430f Update Stylelint and Postcss 
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I961be18530d3ccbc4efed0c2cda9bd603b14e27b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372931
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-07 14:36:30 +00:00
Tim van der Lippe 0150c2a641 Update build packages 
Updates TypeScript and @types packages, as well as Rollup + terser.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Id8c4d360be486a703d51a937302c894de3a44fe9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372930
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-07 14:33:50 +00:00
Tim van der Lippe 953e537f89 Update typescript-eslint 
DISABLE_THIRD_PARTY_CHECK=ESLint fix
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I3c9830be1bf007e8443d1664d3979625d175248d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372929
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-07 14:30:30 +00:00
Tim van der Lippe d3425b95d0 Update unit test NPM dependencies 
Updates Karma, Mocha and Sinon.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Ia93cdafc646e4d3277e7ce869a7a8b5e66a13f0d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372928
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-07 14:26:50 +00:00
Tim van der Lippe 08285ab74f Use GN build timestamps for copyright year 
To avoid non-determinism on January 1st of a new year, we have
to use the build timestamp from GN to compute the current year.
The build timestamp will be the same for all bots, which ensures
that all files are built with the same year in the copyright header.

R=jacktfranklin@chromium.org

Fixed: 1283883
Change-Id: Ifbe581ddb65095ca6ef555625be11a370cb8f238
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372924
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-07 12:09:00 +00:00
Tim van der Lippe 0ceb465d1c Update ESLint and plugin packages 
R=jacktfranklin@chromium.org

Bug: none
Change-Id: If1b2420ba6e1c100c3d6b2013815ff1a555ea987
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3369367
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-06 15:06:40 +00:00
Jack Franklin a584190fb0 Lint against manually binding event handlers in components 
Bug: 1270726
Change-Id: I103e91d43fa55abd06d068065175c815f9a59e5d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3369363
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-06 14:35:29 +00:00
Jack Franklin 0a188d5d28 Fix paths not using sharedResourcesBase in component-server 
This was missed when these sheets were added.

Bug: none
Change-Id: Ic4411e6f62c98db73d727611ba87b55eb8a31ad7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3367665
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-05 13:07:57 +00:00
Takuto Ikuta 378ed186f5 use urllib.request.urlcleanup() in download_chromium.py 
Fixed: 1280064
Change-Id: Ie33b6d46ffd0b30ddba73efceec0bbe812df07ae
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3365894
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-05 11:02:37 +00:00
John Emau 94a007152f [ESLint] Update check_license_header_tests with new year 
Tests were hardcoded to expect the year 2021 in the license comment.
Implementation was fixed in 5bb7528e.

Happy New Year!

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Id99e2c67ae2d2f66df0508b5754abbd53a14c3f1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3364293
Auto-Submit: John Emau <John.Emau@microsoft.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-04 09:10:29 +00:00