zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-30 01:07:01 +08:00
Code Issues Packages Projects Releases Wiki Activity
25,392 Commits 43 Branches 79 Tags
32caf01d799bdfd97b73ce8a96b7b8790b036476
Commit Graph
1689 Commits
Author SHA1 Message Date
Nikolay Vitkov 77ba8df5a3 [stylelint] Run test on Presubmit 
We missed running this test and thus didn't catch some changes.

Bug: none
Change-Id: I4781780c6df539671bf3191b888fb8ca8ae436b2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6401394
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-27 08:40:23 -07:00
Danil Somsikov c14787393e Reduce the number of casts to Node in preferTemplateLiterals 
The problem is that ESLint defines a `parent` property on the estree Node. However specific estree Node subtypes, such as MemberExpression, have properties with estree Node subtypes, such as Identifier. The value in practice does have a `parent` property but this is not reflected in types.

This CL makes subrules unaware of the difference by exposing only the estree type to them and makes "core" libraries do the casting where necessary.

Bug: 400353541
Change-Id: I84db45bb35bbfb09f0d6bbde8f730d0f61f09c71
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6400633
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2025-03-27 08:29:54 -07:00
Danil Somsikov 555cc4ba2b Extract "subrules" out of preferTemplateLiterals 
Bug: 400353541
Change-Id: I068797f4ed37071a655b767f2d22e65b3dd8e72b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6394682
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2025-03-27 08:25:05 -07:00
Nikolay Vitkov a175b3fd0d Use correct package for JavaScript natives 
We never install the packages mentioned in that package json
but rely on the node_modules one, so removed.
Also update the packages and types

Bug: none
Change-Id: I0676c36621f39bff7408c5b910f5e4461f3f0158
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6394480
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-03-27 00:19:13 -07:00
Danil Somsikov 8c395f4474 Extract DOM fragment and AST libraries from preferTemplateLiterals rule 
Bug: 400353541
Change-Id: Id52ceaa205579096a7b9d845bc3d521a3e7bb303
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396062
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2025-03-26 08:09:24 -07:00
Benedikt Meurer 9cfc7f9b9c [npm] Fix flag name for patching. 
Bug: 393063467
Change-Id: Ib439eeb44079655ff4eadc7cb8102b4f89796a70
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396858
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2025-03-26 05:15:51 -07:00
Nikolay Vitkov b9f5c81d58 Fix delete after copy 
Bug: none
Change-Id: I278b7409a86756a16e93d0ac1751ff288a74bd77
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396857
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
 2025-03-26 05:13:44 -07:00
Nikolay Vitkov c5db4754c2 Fix passing command to sub-script 
https://github.com/yargs/yargs-parser?tab=readme-ov-file#strip-aliased

Bug: none
Change-Id: Ifb1a77de162ea6367ed76d7e2f6f4301d4c9890d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396776
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
 2025-03-26 02:49:15 -07:00
Benedikt Meurer 173c953b91 [npm] Enable Auto-annotation labeling with npm start. 
Bug: 393063467
Change-Id: I93ce321a5d62308ca48d040697501416b0d51790
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387111
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2025-03-26 01:22:26 -07:00
Danil Somsikov dd60dc9c8a Support class properties as DOM fragments in the preferTemplateLiterals 
Bug: 400353541
Change-Id: I0d0724f752d75a262da31deaf0662221cc8442d4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387921
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2025-03-25 14:06:41 -07:00
Danil Somsikov e4192641bb Support toolbar buttons in the preferTemplateLiterals 
Tighten up types along the way.

Bug: 400353541
Change-Id: I23b644e7ebc2c19194486817ac98c39498ae1679
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387112
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2025-03-25 13:40:50 -07:00
Jack Franklin db52fce504 Define window.scheduler as non-optional 
We used the wicg-task-scheduling types for `window.scheduler` but it
types it as optional - this is true for the general case but because we
are in Chrome we know it exists.

Unfortunately you cannot override the member from optional or not on
`Window`, so this CL removes the use of the
`@types/wicg-task-scheduling` package and reuses the code inline with
the extension to the `Window` interface making it always present.

Bug: none
Change-Id: I8399d3477f89f88e758ed31399c6256fcbd31de9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6393155
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
 2025-03-25 12:28:00 -07:00
Nikolay Vitkov 953dde3e99 Fix script to pass only non included options 
This should be more correct than deleting the object above as
under some cases yargs will include the aliases
https://github.com/yargs/yargs-parser?tab=readme-ov-file#strip-aliased

Bug: none
Change-Id: I8daa2a77e4b103c516a06aaf47cdded1bf3ca605
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387922
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-25 10:55:41 -07:00
Paul Irish 2467bf84e8 Add more experiment flags to start script 
Bug:none
Change-Id: Iec3215c9dd003b2eaa71b9062db045c473c1c9cd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6391995
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
 2025-03-25 10:20:57 -07:00
Nikolay Vitkov 7099949310 [cleanup] Fix yargs type 
Uses ParseSync else the result is Promise<T> | T.
This give IDE better types to work with.

Bug: none
Change-Id: I4d6014aeccd7428ec03bfde90c5d728c6182c1f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387381
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-25 06:21:49 -07:00
Benedikt Meurer 6b1b791739 [npm] Port npm start to JavaScript. 
There's no point in writing this one script in Python. It's much better
to have it in JavaScript, just like `npm run build`.

Bug: 404192426
Change-Id: Ic19eaeb5b1d97ca750ae4253963b8434072d00fd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387801
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-25 05:33:21 -07:00
Danil Somsikov 0832829c9c Support ToolbarInput and Adorner in the preferTemplateLiterals 
Bug: 400353541
Change-Id: Ibb13f752eb215b3a01b8d0ad16ced080b98a68ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387797
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2025-03-25 03:23:06 -07:00
Danil Somsikov 715d95eb9d Remove all the references to the processed DOM fragments 
Bug: 400353541
Change-Id: Ie86c6e6e8810f34ed51fd22dd43f3e62fe540534
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381538
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2025-03-24 03:47:24 -07:00
Benedikt Meurer ce8feaf8c6 [npm] Tweaks for the npm run build script. 
This addresses late feedback in https://crrev.com/c/6367220.

Bug: 404192426
Change-Id: Ib514a6793c5a015021f2e6584cbe6ecbb71f5681
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6372905
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-03-20 02:38:07 -07:00
Benedikt Meurer eabb1f3605 [npm] Add watch mode to npm run build and npm start. 
This adds a new script for `npm run build`, which supports a `--watch`
argument, to automatically re-build whenever source files change. It
also hooks this up to `npm start`, which to automatically rebuild in
the background while Chrome is running.

Bug: 404192426
Change-Id: I90ee3ea81312bcfff9470ab8c62d38608e4e9a71
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367220
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2025-03-19 11:01:21 -07:00
Nikolay Vitkov efd6594929 [eslint] Support no used for NotTranslated 
Bug: none
Change-Id: Ia1dec1d28bbbd63e2e192ff2d8f7556fc743ffd7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367218
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2025-03-19 02:47:55 -07:00
Benedikt Meurer f395cc3765 [npm] Fix enabled/disabled features. 
Pass only a single `--disable-features=` / `--enable-features` CLI
flag to Chrome binary.

Bug: 404192426
Change-Id: I858f87b41e9328cb0e3b9a5c7e16a0f57a73be53
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367217
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2025-03-18 07:28:52 -07:00
Benedikt Meurer 06791eb495 [npm] Pass --use-mock-keychain on macOS in general. 
Bug: 404192426
Change-Id: Ic04335232e4535e0d3c3419141db1d497d168580
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6366898
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2025-03-18 07:28:52 -07:00
Benedikt Meurer 9ce8154fca [npm] Also enable DevToolsCssValueTracing by default. 
Make `npm start` also enable the CSS Value Debugger by default.

Bug: 404192426, 396080529
Change-Id: I4eaea73ad0f25b498458eb4b000c1ab542457ca8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6366896
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2025-03-18 05:42:29 -07:00
Benedikt Meurer 6b5dba97f0 [npm] Add initial npm start script. 
This adds an initial version of the `npm start` script, which builds the
DevTools front-end and launches either CfT or Chrome Canary binary with
the custom DevTools front-end, passing appropriate flags to enable or
disable certain experimental features.

Bug: 404192426
Change-Id: Ia7bcbf8cb5f93bcf455e59964a488480e8ec1fff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367034
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2025-03-18 03:34:36 -07:00
Benedikt Meurer 5307d4dd45 [unified-css] Rename cssContent to cssText. 
The name `cssText` is more aligned with the Web Platform APIs (both
`CSSRule` and `CSSStyleDeclaration` have a `cssText` property).
Otherwise this change is neutral.

Bug: 391381439
Change-Id: Iae65bd4cc0fe96078cdd8c2847573551fd3f80f9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6357196
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-17 05:45:06 -07:00
Nikolay Vitkov afc8a8cec8 [eslint] Include ExtensionAPI 
This makes all current files under DevTools lintable with EsLint
by default.
Also remove the rule for default export for configs.

Bug: 397260638
Change-Id: I3b380ad4351eb53c65207b242d7f8221e7788e48
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6357121
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-03-17 03:48:33 -07:00
Alex Rudenko feb21f6438 Add assertScreenshot to unit tests 
This CL adds a custom browser wrapper that starts the browser using
Puppeteer instead of letting Karma to directly start the browser. The
wrapper also exposes a binding that allows the test code to capture a
screenshot of the test DOM. The helper reuses existing screenshot
assertions and reports the result back to the test code.

This CL also adds args to improve stability of screenshots and
fixes the font to be a Roboto font loaded from Google Fonts.

To test: `npm run test --
front_end/panels/ai_assistance/components/UserActionRow.test.ts`

Bug: 401489541
Change-Id: I04889d0f0caa5c468fd35f98c66b0e6ac393de18
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6330749
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2025-03-14 11:32:55 -07:00
Danil Somsikov 469b8180fc Support createChild and toolbar items in the preferTemplateLiterals rule 
Bug: 400353541
Change-Id: I27a18bb4829336dfaba4dcdd697c84d6591fb60e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6357270
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2025-03-14 06:01:58 -07:00
Danil Somsikov fe93423539 Handle variables in the preferTemplateLiterals lint rule 
Bug: 400353541
Change-Id: I47bacbb4b844e2499f138be88448171841f9b0a0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6353440
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2025-03-14 01:36:00 -07:00
Danil Somsikov 8ef31f7858 Improve DOM API parsing for preferTemplateLiterals rule 
- parse the event listeners
- parse the property methods like .classList.add
- fix the rendering for empty elements

Bug: 400353541
Change-Id: I9d734f156ee45bd10856b3354fc10a11b589339a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6352081
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2025-03-13 10:48:27 -07:00
Danil Somsikov b90c04ffaa Eslint rule for identifying and templatizing manually constructed DOM 
This is not yet enabled and will be further expanded to handle more imperative API and variables

Bug: 400353541
Change-Id: Ie1d514bc2a1813a5cadf98b1a46579c386f22203
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6346607
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-13 04:54:40 -07:00
Jack Franklin 046931e395 AI: fix autofreestyler not removing Insight quotes 
Bug: 400349823
Change-Id: I742ac0228cc8f1341871fe30bb1f5cd9979e503c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6329525
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Nancy Li <nancyly@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
 2025-03-07 05:25:21 -08:00
Jack Franklin 70d9526f85 AI: add proper CTA for "Ask AI" in Insights 
https://screenshot.googleplex.com/7cRcFe487Le3KNK

Bug: 400350312
Change-Id: I7ca20f7b297e7c8424b58171b28038ea59162a62
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6330679
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
 2025-03-06 04:44:40 -08:00
Jack Franklin 66bddcab59 AI: update autofreestyler to support Insights AI example 
Fixed: 400349823
Change-Id: I7ea9605ea96a3dcf05a63102930fd1cb3aa999e7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6321991
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2025-03-04 06:40:20 -08:00
Simon Zünd 8cedabfd47 [build] Remove 'devtools_use_remoteexec' GN arg 
This was an initial experiment to make ts_library work with goma. We
got as far as building leaf modules remotely but getting the rest to
work was deemed infeasible.

This CL removes the prototype.

Note that this is different from siso + use_remoteexec. That works
silently under the hood and only relies on inputs/outputs being
defined correctly. It doesn't require special support in our
ts_library.py.

R=pfaffe@chromium.org

Bug: 40153338
Change-Id: I6de5e30eeb74b80a2ec591dfff0f700a584a43a7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6309563
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2025-03-03 00:01:03 -08:00
Jack Franklin c10b497bff ESLint: lint *.d.ts files 
Bug: none
Change-Id: Ie91dbdc6ed1533c2c58cdb2eafa6d5f23632d243
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6311457
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2025-02-28 11:35:14 -08:00
Liviu Rau 9f15bec464 Handle non-hosted types for mocha 
Bug: 390535614
Change-Id: I294c2e561bfb6749173d5108fe23a99e722f8cfb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6304927
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
 2025-02-27 10:04:10 -08:00
Benedikt Meurer 96faaf281e [project_settings] Generate devtools.json for DevTools-on-DevTools. 
This generates project settings for DevTools-on-DevTools, using a v5
UUID with a pre-defined namespace, to ensure that builds remain
deterministic.

Fixed: 399502654
Bug: 395562934, 395037775
Change-Id: Ifa7c217eb9e5d0558b99c0e46085330bad9f8888
Doc: https://goo.gle/devtools-json-design
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6304926
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2025-02-27 01:57:31 -08:00
Nikolay Vitkov d1ebd9e14d [EsLint] Don't use empty blocks 
Bug: 397260638
Change-Id: Ibf4389ce952333a7af1877450ded87a480d2041f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6298125
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-02-26 08:30:00 -08:00
Simon Zünd 5ff5d987c1 [l10n] Fix 'generated/Deprecation.ts' 
The CL https://crrev.com/c/6287325 broke the extraction of the
generated deprecation UI messages.

This CL fixes it by appending the now necessary `as const` suffix.

R=kimanh@chromium.org

Bug: None
Change-Id: I63803bcc9b40adba0d15559d5dc3400ef8374621
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6297980
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2025-02-26 00:34:05 -08:00
Ergun Erdogmus 5efc7e9be2 [Eslint] Add a custom rule for enforcing as const in UIStrings 
We needed to update other l10n related eslint rules and
`collect-strings` script to look for `as const` definitions as well.

Fixed: 397381592
Change-Id: Ia3eb9a97fa1595093fb332525f996039f7546d8e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6287325
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2025-02-21 04:46:52 -08:00
Nikolay Vitkov 4dc470bc32 [eslint] Fix when running with . 
Fixes some issue around what gets ignored when linting.
Found while running `npm run lint -- .`

Bug: 397260638
Change-Id: I858b9078611a3cb9f31c60ff3e18d99b56563d73
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6280813
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2025-02-20 05:59:37 -08:00
Nikolay Vitkov d36860c0b4 [eslint] Enable useful rules 
@typescript-eslint/no-inferrable-types Simplifies the code and makes
type be more specific.

@typescript-eslint/return-await In theory more performant, but also
provides better debugging experience.

@typescript-eslint/ban-ts-comment Disallow all but ts-expect-error, as
else the error may get fixed not remove and later mask unrelated issues

Bug: 397260638
Change-Id: I09f268eb9157336635c378fa76546a4196e448e9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6281149
Reviewed-by: Victor Porof <victorporof@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2025-02-19 10:49:41 -08:00
Nikolay Vitkov 2801cc647a [eslint] Add new test case for html tagged template 
With the new change of allowing destruction in the import,
create a test case for this rule as well.

Bug: 397260638
Change-Id: I276d185beb377599cec2cd7fdb526fc33fae98f1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6278525
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-02-18 05:55:06 -08:00
Nikolay Vitkov 93062643d1 [eslint] Add rule only-throw-error 
https://typescript-eslint.io/rules/only-throw-error/

Bug: 397260638
Change-Id: I2dbdd6006ce21a99818fd6de2e4d727894194e35
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6277290
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-02-18 02:23:53 -08:00
Paul Irish 7479044f96 Remove TimelineModel by moving TracingLayerTree into timeline 
Change-Id: Ib3834ead748079304ced7635a7de98f51296727e
Bug: 358583420
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6277145
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2025-02-18 01:20:44 -08:00
Nikolay Vitkov f1e3bd8d99 [eslint] Introduce eslint-plugin-eslint-plugin 
Bug: none
Change-Id: I733528d699da8aa749d19d249e7752895c5a8195
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6259394
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-02-13 04:23:19 -08:00
Nikolay Vitkov 49d12de8b5 Revert "Remove custom_element_definitions_location lint rule." 
This reverts commit dc5df3fd69.

Reason for revert: Actually this is fully inline with the UI eng vision. Not sure what I was thinking.

Original change's description:
> Remove custom_element_definitions_location lint rule.
>
> It is hard to justify this requiement in the light of UI engineering
> approach we are taking.
>
> Bug: 301364727
> Change-Id: I9f8f42255aab5dd41858e5840e048e47719f8520
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5899035
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
> Auto-Submit: Danil Somsikov <dsv@chromium.org>

Bug: 301364727
Change-Id: I5096f996bb1ca22d8e1a26535dc3aa742fb84c02
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6252746
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-02-12 09:56:48 -08:00
Benedikt Meurer 84b0fcc58c [eslint] Replace prefer-readonly-keyword with @typescript-eslint/array-type. 
We had our own homegrown ESLint rule that was trying to enforce some
consistency around `ReadonlyArray<T>` vs. `readonly T[]`, but that was
fairly limited and still allowed for `Array<T>` vs `T[]` with no shared
discipline.

We now use the `@typescript-eslint/array-type` rule instead and enforce
that for simple types the `T[]` (and `readonly T[]`) syntax is used,
while for complex types the `Array<A & B>` (and `ReadonlyArray<A & B>`)
syntax is used.

Bug: none
Change-Id: I8933869f98577d4afc4141c5736fccb2159924a6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6257990
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-02-12 07:40:43 -08:00