There are multiple changes in this patch. For the Styles panel,
the color on the the web property when focused, now changes to
HighlightText. The link is now LinkText color on rest and hover state,
but changes to HighlightText when focused.
The toolbar with drop-down, the history drop-down and search box
now have borders. The disabled text button is fixed, with the correct
background, foreground and border color. The toolbar button text has
the correct color on hover and focus.
Made another pass to remove !important
Before: https://imgur.com/a/PJRm3K0
After: https://imgur.com/a/kFUXCFp
Bug: 1048378
Change-Id: Ie33778a0129203b98c5426f2a4a58fc5ee34a568
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2063384
Commit-Queue: Kham Udom <khamu@microsoft.com>
Reviewed-by: Kalon Hinds <kahinds@microsoft.com>
CL for updating blink tests: https://chromium-review.googlesource.com/c/chromium/src/+/1972142
I provided a toggle instead of using CSS trimming for all the long URLs because there are other cases
that rely on the current behaviour. For example, the "Elements" panel shows URLs for <script> tags.
These URLs use the same _createLink(). The current trimming behaviour for the <script> tag might be desirable
because it truncates in the middle, leaving the end of the JS file path shown, which sometimes contains
important info (e.g. query parameters, file extensions).
Another part of implementation is to figure out the max width in every case. For now the text trimming is using
call-site-supplied max length, or the global default max URL length. Updating each case to use CSS to control
the length/width needs more time to investigate. But eventually this has the added benefit of avoiding
the visual problem where string's length doesn't match its visual length.
Ideally I want to switch all call sites of LinkifyURL to use CSS text-overflow trimming.
This effort is tracked in this task: https://bugs.chromium.org/p/chromium/issues/detail?id=1035676
Bug: chromium:1027168
Change-Id: I7ca2187697332b66345766edb1912c5d9085fc2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1971830
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Changhao Han
