zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-12 17:45:49 +08:00
Code Issues Packages Projects Releases Wiki Activity
5,626 Commits 45 Branches 79 Tags
3387bd406401f6f200d4ae2d3012f2332f656708
Commit Graph
20 Commits
Author SHA1 Message Date
Wolfgang Beyer 5893cf5633 Update protocol 
DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: chromium:1107766
Change-Id: I6c3f0ca9d5b5493bf6241dc7fd3901fa44ba0f72
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2440478
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2020-10-01 10:56:06 +00:00
Patrick Brosset 6f3b86ef7f Rolling DevTools deps 
This CL is the result of running the roll_Deps.py script.

DISABLE_THIRD_PARTY_CHECK=Update protocol

Change-Id: I7d284adfc099e80493fed0810f60462bae3dad10
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2413039
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
 2020-09-16 16:36:07 +00:00
Wolfgang Beyer 43f4ee3624 Update CDP 
Rolls browser_protocol.pdl from chromium to devtools-frontend.

Includes update to targetInfo (backend CL: https://crrev.com/c/2309698)

DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: chromium:1107766
Change-Id: I21b89d4a6a71a8bc443ebbaa7452e55bd056d166
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2339525
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2020-08-06 08:33:17 +00:00
Olivia Flynn 828c1805a6 Updating CDP and dependencies 
created with roll_deps.py && npm run generate-protocol-resources
DISABLE_THIRD_PARTY_CHECK="rolling CDP"

Change-Id: I2cd4b128c924ff34bf8675e4be896a2457de97c2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2333067
Reviewed-by: Tony Ross <tross@microsoft.com>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
Commit-Queue: Olivia Flynn <t-olfly@microsoft.com>
 2020-07-31 20:25:23 +00:00
Alex Rudenko 94a6bdf144 Update CDP 
Contains the result of `scripts/deps/roll_deps.py && npm run generate-protocol-resources`

DISABLE_THIRD_PARTY_CHECK=Update protocol

Bug: 384968
Change-Id: Ie9a551d01bb1008e44a20363ab1e152166f68a8d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2270230
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-06-29 08:20:22 +00:00
Peter Marshall 3a5e4e6908 Update CDP 
Contains the result of `scripts/deps/roll_deps.py && npm run generate-protocol-resources`

DISABLE_THIRD_PARTY_CHECK=Update protocol

Bug: chromium:1084558
Change-Id: I983f40d70e7412df447fd4c31bc34719f9eb07b1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2253901
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-06-22 08:12:13 +00:00
Alex Rudenko 0697f50b6b Filter out internal CSS properties 
Internal CSS properties should not be visible anywhere so this CL
removes them from the generated files to reduce the file size.

Fixed: 1092826
Change-Id: I0b4d4694a40bef8444b06eb0578185f60651633a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2245143
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-06-15 14:29:42 +00:00
Alex Rudenko d13aac9a56 Ignore internal css keywords 
Adds filtering of internal CSS keywords to generate_supported_css.py
An internal keyword was added on the blink side[1] which breaks
CSS autocompletion tests.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/2217673

Bug: 1092826
Change-Id: I6aede74affcddd88c1efabd94e2441a9b6ebd8fc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2236403
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-06-09 11:04:09 +00:00
Alex Rudenko d3a1df10d3 Update CDP 
Contains the result of `scripts/deps/roll_deps.py && npm run generate-protocol-resources`

DISABLE_THIRD_PARTY_CHECK=Update protocol

Bug: 946975
Change-Id: I3034ffdd3f0da223c8b6541875768470bcff2c6e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2236400
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-06-09 08:59:19 +00:00
Anubha Mathur f2ea618e6b Update browser_protocol.pdl 
DISABLE_THIRD_PARTY_CHECK=Update browser.pdl deps

Temporarily disabled harImporter.js test:
https://chromium-review.googlesource.com/c/chromium/src/+/2220809

Change-Id: Ic827feb73fba7f5e788a4a80d779f8f919b77234
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2220495
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Anubha Mathur <anubmat@microsoft.com>
 2020-05-29 18:42:33 +00:00
Alex Rudenko 00931d64f3 Update CDP 
Contains the result of `scripts/deps/roll_deps.py && npm run generate-protocol-resources`

DISABLE_THIRD_PARTY_CHECK=Update protocol

Bug: 924698
Change-Id: I7b684933792a7b518bbd9c7964c778ced1bee26d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2178887
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-05-04 08:32:31 +00:00
Mathias Bynens 5bcd719cf0 Roll css_properties.json5 
DISABLE_THIRD_PARTY_CHECK=update generated code
TBR=mathias@chromium.org,changhaohan@chromium.org,alexrudenko@chromium.org
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165756
Bug: chromium:1075437
Change-Id: Iaf8efd63f9b2ab4e3e18174bef89a8ac95e18a3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2168091
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-04-27 16:27:07 +00:00
Mathias Bynens e231df478c Revert "Roll deps" 
This reverts commit 99d87e940b.

Reason for revert: https://ci.chromium.org/p/devtools-frontend/builders/ci/Stand-alone%20Linux/1355?

Original change's description:
> Roll deps
> 
> This patch includes some manual changes to the MediaModel, in order
> to support the new playerMessagesLogged and playerErrorsRaised events
> which are added in the roll.
> 
> The patch also includes the result of:
> 
>     scripts/deps/roll_deps.py $CHROMIUM_SRC_DIR $DEVTOOLS_FRONTEND_DIR
> 
> As a drive-by, this patch also makes `scripts/deps/*.py` executable so
> that they can be invoked directly without the need to explicitly invoke
> Python.
> 
> DISABLE_THIRD_PARTY_CHECK=see above
> 
> No-Presubmit: true
> Bug: chromium:1075437
> Change-Id: I794006f5a2077c8929f7d28bdd3f7b308603b6d9
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165756
> Commit-Queue: Mathias Bynens <mathias@chromium.org>
> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>

TBR=mathias@chromium.org,changhaohan@chromium.org,alexrudenko@chromium.org

Change-Id: If8c4886b61ef1200bdcd2e93604f7d67c57235ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1075437
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2167397
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-04-27 11:48:48 +00:00
Mathias Bynens 99d87e940b Roll deps 
This patch includes some manual changes to the MediaModel, in order
to support the new playerMessagesLogged and playerErrorsRaised events
which are added in the roll.

The patch also includes the result of:

    scripts/deps/roll_deps.py $CHROMIUM_SRC_DIR $DEVTOOLS_FRONTEND_DIR

As a drive-by, this patch also makes `scripts/deps/*.py` executable so
that they can be invoked directly without the need to explicitly invoke
Python.

DISABLE_THIRD_PARTY_CHECK=see above

No-Presubmit: true
Bug: chromium:1075437
Change-Id: I794006f5a2077c8929f7d28bdd3f7b308603b6d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165756
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-04-27 11:13:45 +00:00
Mathias Bynens 51980699f7 Avoid unnecessary use of Object.entries 
Previously, the script would output code of the form:

    new Map(Object.entries({
      'word-wrap': 'overflow-wrap'
    }));

This patch simplifies that down to:

    new Map([
      ['word-wrap', 'overflow-wrap']
    ]);

No-Presubmit: true
Bug: chromium:1039620, chromium:1075437
Change-Id: Ia102b46b70bdbb227c5ff41742fcb82940d48eb9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165787
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-04-27 09:32:55 +00:00
Tim van der Lippe c19ea32ca5 Fix protocol generator formats 
- The protocol files were generated without license headers
- There were whitespace issues in the .d.ts files

Change-Id: I19572989360a4a537fdfe829f212587ae70e180f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107217
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2020-03-17 12:34:08 +00:00
Changhao Han 1e4c9dd21a use "alias_for" from css_properties.json5 to get canonical css property names 
Bug: chromium:1039620
Change-Id: I3be48ee7da959fa500c8775323aa416de520353e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2089908
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2020-03-09 21:49:48 +00:00
Tim van der Lippe 6a0c2e2f5b Sort generated property values on keys 
When dumping the JSON object, we have to ensure that the keys are in the
same order. Otherwise, the generated file is non-deterministic.

We hit this issue when we made a subsequent update in
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2089908
where we are adding an additional dictionary to the file, causing
failures on Windows.

R=changhaohan@chromium.org

Bug: 1039620
Change-Id: Iec33962d4fd5dff461bc2930db54e5c85ce645b7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2095300
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2020-03-09 18:00:38 +00:00
Tim van der Lippe b3b90761b1 Generate InspectorBackendCommands.js on presubmit 
This checks in the InspectorBackendCommands in the source tree file
and ensures that it is kept in sync whenever the third_party
location has been updated.

In the process, I discovered multiple misconfigurations in the formatting
presubmit check. First of all, it was never running, because the
.eslintignore had an empty line. Second of all, it was running twice,
which is unnecessary since we now check for changed files at the end
of the presubmit. Lastly, it was only formatting JS files, while it
should check all files.

I have also updated the _CheckGeneratedFiles check to only run if it
is actually necessary. If there are no changes made to any affected of
the files, it will skip the step. This should thus reduce the presubmit
time and we will only pay the cost if we actually update any of the
files.

Lastly, it will now properly format and lint the generated files. This
makes reading the code a lot easier and makes it easier to digest the
diff when a protocol update goes through. I have verified that, in a
full build, the files are still minified. Thus, this has no impact on
the loading performance.

DISABLE_THIRD_PARTY_CHECK=Updating protocol generation

Fixed: 1056614
Change-Id: If49b0e749978ea1a7838992ec13507ee761ad76c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2087765
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-04 15:52:35 +00:00
Tim van der Lippe f664763cdf Generate SupportedCSSProperties.js on presubmit 
This checks in the SupportedCSSProperties in the source tree file
and ensures that it is kept in sync whenever the third_party
location has been updated.

Bug: 1056614
Change-Id: If0ff2ba0f94f1f0eded2792922e9a917820d9772
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2087762
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-03-04 14:23:14 +00:00