zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 12:33:47 +08:00
Code Issues Packages Projects Releases Wiki Activity
5,626 Commits 43 Branches 79 Tags
3387bd406401f6f200d4ae2d3012f2332f656708
Commit Graph
37 Commits
Author SHA1 Message Date
strangeforloop c7e96aec11 fix uneven outline and padding issue 
updated AUTHORS page

Bug: 1137347
Change-Id: I2f6e11c192536218ca413e4502a8abffa0e5ce24
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2477338
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-10-19 05:41:30 +00:00
Kateryna Prokopenko 29d6f5d78e Replace icons in the issues tab with the new Icon component 
Screenshot: https://imgur.com/a/1MBTnT4
Bug: chromium:1126031
Change-Id: I2f6030d7be64ebf191082ce55f6998a5f8ddde50
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2436827
Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-10-15 08:25:03 +00:00
Wolfgang Beyer 0ccfe926e3 Dark theme improvements for issues panel 
- Reduces brightness of title and paragraph text to be in line with the
  rest of dev tools
- Adorner styling
- Text link colors
- Icon link colors
- Table header colors (also for light theme)
- Fixed table cell content alignment for multiline items

before: https://i.imgur.com/Npq8wUU.png
after: https://i.imgur.com/3Qy2jrn.png

Fixed: chromium:1119335
Bug:chromium:1122511

Change-Id: Id4f1387a029065b6ca81b6c4c91e5bcc03fd6a1e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2387725
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2020-09-30 13:17:07 +00:00
Tony Ross 246d63ffce Add option to group issues by category 
Adds a new (hidden) checkbox to the toolbar to toggle grouping by
issue category on/off (default off). When grouped, categories
replace issues as the top level items in the panel, with
related issues displayed indented under each category.

Screenshot: https://imgur.com/a/XkxtnNW

Bug: 1072331
Change-Id: Ib72f555245a5cc3158233bb1280b7e6907ab15f3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2399128
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Tony Ross <tross@microsoft.com>
 2020-09-24 18:42:05 +00:00
Wolfgang Beyer 101b41c4cb Turn link icon into mask 
This allows changing the icon's color (for dark theme...). The icon is
currently only being used in 2 places, both have been adapted to handle
the icon as a mask.

Screenshots:
light theme: https://i.imgur.com/NSsfOL4.png
dark theme: https://i.imgur.com/qG0KxBN.png

Bug: chromium:1072335, chromium:1122511
Change-Id: I76d16b94722205e87549fa01e58a3f92a8388ff5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391253
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@google.com>
 2020-09-21 08:41:30 +00:00
Wolfgang Beyer 0c589cca4e [Frametree] Add icons to links in FrameDetailsView 
This CL makes the FrameDetailsView prettier by adding small icons to
its links.

Screenshots:
https://i.imgur.com/V0wzKhq.png

Bug: chromium:1093247

Change-Id: Ia57d63269531798e7cf3fe6e72358a25452a85d8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2372384
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-08-27 13:09:35 +00:00
Peter Marshall 9a3d85fa0b css: Use :focus-visible instead of our custom data-keyboard-focus 
https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible

:focus-visible is basically the exact same functionality as the custom
data-keyboard-focus attribute that devtools maintains. This CL converts
all of our uses of data-keyboard-focus in CSS to use :focus-visible.

This has no intended behaviour change although it's possible there are
small differences in our implementation vs. the web platform one, so
this might cause some regression with focus styles for keyboard
interaction.

I tested a few of these manually to verify they still do the same thing.

The CSS linter was unhappy about the ordering of some rules due to
specificity-ordering checks, so there is some re-ordering too.

A follow-up CL will remove our implementation of data-keyboard-focus.

Change-Id: Ifc273f7d82e16ea07e24ed2d1faa6f794a12501d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2352236
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
 2020-08-24 07:58:42 +00:00
Kateryna Prokopenko 3546945795 [issues] Add affected resource 'blocked' status for CSP issues 
For now the status is hard-coded to 'blocked', as we do not report issues in Report-Only case (where the resources are not blocked).

Screenshot: https://imgur.com/a/8ORGniQ
Bug: chromium:1082628
Change-Id: I6deea9270a3ef91fd86447eb19de9b48004c7fed
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2292010
Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-08-07 07:14:40 +00:00
Sigurd Schneider d5dec09c44 Generate COEP issues based on issues generated in the back-end 
This also undoes a change where certain frame navigations are
ignored in the front-end to improve debuggability. The reason is
that the change doesn't work for OOPIFs, and as those are very
common with COEP issues, prevents debugability there. We likely
need to adopt a fix similar to https://crrev.com/c/2144163 to
solve this issue.

Screenshot: https://imgur.com/a/zfeMiHl
Bug: chromium:1051466, chromium:1078823
Change-Id: I943ba9a38909b6f4505d24bdd89263f9e58cf730
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332229
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-08-03 14:57:27 +00:00
Tim van der Lippe 2efbb1b802 Revert "Enable property-no-vendor-prefix stylelint check" 
This reverts commit 190803bad8.

Reason for revert: This breaks the icons in DevTools, which leaves gray backgrounds behind.

Original change's description:
> Enable property-no-vendor-prefix stylelint check
> 
> This patch drops unnecessary -webkit- prefixes in CSS and enables
> a lint check to enforce that prevent such properties from being
> added in the future. Note that the use of vendor-prefixed CSS
> properties is still accepted in cases where there is no standardized
> and browser-supported alternative.
> 
> Bug: chromium:1104187
> Change-Id: I29ae93d5a760c4f5037f20663754f448b5083235
> Fixed: chromium:1031475
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2297386
> Reviewed-by: Changhao Han <changhaohan@chromium.org>
> Commit-Queue: Mathias Bynens <mathias@chromium.org>

TBR=mathias@chromium.org,changhaohan@chromium.org

Change-Id: I5fe13b7afd8b71180163c7419092cc6a758903b6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1104187
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2297391
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-07-14 14:24:29 +00:00
Mathias Bynens 190803bad8 Enable property-no-vendor-prefix stylelint check 
This patch drops unnecessary -webkit- prefixes in CSS and enables
a lint check to enforce that prevent such properties from being
added in the future. Note that the use of vendor-prefixed CSS
properties is still accepted in cases where there is no standardized
and browser-supported alternative.

Bug: chromium:1104187
Change-Id: I29ae93d5a760c4f5037f20663754f448b5083235
Fixed: chromium:1031475
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2297386
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-07-14 13:23:06 +00:00
Kateryna Prokopenko 69f975c6fa [issues] Handle CSP issues of URL violation type in the front-end. 
This CL handles the display of CSP URL violations in the DevTools
issues tab.

DISABLE_THIRD_PARTY_CHECK=<Bases on protocol update CL>

Screenshot: https://imgur.com/a/N7YHVaW
Bug: chromium:1082628
Change-Id: I457058d398b9bbb5acdf598d912c3b500185fb20
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2235772
Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-07-06 11:46:11 +00:00
Sigurd Schneider 6ed51a007a Fix stylelint-config-standard issues in issues/issuesTree.css 
R=mathias@chromium.org

Bug: chromium:1083142
Change-Id: I57765051202013dd7d446b98c0d87550614e50bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2264114
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-06-24 13:54:29 +00:00
Sigurd Schneider e82fe5da5c [issues] Link frame resource to rest of devtools 
This introduces the machinery to link from the issues panel to the
elements panel for frame resources. It also introduces highlighting
of the frame when the frame URL in an Heavy Ads issue is hovered.

Screenshot: https://imgur.com/a/J6dHD97
Bug: chromium:1095617
Change-Id: I165fefafdbca02ad1a00e3b79e7d6b83c572ece8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2260675
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-06-24 11:46:29 +00:00
Sigurd Schneider 51152e86cd [issues] Add Heavy Ads issue 
This CL ads a basic version of an Heavy Ads issue. More fancy linking
to other panels will be done in a follow up.

Authoritative source for issue description:
http://doc/19E5wkNr9H2qsFpk-rzDT_uYSlsRAhyGe6lvyks5tlTs#heading=h.l6hsc4mwylzr

Screenshot: https://imgur.com/a/ytl5sv4
Bug: chromium:1095617
Change-Id: I90dccfd60da4799bbb031b63dc509b0fd5c64f06
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2257281
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-06-23 14:01:02 +00:00
Wolfgang Beyer 9827e696d1 [Issues] Fix margin for affected resource list 
Screenshots:
before: https://i.imgur.com/WWmNj5b.png
after: https://i.imgur.com/DjWBENo.png

Bug: chromium:1072335
Change-Id: Id63b7e3fabe5335db3debc50f1e88ff40d5343ea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2203443
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Peter Müller <petermueller@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-05-20 07:12:17 +00:00
Mathias Bynens ca9fa2d73f Consistently format CSS color and opacity values 
- Prefer the modern comma-free CSS color function syntax over the
  legacy syntax. [1]
- Explicitly use the `deg` suffix for angle values in colors, to
  clarify the range.
- Explicitly use the `%` suffix for percentages instead of formatting
  the value as a number, again to clarify the range.

[1]: https://twitter.com/mathias/status/1253242715304857601
[2]: https://goo.gle/devtools-css-color

Bug: chromium:1083142
Fixed: chromium:1073885
Change-Id: I8e1582a2dee3553a61df88564051ea84c2011d76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2209091
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
 2020-05-19 16:50:26 +00:00
John Emau b26232fb0c [issues] Affected sources styling 
This adds missing styles to the affected sources resources so they are
styled consistently with other affected resources.

This change also removes usages of the deprecated `createElementWithClass` helper.

The screenshot below was taken using dummy data added only in patchset 2:
https://crrev.com/c/2176407/2/front_end/sdk/Issue.js

Screenshot: https://imgur.com/offKPXX
Bug: chromium:1070376
Change-Id: I7694b147a40a24395cf47bcc473b94029135b39e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2176407
Commit-Queue: John Emau <John.Emau@microsoft.com>
Reviewed-by: Tony Ross <tross@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-05-15 22:21:57 +00:00
Mathias Bynens b0c1f4bce2 Fix stylelint-config-standard violations 
Bug: chromium:1083142
Change-Id: I5ea4cc5d0f83e52856383ba37a47472e33eb19a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2204113
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-05-15 17:05:27 +00:00
Kateryna Prokopenko 6264f00192 [Issues] Add aggregated count to issue title 
Add an aggregated number of issues next to the warning sign for each
issue title.

Screenshot: https://imgur.com/a/Hp7axbV
Bug: chromium:1057979
Change-Id: Ic7fb3654c8f36da26429bdbbacd9388f11a3a387
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2193951
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-05-12 13:11:14 +00:00
Sigurd Schneider 1e1a30e927 [issues] Update SameSiteCookie issue descriptions 
TBR=szuend@chromium.org

Bug: chromium:1077702
Change-Id: I140a2fafd6af5921d462368975edeb83e22e4906
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2193955
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-05-12 09:25:23 +00:00
Wolfgang Beyer 958b2db5a0 [Issues] Only show background color on node expansion 
Affected resources do not have a grey background now when they are not
expanded. Only upon expansion this background is added. Paddings and
margins are being adapted too, so that both states look proper.

Screenshots:
https://imgur.com/eqWWAcs
https://imgur.com/LHM0MCK
https://imgur.com/Sd51HJi

Bug: chromium:1057979
Change-Id: Iacd3c9cc6573c83ccb6d726ca5f1d873ecb93669
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2187617
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2020-05-12 07:53:53 +00:00
Wolfgang Beyer 633c3fe656 Fix list arrow styling for issue description 
The vertical alignment of the arrow symbol marking a list item as well
as the whitespace immediately following it were inconsistent. This CL
fixes this.

Screenshots:
before:
https://imgur.com/Dp14YEs
https://imgur.com/QSTsnP1

after:
https://imgur.com/2DC69x5
https://imgur.com/O5hUcAY

Bug: chromium:1057979
Change-Id: I287e5c34aaad6ef0e59057035233cf31814a6b13
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2192898
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2020-05-11 11:38:40 +00:00
Simon Zünd 906108beba [issues] Descriptions can provide more than one link 
This CL extends issue descriptions to link to more than one external
information resource. Currently only used by COEP issue descriptions.

Screenshot: https://imgur.com/a/fWQHH9e

R=sigurds@chromium.org

Bug: chromium:1057979
Change-Id: I32cddfa334ebf26793e47472a4184be69ccaa872
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2190473
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-05-08 13:03:32 +00:00
Simon Zünd 7d1974166a [issues] Adjust colors for dark mode 
This CL incorporates UX feedback for the Issues panel in dark mode.

R=sigurds@chromium.org

Bug: chromium:1057979
Change-Id: I1d51d658ba3d82f224ed638f0903a1a18e6cd834
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2190335
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-05-08 11:07:04 +00:00
Simon Zünd 1058fc52ff [issues] Update texts for COEP issues 
This CL incorporates UX feedback changing the contents of the texts
themselves and slightly changes the rendering to allow for normal text
and 'code' in the same paragraph.

Screenshots: https://imgur.com/a/je2mkWu

Bug: chromium:1077702
Change-Id: Ib69b09d9b7a5e8a93c08f32685b08e1c57ae928d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2183924
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-05-07 12:43:39 +00:00
John Emau 18575dd6ef [issues] Add affected elements 
This changes added the element(s) affected resource type. The an affected
element represented by a subset of Protocol.DOM.BackendNode properties [1].

In the issues panel view the `backendNodeId` and `nodeName` are used to
display a deferred node link that will only push the node to the front-end
when activated by the user.

Activating the tag name link opens the elements panel and highlights the
node.

Note that only the element tag is displayed and not attributes on the element
such as id or classes.

This change is only the front-end displaying of the affected element and
will be useful for future back-end issue implementations, e.g. _Preload
warnings_ would link to the offending <script> tag in the Elements panel [2].

The below screenshot and gif are demo's using dummy data in patchset 3 [3], unfortunately
the backEndNodId changes often so there is no guarantee the dummy data
will work correctly on every page.

[1]: https://chromedevtools.github.io/devtools-protocol/tot/DOM/#type-BackendNode
[2]: https://imgur.com/nAMHsfm
[3]: https://crrev.com/c/2176406/2..3

Screenshot: https://imgur.com/oG78y7O
Keyboard Accessibility GIF: https://imgur.com/dMloRDc
Bug: chromium:1070375
Change-Id: Ia27a067c92bdf5fb14bb008151c4d80293d70678
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2176406
Commit-Queue: John Emau <John.Emau@microsoft.com>
Reviewed-by: Tony Ross <tross@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-05-06 20:08:32 +00:00
Sigurd Schneider 9a679bebfa [issues] Only link cookie to network panel if a request is present 
There are issues triggered from document.cookie in JavaScript, and it
doesn't make sense to link to the network request panel for such cookie
issues. We currently don't have the source location in the issue (this
requires back-end changes), so the option that should cause the least
confusion is to not link at all.

In some cases, the cookie might be available in the cookies section of
the application panel, but it is difficult to link there.

Bug: chromium:1057979
Change-Id: Id2eb0721397aa7c0e39cfcca2b829a6f57dcc4b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2182417
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-05-06 06:21:51 +00:00
Wolfgang Beyer ae8e6dba9c Move issue indicator triangle to the left 
This CL moves the triangle indicator for expanding/collapsing issues
to the left side of the line. We received feedback that the UI does not
clearly show that the issue headline is clickable. We hope that the
triangle indicator now makes this more obvious.

Screenshot: https://imgur.com/iw48RNT

Bug: chromium:1057979
Change-Id: I46474b0bcc5bd1e9547c54607c9fcdff654eb779
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2182418
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-05-05 11:23:36 +00:00
Wolfgang Beyer 5ba8d19462 Fix whitespace for affected resources 
Screenshots:
before: https://imgur.com/atprmfw
after: https://imgur.com/zfxkUfy

Bug: 1057979
Change-Id: I9e0995a9496b6057e2aaa73069548fc04ae94df0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2182415
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-05-05 10:50:26 +00:00
Simon Zünd d31aa5bee0 [issues] Remove issues code from issue description 
For the initial launch we won't show the issues code for each
aggregated issue. As this CL is self-contained, we remove the code
altogether (a revert should be straight-forward).

R=sigurds@chromium.org

Bug: chromium:1057979
Change-Id: I72b6789b7beac237d2e0399a0b9019664a508b33
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2182412
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-05-05 09:31:16 +00:00
Sigurd Schneider e578599de6 [issues] Make issues user-selectable 
Bug: chromium:1057979
Change-Id: I516377eb58506657868d03685a0f497eab0433c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2182411
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-05-05 08:49:46 +00:00
Wolfgang Beyer bf14c674e7 [issues] Add Mixed Content Issues to Issues Pane 
This CL creates issues for mixed content. These issues are created in
addition to the console messages about mixed content but should replace
them at some point in time.

Screenshot: https://imgur.com/TfPWPBt

Bug: chromium:1053468
Change-Id: I3fd503881e46847c1dc6c517af43972be3a6d7d8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2119686
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-04-28 12:08:12 +00:00
Simon Zünd d605957919 [issues] Improve text colors in dark mode 
Screenshot: https://imgur.com/a/1E3eBio

R=mathias@chromium.org

Bug: chromium:1057979, chromium:1068935
Change-Id: I9794a496ec803a29cc94299c1886df833a90a3b5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2160938
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-04-23 09:59:56 +00:00
Sigurd Schneider 8c9b0e77eb [issues] Misc CSS improvements 
- Improve is-open-triange movement and orientation
 - Keep toolbar fixed at top, don't scroll it
 - Fix font weight for issue title (broken CSS rule)
 - Reign in block margins of paragraph tags.
 - Fix colors for section headers
 - Decrease indent for resolutions list

Bug: chromium:1057979
Change-Id: I9df679853cf8f303c3aee2b77ea535234672e189
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2156348
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-04-20 10:11:16 +00:00
Simon Zünd 35ebb85fa7 [issues] Adapt SameSite cookie issues to backend changes 
This CL uses the more detailed issues format provided by the backend
to create SameSite cookie issues in the issues panel. The existing
issues are removed or replaced to avoid confusion.

Change-Id: I83faaa604a2e6a04f4fceeb14de4848a675721a1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2144165
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-04-17 13:18:17 +00:00
Tony Ross c4fb400988 Add keyboard accessibility to Issues panel 
Converts display of issues to use TreeOutline allowing re-use of
built-in keyboard handling from that component. Redundant UI elements
such as expand/collapse toggles have been removed and the corresponding
equivalents in TreeOutline re-styled to match the existing Issues panel
design.

Also removes the height animation for opening/closing issues to avoid
clipping content (see https://imgur.com/a/iZJPyL0). This was an
existing issue for which re-implementing the broken behavior on top of
TreeOutline seemed out-of-scope. Follow-up work could consider re-adding
this animation in a way that doesn't clip content.

Bug: 1067773
Change-Id: Id6b1a3391efbc74139cc20d572c3fef038d3ecad
Gif: https://imgur.com/a/c9lZ3bm
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2144339
Commit-Queue: Tony Ross <tross@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: John Emau <John.Emau@microsoft.com>
 2020-04-16 16:20:23 +00:00