The logic for tracking colors for the dark theme did not test the labels
for the Perfmon charting, but rather the chart lines themselves. This
CL ensures the labels are checked, but also bumps the minimum cap value
so that the labels in the Perfmon obtain a contrast of > 7.0.
See
Bug: 1098637
Change-Id: I6b366d672fca971b134261fa1de2477ef52345c3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2264116
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
This CL changes references to self.Common.settings (the global
instance of SDK.Common.Settings) over to
Common.Settings.Settings.instance(). To keep both TypeScript and
Closure happy we must make a method on the Settings class itself,
since it only allows private constructors to be accessed by static
methods on the class.
Bug: 1058320
Change-Id: I04afc8caf64acf29cdda13ef03ad05cfff4786a1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2091450
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
This CL changes references to self.SDK.targetManager (the global
instance of SDK.SDKModel.TargetManager) over to
SDK.SDKModel.TargetManager.instance(). To keep both TypeScript and
Closure happy we must make a method on the TargetManager class itself,
since it only allows private constructors to be accessed by static
methods on the class.
Bug: 1058320
Change-Id: I6ca35024c21cf24254fd6273138a1ab3e163ee00
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2088092
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.
This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.
Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9
Accessibility testing of the Performance Monitor tool revealed several
issues which are addressed in this patch:
- Keyboard A11y: The graph toggling UI could not be navigated or
manipulated via the keyboard. This restricts keyboard-only users from
interacting correctly with the tool.
- The fix was to allow users to navigate through the list of
MetricIndicators in the left panel using the Tab key.
Also adding a keypress event listener to allow toggling each of the
MetricIndicators with either the 'Enter' or 'Space' keys.
- Color A11y: The UI relied solely on color differences to identify each
graph. This prevents users with reduced color perception from easily
using the tool.
- The fix was to add a text label to each graph and improve the
contrast ratio of the fill color.
- Screen Reader A11y: There was no screen reader accessible information
in the perf monitor tool. This prevents visually impared users from
using the tool.
- The fix was to add announceable text to the buttons and a
description to the graph (A future improvement would be to also
announce the graph values in realtime as the data comes in)
Screenshot of changes for comparison:
https://imgur.com/a/nUNInsl
Change-Id: Iaf8d2b5bf54f91b776372ae9d4c5e182d1bd6721
Reviewed-on: https://chromium-review.googlesource.com/c/1488051
Commit-Queue: James Lissiak <jalissia@microsoft.com>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#636154}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 05503b6028373f309a24747e4e208002750933a9
Paul Lewis