Tim van der Lippe
7b775bf4f7
Remove Node.prototype.appendChildren
...
We can use the standard Node.prototype.append instead.
R=szuend@chromium.org
Bug: 1050549
Change-Id: Ie5ab9c525b93e71983dd8296b01512bd62843e50
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2443092
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
2020-10-02 10:55:00 +00:00
Jan Scheffler
77e3e68311
Migrate front_end/profiler to devtools_entrypoint
...
R=aerotwist@chromium.org , jacktfranklin@chromium.org
Bug: 1101738
Change-Id: Ie603b7d8535a9051196da6c952cc1e5b9e0f9759
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2328764
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Jan Scheffler <janscheffler@chromium.org >
2020-07-30 15:26:20 +00:00
Changhao Han
b9f308bca2
Delay rendering of box model until style sections are initialized
...
Currently in the Styles pane, the box model (MetricsSidebarPane) renders
before the CSS properties sections, which creates a visual flash and
may confuse developers. This CL fixes this flash by delaying the
rendering of the box model until the style sections are initialized.
screencasts: https://imgur.com/a/2v6AyIw
screencast for loading spinner: https://imgur.com/a/ZFYXCSE
Issue for adding a loading screen: https://crbug.com/1102839
Bug: chromium:1095547
Change-Id: Ib201e7c9ebf96f41ba96423ff830a71332c6fcc4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2273179
Commit-Queue: Changhao Han <changhaohan@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-07-14 12:02:50 +00:00
Tim van der Lippe
e7f27058f4
Replace double class invocations of createElementWithClass
...
This applies the following replacement to the codebase:
(\S+) = createElementWithClass\('(\w+)', '([^'\s]+) ([^'\s]+)'\);
to
$1 = document.createElement('$2');\n$1.classList.add('$3');\n$1.classList.add('$4');
R=aerotwist@chromium.org
Bug: 1011811, 1077215
Change-Id: I0ac37f594bd12dd7b1ffb53d7ca9ef04761df5f0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2176114
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-05-04 09:49:41 +00:00
Tim van der Lippe
f49e23286b
Replace single class invocations of createElementWithClass
...
This applies the following replacement to the codebase:
(\S+) = createElementWithClass\('(\w+)', '([^'\s]+)'\);
to
$1 = document.createElement('$2');\n$1.classList.add('$3');
R=aerotwist@chromium.org
No-Presubmit: true
Bug: 1011811, 1077215
Change-Id: I0d76b39f1ed8cd4a44f18f94e398db934ba4b09c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2176112
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-05-01 16:54:52 +00:00
Mathias Bynens
23ee1aad0a
Reconfigure lint rule w.r.t. quotes
...
We prefer single quotes by default, but still want to allow double
quotes in cases where that helps avoid quote-escaping, and also want
to allow template literals in cases where string interpolation is
used. For example:
const a = 'xxx'; // ok
const b = "xxx"; // not ok, should use single quotes
const c = "xxx'xxx"; // ok, double quotes avoid an escape sequence
const d = `xxx`; // not ok, frivolous use of template literal
const e = `xxx ${42}`; // ok
Per https://github.com/eslint/eslint/issues/12976 , setting
the `allowTemplateLiterals` option for the `quotes` lint rule to
`false` gives us the desired behavior.
Note that the above lint rules are auto-fixed when running the linter;
there should be no need to manually make any changes to appease the
linter.
Per review feedback, this patch also removes the following escape
sequences for printable non-ASCII symbols:
- U+00D7 → ×
- U+2026 → …
- U+2019 → ’
Chromium CL temporarily updating test expectations:
https://chromium-review.googlesource.com/c/chromium/src/+/2083147
Cq-Depend: chromium:2083147
Bug: chromium:1057042
Change-Id: Id6bec3f96ca694d2fbc07dd8629fce305a58df8a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2082372
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Auto-Submit: Mathias Bynens <mathias@chromium.org >
2020-03-02 16:18:16 +00:00
Tim van der Lippe
c02a97ca2c
Fix imports for Common.Event typedef
...
All references now use the fully qualified
"Common.EventTarget.EventTargetEvent". It renames it to
"EventTargetEvent" to prevent a name-clash with the native "Event" type.
Bug: 1006759
Change-Id: I13fcdfd613041da146d741a0d1f785bfc905a7a8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2056481
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-02-14 15:21:06 +00:00
Tim van der Lippe
e54f66edc5
Migrate profiler/ to import cross-module
...
Bug: 1006759
Change-Id: Ie62c0fd5af48e5bf4ee8dfc1aead8d2f9af49783
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2035936
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-02-12 14:11:02 +00:00
Paul Lewis
0d43b80f06
Migrates profiler/ to ESM internally
...
Bug: 1006759
Change-Id: Ic455b75d0b7f8288c3f009b98f05b2aa9c3ac9ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1997345
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2020-01-14 13:53:10 +00:00
Tim van der Lippe