Commit Graph
7 Commits
Author SHA1 Message Date
Mathias Bynens ca9fa2d73f Consistently format CSS color and opacity values
- Prefer the modern comma-free CSS color function syntax over the
  legacy syntax. [1]
- Explicitly use the `deg` suffix for angle values in colors, to
  clarify the range.
- Explicitly use the `%` suffix for percentages instead of formatting
  the value as a number, again to clarify the range.

[1]: https://twitter.com/mathias/status/1253242715304857601
[2]: https://goo.gle/devtools-css-color

Bug: chromium:1083142
Fixed: chromium:1073885
Change-Id: I8e1582a2dee3553a61df88564051ea84c2011d76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2209091
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
2020-05-19 16:50:26 +00:00
Mathias Bynens b0c1f4bce2 Fix stylelint-config-standard violations
Bug: chromium:1083142
Change-Id: I5ea4cc5d0f83e52856383ba37a47472e33eb19a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2204113
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
2020-05-15 17:05:27 +00:00
Mathias Bynens 9680e2e8b0 Drop -webkit-user-select in favor of user-select
Bug: chromium:1031475
Change-Id: Ibbf222135c97e79ae3be816216fec9675d643952
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1953613
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
2019-12-06 10:31:53 +00:00
Michael Liao c20eb36aa7 DevTools [Security]: Show More/Show Less SR fix
Re-upload of https://chromium-review.googlesource.com/c/chromium/src/+/1767482 to DevTools repository

Issue:
- SR would not announce "Show More/Show Less" and "Show Full Details/Hide Full Details" button text change
Changes:
- The "Show More/Show Less" type buttons now announce the change in button text content and expanded/collapse state.

The button work for Security Panel has been moved to this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1819626/5

GIF of SR/Button behavior:
https://imgur.com/aUXwXXY

Bug: 963183
Change-Id: I6550fbf7023e0162964f0096b8057efedce87114
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1873208
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
2019-10-25 22:03:56 +00:00
Jan Scheffler 673dec0c44 [devtools] Make links look like links
This patch adds a createTextLink method to create
text links and uses it in the security > origin view to
link to the network pane. It also adds "show more" and
"show less" classes for to the text link.

Bug: chromium:977423
Change-Id: If5ff95e5d26af3a20680e93e23e110b912a41de4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789531
Commit-Queue: Jan Scheffler <janscheffler@google.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#699635}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2d23c1d6ec05bae5d56cc417b90146d9064dde95
2019-09-25 06:00:01 +00:00
Michael Liao (WPT) 73a506ef71 Devtools: making security origin and overview page accessible + adding tests
Changes:

Origin:
- 'Origin' text is now a header 1
- 'Connection' text is now a header 2
- 'Certificate' text is now a header 2
- 'Certificate Transparency' text is now a header 2
- 'Show more/less' and 'Show full details' links are now marked as buttons and are keyboard accessible

Overview:
- 'Security overview' text is now a header 1
- page security description is now a header 2
- 'View x in network panel' link is now marked as a button and is keyboard accessible

.devtools-link css changes:
https://imgur.com/a/9FtpsU4

link elements to button element change:
https://imgur.com/zSMcGVQ

CR Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=962686

Change-Id: I3a62e898d7135ace1d8a9c76dfdbad382c928500
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606195
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#672600}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ec4778d2487334d68e9fdc9c55d95ab4b9bddf3f
2019-06-26 19:02:00 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2.
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00