Commit Graph
8 Commits
Author SHA1 Message Date
Simon Zünd 2ab7821a13 [ts] Type-check timeline/UIDevToolsController.js with TypeScript
R=jacktfranklin@chromium.org

Bug: chromium:1011811
Change-Id: Ic9ab020e95fb006d607e6046d33dffdc848be2a1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2436731
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2020-09-29 08:23:48 +00:00
Jan Scheffler f168ba4164 [TypeScript] Migrate front_end/timeline to devtools_entrypoint
Bug: 1101738
Change-Id: Ida2ba236c097adfdbbeadae06cc844f7446073c3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2307312
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-07-30 16:09:10 +00:00
Paul Lewis 897ad8b20c Migrates timeline/ to ESM internally
Bug: 1006759
Change-Id: I1e015d9d7aada2478dcc55dd919768ded9709e03
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2002599
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-01-22 12:58:44 +00:00
Tim van der Lippe 0176f6cd86 Reland "Migrate timeline/ to ESM"
This reverts commit 96705c6461.

Reason for revert: Build failure fixed

Original change's description:
> Revert "Migrate timeline/ to ESM"
>
> This reverts commit 907156a7b0.
>
> It has been causing Windows build errors which has been preventing
> the autoroller in Chromium. Sample build output:
>
> F:\chromium\src\out\release_x64>autoninja chrome && chrome
> "f:\chromium\depot_tools\ninja.exe" chrome -j 320
> [1/1] Regenerating ninja files
> ninja: fatal: CreateProcess: The parameter is incorrect.rate_devtools_grd(//build/toolchain/win:win_clang_x64)
> Change-Id: I3d8c567be6d09160acfadb85dc1bf5e8a53b800c
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1990451
> Reviewed-by: Mike Jackson <mjackson@microsoft.com>
> Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>

Change-Id: Id588405f5ca1635e417641985df89c56f8564563
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1981621
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-01-09 12:09:01 +00:00
Rob Paveza 96705c6461 Revert "Migrate timeline/ to ESM"
This reverts commit 907156a7b0.

It has been causing Windows build errors which has been preventing
the autoroller in Chromium. Sample build output:

F:\chromium\src\out\release_x64>autoninja chrome && chrome
"f:\chromium\depot_tools\ninja.exe" chrome -j 320
[1/1] Regenerating ninja files
ninja: fatal: CreateProcess: The parameter is incorrect.rate_devtools_grd(//build/toolchain/win:win_clang_x64)
Change-Id: I3d8c567be6d09160acfadb85dc1bf5e8a53b800c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1990451
Reviewed-by: Mike Jackson <mjackson@microsoft.com>
Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>
2020-01-08 01:57:27 +00:00
Tim van der Lippe 907156a7b0 Migrate timeline/ to ESM
Bug: 1006759
Change-Id: I70fffc8f52e6ecdbb009babd770da4971c9fbe1a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1981616
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-01-07 17:29:28 +00:00
Tim van der Lippe 20b29c2646 Enforce newlines at end of files
Trying to upload a CL with missing newlines at the end of files fails with the following warning:

These files should end in one (and only one) newline character:

Update the ESLint config to let the linter fix these errors.

Change-Id: Ia858b5864a1dc43144e0c6d81dedbf46376c2b8d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1897679
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
2019-11-04 15:02:44 +00:00
Yang Guo 1225402840 DevTools: override logic in Timeline Panel for UiDevTools
This enables showing more details in the Timeline Panel.

Steps to use:
 - Run chrome with --enable-ui-devtools
 - Navigate to chrome://inspect#other
 - Connect to UiDevToolsClient
 - Record a performance trace

Change-Id: If8af634f894f937bd4192c774bedf105b8563a42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767717
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#701706}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 084d7fa18a548849c9d5353e2870dcf82c687415
2019-10-01 19:20:44 +00:00