 Jack Franklin
|
92fb5f5b91
|
[DarkMode] changesView.css
Bug: chromium:1152736
Change-Id: Iae6c0d050d5f0593a1ff3eff0fa4e95641b5412d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2905503
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
|
2021-05-19 12:07:42 +00:00 |
|
|
Tim van der Lippe
|
af02decd68
|
Disallow !important in CSS files
To make sure that any newly written CSS files for new components
do not use !important, since they will be using shadow DOM. Moreover,
!important is usually an anti-pattern that makes it harder to reason
about CSS cascading. It is also disallowed internally at Google.
R=jacktfranklin@chromium.org
Bug: none
Change-Id: Idcd2c90d01ff2e782a02d0a4631be384b1a3ca74
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2871716
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
|
2021-05-04 16:14:35 +00:00 |
|
|
Jack Franklin
|
9b1435f00c
|
Prefix more legacy CSS variables with --legacy-*.
Bug: chromium:1152736
Change-Id: I2a122a944061a85764e4dfdd5c46025b8606e706
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2854688
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
|
2021-04-28 14:12:24 +00:00 |
|
|
Jack Franklin
|
374ec39011
|
Remove --toolbar-bg-color and --tab-selected-bg-color
These were both aliased to new colors anyway, so this CL removes the
legacy colors and updates all usages to point to the new CSS
variables.
Bug: chromium:1152736
Change-Id: Ibe034fd8ca9fb8057f92dc6d3974dc73f28f8f92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2853384
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
|
2021-04-28 09:29:44 +00:00 |
|
|
Tim van der Lippe
|
ad935d1203
|
Move changes to panels/changes
R=aerotwist@chromium.org
Bug: 1187573
Change-Id: Ie491631f84a89c24a8a1feedd74d667c8c38b3d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2767265
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
|
2021-03-18 13:38:37 +00:00 |
|