Commit Graph
7 Commits
Author SHA1 Message Date
Kalon Hinds 9790091ab7 High contrast support for Application panel
This patch adds high contrast support to the application panel by
attributing the correct link text color for clickable devtool links as
well as fixing tree-outline icon behavior on hover and selection.

Before: https://i.imgur.com/2Nr9RUs.gif
After: https://i.imgur.com/o6DKpC1.gif

Bug: 1048378
Change-Id: I2f7e27134af0d6d88308722946a7aa5a3b55a676
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2044000
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
2020-02-10 18:17:20 +00:00
Kham Udom 047cb6914a Fixed high contrast in Elements panels.
Update the DOM tree panel by fixing missing expanded glyph, removed the
borders, set by the system. The borders should only be visible,
when elements are hovered or selected.

Made sure all the panels, Style, Computed, Event Listeners,
DOM Breakpoints, Properties, and Accessibility, have a hover state,
if there is one, in Default mode. Otherwise, all panels
should be navigable, with keyboard.

Before: https://imgur.com/a/XaXWvFW
After: https://imgur.com/a/1lBV1Br

Update:1
Addressed comments to move styles to a central location,
removed unnecessary use of forced-colors and !important
and unused rule sets.

Update:2
Address change to use border color, more refactoring work
to remove unnecessary !important, more work on centralizing
styles

Bug: 1048378

Change-Id: I6942eb46d6c741fdea3f062ac61ead7c6e9d1bbc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2007930
Commit-Queue: Kham Udom <khamu@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2020-02-04 18:57:20 +00:00
Erik Luo cedf2be6db Revert "DevTools: prepare Computed sidebar for groups"
This reverts commit 2d8ad76070a840ce3821f3d28e55cd952f7640c0.

Reason for revert: Grouping would break alphabetical sort, which is controversial.

Original change's description:
> DevTools: prepare Computed sidebar for groups
> 
> Computed sidebar
> - Removes even/odd striping
> - Extracts a function to build a property's TreeElement
> 
> Bug: 929536
> Change-Id: I727cf1efa5ac65277a046b52575f35102323c38f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548446
> Reviewed-by: Joey Arhar <jarhar@chromium.org>
> Commit-Queue: Erik Luo <luoe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#648029}

TBR=luoe@chromium.org,jarhar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 929536
Change-Id: Icec233a91c07b2b864830df6419690911070101a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565380
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#650149}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 37893dee61d4f8d4a23c0d23bd36dbd4ef6d893c
2019-04-12 00:59:26 +00:00
Erik Luo 247064ee0f DevTools: prepare Computed sidebar for groups
Computed sidebar
- Removes even/odd striping
- Extracts a function to build a property's TreeElement

Bug: 929536
Change-Id: I727cf1efa5ac65277a046b52575f35102323c38f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548446
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#648029}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2d8ad76070a840ce3821f3d28e55cd952f7640c0
2019-04-05 01:44:27 +00:00
Erik Luo 08e147b821 DevTools: use 2 rows for narrow Computed sidebar layouts
Screenshot: https://imgur.com/a/E0g35gC

Bug: 899235
Change-Id: I90c643e48cfb8a7519627cd1446e04da19d09950
Reviewed-on: https://chromium-review.googlesource.com/c/1418502
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#631077}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: de362015ae467b05c3a90b54cfed8c6534776f20
2019-02-12 03:27:11 +00:00
Erik Luo f6956bc49e DevTools: remove flex from Computed widget for copyability
Bug: 899235
Change-Id: Ifb75bcd27cf74e95e4b30511f72d367a349d762b
Reviewed-on: https://chromium-review.googlesource.com/c/1418372
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#630264}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 61ecd6b7214a945d4831e686b461acc8b8e885a2
2019-02-08 10:24:46 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2.
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00