Wolfgang Beyer
585ded41b5
Revert "Use 1000 not 1024 for kB and MB calculations"
...
This reverts commit e4d2472814 .
Reason for revert: Further discussions are needed to ensure
consistency between DevTools and Lighthouse on how to calculate
kb/MB.
Original change's description:
> Use 1000 not 1024 for kB and MB calculations
>
> This removes the usage of the number 1024 for the calculation of kB and
> MB values. Instead the correct value of 1000 is used.
> The changes mostly affect the file/transfer size values seen in the
> network tab (screenshot: https://imgur.com/a/cDqxScS ).
>
> Bug: chromium:1035309
> Change-Id: Ic3fe4fc6536326d44fc9f838189db9b0c19d0955
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2062606
> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org >
> Reviewed-by: Mathias Bynens <mathias@chromium.org >
TBR=mathias@chromium.org ,wolfi@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1035309
Change-Id: I60dd9be51a097166889db9d7206ad251be6d2235
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2071878
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org >
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org >
2020-02-25 09:00:57 +00:00
Wolfgang Beyer
e4d2472814
Use 1000 not 1024 for kB and MB calculations
...
This removes the usage of the number 1024 for the calculation of kB and
MB values. Instead the correct value of 1000 is used.
The changes mostly affect the file/transfer size values seen in the
network tab (screenshot: https://imgur.com/a/cDqxScS ).
Bug: chromium:1035309
Change-Id: Ic3fe4fc6536326d44fc9f838189db9b0c19d0955
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2062606
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-02-20 08:05:05 +00:00
Wolfgang Beyer
24e80608d1
Revert "Reland "Use 1000 not 1024 for kB and MB calculations""
...
This reverts commit d75b4fefd4 .
Reason for revert: breaks on rolling into chromium
Link: https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/496073
Original change's description:
> Reland "Use 1000 not 1024 for kB and MB calculations"
>
> This is a reland of 759a1364c7
>
> Original change's description:
> > Use 1000 not 1024 for kB and MB calculations
> >
> > This removes the usage of the number 1024 for the calculation of kB and
> > MB values. Instead the correct value of 1000 is used.
> > The changes mostly affect the file/transfer size values seen in the
> > network tab (screenshot: https://imgur.com/a/cDqxScS ).
> >
> > Bug: chromium:1035309
> > Change-Id: I2b3e811496f5c99b7b2d77a66834c242f0620df2
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2056480
> > Commit-Queue: Wolfgang Beyer <wolfi@chromium.org >
> > Reviewed-by: Mathias Bynens <mathias@chromium.org >
>
> Bug: chromium:1035309
> Change-Id: Ice93c7d16897e54ecee5a5dd298223971c31e90e
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2061728
> Reviewed-by: Mathias Bynens <mathias@chromium.org >
> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org >
TBR=mathias@chromium.org ,wolfi@chromium.org
Change-Id: I8533e20f557ade56366989a91a2834be6f2d96a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1035309
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2061730
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org >
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org >
2020-02-18 11:56:36 +00:00
Wolfgang Beyer
d75b4fefd4
Reland "Use 1000 not 1024 for kB and MB calculations"
...
This is a reland of 759a1364c7
Original change's description:
> Use 1000 not 1024 for kB and MB calculations
>
> This removes the usage of the number 1024 for the calculation of kB and
> MB values. Instead the correct value of 1000 is used.
> The changes mostly affect the file/transfer size values seen in the
> network tab (screenshot: https://imgur.com/a/cDqxScS ).
>
> Bug: chromium:1035309
> Change-Id: I2b3e811496f5c99b7b2d77a66834c242f0620df2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2056480
> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org >
> Reviewed-by: Mathias Bynens <mathias@chromium.org >
Bug: chromium:1035309
Change-Id: Ice93c7d16897e54ecee5a5dd298223971c31e90e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2061728
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org >
2020-02-18 08:17:46 +00:00
Mathias Bynens
fc21799269
Revert "Use 1000 not 1024 for kB and MB calculations"
...
This reverts commit 759a1364c7 .
Reason for revert: broke the tree https://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/508
Original change's description:
> Use 1000 not 1024 for kB and MB calculations
>
> This removes the usage of the number 1024 for the calculation of kB and
> MB values. Instead the correct value of 1000 is used.
> The changes mostly affect the file/transfer size values seen in the
> network tab (screenshot: https://imgur.com/a/cDqxScS ).
>
> Bug: chromium:1035309
> Change-Id: I2b3e811496f5c99b7b2d77a66834c242f0620df2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2056480
> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org >
> Reviewed-by: Mathias Bynens <mathias@chromium.org >
TBR=mathias@chromium.org ,wolfi@chromium.org
Change-Id: I69a34847e838a83e1795f316e782870a7fc42d8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1035309
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2060493
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Mathias Bynens <mathias@chromium.org >
2020-02-17 15:10:55 +00:00
Wolfgang Beyer
759a1364c7
Use 1000 not 1024 for kB and MB calculations
...
This removes the usage of the number 1024 for the calculation of kB and
MB values. Instead the correct value of 1000 is used.
The changes mostly affect the file/transfer size values seen in the
network tab (screenshot: https://imgur.com/a/cDqxScS ).
Bug: chromium:1035309
Change-Id: I2b3e811496f5c99b7b2d77a66834c242f0620df2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2056480
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-02-17 12:52:27 +00:00
James Lissiak
821d228775
DevTools: Replace the chrome-devtools:// URL scheme with a more generic
...
devtools:// scheme
This change replaces the chrome-devtools:// URL scheme, with a more
browser-agnostic equivalent.
Naturally, many files had to be touched, but it's mostly a
straightforward find/replace.
A related change is out against the catapult repo here:
https://chromium-review.googlesource.com/c/catapult/+/1606268 ,
which removes a test file containing the old scheme. Once it goes in,
the root DEPS file in the chromium repo needs to be updated as well.
Note:
This is a continuation of patch 1552143, but since Fabio is out on
leave and I don't have permissions to upload to his patch, I needed to
start a new one.
Bug: 960409
Change-Id: I3ede7f8d1dcbca457167eb3641ae60e9685d8d78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582881
Commit-Queue: James Lissiak <jalissia@microsoft.com >
Reviewed-by: Joel Einbinder <einbinder@chromium.org >
Reviewed-by: Tom Sepez <tsepez@chromium.org >
Reviewed-by: Scott Violet <sky@chromium.org >
Reviewed-by: Charlie Reis <creis@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#659944}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 28b21a67f09a13c465b73776aecd9995d8a07737
2019-05-15 15:32:04 +00:00
Joel Einbinder
5b2829a446
DevTools: Add a script to launch old versions of DevTools
...
This can be used for testing devtools_compatibility.js against various
older versions of DevTools.
Bug: 898245
Change-Id: I0eb15d1e4a1e893b97a7c9a77c2c80c7006068a2
Reviewed-on: https://chromium-review.googlesource.com/c/1298617
Reviewed-by: Dmitry Gozman <dgozman@chromium.org >
Commit-Queue: Joel Einbinder <einbinder@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#602806}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6ca23eae57e2021ff9a1899beba7b89f90b6673b
2018-10-25 18:32:44 +00:00