Tim van der Lippe
c2cb4301c9
Add missing license headers
...
In a follow-up CL we will be porting the license header check to ESLint.
This allows us to add missing license headers for TypeScript-authored
files. The script found some missing license headers already, which this
CL adds.
Change-Id: Id5041813281d2a7151297f9ed29baabc1cfd85af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2097991
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2020-03-12 14:53:52 +00:00
Tim van der Lippe
ba26b2b503
Run ESLint on the scripts directory
...
We weren't running ESLint on this directory and, as it turns out, there
are quite a few linter errors in this folder.
R=jacktfranklin@chromium.org
Change-Id: Ic6cb9f6ad4858f69114e0c433a954041215b49e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2096705
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
2020-03-11 14:47:51 +00:00
Brandon Goddard
53faba1c7d
Reland "Add script that checks license headers of JavaScript files"
...
This reverts commit 27f15d113a6122ebd2f9https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016747
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
> > Reviewed-by: Liviu Rau <liviurau@chromium.org >
> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org >
>
> TBR=bmeurer@chromium.org ,aerotwist@chromium.org ,tvanderlippe@chromium.org ,liviurau@chromium.org
>
> Change-Id: Idc27e9b78d5ac314176c71f8f4a7a2257da08be9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019019
> Reviewed-by: Lorne Mitchell <lomitch@microsoft.com >
> Reviewed-by: Brandon Goddard <brgoddar@microsoft.com >
> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com >
TBR=bmeurer@chromium.org ,aerotwist@chromium.org ,lomitch@microsoft.com ,brgoddar@microsoft.com ,tvanderlippe@chromium.org ,liviurau@chromium.org
Change-Id: I191665c8e3fdbee7f3c5c312b5ba00513502e080
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019021
Reviewed-by: Fabio Rocha <fabio.rocha@microsoft.com >
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com >
2020-01-24 18:16:35 +00:00
Brandon Goddard
27f15d113a
Revert "Add script that checks license headers of JavaScript files"
...
This reverts commit 6122ebd2f9https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016747
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
> Reviewed-by: Liviu Rau <liviurau@chromium.org >
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org >
TBR=bmeurer@chromium.org ,aerotwist@chromium.org ,tvanderlippe@chromium.org ,liviurau@chromium.org
Change-Id: Idc27e9b78d5ac314176c71f8f4a7a2257da08be9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019019
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com >
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com >
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com >
2020-01-24 16:50:05 +00:00
Tim van der Lippe
6122ebd2f9
Add script that checks license headers of JavaScript files
...
The script checks if the license header is the BSD-3 license header that
DevTools is licensed under. It excludes files that have license headers
that reference non-Google/non-Chromium authors or are third_party
bundles that are checked into a non-third_party folder.
Change-Id: I35f78036b48d3d7b7dcb9db1e070691282e27a02
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016747
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Liviu Rau <liviurau@chromium.org >
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org >
2020-01-24 11:51:49 +00:00
Tim van der Lippe
e6a9868686
Migrate javascript_metadata/ to ESM internally
...
Bug: 1006759
Change-Id: Ibb7c4fb15197431c37c485bd1a05b20acf2bf098
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994967
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-01-15 15:27:13 +00:00
Paul Lewis
ea12f14458
Migrates javascript_metadata/ to esm
...
Bug: 1006759
Change-Id: I91c9f30d63e36995e7fa14b49072f2dcc6c37af6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1937028
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2019-11-26 17:16:06 +00:00
Joel Einbinder
75bb433138
DevTools: Fix argument hints for static constructor methods
...
The constructor name was not being passed correctly into the JSON,
which was causing static methods to be incorrectly parsed as
unique top level functions.
Bug: 913363
Change-Id: If0a94184cceef0c16b8755fe375aad3e2e48de0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501495
Reviewed-by: Erik Luo <luoe@chromium.org >
Commit-Queue: Joel Einbinder <einbinder@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#637852}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 02ae595073a7336412d333ff58c4b4b3f144c736
2019-03-05 22:33:55 +00:00
Joel Einbinder
705daf04ca
DevTools: Deduplicate more function signatures for argument hints
...
Sometimes a function would have multiple signatures in the IDL files
with the difference just being some of the arguments are optional.
This patch improves the deduplication logic to correctly support
array.splice(start, ?deleteCount, ...items)
Change-Id: Ie9230d54dadd1c8c7cadbb92afc37fbfa87ea857
Reviewed-on: https://chromium-review.googlesource.com/1062885
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org >
Commit-Queue: Joel Einbinder <einbinder@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#559342}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ddcb027a039f212e0701f7118ea7dd8b8cea65b4
2018-05-16 23:57:41 +00:00
Joel Einbinder
3f23eb2bdd
DevTools: Argument hints for native functions
...
Change-Id: Ia0e9f3c98735d64a1188b4373c90b7ef2684ea48
Reviewed-on: https://chromium-review.googlesource.com/1054582
Commit-Queue: Joel Einbinder <einbinder@chromium.org >
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org >
Reviewed-by: Erik Luo <luoe@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#558527}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a5be1a79f122d4496aa4a09ddfad0b475d878248
2018-05-14 23:27:51 +00:00
Tim van der Lippe