zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 12:33:47 +08:00
Code Issues Packages Projects Releases Wiki Activity
21,993 Commits 43 Branches 79 Tags
4d982f5fa22ed2bb960119d79f74b161d98645bc
Commit Graph
1536 Commits
Author SHA1 Message Date
Alex Rudenko 4d982f5fa2 [FreestylerEval] Support shadow roots 
Bug: 362730981
Change-Id: I7c8142f9a430951657c2843a28ea4673b43db019
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5829407
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-09-03 09:40:01 +00:00
Ergun Erdogmus 5f96b3cd26 [FreestylerEval] Sort examples in the UI 
Drive-by: Remove "Fix this issue" default query and add a flag to control it

Bug: 362730981
Change-Id: I26ea3bd0dba746d8559e8c9c38f8e987c163d5c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5831211
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-03 05:38:23 +00:00
Jack Franklin 2f408ac801 Roll browser-protocol 
This roll requires a manual review. See http://go/reviewed-rolls for guidance.

In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.

Roll created at https://cr-buildbucket.appspot.com/build/8737908188620784401

R=devtools-waterfall-sheriff-onduty@rotations.google.com

This CL also updates ESLint to disable formatting the Generated CSS
properties file; this is causing issues on Windows PRESUBMIT where
ESLint formatting fails for currently unknown reasons. Whilst we
investigate this disabling of ESLint unblocks us landing
browser-protocol rolls.

Bug: none
Change-Id: I79c0166add6d8f0748df54e979e76ce32db04e51
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5829947
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-09-03 04:32:34 +00:00
Ergun Erdogmus da928f8049 [FreestylerEval] Format errors better with cause 
Bug: 362730981
Change-Id: I899c8e764648f182bdb639544422fb77b90cd695
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5831428
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-09-02 13:09:49 +00:00
Ergun Erdogmus fb908db79e [FreestylerEval] Fix example change through selector 
Bug: 362730981
Change-Id: If4066c118a2f8035a5759e0c432ff5bfbb807d60
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5831424
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-02 13:04:46 +00:00
Ergun Erdogmus 2eb0b6f300 [FreestylerEval] Fix arrow navigation not workign correctly in eval tool 
Bug: 362730981
Change-Id: If5ed13a33fce9cd106664e9355792babf3ff9188
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5828829
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-02 10:56:15 +00:00
Ergun Erdogmus a67d39a386 [Freestyler] Run AutoFreestyler examples in parallel 
Changes are:
* Run `AutoFreestyler` prompt execution in parallel and run preparation sequentially (less flaky that way)
* Add an option to continue running sequentially too
* Update logging

Drive-by:
* Fix Freestyler effect is not getting confirmed by doing confirmation programmatically with an event

Bug: 362730981
Change-Id: I0851413ce1ec10b8327f556f1d5664fc51f7d95f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5828828
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-02 10:16:28 +00:00
Ergun Erdogmus 2d68b62358 [Freestyler] Add label to auto freestyler runs for better inspection 
Drive-by: reverse the order of the datasets since we most likely
want to see the last dataset the first.

Bug: 362730981
Change-Id: I1a15faf8954172edfb3b4b52798f906018b3bad4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5828861
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-08-30 11:41:52 +00:00
Alex Rudenko 3be028177b [Freestyler] Compute the fixable suggestion 
Bug: 361744978
Change-Id: Ic31cf6fc9a6a602abdef59ade87763847155bdb4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5816330
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-08-30 11:23:51 +00:00
Ergun Erdogmus dbc4789c32 [Freestyler] Add a try-catch block for running example 
Currently, reading comments inside shadow DOM fails

Bug: 362730981
Change-Id: I82372bb126ca6d65879dcdaa636467f760a7427a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5823401
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-08-29 15:32:19 +00:00
Alex Rudenko d6637136b5 [Freestyler] Fix ui translation issues and add a tab clean-up step 
Also, adds OWNERS.

Bug: 362730981
Change-Id: Ibbdc7f019cebc9e68f3eb78943a230d45d57207c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5823219
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-08-29 12:15:55 +00:00
Ergun Erdogmus ac2ca23d14 [Freestyler] Add AutoFreestyler in the codebase and create a simple eval UI 
Bug: 362730981
Change-Id: I2f672b0e840c94e066e875259fb8677d61f1b3e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5823213
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-08-29 08:50:36 +00:00
Danil Somsikov 1a6d02a350 Include CSS properties into known js contexts 
Bug: 357571602
Change-Id: Ie5f71b8582e28d8759519ef1397c7033debdbfed
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5816335
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2024-08-27 15:49:45 +00:00
Simon Zünd e20bdacd07 [deps] Move ts_library out of third_party 
ts_library.py and typescript.gni do not contain any third party code.
They had the Chromium license headers from the beginning. The only
"third-party"ness they have, is that they use the "typescript"
npm package.

R=alexrudenko@chromium.org

Fixed: 362397305
Change-Id: I33a2ee2817c940e365f810e897de5907bf586093
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5816329
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-08-27 10:47:27 +00:00
Adam Raine 3db6a5f4a7 [MetricCard] Update compare strings from translator feedback 
Bug: None
Change-Id: Ia19ab048d25cc9d108fca609c630e952f882ef99
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5809107
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-08-26 06:45:51 +00:00
Benedikt Meurer b7d85047a3 [eslint] Migrate front_end/core/ to CONSTANT_CASE enum values. 
Note that this only migrates the code, but doesn't yet change the
ESLint configuration, since other folders are still pending.

Bug: 361720369
Change-Id: Ia248c58a67680ff2ed8f81af0e0c04d6b6de1c7c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5807576
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2024-08-23 14:18:27 +00:00
Adam Raine 552aa9b977 [RPP Observations] Update metric compare strings 
- Refactors metric compare strings to allow sharable types
- Updates compare strings to witch "and"/"but" transitions as suggested
  by translatros.

Bug: None
Change-Id: I1acb2aaad3e45eea231125ff19130e2762d8eaa0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5805745
Commit-Queue: Adam Raine <asraine@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-08-23 08:52:14 +00:00
Danil Somsikov 65e958b5fc [console] Use Acorn instead of function constructor in JavaScriptREPL 
With strict CSP (no usafe-eval) the function constructor will always throw

Bug: 360830630
Change-Id: I5e99d660d8d9e50520f95a46355ca4b9b1350693
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5796885
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-08-20 08:33:10 +00:00
Benedikt Meurer e6a39dc688 [scripts] Provide a single npm run lint command. 
This unifies the current set of two dedicated scripts for running ESLint
and stylelint into a single script, with a single npm run-script
command. We need to migrate the Infra and devtools-internal before we
can fully remove the old scripts.

Bug: 360832181
Change-Id: Ifb98d882d951fb3e1c9d7ff8aae22c8d844ced55
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5796886
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-08-19 16:04:20 +00:00
Benedikt Meurer bc9da61308 [docs] Subsume the outdated DevTools Testing overview. 
Include everything that was still missing from the Testing overview
document[^1] into our main testing guide.

[^1]: https://docs.google.com/document/d/1c2KLKoFMqLB2A9sNAHIhYb70XFyfBUBs5BZSYfQAT-Y

Bug: 343896438
Change-Id: I852ac9e3a035f2c01ced7c59a6db2ad374ea3f88
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5789709
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2024-08-19 11:11:17 +00:00
Philip Pfaffe 0d6c0fcf8d Remove shorthands from the all list 
Bug: 329821774
Change-Id: I485b006a333cc7e0b3259bd51eac663992d6fcaf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5793100
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2024-08-19 10:12:24 +00:00
Philip Pfaffe a7a01da4e1 Correctly declare all as a shorthand 
Fixed: 329821774
Change-Id: Ic880b097fcf6519cb11c23989223ef0019006173
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5783740
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-08-14 14:10:46 +00:00
Simon Zünd a92b0bba20 [deps] Use gclient sync --nohooks to fetch GCS node binary 
R=pfaffe@chromium.org

Bug: None
Change-Id: I100abf66fad16f3e4ba22c9bea04f564adcc2569
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5776285
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-08-09 12:56:26 +00:00
Kim-Anh Tran 847478ba87 [ve] Use absolute path to KnownContextValues.ts 
Bug: 357571602
Change-Id: Ie49541d953872ef32e90ce01e8d7b5f8d30f7035
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5769261
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2024-08-07 17:10:01 +00:00
Adam Raine 17f93b862f [RPP Observations] Add detailed local/field comparison text to the tooltip 
https://screenshot.googleplex.com/4s5TLYGNk9rYC3p

Bug: 313906438
Change-Id: Iffc935e1c21d0ef1665ed4e8cdb718fb388d2456
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5767601
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2024-08-07 15:11:40 +00:00
Jack Franklin f554ff5322 RPP: insight hover icon design system fixes 
As a drive-by, also fix the lint rule to allow the sys elevation
variables when declaring box-shadow.

Bug: 348591291
Change-Id: Ib80460fef3ca4fc963e4142c2b88bfa164c8876d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5769260
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2024-08-07 13:35:02 +00:00
Danil Somsikov 2c9421b8f3 Also add newline at the end of KnownContextValues.ts 
Bug: 357571602
Change-Id: I2e694ae18db30c0b0d83ab072807466e5f1324dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5769257
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2024-08-07 11:59:10 +00:00
Danil Somsikov 9ea056f21c Include the license header into the KnownContextValues.ts 
Bug: 357571602
Change-Id: Ib5a5ab044d49f255579ae0477987bf14f39819f8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5766436
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2024-08-07 10:59:19 +00:00
Danil Somsikov 08ac97309f [ve] Track known jslog context values 
This CL introduces a list of known jslog context values, an eslint rule
to update this list and a console error message when unknown context
values are being used.

Bug: 357571602
Change-Id: I5cb2b2e8788537022d11a3acc61fb37a23bcd38d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5756569
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2024-08-07 07:40:23 +00:00
Adam Raine 8a1160df26 [RPP Observations] Adhere to greenlines and update style 
Before:
https://screenshot.googleplex.com/6MXsxBbwXMAT8Mx

After:
https://screenshot.googleplex.com/3eirANU4yMuFYJ7

- Use headings and landmark regions as the mocks indicate
- Add accessible labels to controls as the mocks indicate
- Move combobox labels inside the outlined region
- Updates `ban_a_tags_in_lit_html` to allow `<aside>` tags
- Minor style updates

Bug: 334926021
Change-Id: I5b269e5c07c1a3c88ee5daebbc68c9c8f6a10949
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5762777
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2024-08-06 09:19:21 +00:00
Adam Raine 3442a3ef00 [RPP Observations] Add basic info nuggets to metric cards 
https://screenshot.googleplex.com/4Ctja2pv2iAsRWG

The code for the info nugget strings is auto-generated by a script. In
theory, we shouldn't need to run this script very often so not worth the
effort to add it to the formal build process IMO.

This required a pretty large refactor of the `MetricCard` component,
but it's a worthwhile cleanup.

Bug: 313906438
Change-Id: Ia6c7f84954ba71e358031f84f48eaaad22d69ee1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5757940
Commit-Queue: Adam Raine <asraine@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-08-05 16:34:02 +00:00
Philip Pfaffe 3b208214f0 Make manage_node_deps script compatible with a chromium checkout 
Bug: none
Change-Id: I7fa46c6313d43a60ceea7564222a7b9d162ea584
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5752061
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-07-31 08:31:57 +00:00
Liviu Rau 75dccf1923 Update chromium_browser_protocol_revision only on actual rolls 
Bug: 352290454
Change-Id: I7161938a3482b4123fd7da67679270d321f6a501
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5737518
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Liviu Rau <liviurau@google.com>
 2024-07-24 13:30:09 +00:00
Philip Pfaffe 2e879471bc [build] add source urls to legacy CSS files 
This makes debugging devtools styles much easier.

Fixed: 353448941
Change-Id: Iaea08580f9ad563b40f99a7f34da23055b4c8551
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5712990
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2024-07-17 07:43:20 +00:00
Paul Irish fa68c093a2 Introduce eslint rule enforce optional properties are last 
Bug:338453175
Change-Id: I67b041f221592afd32f2409c228c4e5fdab1b9d0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5704156
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-07-16 23:11:18 +00:00
Liviu Rau 88c99fa3e7 Keep track of the last time we rolled browser protocol 
Also added the option to write the 2 revision numbers to a file to be consumed by the builder for writing a gitiles log line(s) in the CL description.

Bug: 352290454
Change-Id: I6941c9121347ad11d86cc022d98b70852b4373ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5688845
Commit-Queue: Liviu Rau <liviurau@google.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2024-07-11 09:49:29 +00:00
Eric Leese 460be15667 Add support for running tests in a full checkout. 
Allows the npm run test script to work when running from the
third_party/devtools-frontend/src folder of a full chromium
checkout. In this case it will trigger a chrome build and use
that binary instead of a downloaded release.

Bug: None
Change-Id: Ib53ee477954f298f443b0f528c68b25293701338
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5683365
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Eric Leese <leese@google.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-07-10 12:52:54 +00:00
Philip Pfaffe 9d80aef256 [testing] Delete obsolete runners 
Fixed: 333423685
Change-Id: I5eb0ff36ee81fad3c50ba96b3a79d1f7296df5d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5563425
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2024-07-09 18:09:36 +00:00
Liviu Rau 715da070da [testing] fix interaction tests coverage 
Bug: 333423685
Change-Id: Idfc1d058e4041afe4e53fc2aa63f877b9bbe27ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5688550
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Liviu Rau <liviurau@google.com>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-07-09 14:01:56 +00:00
Liviu Rau 6153d30e73 Add revision info to README.chromium files in dependencies 
Bug: 349578038
Change-Id: I32059625a8efb04f339a052a2c6a30b7f1588981
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5672207
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Liviu Rau <liviurau@google.com>
 2024-07-03 09:19:00 +00:00
Alex Rudenko 4c70dd1644 Remove TypeScript globals 
It looks like they all are part of TypeScript types now.

Bug: none
Change-Id: I517703732cf0ad88891981f7b9e402563dc6e47e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5643075
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-06-20 04:27:06 +00:00
Yuan Kang d60d33e9f3 Add NPM Lockfiles: 
Adds corresponding NPM lockfiles to package.json files. This enumerates dependencies, including transitive ones, and their versions, to avoid using vulnerable ones. For more details, see go/npm-lockfile-cl-guide

Bug: none
Change-Id: Ia1e5a33ef6adfe017b93e0fdb0265af04c22adfd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5632127
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-06-19 04:40:09 +00:00
Changhao Han 2d4ded199d Remove - before dark theme class name 
It does not seem that we had a particular reason to name to dark theme
class with a prepending `-`. This CL removes it so that we're consistent
with general naming conventions for CSS classes.

Bug: None
Change-Id: I19665fee4cf7a1237134f30c8f1f41e5cce17ce9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5627213
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2024-06-13 13:37:31 +00:00
Alex Rudenko 1159f76477 Roll puppeteer to 22.11.0 manually 
Also, removed source map files from the automatically rolled
libraries to avoid hitting the limits on Windows.

Fixed: 346956226
Change-Id: Ic8a7e9d272c0fc018ec0a583e7fe9b08f4f71b8a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5629080
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-06-13 12:52:21 +00:00
Liviu Rau bd81a0549d [browser_protocol] Use node from devtools 
Node deps got removed from chromium and the roller fails again.https://ci.chromium.org/ui/p/devtools-frontend/builders/ci-hp/Roll%20deps%20and%20chromium%20pin%20into%20devtools-frontend/b8746095888130672961/overview

Bug: 344827358
Change-Id: Ibd0fcdf756f9bf3a950cf841163a4a7f99ea45bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5594155
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Liviu Rau <liviurau@google.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-06-05 08:04:18 +00:00
Simon Zünd 7a3d427aa0 [unittest] Pass 'is_test_script=True' to the LPAC ACL script 
We don't know if this will actually fix the problem but it doesn't
hurt to try.

R=pfaffe@chromium.org

Bug: 324929074
Change-Id: I7c92bc036863b93f4f90af5be147e67f88a52115
No-Tree-Checks: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5568340
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-05-28 08:06:56 +00:00
Jack Franklin 2bbb561a5b Update metrics enum PRESUBMIT check with right path 
The enums file has been moved in Chromium.

Bug: none
Change-Id: I63bd0699076defabdbf13c2dbb58f47d496b7414
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5554256
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-05-22 11:32:21 +00:00
Liviu Rau 3b182cbdd8 [browser_protocol] Remove dependency from roll script 
It got removed from Chromium and the roll script fails now because of it. It also failed without this dependency in the past when we had to add it. We will probably need to pick it from somewhere else if it is still needed.

Bug: 340813542
Change-Id: If33364a9ec34220afb210ea02c02e683930cb0b5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5545190
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Liviu Rau <liviurau@google.com>
 2024-05-21 19:41:50 +00:00
Philip Pfaffe 4f909f3180 [testing] Set chrome binary acls on windows 
Unittests on windows occasionally fail because the chrome binary acls
aren't set up correctly.

Bug: 333423685
Change-Id: If6620bd162e434ee42e5d2ccee657c5b318bdf35
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5553714
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-05-21 10:27:39 +00:00
Liviu Rau cc4ed1e43f Reland "Resolve compilation target in server.js from the current path" 
This is a reland of commit cbda0e2158

Proof of fix @ https://chromium-swarm.appspot.com/task?d=true&id=696bff6c916ca010 where we trigger the same swarming task with a different CAS hash (one generated by the windows bot on self cq).

Original change's description:
> Resolve compilation target in server.js from the current path
>
> Bug: 333423685
> Change-Id: I3c00d9139794c4b7aa51b7ab5fdfef91f3ecd409
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5518529
> Reviewed-by: Andres Olivares <andoli@chromium.org>
> Reviewed-by: Danil Somsikov <dsv@chromium.org>
> Commit-Queue: Liviu Rau <liviurau@google.com>

Bug: 333423685
Change-Id: I7ae05df1492a392e85e13627edf70422fc9abdd0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5521433
Commit-Queue: Liviu Rau <liviurau@google.com>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2024-05-07 14:16:44 +00:00