zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-05 11:31:31 +08:00
Code Issues Packages Projects Releases Wiki Activity
11,596 Commits 43 Branches 79 Tags
5027efee97fed7cccd0c95930833fadbcf9cd28b
Commit Graph
1170 Commits
Author SHA1 Message Date
Nico Weber 5027efee97 Make devtools-frontend gn files not write absoute paths to generated ninja files 
Reduces `diff out/gn{1,2}/toolchain.ninja | wc -l` from 464 to 8
on my linux box.

No intended behavior change.

Bug: chromium:1278777
Change-Id: Ib9e711f67646e848fdfb95393ad75519f789ccf1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3330417
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2021-12-10 15:32:59 +00:00
Jack Franklin 7a9e4e9b2c Support --mocha-reporter-options in run_test_suite 
I landed support for Mocha's `--reporter` flag but you also need
`--reporter-options` to be able to configure them fully.

Bug: 1278289
Change-Id: I8c46bc1e9dfd87ed22edd04d60e906b622364232
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3327249
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2021-12-10 10:53:01 +00:00
Jack Franklin 3d57faf4fe Support --mocha-reporter in run_test_suite.js 
So that we can generate JSON reports from test runs.

Bug: 1278289
Change-Id: I8450280297102154a36fd9698f6cb05a76899103
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3327242
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2021-12-09 14:50:06 +00:00
Johan Bay 72ea2d5c4b Revert "Update NPM dependencies" 
This reverts commit 192c3d4ee1.

Reason for revert: Puppeteer's types.d.ts is broken.
See crrev.com/c/3320453.

Original change's description:
> Update NPM dependencies
>
> Update puppeteer to version 12.0.1
>
> Change-Id: I8f2b0378458ba9867bf58c4c49c7202b8fc2a302
> Bug: none
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3317578
> Commit-Queue: Johan Bay <jobay@chromium.org>
> Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>

Bug: none
Change-Id: Ia73b4360e062e5cfb932ae4af96d28af32c79973
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3320462
Auto-Submit: Johan Bay <jobay@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-08 11:13:19 +00:00
Tim van der Lippe 4775ec11d6 Remove rjsmin again 
Chrome OS now uses the appropriate third_party version:
https://crrev.com/c/3311066

R=jacktfranklin@chromium.org

Bug: none
Change-Id: I43470c3d1b761e9ef17aadd90491ddeffdc119aa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3318036
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-07 10:57:32 +00:00
Johan Bay 192c3d4ee1 Update NPM dependencies 
Update puppeteer to version 12.0.1

Change-Id: I8f2b0378458ba9867bf58c4c49c7202b8fc2a302
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3317578
Commit-Queue: Johan Bay <jobay@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-07 09:32:13 +00:00
Jack Franklin b633909bdc Use ESLint isLitHtmlDotHtmlCall util in rules 
Bug: 1276968
Change-Id: I88bb566d92d6c11d42a39d384b83b75efa8ac6ea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3317580
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-06 16:19:20 +00:00
Jack Franklin 54e36ade34 Lint against {describe,it}.only in ESLint tests 
Bug: none
Change-Id: Ia9dd8e924f14020d02cce25d301d086c382ebb7e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3317576
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-06 15:22:30 +00:00
Jack Franklin c1991d2a40 Extract isLitHtmlTemplateCall to ESLint utils 
Will update usages to use this util in a follow-up CL, and see if there
are more duplicated utils that deserve to be extracted.

Bug: 1276968
Change-Id: I2470da9c1f1c6fd0bf1d02a3958eabadec91d3e0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3317352
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-06 14:37:51 +00:00
Jack Franklin f13bdf17c2 Add ESLint rule for unnecessary quotes around attributes 
Bug: none
Change-Id: Ic7336d3f28def1ac6bc03d60d70662bddaab03d0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3313072
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-03 12:36:10 +00:00
Jack Franklin cdbd19c6bd Enable no only: true rule in ESLint directory 
Bug: none
Change-Id: Ib3c2e8ccbe30209f3fec04c739612eb970071021
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3314757
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-03 12:32:19 +00:00
Jack Franklin 2a84998f49 Lint for only: true in ESLint tests 
These are just like `it.only()` and we want to ensure they don't make it
to CQ and cause us to not run all the ESLint tests.

Bug: none
Change-Id: I96c1ba2838c16c9e15ae204a39bef68095e6848a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3314756
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-03 11:43:59 +00:00
Tim van der Lippe d36fbdeda7 Temporarily add back rjsmin.py for Chrome OS 
Chrome OS is accidentally relying on DevTools build scripts:
https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/resources/chromeos/accessibility/common/run_jsbundler.gni;l=16;drc=e86ab6e79b3cef0b3a37f691d8ec38d25fa0ca9e
We should clean that up, but for now let's add back the rjsmin.py script
back to unblock the DevTools autoroller.

R=kprokopenko@chromium.org

Bug: none
Change-Id: Icf51ffb5b468809bd623b3252d2f5c994409ff2f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3313066
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2021-12-02 15:08:18 +00:00
Tim van der Lippe 2ec9790ec5 Remove build_release_applications and friends 
This script is now unused and fully replaced by GN. As such, this
concludes the full `module.json` migration and related scripts, which
means we can consider crbug.com/1127902 fixed.

R=jacktfranklin@chromium.org

Fixed: 1127902
Change-Id: I0fde9c4fede0cdc8649e5e455e025a70ed4d2a09
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3310869
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-02 12:08:02 +00:00
Tim van der Lippe fd742ce33a Remove entrypoints/js_app/js_app.json 
Since this was the last entrypoint that was still processed with
`build_release_applications`, GN now starts to error and claims the
action is unused (which it is). Therefore, we need to clean up this
action as well as all the GN variables it had been using. I will clean
up the actual Python implementation in a follow-up CL, to keep this one
as small as it can be.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Ie4296885e6825d72a0b6c356971290337b680a71
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3310868
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-02 11:32:52 +00:00
Tim van der Lippe 8aeee41bc7 Remove module.json schema checks 
We have now removed all module.json files, so these checks are obsolete.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Iefe8538474b77f78eed010b0fad9461873bad03c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3310603
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-02 11:28:37 +00:00
Tim van der Lippe 73b8c4f35c Remove entrypoints/devtools_app/devtools_app.json 
R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I0d143909fa7bc40368e223b17b3825b97b6ab772
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3310865
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-02 11:26:33 +00:00
Jack Franklin 18c71916b6 Make l10n_filename_matches always need directory argument 
I realised we could make this rule much simpler:

1. It's always enabled in an `.eslintrc.js` file that is in the
   directory we want to lint.
2. Therefore, let's make the rule always required (rather than have
   some hidden default) and then we can just pass `__dirname` in.

Bug: none
Change-Id: I98cd7337181025ba3d3a1e7d1ecdf75974bc0ead
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3310611
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-01 15:27:56 +00:00
Tim van der Lippe 74367fb7b3 Remove entrypoints/inspector/inspector.json 
R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: If2d7b0d6b5058bd48955eac679fd54777e976489
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3307442
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-01 13:38:36 +00:00
Tim van der Lippe 091a3775d2 Remove entrypoints/worker_app/worker_app.json 
R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I0df40c6cd6626f599c35b0c0b8dc1d59ee0df86b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3307440
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-01 13:30:17 +00:00
Tim van der Lippe 67872d6878 Remove entrypoints/node_app/node_app.json 
This CL does a couple of things to preserve the current behavior:
- It folds `node_main` into `node_app`, since we no longer require that
distinction (this was only required prior where we used `autostart` for
`node_main`, which we no longer do)
- It removes as much side-effect instantiation from various modules and
moves them into `node_app.ts`. The order is a bit awkward, but the calls
at the end of `node_app.ts` is the order of side-effect calls as it
exists currently. After we cleaned up all entrypoints, we can remove
some of the calls and clean it up further, but let's keep them here
explicitly to ensure we retain existing behavior.
- Folds `node_app-meta.ts` into `node_app.ts` for simplicity
- We now roll up everything into `node_app.ts` directly, rather than
having a separate meta script. Since this is an entrypoint, we can do
that here. Since the entrypoint will always eagerly load, we don't need
an explicit difference between the meta file and the module
implementation.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Ida1cee76ae04b3d590dcd16d0225f65852bce5a5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306499
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-30 14:32:54 +00:00
Tim van der Lippe 19b714a693 Remove entrypoints/shell/shell.json 
Shell no longer has any content, so we can remove it from all
entrypoints. We still want to share the contents of the meta files and
all, so keep these in. However, since we are no longer processing the
`shell.js` file `build_release_applications`, we can now fold in
`shell-meta-files.ts` into `shell.js`.

Ideally, we also change `shell` to be TypeScript-authored, but we can
only do that after all entrypoints that import it (in their respective
`.js` files) are TypeScript. So we will have to do that last.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I47239286f6f1dbff63ce69cf8ca4c78bd4761030
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306497
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-29 15:55:52 +00:00
Danil Somsikov e2e1bdae2a Don't add payoad tab twice 
Bug: 1273972
Change-Id: I9bf27d223398c4d7511178d3403f9dff4b79fb4f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3304173
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-29 11:27:20 +00:00
Jack Franklin f47f3975e0 Enable l10n_filename_matches rule to have its root dir configured 
This means if we are to re-use this rule we can configure it to have a
custom root directory to validate and check all the paths against.

Bug: 1187014
Change-Id: I2ab5f921030cb41a024250ac29dd1c1c868f5454
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3302739
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-26 13:10:30 +00:00
Takuto Ikuta 0319fe0978 DEPS: use python3 
Bug: chromium:1208028
Change-Id: I409b42bd5e6297242d37cc3e88a532107222b77b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3301348
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
 2021-11-25 07:54:05 +00:00
Tim van der Lippe c4035e3b0d Update TypeScript to 4.5.2 
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I24da805038bd5d1d88dfad689f7a4ccf894af904
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3297838
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-24 12:24:53 +00:00
Tim van der Lippe c581bb8fad Update marked to 4.0.4 
DISABLE_THIRD_PARTY_CHECK=Have to update both @types/marked and marked
R=szuend@chromium.org

Bug: none
Change-Id: I1030c1d11f329bbb4b28566921efff0fd439b6de
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3297844
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-24 06:28:40 +00:00
Tim van der Lippe 0124c686d3 Update ESLint packages 
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I156623832abc081748ee50fed0ce93d864e54a67
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3297836
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-23 15:41:49 +00:00
Tim van der Lippe adf814f1f3 Remove unit test folder exemption 
Previously, we exempted our unit tests from importing only entrypoints.
However, we later realized that we always have to import the entrypoint
to avoid build non-determinism problems. Therefore, remove these exemptions,
which incidentally caught some existing violations.

The ColorUtils file is special in inspector_overlay, so we can safely
exempt that one as a one-off. The e2e-test need to import the helpers
as all other e2e-tests do. The hello-world is an example, so let's ignore
that one for now.

R=jacktfranklin@chromium.org

Bug: 1271490
Change-Id: Ib05d799b547e46cde4349b8738a5ecd63d50f3e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3291160
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-19 14:44:06 +00:00
Tim van der Lippe 6470244157 Remove panels/layers/module.json 
R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Id0995ea16b142ffd956c93a45753f6ded213ddce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3289767
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-18 15:32:56 +00:00
Tim van der Lippe 379c288384 Allow meta-files to import relative entrypoints 
We previously disabled this rule in a lot of places to workaround the
fact that the rule wasn't adhering to importing entrypoints in meta
files. Instead, let's update the rule to make it clear that this pattern
is expected and fine.

R=alexrudenko@chromium.org

Bug: 1271490
Change-Id: Idd139b42d9bb27f1f20e573b31bcd5efff8815af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3289221
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-18 14:53:06 +00:00
Tim van der Lippe cd385c2f28 Remove resources from ui/legacy/module.json 
This moves all ui/legacy stylesheets to the .css.legacy.js format. By
doing so, we can remove the module.json in a follow-up CL.

R=jacktfranklin@chromium.org

Bug: 1190991
Change-Id: I23b590845ae27880058b2ab02da8edf378ae8232
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3284811
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-16 16:47:21 +00:00
Tim van der Lippe 1b5567f78a Remove resources from perf_ui 
To remove the module.json file in perf_ui, we need to migrate the
resources to the new `generate_css` template. However, perf_ui is a bit
special, in that it doesn't properly use the widget structure. As such,
it sometimes injects CSS in places where there is no clear shadowRoot
available. Therefore, it is not possible to migrate to CSSStyleSheet in
combination with adoptedStylesheets.

As a workaround (to unblock the module.json removal), we augment
`generate_css` to add legacy file generation. All remaining resources in
DevTools will migrate to these `.css.legacy.js` files. That's because
these resources either are special (perf_ui) or are used in the
`device_mode_emulation_frame` which can't use `CSSStyleSheet` itself.

The files export an object, rather than a plain string. That's because
we need to be able to distinguish what string is referencing a CSS file
path and which strings contain the actual CSS styles. By using an
object, we can remain using the `typeof` check for string in the legacy
CSS infrastructure and otherwise destructure the object.

After this, we can remove perf_ui from the module.json structure and
properly bundle+minify the CSS resources.

R=jacktfranklin@chromium.org

Bug: 1190991, 1127902
Change-Id: I7523333e8025ae5fe5ed74b99b4e45907ff9ad97
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3275787
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-12 15:25:03 +00:00
Tim van der Lippe 0fb47801b6 Upgrade ESLint 
This pulls in version 8, which covers numerous breaking changes. Most
notably, the `CLIEngine` class has been removed, for which we should now
use `ESLint`.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: I3b64600e690f073d4db19fb34539db7200f3b561
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3268298
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-11 09:11:25 +00:00
Tim van der Lippe f9e565ef89 Add new run_lint_check_js.mjs 
ESLint 8 removed CLIEngine. Therefore, we need to migrate away from
CLIEngine to the main ESLint class (which already exists in ESLint 7).
However, that class is based on promises, which means we can't use them
in a CommonJS context.

Therefore, introduce a new `.mjs` version that uses ES modules (which
can do as we are on a recent version of Node) and use the promise
versions. There are no other functional changes compared to the old
`.js` script.

The reason that we first have to add this file here, is that our CQ
directly refers to the `.js` version. That means we first land this CL,
we update our CQ configuration and only then can we remove the `.js`
file from our repository.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Iad3656931ae09eb7f9f23b3e6ad7d39c8a761a31
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3268299
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-09 10:25:30 +00:00
Tim van der Lippe 6ddb01d4f5 Upgrade typescript-eslint 
This also includes some fixes in the rule implementations that are
required for the 5.0.0 breaking change as documented in
https://github.com/typescript-eslint/typescript-eslint/releases/tag/v5.0.0
which lists the AST-Spec changes. Specifically, `ClassProperty`
was renamed to `PropertyDefinition`.

DISABLE_THIRD_PARTY_CHECK=Requires AST changes in ESLint rules
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I1d107b071fa265af8e178ee5e229f4a9d2f00d75
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3268295
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-08 16:19:39 +00:00
Tim van der Lippe bc3a0b7a2b Upgrade eslint-plugin-import 
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I0ad7ba9133af3db19c448a284d79bdfc08101dea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3268294
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-08 16:05:33 +00:00
Tim van der Lippe 10714b5729 Upgrade eslint-plugin-lit-a11y 
This pulls in the fix for https://github.com/open-wc/open-wc/issues/2206
which reduces the size of our node_modules significantly.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Id19be5e7ed6398ffd2edb1d08b4752ef6a1d6b17
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3268293
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-08 15:56:59 +00:00
Tim van der Lippe 16b822804c Reland "Reland "Update stylelint to 14.0.1"" 
This reverts commit 2b4a9df2d9.

Reason for revert: subsequent presubmit uploads should be fixed now.

Original change's description:
> Revert "Reland "Update stylelint to 14.0.1""
>
> This reverts commit f2ea2c940d.
>
> Reason for revert: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8831129368825517985/overview
>
> Original change's description:
> > Reland "Update stylelint to 14.0.1"
> >
> > This reverts commit 6c0f161c95.
> >
> > Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed
> >
> > Original change's description:
> > > Revert "Update stylelint to 14.0.1"
> > >
> > > This reverts commit 1e08ee816b.
> > >
> > > Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview
> > >
> > > Original change's description:
> > > > Update stylelint to 14.0.1
> > > >
> > > > This also upgrades PostCSS to 8.3.11.
> > > >
> > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> > > > R=​szuend@chromium.org
> > > >
> > > > Bug: none
> > > > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
> > > > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > >
> > > Bug: none
> > > Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Owners-Override: Alex Rudenko <alexrudenko@chromium.org>
> > > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
> >
> > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> >
> > Bug: none
> > Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
>
> Bug: none
> Change-Id: Idc6c9f5cc1e225c752799461eb0344e94b4ad1e5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264222
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration

Bug: none
Change-Id: I609941d48b46bfcf454b03dcc75a76d460fbe674
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264223
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-08 14:47:39 +00:00
Tim van der Lippe 2b4a9df2d9 Revert "Reland "Update stylelint to 14.0.1"" 
This reverts commit f2ea2c940d.

Reason for revert: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8831129368825517985/overview

Original change's description:
> Reland "Update stylelint to 14.0.1"
>
> This reverts commit 6c0f161c95.
>
> Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed
>
> Original change's description:
> > Revert "Update stylelint to 14.0.1"
> >
> > This reverts commit 1e08ee816b.
> >
> > Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview
> >
> > Original change's description:
> > > Update stylelint to 14.0.1
> > >
> > > This also upgrades PostCSS to 8.3.11.
> > >
> > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> > > R=​szuend@chromium.org
> > >
> > > Bug: none
> > > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
> > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
> > > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> >
> > Bug: none
> > Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Owners-Override: Alex Rudenko <alexrudenko@chromium.org>
> > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
>
> DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
>
> Bug: none
> Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>

Bug: none
Change-Id: Idc6c9f5cc1e225c752799461eb0344e94b4ad1e5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264222
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2021-11-08 12:59:31 +00:00
Tim van der Lippe f2ea2c940d Reland "Update stylelint to 14.0.1" 
This reverts commit 6c0f161c95.

Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed

Original change's description:
> Revert "Update stylelint to 14.0.1"
>
> This reverts commit 1e08ee816b.
>
> Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview
>
> Original change's description:
> > Update stylelint to 14.0.1
> >
> > This also upgrades PostCSS to 8.3.11.
> >
> > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> > R=​szuend@chromium.org
> >
> > Bug: none
> > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
>
> Bug: none
> Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Owners-Override: Alex Rudenko <alexrudenko@chromium.org>
> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>

DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration

Bug: none
Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-08 11:24:28 +00:00
Tim van der Lippe e096798938 Fix eslint tests for Windows 
The error messages should use the proper file path format, so manually
replace the Windows folder separators with the UNIX path separators.

R=andoli@chromium.org

Fixed: 1266413
Change-Id: I499e79e857eaf97eb65faf1cb180479f08b1ee69
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259535
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-11-05 15:29:59 +00:00
Alex Rudenko 6c0f161c95 Revert "Update stylelint to 14.0.1" 
This reverts commit 1e08ee816b.

Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview

Original change's description:
> Update stylelint to 14.0.1
>
> This also upgrades PostCSS to 8.3.11.
>
> DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> R=​szuend@chromium.org
>
> Bug: none
> Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

Bug: none
Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-05 06:32:31 +00:00
Tim van der Lippe 1e08ee816b Update stylelint to 14.0.1 
This also upgrades PostCSS to 8.3.11.

DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
R=szuend@chromium.org

Bug: none
Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-04 20:20:31 +00:00
Andres Olivares c860fe1985 Introduce describe.skipOnPlatforms mocha extension 
NOPRESUBMIT=true
Bug: none
Change-Id: If0e96e43aa13a2fa557a075975c2e7f365db930a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3258130
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-03 20:44:06 +00:00
Andres Olivares 8388f33735 Use case sensitive look up in build scripts to copy file contents. 
These scripts check if a file exists and whether its content is
different from a source file before copying it. However the file look up
done with fs.existsSync() could be case-insensitive depending on the
underlying file system.

This CL implements the a case-sensitive file look up to compare against
the exact path name of the file being copied.

Bug: none
Change-Id: I0dc175c2292b3caea541a585562e8e25db637340
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3256666
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2021-11-02 15:57:40 +00:00
Alex Rudenko 273b9aa203 ESLint: ban <a> tags in lit-html templates 
NOPRESUBMIT=true
Bug: 1264796
Change-Id: I58b7e01d4232e93fc08f12fa2f9173e1c6c07060
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253322
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-10-29 13:47:02 +00:00
Mathias Bynens 4c6e92b7b8 Avoid collapsing inline tag whitespace 
This patch ensures we collapse spaces between DOM nodes
into a single space rather than removing the space entirely.
This prevents issues with missing spaces in UI text, and
generally makes the HTML minification step more safe.

Bug: chromium:1264791
Change-Id: Ib8dfaa58e973ee8682a1f43226db9f9483d9606b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252958
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2021-10-29 12:24:12 +00:00
Tim van der Lippe b1953da009 Do not include generated CSS files in code coverage report 
These are auto-generated and we don't need to know the code coverage for
these files.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Ieaaed88a3752a755e4f5e30495e38434330c7263
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3222663
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-14 10:46:49 +00:00
Tim van der Lippe 286bd5c44a Stop renaming properties in comments 
This can break automation such as the localization collection script and
the license headers, as these are sensitive to specific references in
the comments themselves. It is probably safer to not change any of the
comments anyways.

R=jacktfranklin@chromium.org

Bug: 1222126
Change-Id: Ib5223559abc215dee0f4ac16b3a3269ee827702c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3219238
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-13 11:48:33 +00:00