zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-06 03:51:24 +08:00
Code Issues Packages Projects Releases Wiki Activity
10,073 Commits 43 Branches 79 Tags
52ffe818db45e37306fbf09696bfc76fa8975e43
Commit Graph
1062 Commits
Author SHA1 Message Date
Kriti Sapra 52ffe818db [CSS]: panels/event-listeners, panels/layer_viewer and panels/media 
Bug: 1106746
Change-Id: I2a8e4421e9bc1be3c11ee21965041727de1b811d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3064215
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-08-03 13:37:03 +00:00
Tim van der Lippe 01ee32f632 Update TypeScript to version 4.3.5 
R=szuend@chromium.org

Bug: none
Change-Id: Ide44ae2b82cebf96d255f7252b3a4c3882711fad
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3060706
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-07-30 11:05:46 +00:00
Tim van der Lippe 2c89197d0d Update ESLint-related packages 
R=jacktfranklin@chromium.org

No-Presubmit: True
Bug: none
Change-Id: I52dc24b12e350787085c5e3d131cface7ea87142
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3060705
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-07-30 11:02:26 +00:00
Tim van der Lippe d8dbc41c38 Update build optimization packages 
This updates Rollup, SVGO and clean-css. Only clean-css had reported
breaking changes, but we are not affected (Node compatibility removals
and changes to features we don't use).

R=jacktfranklin@chromium.org

Bug: none
Change-Id: I94c293e128d1ddb81f12036421a715da210e7633
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3060704
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-07-30 10:46:16 +00:00
Tim van der Lippe f8c34aec19 Update all @types packages 
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I4f7d326cb76d714b30abeff8db9a0aa042e4d938
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3059613
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-07-30 10:40:28 +00:00
Kriti Sapra e812e1d2c1 [CSS]: panels/animation 
Also added checks to migration script to ensure the bodynodes have
expressions and callees.

Bug: 1106746
Change-Id: I7697c0eb725d2a3befc9b97bfcb4fa385c6a68c5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3060698
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kriti Sapra <kritisapra@google.com>
 2021-07-29 14:49:07 +00:00
Kriti Sapra 897c8aa904 [CSS] panels/lighthouse and generate_css_js now escapes ` characters 
Since we put the contents of the CSS file in ``, we need to escape any
characters that may appear in comments in the CSS file before adding
it to the .css.js file.

Bug: 1106746
Change-Id: I5e304fac9c254699f64ebe1a8f99d0b13f7307ba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3059610
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-07-29 13:00:17 +00:00
Kriti Sapra ec691c3226 Fixed path bug in migration scripts and migrated panels/help 
Bug: 1106746
Change-Id: I7ae55553b6669ed60a511ab35107b0f2642862aa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3059607
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kriti Sapra <kritisapra@google.com>
 2021-07-29 12:28:16 +00:00
Kriti Sapra 4d5496c671 Updated scripts to resolve paths for css files not in same directory 
and fixed duplicate entries in `devtools_grd_files`.

Some files import CSS files not in the same directory as them. The
script was currently unable to handle this case and so migrations led
to `File Not Found` errors for the `.css.js` files. The script now
finds the relative path from the imported file to the current file and
adapts the import statement correctly.

Duplicates were being added to `devtools_grd_files` which led to errors
during the build. The check now verifies the entire file path is
contained in the GRD file to prevent duplication.

Bug: 1106746
Change-Id: I5da808a8885bc18477cfa31801a904e17924caab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3059012
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-28 15:38:56 +00:00
Kriti Sapra 56daf78ddb Updated no-multiple-empty-lines to only have 1 as max 
DISABLE_THIRD_PARTY_CHECK=updated linting formatting
Bug: 1106746
Change-Id: I371bca95b7cf1e8b7eaa4f9e7c3860af4eedee3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3057042
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-28 14:10:15 +00:00
Kriti Sapra 93f79d6e7b Check if the file already imports css file and prevents duplication 
Bug: 1106746
Change-Id: I3d3b905c00dd7c6ce0ceefd4b2617ffe0d7ea4bc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3056377
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-27 16:37:39 +00:00
Kriti Sapra 92b65490c2 [CSS] panels/settings 
Bug: 1106746
Change-Id: Ic00f88723ed727a3056d1482b22d4429459254c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3056376
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-27 16:27:20 +00:00
Simon Zünd fb7befcb75 [i18n] Remove i18n-bundle, the bundling script and the PRESUBMIT check 
No users of the bundle left, so it can safely be removed. A last
cleanup step will remove the NPM packages necessary for bundling.

R=tvanderlippe@chromium.org

Bug: 1231873
Change-Id: I372f66339131a280c78514326d3527cbaa6cb6ea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3055246
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-07-27 14:56:29 +00:00
Kriti Sapra cf9d397f58 Add .css.js file to devtools_grd_files from migration scrips 
Bug: 1106746
Change-Id: Ifdc5ec5bb0e19e73c41e3bd0ed3f48679a161cda
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3055241
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kriti Sapra <kritisapra@google.com>
 2021-07-27 13:36:09 +00:00
Simon Zünd 73101b3e13 [deps] Remove @rollup/plugin-commonjs 
The dependency was only used by buildi18nBundle.js, which will be
removed. The CL was generated with npm 7.19.1.

R=tvanderlippe@chromium.org

Fixed: 1231873
Change-Id: Ie58e9e100e8b754d3c0c2a7badcabfc3aefcc4f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3055248
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-07-27 13:27:49 +00:00
Kriti Sapra 8733f78d00 Added edge case support for migrating legacy calls to 
`registerRequiredCSS`.

There are two main edge cases: multiple calls to
`this.registerRequiredCSS` and calls to properties of the object, e.g.
`this._widget.registerRequiredCSS`. I have added cases to the ESLint
rule to migrate these automatically.

In ESLint tests, the output is produced after only a single pass of
the rule. Keeping this in mind, the tests for multiple calls have
been broken down into multiple tests cases.

Bug: 1106746
Change-Id: If5a4827ec7230508c9208c6d23882499495be12a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3053744
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Kriti Sapra <kritisapra@google.com>
 2021-07-27 09:14:09 +00:00
Kriti Sapra 62a28b02c0 Added ESLint rule to migrate legacy calls to createShadowRootWithStyles 
Bug: 1106746
Change-Id: Id39b79e3baea93411630f6526348f30081844e82
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3048479
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Kriti Sapra <kritisapra@google.com>
 2021-07-26 14:12:19 +00:00
Danil Somsikov 3a8de8523b Add echoing websocket server to the hosted_mode server. 
This will be useful for testing websocket-related features in
devtools. From experience, echo is almost always enough to simulate needed
behavior it test, so this is not configurable until needed.

Bug: 1228705
Change-Id: Ic88b1783443c059af88cef4ea96adcf130a5a7b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3048471
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-07-23 11:30:02 +00:00
Kriti Sapra 8f45fb532f Created ESLint rule and tests to migrate legacy files 
It adds `import componentStyles from './component.css.js'` for any
registerRequiredCSS('front_end/component/component.css') call.

It also checks if there is an existing `wasShown()` method. If this
exists then it adds an extra line to add the
`this.adoptedStyleSheets = [componentStyles]` statement. Otherwise,
the `wasShown()` method is created and added.

Bug: 1106746
Change-Id: I7d0244d129fe0f4a50432fd7b53135760ae304ae
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3043915
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-07-23 11:03:24 +00:00
Danil Somsikov bc259b668a Add ws module to later add websocket server to the hosted_mode server. 
This will be useful for testing websocket-related features in devtools.

Bug: 1228705
Change-Id: Ic2a2a1d8d420734900df93a29966a9ebf9727215
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3048190
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2021-07-23 10:50:52 +00:00
Alex Rudenko 413451a8b1 Fix root path detection 
Bug: none
Change-Id: I5834aa987d8f46f2c7042c79f501e0eb9503ed96
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3045708
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-07-22 16:16:03 +00:00
Tim van der Lippe 2b21feb560 Use devtools.gni for devtools_location 
The Chromium build configuration now defines where DevTools lives.

This requires https://crrev.com/c/3043613 to roll into /build first.

R=alexrudenko@chromium.org

Fixed: 1231495
Change-Id: I2b6721a9541d191492429e9a0027523f7c9bd013
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3043614
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-07-22 13:27:33 +00:00
Tim van der Lippe e4dfc5e76a Fix devtools_location specification 
By moving the declaration into default_args, we make sure that we don't
accidentally override any definition in the GN args of an engineers.
This allows us to gradually cleanup devtools_location in Chromium.

R=alexrudenko@chromium.org

Bug: 1231495
Change-Id: I52947737907fa4c536e784eb3e993805623b0489
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3043612
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-07-21 13:34:32 +00:00
Simon Zünd 8c172ce037 [l10n] Add linter rule to forbid calling i18nString without UIStrings 
This CL prevents calls to i18nString and i18nLazyString without using
`UIStrings` as the first argument. While the rule is rather strict,
the few places where different usage is warranted, the rule can
be disabled.

The CL also fixes all call sites in violation  by either updating
types, or disabling the rule.

R=tvanderlippe@chromium.org

Bug: 1180760
Change-Id: Ibef05525577fc6b4443c1f7ea69023f1bba828ef
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3041381
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-07-21 12:29:41 +00:00
Kriti Sapra bc43679a32 Added clean-css to minify CSS on release build 
Bug: 1106746
Change-Id: I4165bb4fa30564dc3b8eff942f6cb341a6e31ffb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3037550
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-20 12:22:02 +00:00
Kriti Sapra 85d053b74c Added clean-css to manage-node-deps 
Bug: 1106746
Change-Id: Id978a94d06b15a34e396a19d46b2033e32e4fa71
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3038602
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kriti Sapra <kritisapra@google.com>
 2021-07-19 15:29:01 +00:00
Victor Porof 3393236ac7 Use chokidar as the file watcher 
DISABLE_THIRD_PARTY_CHECK=tvanderlippe

Our file watcher that was rebuilding devtools on changes relied on a
recursive option. The recursive option was only supported on macOS and
Windows, and an ERR_FEATURE_UNAVAILABLE_ON_PLATFORM exception was be
thrown when the option is used on a platform that does not support it.

One of those unsupported platforms was linux, which happens to be a
favorite around these places.

This CL switches to a cross-platform file watcher instead.

Bug: 1229622
Change-Id: Id38d1568999cdff8f054a1e716ee2525fed62fe7
Signed-off-by: Victor Porof <victorporof@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3030767
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-07-15 16:12:46 +00:00
Victor Porof 82a4ac6041 Add chokidar as a dev dependency 
Signed-off-by: Victor Porof <victorporof@chromium.org>
Change-Id: Ideee6bb0738545f4ec8b200893149f0d5ad9e39a
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3030765
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-07-15 15:38:35 +00:00
Tim van der Lippe a53672de83 Check license headers for CSS files during PRESUBMIT 
This mirrors the license header checks we perform for
Python-like files and apply the same logic for CSS.

To do so, we modify the relevant regexes and patch
function to use the correct version of comment structure
for CSS files (which use `/*` rather than `#` as delimiters).

R=jacktfranklin@chromium.org

Bug: 1106746
Change-Id: I51d51e9b793a1015aeb20a3b3a55e075c2ee748f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3014756
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-13 12:28:56 +00:00
Tim van der Lippe 0f7a51b049 Fix duplicate entrypoint naming 
In preparation of renaming an entrypoint, I discovered there was
a little bit of duplication in `generate_html_entrypoints`. To ease
renaming and maintenance, let's unify the two.

R=jacktfranklin@chromium.org

Bug: 1228264
Change-Id: I1bc98123ecd2f03e23003611bcd1e571f8c75cfb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3021230
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-12 16:41:25 +00:00
Sigurd Schneider 3d756d2481 Ensure consistent usage of Protocol.Network.RequestId 
This uncovered the fact that NetworkRequests really have two
request ids: One that is a string used in the front-end that
doesn't always have a corresponding request in the back-end,
and one that is always a back-end id. This CL makes this
explit in the types.

DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I894d6ab4d14099b9793c5e1c1a2863d2ec9c2548
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3014857
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-07-09 12:06:52 +00:00
Sigurd Schneider 30b3bd549e Ensure Fetch.RequestId is type-annotated consistently 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I02a33641e5a792e198611c43e511882c82486378
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3009827
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-07-07 13:58:18 +00:00
Sigurd Schneider c67d1d0cc3 Ensure Accessibility.AXNodeId is type-annotated consistently 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: Id731a0226ecff428e62482cdb16be9d08b0e2ed1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3009825
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-07-07 13:37:59 +00:00
Paul Lewis 2906222f2a Update Chromium source references 
Some comments in the code refer to the master branch. This CL updates
those comments to refer to the main branch instead.

Bug: 1226943
Change-Id: Ib01747a447f7fc462ed92ba2fbb961cd12c3e490
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3009819
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-07-07 10:11:57 +00:00
Sigurd Schneider baf3960471 Improve types of Dispatchers in InspectorBackend 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1172300
Change-Id: I99837d4d0b459f00084d8b44aa3008d61a6655ee
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3009814
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-07-07 08:22:27 +00:00
Sigurd Schneider e18ce8ea87 Ensure DOM.BackendNodeId is type-annotated consistently 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I8ce305dfcefcd81b93c3decf931b747da160c7ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3003253
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-07-06 09:40:16 +00:00
Sigurd Schneider 73d92ec33f Ensure DOM.NodeId is type-annotated consistently 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I6ce261be75eec735d818cdf258cfa484b7e82dc5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3003252
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-07-06 09:30:46 +00:00
Sigurd Schneider 8d9cf0d99e Ensure CacheId is treated opaquely via type system 
CacheIds must be treated opaquely by the front-end (they shouldn't be
analyzed or cooked up). This CL modifies the type emitted for CacheId
such that this is checked by the type system.

DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: Id3188bbaabf1d6554e8c412ab42f4877e262a173
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3003251
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-07-06 08:36:36 +00:00
Sigurd Schneider 6fdf2da9db Teach check_experiments.js to recognize Root.Runtime.ExperimentName 
This modifies check_experiments.js such that it recognizes the use
of Root.Runtime.ExperimentName enum members, e.g. it allows to
write

Root.Runtime.experiments.register(
  Root.Runtime.ExperimentName.LOCALIZED_DEVTOOLS,
  'Enable localized DevTools');

Bug: chromium:1226082
Change-Id: Iac0bd394a739562df7e7ce0b06f0a8ede3fdfbd7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3003255
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-07-05 14:31:23 +00:00
Christy Chen ab9a44d9de Fix devtools experiment UserMetrics and presubmit check 
There are missing entries for DevTools experiment in the UserMetrics emun, and the presubmit check has been broken so the issue didnt get caught.
This CL fix the DevTools experiment userMetrics and presubmit check

Bug: 1226082
Change-Id: I881a846b3d988746fb96ffd91eb16789198c2e3a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3002943
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-07-05 13:19:15 +00:00
Sigurd Schneider 297b80bd3c Distinguish qualified and unqualified names 
This change distinguishes qualified and unqualified names in
the inspector backend to avoid programming mistakes.

DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1172300
Change-Id: I0e0bdd82e9a4f7ce4feff459159bc18d124a949a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3003258
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-07-05 13:08:18 +00:00
Jack Franklin af799b35b5 Ensure all web components have a litTagName defined 
I discovered that the ESLint rule that enforced static tag names
wouldn't detect components that were defined as `export class ...`.

This CL fixes that rule and then subsequently fixes all the following
violations that were found now the rule is correct.

Fixed: 1225550
Change-Id: I2753659af9ba9e7280c0a212bfaaa42a1f1e849b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2999487
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-07-01 09:14:08 +00:00
Jack Franklin 41aa9f2369 Update + enforce all litTagNames are readonly 
Bug: 1225263
Change-Id: I3f22d7521229d9659fd546daeb5d776de2571500
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2997502
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-01 07:24:59 +00:00
Kriti Sapra b2b29f2cc7 [CSS Migration]: Enabled wasShown esLint rule 
Bug: 1106746
Change-Id: I373793016ce59308d1cde1b8cb7f15989d298ecc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2988318
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kriti Sapra <kritisapra@google.com>
 2021-06-29 14:00:57 +00:00
Kriti Sapra 9bd71c44f5 [CSS Migration]: Enabling lint rule to prevent <style> tags in LitHTML tempaltes 
Bug: 1106746
Change-Id: Idce7b8c0993695efa9b71402282f4deeaf10d7ff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2988914
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kriti Sapra <kritisapra@google.com>
 2021-06-29 13:08:51 +00:00
Kriti Sapra ef6988a729 [CSS Migration]: Added ESLint rule to ensure wasShown methods contain call to super.wasShown() 
Bug: 1106746
Change-Id: I7c1289f29e8b8c40e25ba37098d8c7d69e781d50
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2988310
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-06-29 09:22:02 +00:00
Kriti Sapra 5c3434c51b [CSS Migration] Added ESLint rule that bans <style> tags being used in LitHtml templates 
Bug: 1106746
Change-Id: I0701fdb0c38c2fdb43df60bb80f54075ad58f592
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2988306
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kriti Sapra <kritisapra@google.com>
 2021-06-28 11:35:20 +00:00
Jack Franklin 6c391a0969 [DarkMode] remove cmdevtools.darkmode.css 
This CL re-writes `cmdevtools.css` to migrate all the colors over to
CSS variables, and defines those colors in dark mode also. To generate
this CSS I wrote a very hacky script that parsed the original CSS,
found all the colors, and then generated the variable names and
values. It used the original legacy color patching code to generate
the dark mode values.

Given `cmdevtools.css` now contains all dark mode overrides, this CL
removes the darkmode stylesheet for `cmdevtools.css`. Given that it's
the only dark mode CSS sheet, this CL also removes all the
infrastructure for generating and checking these sheets are up to
date.

The motivation for doing this work is that maintaining the darkmode
CSS stylesheets means we have to keep the legacy patching around in
order to (re)generate the stylesheets. Doing this one off script to
move all the overrides into the original file means we don't need to
keep the legacy patching around.



Bug: chromium:1152736
Change-Id: I0cf07d54370716299819478356b42728e0e3aadb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2982137
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-06-25 10:53:26 +00:00
Kriti Sapra 1d765a5fdf Added new .css.js files to grd_files_debug_sources 
We got alerted that DevTools was not loading in chrome due to .css.js
files not being listed in the grd_files_debug_sources. This CL has the
fix for that. It adds all the migrated CSS files so far to the
debug grd files.

Bug: 1106746
Change-Id: I9b75581e59ecd3290b4fd4eecf1ddbcd46954e18
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2979698
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-06-23 09:44:29 +00:00
Simon Zünd 918e280504 Revert "Added grd_files_sources to generate_css template" 
This reverts commit d2b207117a.

Reason for revert: Seems to break debug compilation step:
https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Linux%20Compile%20Debug/3919/overview

Also confirmed locally.

Original change's description:
> Added grd_files_sources to generate_css template
>
> Bug: 1106746
> Change-Id: I4bbfc0b577248e810521460c9fb35f9dcb320f9b
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2978357
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Kriti Sapra <kritisapra@google.com>

Bug: 1106746
Change-Id: Iddd80ce81fb74092d7852b3e4f93bafa5bf7b0bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2979696
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
 2021-06-23 06:28:50 +00:00