zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-19 13:04:39 +08:00
Code Issues Packages Projects Releases Wiki Activity
6,762 Commits 45 Branches 79 Tags
59ea4edef752df4437f825732cbcacf4f6df211c
Commit Graph
218 Commits
Author SHA1 Message Date
Wolfgang Beyer 08a5d41a75 Rename frameworkBlackboxSettingsTab to frameworkIgnoreListSettingsTab 
This patch replaces unwelcoming language with better terms.

Bug: 1152082
Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k

Change-Id: I2d8930e68e30d0467dc70044d3089451d4cbad39
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2587018
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2020-12-16 10:04:38 +00:00
Christy Chen ae8efc5c4e [Loc] Migrate persistence to localization V2 
Migrate persistence
Tested with en-XL: https://imgur.com/a/nreUeRP


Bug: 1136655
Change-Id: I8eaf5d830a411d75182b5a7f642ad5ca559c781a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2591893
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-15 17:02:38 +00:00
Maks Orlovich 41545839b3 Add ability to edit UA-CH for custom devices. 
User-Agent Client Hints are an alternative to the UA String that's
more structured (no ad-hoc parsing!) and has better privacy control
(explicit control over which bits of more identifying information are
 sent).

Devtools has already supported emulating the sent client hints of the
bundled in devices; this also lets the user configure them for any new
custom devices they may add.

Screenshots:
current look, before any changes:
https://imgur.com/OHq1GMS

new, UA-CH section folded:
https://imgur.com/Eufp0VE

new section open and empty:
https://imgur.com/5uvxewJ

entering data:
https://imgur.com/ygIqS9z

all done:
https://imgur.com/5BH1Pse


Bug: 1073909
Change-Id: Id79e5eaae5d1f690d22635ca5f27566b982776b1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2543693
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-15 16:49:09 +00:00
Sigurd Schneider 59f16f12f7 Factor out AffectedResourcesView to its own file 
This will make it easier to add new AffectedResources views.

Change-Id: I87b8459f5549803c93136dc8d0b7c89352cf4362
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2589957
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2020-12-15 08:47:27 +00:00
Wolfgang Beyer af081e82fe Rename BlackboxManager.js to IgnoreListManager.js 
This patch replaces unwelcoming language with better terms.

Bug: 1152082
Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k

Change-Id: I6a42ef748f2b8e15c05b607ef7a4431948e116c9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2584971
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-12-15 08:39:37 +00:00
Sigurd Schneider e1ed9df8b8 Refactor ApplicationCacheManifestTreeElement 
This CL moves ApplicationCacheManifestTreeElement to a new file
ApplicationPanelCacheSection.ts that provides a home for all tree
element classes used in the cache section of the Application panel.

Bug: chromium:1157484
Change-Id: I83409154c82a315686770af4683fd4c7e51fa578
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2587016
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-12-14 10:46:26 +00:00
chait pinnamaneni b316d12a68 adding link support for markdownview 
Bug:1154783
Change-Id: Id87ae9da3ce1a705397af00ffd52a21175795286
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2580852
Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-11 19:59:27 +00:00
Christy Chen 393c680774 [Loc] Migrate node_debugger to Localization V2 
Bug: 1136655
Change-Id: I080bf2712871e5174873c418ad193bb82c4e543b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2580845
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-12-11 18:06:07 +00:00
Christy Chen a09a090c7a [Loc] Migrate js_profiler to Localization V2 
Bug: 1136655
Change-Id: I4f1e47cc0aff903545187ea387c24af507e5e5e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2583063
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-12-11 18:00:17 +00:00
Alfonso Castaño f74238620c [Backend] Show Issue next to corresponding line in Source Tab 
This CL contains the backend changes, the UI changes are in a followup CL.

UI CL: https://chromium-review.googlesource.com/c/2567969
Design-doc: https://docs.google.com/document/d/1TgMAUsruc_xAPAseG96H0-NHRT_PiXciedD58hgq1e4/
Screenshot: https://i.imgur.com/2iOUMqK.png
Bug: chromium:1150883
Change-Id: If252699ea6b6e33f0608bb824c00dbb9f4aacb73
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2558298
Commit-Queue: Alfonso Castaño <alcastano@google.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-12-11 12:14:17 +00:00
Sigurd Schneider 721ef456ee Refactor ApplicationPanelTreeElement 
Currently we have a large number of classes in ApplicationPanelSidebar
that all inherit (ultimately) from BaseStorageTreeElement. That class-
name is from a time when the Application panel was only about storage
and is nowadays misleading. This CL renames the class to
ApplicationPanelTreeElement and moves it to its own file. This enables
moving other classes to separate files as well.

Bug: chromium:1157484
Change-Id: Ibe4542774b15daee2e2f78d3499208d8d0c6d7c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2584922
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2020-12-11 08:55:37 +00:00
Simon Zünd 5ed854f3f2 Move Icon component from 'elements' to 'ui/components' module 
R=jacktfranklin@chromium.org

Change-Id: I49997ec89954ebcf84931af355942f5196ff190f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2581932
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-10 11:09:48 +00:00
Tim van der Lippe c8dc38a7d6 Move worker integration into entrypoint for heap_snapshot_worker 
This allows us to import the heap_snapshot_worker bundle in the
unit tests, to start computing coverage for it.

R=jacktfranklin@chromium.org

Bug: 1009443
Change-Id: I5f1456c8c28679da3e259b2da8c3e0386af5e38d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2581926
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-10 10:02:48 +00:00
vidorteg 3c56ca23d9 [Loc] Migrate node_main panel to Localization V2 
- Migrate node_main to use Localization V2 APIs.
- Removed node_main grdps

Tested with en-XL.json
https://imgur.com/a/fky46TA

Bug: 1136655
Change-Id: I6fcb6328a8a053b084f094ac0c5b1f7e98449992
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2578185
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-12-10 00:10:57 +00:00
vidorteg 768ced1d57 [Loc] Migrate mobile throttling setting panel to Localization V2 
- Migrate mobile throttling setting panel to use Localization V2 APIs.
- Removed media grdps

Tested with en-XL.json
https://imgur.com/a/PfBEBxD

Bug: 1136655
Change-Id: Ic8729040a89baa7c0d860724e7e3b8146194160f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2572862
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-09 22:32:37 +00:00
Christy Chen 87d9ffc323 [Loc] Migrate input to Localization V2 
Bug: 1136655
Change-Id: I7d8b1c34aaea07b896ec913faf141381422c3bd6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2580848
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-09 17:59:07 +00:00
Maks Orlovich 4d873174c4 Add a utility for structured header handling (1/3) 
This is a prerequisite for support for custom UA-CH in device emulation;
and will be used to convert between text and internal representations.

This portion includes the item parsing algorithm + its tests.

Bug: 1073909
Change-Id: I196a4fda0790ff6f62e0ca97a79cb75f7c7acb99
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2571441
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-09 14:55:56 +00:00
Christy Chen 19739b881b [Loc] Migrate help to localization V2 
migrate help directory

Bug: 1136655
Change-Id: Ib361747d53faa0a5cc860d331238e08d327031cc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577943
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-12-08 21:25:02 +00:00
Tim van der Lippe d47c1d7073 Fold cm_modes into text_editor 
Historically, cm_modes was used to lazily load CodeMirror MIME modes.
However, since we are no longer using CodeMirror MIME modes as
remote modules, we have switched to using ES imports to load them
instead. To that end, we made the `DefaultCodeMirrorMimeMode` extension
obsolete, as it became a noop for loading.

Moreover, cm_modes was loaded via the module.json infrastructure
present in the shell.json file. As such, in release mode these
files would properly load, but in a standalone (e.g. unit test)
environment, the missing links would cause these modes not to load.

To remedy the situation, we perform multiple fixes:
1. Remove the module.json extensions, since we are using ES imports
instead.
2. Remove DefaultCodeMirrorMimeMode.js (it is obsolete)
3. Move cm_modes.js into text_editor (this was the only module
that actually was loading the full version of CodeMirror)
4. Remove the infrastructure in CodeMirrorTextEditor.js to retrieve
the Mime modes (these were effectfully noops).

I have personally verified these Mime modes are still correctly
loading by opening a personal workspace with various Python/CC files
and confirmed that the syntax highlighting in the sources panel
is as expected.

R=aerotwist@chromium.org

Bug: 1127902
Change-Id: Ia3502713be247dc373e80fc3daa65ca7d9ecc1fe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577560
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-12-07 16:33:06 +00:00
Tim van der Lippe 3ae83c2c96 Upgrade third_party/acorn to 8.0.4 
This allows us to remove both numeric-separator and
logical-assignment plugin extensions, which reached stage 4
and are supported since Acorn 7.4.0:
https://github.com/acornjs/acorn/blob/master/acorn/CHANGELOG.md#740-2020-08-03
The parser then requires the ECMA_VERSION to be set to 2021 to make it
parse these new constructs.

Next to that, the only breaking change in 8.0.0
(https://github.com/acornjs/acorn/blob/master/acorn/CHANGELOG.md#800-2020-08-12)
makes ecmaVersion required, which we always specified already.

R=bmeurer@chromium.org

Change-Id: I64f06817f2c02e79fc29bd0a49b57b9172977a93
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2574458
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-07 11:55:55 +00:00
Sigurd Schneider 6cd7f22366 Remove twin definitions from ConsoleModel 
ConsoleModel was defining twin enums for protocol definitions. This
was a brittle approach, because those enums needed to be kept in sync
with the CDP enums by hand. Additionally, we didn't get good
type-checking, as the protocol types had to be up-cast to string to
match the ConsoleModel's interface.

This CL uses proper types to enhance type-checking, and strengthens
the ConsoleModel's interface types accordingly.

We need the .ts file to get the right type for the enums.

Bug: chromium:1153099
Change-Id: I9b669a65531bad560a00c6feb4ea4c6cd29679e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2563819
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-07 11:29:20 +00:00
Christy Chen b97d85b7ca [Loc] Migrate protocol monitor tool to localization V2 
Migrate protocol monitor tool
Tested with en-XL: https://imgur.com/a/IPT8ly2


Bug: 1136655
Change-Id: I538590b76e8511cc539d3b4770790db34c2ec5f9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2572872
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-12-04 22:22:17 +00:00
vidorteg d083f4ab10 [Loc] Migrate media panel to Localization V2 
- Migrate media panel to use Localization V2 APIs.
- Removed media grdps

Tested with en-XL.json
https://imgur.com/a/j3MxnLu

Bug: 1136655
Change-Id: Iebcce7e991db19cda8477f75b180390e1e7f5a78
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2570496
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
 2020-12-03 17:28:01 +00:00
Andres Olivares 7b9af18e2c Add ViewRegistration.ts 
Refactor ViewManager.js typedefs and methods introduced for
migrating to a new JavaScript-based extension registration,
into a dedicated TypeScript file.

Bug: 1134103
Change-Id: If0cd5d505e204576285e610a32f403489c92a89f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567981
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-02 17:02:07 +00:00
Andres Olivares 6490c00614 Add SettingRegistration.ts 
Refactor Settings.js typedefs and methods introduced for
migrating to a new JavaScript-based extension registration,
into a dedicated TypeScript file.

R=tvanderlippe@chromium.org

Bug: 1134103
Change-Id: I3d4793fbbf3371e9376fd05e15e141f38f95a0e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567383
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-02 16:27:22 +00:00
Christy Chen 5d7848d54d Reland "[Loc] Migrate changes tool to localization V2" 
This reverts commit 9e5ab71e50.

Reason for revert: The Cl was reverted due to devtools pak file limitation. That issue has been fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2558341

Original change's description:
> Revert "[Loc] Migrate changes tool to localization V2"
>
> This reverts commit abcb8f7aa8.
>
> Reason for revert: Consistently causing autoroll issues when rolling devtools-frontend into Chromium - see https://chromium-review.googlesource.com/c/chromium/src/+/2554521 for an example.
>
> To recreate this, do a debug build of Chromium with this patch applied to DevTools. It's causing an issue with duplicate keys in the pak files. No DevTools Frontend builds do a debug build of Chromium with the DevTools frontend patch applied so our CQ will be green despite causing an issue.
>
> You can run this locally in Chromium to reproduce via:
>
> autoninja -C out/Default chrome:packed_resources_extra
>
> Which will show the error. 
>
> Original change's description:
> > [Loc] Migrate changes tool to localization V2
> >
> > Migrate changes tool
> > Tested with en-XL: https://imgur.com/a/hFDBjQV
> >
> >
> > Bug: 1136655
> > Change-Id: Ic434c3085b9e2f2cf44583cca7ee1ce8f1d412f2
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548688
> > Commit-Queue: Christy Chen <chrche@microsoft.com>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
>
> TBR=szuend@chromium.org,chrche@microsoft.com
>
> Change-Id: I94b27434562f6a6bff3be381ab8a5802bd8b03f9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1136655
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2557044
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>

TBR=szuend@chromium.org,chrche@microsoft.com,jacktfranklin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1136655
Change-Id: I35166a6f4f38462073b933c01c169b3c8d14311b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567344
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Christy Chen <chrche@microsoft.com>
Commit-Queue: Christy Chen <chrche@microsoft.com>
 2020-12-02 06:13:17 +00:00
Kalon Hinds de5da1203d [Loc] Migrate snippets to Localization V2 
Bug: 1136655
Change-Id: I724747d248b047ce85761b9ec7c6ae512c939ddb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548691
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-01 21:54:27 +00:00
Michael Liao 6035f4a583 [Font Editor Prototype]: Implements Experimental Typography CSS Editor in Styles Pane 
Reference Document: https://docs.google.com/document/d/1zvmKDfdgVgL-QX2W4nKfgoeG_69YDF0AsLerIzL3rPE/edit?usp=sharing

Explainer: https://docs.google.com/document/d/1TmvbZuJR4fHuViE0X23y_1kUT43qt98mdj5GZxWf_W0/edit

Bug: 1093229
Change-Id: I0a8d049bd564a5ba547466067a12185565af7820
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2305613
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Songtao Xia <soxia@microsoft.com>
Reviewed-by: Tony Ross <tross@microsoft.com>
Reviewed-by: Shane Clifford <shanejc@microsoft.com>
 2020-12-01 19:54:05 +00:00
Alfonso Castaño b2302644f8 Display CSP Violations in a new tab drawer 
This CL introduces a new experimental tab drawer listing all CSP Violations.
It enables searching, sorting and filtering by categories of violations.

Design-doc: https://docs.google.com/document/d/1Zqd6Fq1g_Wb8Ies40OU1TSQ4f402cILFk4Nn_kP-_Cc/
Screenshot: https://i.imgur.com/ivAo61u.png
Bug: chromium:1137837
Change-Id: Ib7997b9ab59658871234ba557da8c20f50019311
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2538838
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Alfonso Castaño <alcastano@google.com>
 2020-12-01 15:12:35 +00:00
Kim-Anh Tran b11a912940 [LMI] Bind lifetime of Uint8Array to Linear Memory Inspector 
This binds the lifetime of the remote object that represents
the Uint8Array to an object group corresponding to the
linear memory inspector. This allows the user to step and finish
execution, and still inspect the same object.

Also-By: bmeurer@chromium.org
Bug: chromium:1110202
Change-Id: I1489f01ab30aee4ce87b995a7e23a19c8acce941
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2564862
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-01 13:46:35 +00:00
Simon Zünd 9cfe927efc Add Trust Token tab for requests in the network panel 
The tab currently shows only the passed parameters to the Trust Token
API. Future CLs will extend the tab to also contain the result of
the Trust Token operation in a seperate section.

Screenshots: https://imgur.com/a/FmI0pIR

R=jacktfranklin@chromium.org, sigurds@chromium.org

Bug: chromium:1126824
Change-Id: Ib189c080965cac7264fab3fb965bc1cade51d3c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2564871
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-01 10:43:35 +00:00
Alice Boxhall 56dbd799f5 Move AccessibilityModel to sdk/ 
Bug: 887173
Change-Id: Iebcec97202cf1a08e703f1cace9208f8df7c9234
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2557825
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-01 07:20:05 +00:00
Jan Scheffler 89ad6d4b94 [Recorder] Add support for window.open 
Bug: chromium:1152405
Change-Id: I443384c30838ab7c26f783898a5aa2c7cf4498c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560938
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
 2020-11-30 10:13:42 +00:00
Simon Zünd 8243768ee0 Introduce 'Report' component, intended to replace 'ReportView.js' 
Screenshot for basic.html: https://imgur.com/a/HKlHFGh

R=jacktfranklin@chromium.org

Change-Id: Idd47a0978fbcba63fb847355032e6142e4145165
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560754
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-11-30 07:12:48 +00:00
Alfonso Castaño b907775cb0 Move linkText of Linkifier into LinkifierUtils 
This CL allows to call linkText without building first a Linkifier object

Bug: chromium:1149403
Change-Id: I8ff5ab0d132ab32ca0149f6f350051aa33609451
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560755
Commit-Queue: Alfonso Castaño <alcastano@google.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-11-27 13:11:16 +00:00
Jack Franklin b70fe2a000 Remove all existing _bridge.js files 
Follow-up CL will remove the bridge generation code completely!

Bug: 1130536
Change-Id: Ie0a3a5a647e5f786c91205d1198f1b1b90fdb6ff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2562711
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2020-11-27 12:21:36 +00:00
Alex Rudenko ae8a3322ee Merge grid & flex highlighers in one 
Some logic requires the state of both the flex and
grid highlighters (setShowViewportSizeOnResize) so it
makes sense to combine the implementation in one class
given they are very similar. Additionally:

- extracted the new class into a separate file.
- added a basic unit test.
- enabled colors for flex containers.

Bug: 1150294
Change-Id: I84ae3dddcc758a3a55f849fa668c30c90e6075b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560749
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
 2020-11-27 08:52:24 +00:00
Jack Franklin fb62f3e8a9 [New Linkifier] Add <devtools-linkifier> web component 
This CL creates a new <devtools-linkifier> component that will eventually
replace the legacy linkifier code.

For now this component only supports taking a string URL, but in time (and as we
need) we can extend it to support all the inputs that the legacy Linkifier code
uses.

It works by emitting an event that is picked up by the legacy linkifier and
threaded through the legacy system.

Bug: 1149403
Change-Id: I76023052d818ab0f296db887fb03d6761ca4796b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2558297
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alfonso Castaño <alcastano@google.com>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-11-26 09:48:03 +00:00
Jack Franklin 3642900e6d Load new theme colours in the component docs. 
This CL updates the component docs server so it automatically injects the new
colour variables (which are part of the dark mode work) into the server. It
contains the following changes:

1. Pulling out the new colours into a new CSS file,
   `ui/themeColors.css`, which contain all the new definitions.
2. Injecting that new file where we inject `inspectorStyles.css`
   currently.
3. Updating the component docs server to intercept any requests to load
   an HTML example file, read the HTML contents and inject a `<style>`
   tag to load in the theme colours.
4. Additionally we now provide a small bit of JS that adds a handy
   button to toggle light/dark mode without needing to dive into the dev
   tools.

Fixed: 1152774
Change-Id: Ia2df0e00315dfeb532570ea5634fa54677337f76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560941
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-25 16:26:10 +00:00
Benedikt Meurer 25e20494db [cleanup] Remove Gimli based DWARF prototype. 
The `WasmSourceMap` approach was used as a proof of concept and served
us well, but hasn't been tested heavily lately, and is not functioning
properly anymore, so drop it in favor of the debugger language plugins.

Bug: chromium:1083146
Fixed: chromium:1152732
Tbr: aerotwist@chromium.org
Change-Id: If2191aa8a2f396136d332ed9b508168f3dc80e2c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560244
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2020-11-25 16:15:25 +00:00
Alex Rudenko c1b7aa6983 Extract OverlayColorGenerator to a separate file 
Extracting OverlayColorGenerator to make the OverlayModel.js a bit
shorter + adding a test.

Change-Id: I5d1d4472fbdbbf6ef41f2359da13bf14d53c965d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560940
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-11-25 16:00:47 +00:00
Kalon Hinds 1f437b9488 [Loc] Migrate performance_monitor to Localization V2 
Bug: 1136655
Change-Id: I281da13c70cc56a92679064d122873b406d54377
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2553935
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-11-25 08:31:14 +00:00
Jack Franklin 9e5ab71e50 Revert "[Loc] Migrate changes tool to localization V2" 
This reverts commit abcb8f7aa8.

Reason for revert: Consistently causing autoroll issues when rolling devtools-frontend into Chromium - see https://chromium-review.googlesource.com/c/chromium/src/+/2554521 for an example.

To recreate this, do a debug build of Chromium with this patch applied to DevTools. It's causing an issue with duplicate keys in the pak files. No DevTools Frontend builds do a debug build of Chromium with the DevTools frontend patch applied so our CQ will be green despite causing an issue.

You can run this locally in Chromium to reproduce via:

autoninja -C out/Default chrome:packed_resources_extra

Which will show the error. 

Original change's description:
> [Loc] Migrate changes tool to localization V2
>
> Migrate changes tool
> Tested with en-XL: https://imgur.com/a/hFDBjQV
>
>
> Bug: 1136655
> Change-Id: Ic434c3085b9e2f2cf44583cca7ee1ce8f1d412f2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548688
> Commit-Queue: Christy Chen <chrche@microsoft.com>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

TBR=szuend@chromium.org,chrche@microsoft.com

Change-Id: I94b27434562f6a6bff3be381ab8a5802bd8b03f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1136655
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2557044
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-11-24 10:54:09 +00:00
Christy Chen abcb8f7aa8 [Loc] Migrate changes tool to localization V2 
Migrate changes tool
Tested with en-XL: https://imgur.com/a/hFDBjQV


Bug: 1136655
Change-Id: Ic434c3085b9e2f2cf44583cca7ee1ce8f1d412f2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548688
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-11-23 18:46:16 +00:00
vidorteg 068400262b [Loc] Migrate lighthouse panel to Localization V2 
- Migrate lighthouse panel to use Localization V2 APIs.
- Does not migrate lighthouse-worker yet (which builds the report)
- Removed lighthouse grdps

Tested with en-XL.json
https://imgur.com/a/sjbn3C5

Bug: 1136655
Change-Id: Ib55fabf941e4c0ae7ef5e1beb3cf4726b836386e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548696
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-11-21 05:39:03 +00:00
vidorteg af634bcc6c [Loc] Migrate animation panel to Localization V2 
- Migrate animation panel to use Localization V2 APIs.
- Removed animation grdps

Tested with en-XL.json
https://imgur.com/a/eVERZjZ

Bug: 1136655
Change-Id: I71fdcff68757b13ed72d735644ef09c6609f54d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548263
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-11-21 02:28:13 +00:00
Kalon Hinds 361d02972a [Loc] Migrate developer_resources to Localization V2 
Bug: 1136655
Change-Id: I01278b1c215dd7efa7255223a520df3524c53897
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2552105
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-11-20 19:47:24 +00:00
Jan Scheffler 3a230e2849 [Recorder] Add recording to DevTools 
Bug: chromium:1144127
Change-Id: I58a5add98bf08a8113ecdf674e08911a79f7b12b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2505657
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-19 13:55:32 +00:00
Alfonso Castaño 13dcbd22d4 Breakpoint on Trusted Type violation (Devtools) 
This CL introduces a categorized sidebar pane to set breakpoints on Trusted Type violations.

DISABLE_THIRD_PARTY_CHECK=protocol change
https://docs.google.com/document/d/1rlRtq_Ai0leS9sqlRvoOL5RNc1BR6Q1yAVvLLJFasMA/
Screenshot: https://i.imgur.com/8Aythwz.png
Bug: chromium:1142804
Change-Id: I3e14e35165f1b157da922f534be52a10df9178ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2517571
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Alfonso Castaño <alcastano@google.com>
 2020-11-19 11:55:14 +00:00
Kalon Hinds 438d44197a [Loc] Migrate security to Localization V2 
Bug: 1136655
Change-Id: I77e776f00249eb97f49e24681d19722f500c4c86
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2546327
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-11-19 01:34:11 +00:00