 Paul Lewis
|
17e384ec75
|
Reland "Migrates refs to Common inside ui/ to ESM"
This reverts commit e2db893b1d.
Reason for revert: Should be fixed now due to https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1981615
Original change's description:
> Revert "Migrates refs to Common inside ui/ to ESM"
>
> This reverts commit 77e01616ea.
>
> Reason for revert:
> https://bugs.chromium.org/p/chromium/issues/detail?id=1039577
>
> Original change's description:
> > Migrates refs to Common inside ui/ to ESM
> >
> > Bug: 1006759
> > Change-Id: I5967981a53e1f227270c112ce636c32f3c33d9e2
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1985676
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
>
> TBR=aerotwist@chromium.org,tvanderlippe@chromium.org
>
> Change-Id: I62c1477175307b0b9a54f2cace5fa6ba5af9d667
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1006759, 1039577
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1989312
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
TBR=tikuta@chromium.org,aerotwist@chromium.org,tvanderlippe@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1006759, 1039577
Change-Id: I15f70155ba12d6d8d0fcfd8d0c956573839f4e97
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991501
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
|
2020-01-08 16:06:56 +00:00 |
|
|
Takuto Ikuta
|
e2db893b1d
|
Revert "Migrates refs to Common inside ui/ to ESM"
This reverts commit 77e01616ea.
Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=1039577
Original change's description:
> Migrates refs to Common inside ui/ to ESM
>
> Bug: 1006759
> Change-Id: I5967981a53e1f227270c112ce636c32f3c33d9e2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1985676
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
TBR=aerotwist@chromium.org,tvanderlippe@chromium.org
Change-Id: I62c1477175307b0b9a54f2cace5fa6ba5af9d667
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1006759, 1039577
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1989312
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
|
2020-01-07 06:29:20 +00:00 |
|
|
Paul Lewis
|
77e01616ea
|
Migrates refs to Common inside ui/ to ESM
Bug: 1006759
Change-Id: I5967981a53e1f227270c112ce636c32f3c33d9e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1985676
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
|
2020-01-06 17:28:33 +00:00 |
|
|
Paul Lewis
|
9950e186c4
|
Migrates internal refs of ui/ to esm
Please note: ESLint and Closure have different opinions on the
necessity of imports, thus // eslint-disable-line no-unused-vars
was added to imports used only for Closure types.
Bug: 1006759
Change-Id: Idd32e12d23a636f1e0fdcb90742e4b706e3cef77
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1967134
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
|
2019-12-16 16:52:27 +00:00 |
|
|
Tim van der Lippe
|
0830b3daa4
|
Convert ui/ to ESM
- ViewManager has been extracted from View
- Action has been extracted from ActionRegistry
- ContextFlavorListener has been extracted from Context
Bug: 1006759
Change-Id: Iff41f3a7db4dcbd6da90fd5752923e32af03bac8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827294
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#702390}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0ffd51ccac853da7c8ec3d91ae868bc61626b29b
|
2019-10-03 13:20:07 +00:00 |
|
|
Mandy Chen
|
d81e834134
|
DevTools: Convert concatenated string and link to embedded link in string in debugging terminated screen
Use UI.formatLocalize to embed a link inside a localizable string.
This is a sequent patch to https://crrev.com/c/1658750
No visual change in UI:
Before: https://i.imgur.com/Tbxkwe1
After: https://imgur.com/hcfsuwf
Bug: 941561
Change-Id: I0d7d8e42a83b9b4f18c6b928a5af706d21f0f85a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658593
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#669064}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 050ddbf4aa54b71f4b4118ad21ea44788abcdb8d
|
2019-06-14 00:31:22 +00:00 |
|
|
Blink Reformat
|
4c46d0969f
|
The Great Blink mv for source files, part 2.
Move and rename files.
NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true
Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
|
2018-04-07 15:32:37 +00:00 |
|