zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 04:26:32 +08:00
Code Issues Packages Projects Releases Wiki Activity
22,955 Commits 43 Branches 79 Tags
5cfe4e795409fd7dd5afc02594a7051648de29aa
Commit Graph
1561 Commits
Author SHA1 Message Date
Jack Franklin dd7b7212cf Lint itScreenshot.skip like we lint other skip calls 
Fixed: 373791684
Change-Id: If9729360cf7260b9cbf068b9cfa5f6876a60cada
No-Presubmit: True
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5933853
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2024-10-16 10:09:51 +00:00
Nikolay Vitkov 60a23c771c [Lint] Fix issue with window 
Windows max line argument is around 8000, if you pass that the command
will fail, we need to split the LitAnalyzer files when we spawn it.

No-Presubmit: true
Bug: none
Change-Id: I68dd71228b02a8ae01555b23a229f5fcc69b2a11
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5923563
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2024-10-15 11:11:02 +00:00
Danil Somsikov 6806877859 Use type-only import where possible. 
Not only this is shorter, it also allows having a side-effect import in addition to the type-only
import and is properly understood by lit-analyzer.

No-Presubmit: true
Bug: 370734442
Change-Id: I32f0a6198e8de8175201d8ce576a63a9ce25806f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5921081
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2024-10-11 20:29:33 +00:00
Joshua Thomas e2625e34dc Fix node path for arm macs 
Bug: 370734442
Change-Id: Ia3a0f63970e302a735b507467e843846a2159f98
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5920518
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Shuran Huang <shuuran@chromium.org>
Commit-Queue: Joshua Thomas <masnoble@chromium.org>
 2024-10-10 17:33:29 +00:00
Nikolay Vitkov a4e79c12f1 Add fixer for assert equal rule 
We currently only report an error, but we can auto fix in the
general use cases where we can deduce the expected type.

No-Presubmit: true
Bug: none
Change-Id: Icb0b8857664f94da6a2f60cbf1862e788e7a4d9c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5917832
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-10-10 13:19:02 +00:00
Danil Somsikov 29e865259c Report lit-analyzer status correctly so that it can break presubmit 
No-Presubmit: true
Bug: none
Change-Id: I1d360f85a3551e6d9d28030007e502d5ce204d83
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5920706
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-10-10 10:21:05 +00:00
Danil Somsikov 868ff924c5 Lint rule enforcing the use of unqalified html template tag. 
lit-analyzer only inspects html`...` not LitHtml.html`...`

No-Presubmit: true
Bug: 370734442
Change-Id: I2ea66f5b0847ce9f04880389fa0197d57aabb0b7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5921258
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-10-10 05:40:41 +00:00
Alex Rudenko c8ad1e5573 [AutoFreestyler] Basic side-by-side view for eval 
Two column layout can be improved but it would require more
changes to how rendering works.

Bug: none
Change-Id: Iccceb1f53d406dcac767e2599b5d39da3c4b6750
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5920235
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-10-09 14:36:30 +00:00
Jack Franklin b055020953 Fix use_theme_colors check with outline properties 
Fixed: 371989111
Change-Id: Ib05081d71f93fa4ebb7fd787b6067ac30154a479
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5912682
Commit-Queue: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2024-10-08 16:53:37 +00:00
Danil Somsikov d74dc865b3 Remove check_component_naming and ban_literal_devtools_component_tag_names eslint rules. 
These are superceeded by the lit-analyzer

No-Presubmit: true
Bug: 301364727
Change-Id: If14f928e9bff3fe5d3cdfe9b7b94adc2887aa43c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5915494
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2024-10-08 08:40:20 +00:00
Danil Somsikov 058b9d879d Add lit-analyzer and run it as a part of lint check 
Bug: 370734442
No-Presubmit: true
Change-Id: I7021b801e5bacd4ed33643651a53b8db20ccf8b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5898986
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-10-07 12:41:05 +00:00
Danil Somsikov dc5df3fd69 Remove custom_element_definitions_location lint rule. 
It is hard to justify this requiement in the light of UI engineering
approach we are taking.

Bug: 301364727
Change-Id: I9f8f42255aab5dd41858e5840e048e47719f8520
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5899035
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2024-10-01 16:29:08 +00:00
Nikolay Vitkov 0ceb32a42f Fix lint rule for multiline props 
In some cases the formatter won't complain about the multiline cases,
but this rule won't pick it up correctly erroring as the `.exec`
returns `null`, fixed with a check.
Also update the RegEx to support multiline CSS and parse them
accordingly.

Bug: none
Change-Id: Ie961e66fce1ff517605d98a14c71086612e61692
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5891590
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2024-09-26 08:54:41 +00:00
Nikolay Vitkov 2709fa7447 [Freestyler] Rename to AI assistance 
Update strings to match new name

Bug: 369535878
Change-Id: Id331ad023eced745d2ae8ef9b09e807e12e31779
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5890171
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2024-09-25 17:53:57 +00:00
Jack Franklin df21499a0d Add default-import-name rule to eslint 
And enable it; we are using this to enforce the name used when the
TraceEngine is imported. The rule is configurable so we can extend it to
check more instances if required.

Bug: 368562239
Change-Id: Ic9b61d981ea32b4549853cdfee78c6e53e9443c6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5882693
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2024-09-23 19:03:04 +00:00
Jack Franklin 2d72d76e3a ESLint: fix formatting of eslint files 
Applies the `quote-props` rule and unignores the front_end/.eslintrc.js
file from ESLint so we consistently lint them all.

Bug: none
Change-Id: I65343550386c762467f41077b1d4dff869dae39d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5882053
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2024-09-23 11:47:40 +00:00
Philip Pfaffe a9900b6f46 [testing] Support running inside of a chromium checkout on mac/win 
Fix the lookup path for the chromium binary

Drive-by: Also check if there's a build.ninja inside the target
directory.

Bug: none
Change-Id: Ib97e278e75892e7e4f67e58996307f131426a26b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5872494
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
 2024-09-19 11:13:16 +00:00
Ergun Erdogmus 3a9b57fa14 [FreestylerEval] Export evaluations as CSV 
Bug: none
Change-Id: I4765f5b77cb099107d38a1053fa1f78ae37e8399
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5865670
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-16 13:48:01 +00:00
Connor Clark 2b55515d9d Add some additional help to snapshot documentation 
Bug: None
Change-Id: I65d0b95e7de7c70b17523830a7eff8c1245d583d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5846631
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-09-10 09:11:47 +00:00
Paul Irish 9657a01fb6 [eslint] enable object-shorthand, no-useless-rename 
Bug: none
Change-Id: I055b1743d105e2e3f5b95e150dbf687531317d57
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5838137
Auto-Submit: Paul Irish <paulirish@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-09-05 15:44:34 +00:00
Alex Rudenko cb4b9688d4 Remove coverage 
Infra change: https://chromium-review.googlesource.com/c/chromium/tools/build/+/5833493

Bug: 364237269
Change-Id: Iebc847a3a3644b5538771b94128943da588910a7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5830445
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-05 11:38:42 +00:00
Benedikt Meurer 67b69bf002 [cleanup] Remove "Highlight important DOM properties in the Object Properties viewer" experiment. 
This feature never made it past the experiment stage and while we believe
that it's beneficial to highlight important DOM properties, we aren't
convinced that this approach is the right one. Since we have no capacity
or intention to work on this experiment, we are removing the code now.

Doc: http://go/pinned-properties
Bug: 40267030, 40840064
Change-Id: Ib2d0f287834ca9ee87d957bd64f77a450c322f46
Fixed: 315126594
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5836838
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Victor Porof <victorporof@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2024-09-04 14:40:11 +00:00
Nikolay Vitkov 47310242ac [Cleanup] Enable EsLint quote-props 
Enable a EsLint rule to enforce code-style

Bug: none
Change-Id: I4fa6d09a744999dc2967fe989a2339423bb78c86
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5833497
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2024-09-04 11:57:11 +00:00
Alex Rudenko b35651707c [FreestylerEval] fix issue with multiline inputs 
Join with space instead of newline. Sending
a newline will result in immediate form submission.

Bug: 362730981
Change-Id: I2f82fcd737efbab2ec963e93f15255b52a1b915b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5829216
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-09-03 11:17:14 +00:00
Jack Franklin 0560bc9af5 Remove clang-format line from generated CSS 
A leftover from when we thought clang-format was incorrectly formatting
this file, which we now know to not be the case.

Bug: none
Change-Id: Ieefa6eea00c64f930727e1cc8dfd669f629dd6e9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5830499
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2024-09-03 11:16:05 +00:00
Alex Rudenko 4d982f5fa2 [FreestylerEval] Support shadow roots 
Bug: 362730981
Change-Id: I7c8142f9a430951657c2843a28ea4673b43db019
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5829407
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-09-03 09:40:01 +00:00
Ergun Erdogmus 5f96b3cd26 [FreestylerEval] Sort examples in the UI 
Drive-by: Remove "Fix this issue" default query and add a flag to control it

Bug: 362730981
Change-Id: I26ea3bd0dba746d8559e8c9c38f8e987c163d5c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5831211
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-03 05:38:23 +00:00
Jack Franklin 2f408ac801 Roll browser-protocol 
This roll requires a manual review. See http://go/reviewed-rolls for guidance.

In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.

Roll created at https://cr-buildbucket.appspot.com/build/8737908188620784401

R=devtools-waterfall-sheriff-onduty@rotations.google.com

This CL also updates ESLint to disable formatting the Generated CSS
properties file; this is causing issues on Windows PRESUBMIT where
ESLint formatting fails for currently unknown reasons. Whilst we
investigate this disabling of ESLint unblocks us landing
browser-protocol rolls.

Bug: none
Change-Id: I79c0166add6d8f0748df54e979e76ce32db04e51
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5829947
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-09-03 04:32:34 +00:00
Ergun Erdogmus da928f8049 [FreestylerEval] Format errors better with cause 
Bug: 362730981
Change-Id: I899c8e764648f182bdb639544422fb77b90cd695
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5831428
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-09-02 13:09:49 +00:00
Ergun Erdogmus fb908db79e [FreestylerEval] Fix example change through selector 
Bug: 362730981
Change-Id: If4066c118a2f8035a5759e0c432ff5bfbb807d60
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5831424
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-02 13:04:46 +00:00
Ergun Erdogmus 2eb0b6f300 [FreestylerEval] Fix arrow navigation not workign correctly in eval tool 
Bug: 362730981
Change-Id: If5ed13a33fce9cd106664e9355792babf3ff9188
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5828829
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-02 10:56:15 +00:00
Ergun Erdogmus a67d39a386 [Freestyler] Run AutoFreestyler examples in parallel 
Changes are:
* Run `AutoFreestyler` prompt execution in parallel and run preparation sequentially (less flaky that way)
* Add an option to continue running sequentially too
* Update logging

Drive-by:
* Fix Freestyler effect is not getting confirmed by doing confirmation programmatically with an event

Bug: 362730981
Change-Id: I0851413ce1ec10b8327f556f1d5664fc51f7d95f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5828828
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-02 10:16:28 +00:00
Ergun Erdogmus 2d68b62358 [Freestyler] Add label to auto freestyler runs for better inspection 
Drive-by: reverse the order of the datasets since we most likely
want to see the last dataset the first.

Bug: 362730981
Change-Id: I1a15faf8954172edfb3b4b52798f906018b3bad4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5828861
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-08-30 11:41:52 +00:00
Alex Rudenko 3be028177b [Freestyler] Compute the fixable suggestion 
Bug: 361744978
Change-Id: Ic31cf6fc9a6a602abdef59ade87763847155bdb4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5816330
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-08-30 11:23:51 +00:00
Ergun Erdogmus dbc4789c32 [Freestyler] Add a try-catch block for running example 
Currently, reading comments inside shadow DOM fails

Bug: 362730981
Change-Id: I82372bb126ca6d65879dcdaa636467f760a7427a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5823401
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-08-29 15:32:19 +00:00
Alex Rudenko d6637136b5 [Freestyler] Fix ui translation issues and add a tab clean-up step 
Also, adds OWNERS.

Bug: 362730981
Change-Id: Ibbdc7f019cebc9e68f3eb78943a230d45d57207c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5823219
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-08-29 12:15:55 +00:00
Ergun Erdogmus ac2ca23d14 [Freestyler] Add AutoFreestyler in the codebase and create a simple eval UI 
Bug: 362730981
Change-Id: I2f672b0e840c94e066e875259fb8677d61f1b3e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5823213
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-08-29 08:50:36 +00:00
Danil Somsikov 1a6d02a350 Include CSS properties into known js contexts 
Bug: 357571602
Change-Id: Ie5f71b8582e28d8759519ef1397c7033debdbfed
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5816335
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2024-08-27 15:49:45 +00:00
Simon Zünd e20bdacd07 [deps] Move ts_library out of third_party 
ts_library.py and typescript.gni do not contain any third party code.
They had the Chromium license headers from the beginning. The only
"third-party"ness they have, is that they use the "typescript"
npm package.

R=alexrudenko@chromium.org

Fixed: 362397305
Change-Id: I33a2ee2817c940e365f810e897de5907bf586093
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5816329
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-08-27 10:47:27 +00:00
Adam Raine 3db6a5f4a7 [MetricCard] Update compare strings from translator feedback 
Bug: None
Change-Id: Ia19ab048d25cc9d108fca609c630e952f882ef99
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5809107
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-08-26 06:45:51 +00:00
Benedikt Meurer b7d85047a3 [eslint] Migrate front_end/core/ to CONSTANT_CASE enum values. 
Note that this only migrates the code, but doesn't yet change the
ESLint configuration, since other folders are still pending.

Bug: 361720369
Change-Id: Ia248c58a67680ff2ed8f81af0e0c04d6b6de1c7c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5807576
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2024-08-23 14:18:27 +00:00
Adam Raine 552aa9b977 [RPP Observations] Update metric compare strings 
- Refactors metric compare strings to allow sharable types
- Updates compare strings to witch "and"/"but" transitions as suggested
  by translatros.

Bug: None
Change-Id: I1acb2aaad3e45eea231125ff19130e2762d8eaa0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5805745
Commit-Queue: Adam Raine <asraine@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-08-23 08:52:14 +00:00
Danil Somsikov 65e958b5fc [console] Use Acorn instead of function constructor in JavaScriptREPL 
With strict CSP (no usafe-eval) the function constructor will always throw

Bug: 360830630
Change-Id: I5e99d660d8d9e50520f95a46355ca4b9b1350693
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5796885
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-08-20 08:33:10 +00:00
Benedikt Meurer e6a39dc688 [scripts] Provide a single npm run lint command. 
This unifies the current set of two dedicated scripts for running ESLint
and stylelint into a single script, with a single npm run-script
command. We need to migrate the Infra and devtools-internal before we
can fully remove the old scripts.

Bug: 360832181
Change-Id: Ifb98d882d951fb3e1c9d7ff8aae22c8d844ced55
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5796886
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-08-19 16:04:20 +00:00
Benedikt Meurer bc9da61308 [docs] Subsume the outdated DevTools Testing overview. 
Include everything that was still missing from the Testing overview
document[^1] into our main testing guide.

[^1]: https://docs.google.com/document/d/1c2KLKoFMqLB2A9sNAHIhYb70XFyfBUBs5BZSYfQAT-Y

Bug: 343896438
Change-Id: I852ac9e3a035f2c01ced7c59a6db2ad374ea3f88
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5789709
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2024-08-19 11:11:17 +00:00
Philip Pfaffe 0d6c0fcf8d Remove shorthands from the all list 
Bug: 329821774
Change-Id: I485b006a333cc7e0b3259bd51eac663992d6fcaf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5793100
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2024-08-19 10:12:24 +00:00
Philip Pfaffe a7a01da4e1 Correctly declare all as a shorthand 
Fixed: 329821774
Change-Id: Ic880b097fcf6519cb11c23989223ef0019006173
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5783740
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-08-14 14:10:46 +00:00
Simon Zünd a92b0bba20 [deps] Use gclient sync --nohooks to fetch GCS node binary 
R=pfaffe@chromium.org

Bug: None
Change-Id: I100abf66fad16f3e4ba22c9bea04f564adcc2569
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5776285
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-08-09 12:56:26 +00:00
Kim-Anh Tran 847478ba87 [ve] Use absolute path to KnownContextValues.ts 
Bug: 357571602
Change-Id: Ie49541d953872ef32e90ce01e8d7b5f8d30f7035
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5769261
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2024-08-07 17:10:01 +00:00
Adam Raine 17f93b862f [RPP Observations] Add detailed local/field comparison text to the tooltip 
https://screenshot.googleplex.com/4s5TLYGNk9rYC3p

Bug: 313906438
Change-Id: Iffc935e1c21d0ef1665ed4e8cdb718fb388d2456
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5767601
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2024-08-07 15:11:40 +00:00