zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-02 18:11:04 +08:00
Code Issues Packages Projects Releases Wiki Activity
2,131 Commits 43 Branches 79 Tags
5f86e050c2e8388eb42cf6fb2ff39b4f2bcbe910
Commit Graph
78 Commits
Author SHA1 Message Date
Al Muthanna Athamina a647af0d9f Remove needless parseInt from toChar test 
Bug: chromium:1045385
Change-Id: I1a68a890d739ca7c904e9a5518d62ae93ef74aaa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019558
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-01-24 17:03:35 +00:00
Al Muthanna Athamina 920a535e52 Improve CharacterIdMap max capacity test 
Bug: chromium:1045385
Change-Id: Ib9b93b9cb6d6561b3f432e32a506ad4602abf039
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019124
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-01-24 14:15:08 +00:00
Mathias Bynens e19ef55a35 [e2e] Simplify collectAllElementsFromPage helper 
This is a follow-up to [1].

[1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2007505/1/test/e2e/helper.ts#74

Bug: chromium:1044632
Change-Id: I1511c53393e9ec57e1c68085d06cf1c9841791fa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019140
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-24 14:12:49 +00:00
Al Muthanna Athamina 5a6f405f63 Remove tests that access private attributes 
This CL removes tests that access private
attributes since doing so is not good practice
and they are covered by other tests.

Change-Id: Ie2c91a1ff374671ebf6c60c7be3685ae795fc990
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2017142
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
 2020-01-23 16:43:30 +00:00
Tim van der Lippe 5a09d7a835 Migrate protocol/ to import cross-module 
Bug: 1006759
Change-Id: Idab6f7a909932a1ad37b9bbb317e1cb3ff567814
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016750
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-23 14:15:00 +00:00
Tim van der Lippe 4d1ddf7f73 Migrates protocol/ to ESM internally 
Bug: 1006759
Change-Id: I99743fcf3d33bc1e5a3b729c2c544826e1d8e923
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2013156
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-23 13:19:20 +00:00
Paul Lewis 4ae5f4f5ce [Global] Update refs to SDK.targetManager 
Bug: 1006759
Change-Id: I0686ef929b89e75c2ea8a731c593d955eca85935
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2015119
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-01-23 10:56:40 +00:00
Al Muthanna Athamina e44c273733 Create Karma tests for CharacterIdMap and Settings 
This CL attempts to create Karma tests for the
Settings and CharacterIdMap files. Please note
that most of the Settings file was not covered
because it throws an error when the Settings
class is instantiated

Change-Id: Ie58a6562ebb7cb89de76c66f394fcb116617cdef
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1883709
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-23 10:45:00 +00:00
Paul Lewis 5da3c093de Fixes e2e hello world test 
TBR=tvanderlippe@chromium.org

Bug: 1044632
Change-Id: I6faf0340f6f792ad6aa540fc31057b426676213e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016742
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-01-23 10:32:00 +00:00
Paul Lewis b8b3801b10 Adds e2e scripts and 'Hello, World' test 
Bug: 1044632
Change-Id: I1f6c75c0c03f7f03cb2e8e92e8766af0c8444057
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2007505
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-01-22 17:23:15 +00:00
Paul Lewis e73301b4f0 Migrates text_utils to ESM internally 
Bug: 1006759
Change-Id: I12d61f3b7a1480332a4c70d04cbb3844cb926631
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2002192
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-22 14:56:54 +00:00
Sigurd Schneider 3266a380c0 [karma-tests] Add more tests for TextRange 
Bug: chromium:1032561
Change-Id: I3f195636f7371477085ae8a9c13b1909297f5e8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2003317
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Almothana Athamneh <almuthanna@google.com>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-20 09:03:37 +00:00
Tim van der Lippe 9293af7230 Migrate sdk/ to ESM internally 
Bug: 1006759
Change-Id: I2bb0c8eaa4fdc89edd8da2b12d9fd0e08d427174
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2003327
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-17 15:17:17 +00:00
Mathias Bynens b446206d93 Make sort test work as intended 
`Array.prototype.sort` updates the array in place, and so this test
was previously equivalent to `array === array`. This patch makes the
test work as intended!

Bug: chromium:1032561
Change-Id: I3702c0ca9b06359df33d915a65e59a2495fb64d2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2003324
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-16 15:57:26 +00:00
Tim van der Lippe 399a956776 Reland "Use typescript-eslint instead of tslint" 
This reverts commit 72da1a51cb.

Reason for revert: Buildbots in Chromium no longer run the linter checks.

Original change's description:
> Revert "Use typescript-eslint instead of tslint"
> 
> This reverts commit d0e22da4db.
> 
> Reason for revert: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8891272266464063200/+/steps/devtools_lint_check__with_patch_/0/stdout
> 
> Original change's description:
> > Use typescript-eslint instead of tslint
> >
> > This will update our eslint configuration to use @typescript-eslint to
> > parse and lint TypeScript files. It integrates with the existing
> > infrastructure to lint our files
> >
> > Fixed: 1041811
> > Change-Id: I29f49a57229e3ee17524045b3905b9cc835271ab
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1998771
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> 
> TBR=aerotwist@chromium.org,tvanderlippe@chromium.org
> 
> Change-Id: Ic0dfc585cd0ac08f1f4a72ce19d0bebc74f9cdb5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2000795
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=aerotwist@chromium.org,tvanderlippe@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I623c9b873ac0af3157ff3b73c91e006f7db58e1e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2003315
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-16 10:58:49 +00:00
Jan Scheffler 7a7f3bccc5 Add karma tests for text_utils/Text.js 
Change-Id: Iecaae7aed2e9ca9e1b151e14165c4e6292fc1af3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1998773
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
 2020-01-16 10:09:44 +00:00
Changhao Han 9a07d87767 [karma-tests] add unit test for BezierUI 
Bug: chromium:1032561
Change-Id: I5648bef600a06286c067ccd8dcfffdc40b7ac51b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2002597
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2020-01-16 09:54:24 +00:00
Peter Marshall ded6565001 [fix-it] Add more unittests for TextUtils.js 
Add tests for everything under Utils.

Increases line coverage from 73.79% to 98.62%.

Bug: chromium:1032561
Change-Id: I319f605ddc66b5c8ab59f24e51873b3ca31c0f9e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2002588
Auto-Submit: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-01-15 16:10:43 +00:00
Simon Zünd 5933290adf [fix-it] Port SourceMap test that checks the 'sections' format 
This CL ports a layout test to Karma that parses a SourceMap containing
multiple sections that originate from different source files.

R=aerotwist@chromium.org

Bug: chromium:1032561
Change-Id: I6d3bd39e8aad75cb01c3871b40fcbebfb52eccaf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2002196
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-01-15 12:23:42 +00:00
Sigurd Schneider 9bdaca083d [karma-tests] Add tests for TextRange 
Bug: chromium:1032561
Change-Id: I3bfd90bba2c1e11fcaedaadbf598d1eb822c9c3b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2000777
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Almothana Athamneh <almuthanna@chromium.org>
 2020-01-15 11:20:43 +00:00
Simon Zünd 74336c9c6e Port SourceMap unit tests that check empty lines and empty segments 
This CL continues the work of porting the 'text-source-map.js' layout
(unit) test to Karma. The tests check that the parsing logic can handle
empty segments and empty lines.

R=aerotwist@chromium.org

Bug: chromium:1032561
Change-Id: I8648f0cfd4dceb96eee303895fcc1180c47313d7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2002189
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-15 11:18:21 +00:00
Simon Zünd 989f726ff7 Port layout test for basic {TextSourceMap} parsing to Karma 
This CL ports one test case from the
'http/tests/devtools/text-source-map.js' layout test to Karma. The
reasoning is that we want to:
   1.) get coverage to find edge cases that might need more tests.
   2.) provide some confidence to refactor SourceMap parsing and test
       the parts individually (e.g. the VLQ decoding).

R=aerotwist@chromium.org

Bug: chromium:1032561
Change-Id: I0eb07c68ba6d75bce1a3436111542707079bb5bd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2000780
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-01-15 10:30:22 +00:00
Mathias Bynens ba11c4c4f5 Simplify tests for utilities.js 
Bug: chromium:1032561
Change-Id: I8fb14d8d60b45fefc98ec62d00d8b17f20922361
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2002191
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-01-15 10:24:31 +00:00
Mathias Bynens dc28303e92 Add tests for ListModel operations 
This patch imports the tests from
chromium/src/third_party/blink/web_tests/http/tests/devtools/unit/list-model.js.

Bug: chromium:1032561
Change-Id: I94e8cbc84a839fc07421dcd1ca5b86e153a0bce0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2000790
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
 2020-01-15 10:22:32 +00:00
Mathias Bynens 786589f59e Add tests for ServerTiming.createFromHeaderValue 
This patch imports the tests from
chromium/src/third_party/blink/web_tests/http/tests/devtools/network/server-timing.js
and adds a few additional ones.

Bug: 1032561
Change-Id: I8a8c5c3079a926fa4c664fa790560b05b4643da7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1998772
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
 2020-01-15 09:21:16 +00:00
Peter Marshall a74d7fdc50 [fix-it] Add more unittests for TextUtils.js 
Add some tests for FilterParser that existed as unit tests in
web tests.

Increases line coverage from 73.79% to 78.62%.

Bug: chromium:1032561
Change-Id: Ife3dd25cc9d20515ed41a30a0957469c181646c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2000784
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
 2020-01-14 16:04:28 +00:00
Al Muthanna Athamina a56c9e1b88 Add Karma tests for Throttler.js 
This CL attempts to add Karma tests
for Throttler.js. Please note that
branches coverage is low and it is aimed
to be increased later on

Change-Id: I19a8edbc1f5e573efd977f7c00f92dc3a03a22ba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1883715
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-14 16:02:48 +00:00
Mathias Bynens 29f70b6bd3 Add unescapeCssString tests 
Bug: chromium:1033910
Change-Id: Ic80fd7c247ecfb9d4c22702b9fd86029a7630278
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2000788
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-14 15:49:38 +00:00
Peter Marshall dbe2c32350 [fix-it] Add unittests for TextUtils.js 
Add some tests for the BalancedJSONFormatter and isMinified. More to
come.

Increases line coverage from 32.41% to 73.79%.

Bug: chromium:1032561
Change-Id: I3dfa6db58b1ad5362c97326e72a0c9192d401ca6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1998768
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Almothana Athamneh <almuthanna@chromium.org>
 2020-01-14 13:44:08 +00:00
Tim van der Lippe d0e22da4db Use typescript-eslint instead of tslint 
This will update our eslint configuration to use @typescript-eslint to
parse and lint TypeScript files. It integrates with the existing
infrastructure to lint our files

Fixed: 1041811
Change-Id: I29f49a57229e3ee17524045b3905b9cc835271ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1998771
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-14 13:32:48 +00:00
Simon Zünd 395b69e993 [fix-it] Add unit test for TextSourceMap.StringCharIterator 
R=aerotwist@chromium.org

Bug: chromium:1032561
Change-Id: Ia7ca19bf71b628fcf97b3282b522566efc7db2f1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1998767
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-01-14 11:50:06 +00:00
Jan Scheffler 0440aee069 Add karma tests for FormattedContentBuilder.ts 
Change-Id: I64860de9400a577ed5a99820fb027b1736960114
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1998763
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
 2020-01-14 11:21:36 +00:00
Simon Zünd 59ba7259cc [cleanup] Consistently use single quotation marks in unit test 
TBR=aerotwist@chromium.org

Change-Id: If0baac182f104d5a46739ec8b089791001a075b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1998765
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-01-14 11:15:46 +00:00
Simon Zünd 126f829327 [fix-it] Add unit test for SourceMapeEntry.compare 
R=aerotwist@chromium.org

Bug: chromium:1032561
Change-Id: Ia4cc93b7810793a0baa75ce12f0ca6f9023bd9f2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1998762
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-01-14 10:40:26 +00:00
Paul Lewis 6196e75c80 Migrates persistence/ to ESM internally 
Bug: 1006759
Change-Id: I3f6351fe6b9f97ca88b528369168bba2fe00f76b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994978
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-13 15:48:34 +00:00
Almothana Athamneh 3643fae0fa Add test files for classes depending on SDK 
This CL attempts to add Karma test files with minimal tests to make some
classes depending on SDK appear in coverage reports and to use them as
placeholders for future tests

Bug: chromium:1032561
Change-Id: Icd678b1eb8ac906b7b3028577458e91a0664b88c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1997344
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
 2020-01-13 14:53:54 +00:00
Almothana Athamneh cc6f887bb1 Add test files for classes depending on UI 
This CL attempts to add Karma test files with minimal tests to make some
classes depending on UI appear in coverage reports and to use them as
placeholders for future tests

Bug: chromium:1032561
Change-Id: Ic0fcc7ec18ce6843e7db55b37152bedcb82cd3bc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1971422
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
 2020-01-09 15:35:52 +00:00
Almothana Athamneh 5b31848ba0 Add test files for existing classes 
This CL attempts to add Karma test files with minimal tests to make some
classes appear in coverage reports and to use them as placeholders
for future tests

Bug: chromium:1032561
Change-Id: Id9f60efad1387b13a30c7937bccda275f8e20bca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1953603
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-08 15:17:35 +00:00
Jan Scheffler 52cef46d51 Refactor Cookie implementation 
This cl prepares the refactoring of how cookies
are handled inside the devtools frontend by
moving the Cookie class outside of CookieParser
and removing the attributes method because it
is only used in tests and duplicates already existing
getter methods in an inconsistent way.

Cl disabling the test: crrev.com/c/1960350
Cl reenabling the test: crrev.com/c/1960279

Bug: chromium:1030258
Change-Id: Idc20d67bd55cab21d2b8d037b33d445b44d79088
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1959984
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2019-12-19 11:26:18 +00:00
Mathias Bynens 2abdc799d9 Restore sorted object property order in expanded view 
A long time ago in a galaxy far, far away, there was a property order
mismatch between the DevTools Console Preview and the expanded view.

For example:

       input> ({ c: 1, b: 1, a: 1 })
     preview> {c: 1, b: 1, a: 1}
    expanded> {a: 1, b: 1, c: 1, __proto__: Object}

We then attempted [1] to remove the confusing mismatch as follows:

       input> ({ c: 1, b: 1, a: 1 })
     preview> {c: 1, b: 1, a: 1}
    expanded> {c: 1, b: 1, a: 1, __proto__: Object}

In addition to avoiding the mismatch, this patch made DevTools more
closely resemble the internal shapes of objects [2] instead of hiding
this information from developers.

However, since shipping, we've heard overwhelming feedback in favor of
restoring the old behavior, where the expanded view is sorted. As a
result of this feedback, this patch restores the sorting logic.

A Chromium-side CL [3] temporarily disables the relevant web tests.
Once this patch lands and rolls into Chromium, we can re-enable these
tests with the up-to-date expectations.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/1806457
[2]: https://mathiasbynens.be/notes/shapes-ics
[3]: https://chromium-review.googlesource.com/c/chromium/src/+/1971832

Bug: chromium:989514, chromium:1008910
Change-Id: I5438987d73b8b980080156b5dd8b11f3f19fcc10
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1969479
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2019-12-18 10:25:38 +00:00
Paul Lewis 4c9c7b71c8 Adds test for measuredScrollbarWidth 
Bug: 1009443
Change-Id: I5ba34b9cea7b3ede64efbc4e326d9c95a6aeada0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1971419
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-12-17 15:01:46 +00:00
Paul Lewis ddfa768086 Updates Karma paths 
This CL removes the need to locate the front_end via relative paths,
i.e. many of our tests import from '../../../../front_end/...'. Instead
they can now import from '/front_end/...'.

Change-Id: I303be64326d4aeb1d65c6e6e169adfdd2a7eadce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1971421
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2019-12-17 14:55:56 +00:00
Simon Zünd 6a3eff7074 Mark audits web tests as 'slow' 
These tests were marked as slow previously in the chromium repo. Remark them
as 'Slow' in the frontend repo since we have test failures on the bots
otherwise.

Drive-by: Disable a test that is now crashing and needs investigation.

TBR: tvanderlippe@chromium.org
Bug: chromium:1034903
Change-Id: I5c4b5c4d6fb8ab58546abd948991e964fd6ddbfe
No-Tree-Checks: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1971412
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@google.com>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2019-12-17 10:54:06 +00:00
Tim van der Lippe 05361f5ce9 Reland "Let console asserts show up in the test results" 
This reverts commit 647f5e462f.

Reason for revert: Failing assertions have been added to test expectations

Original change's description:
> Revert "Let console asserts show up in the test results"
> 
> This reverts commit 1320cca621.
> 
> Reason for revert: Blocks the roll currently by causing layout
> tests to fail on Mac OS:
> https://ci.chromium.org/p/chromium/builders/try/mac-rel/262024
> 
> Failing layout test:
> https://test-results.appspot.com/data/layout_results/mac-rel/262024/webkit_layout_tests%20%28retry%20shards%20with%20patch%29/layout-test-results/results.html
> 
> Original change's description:
> > Let console asserts show up in the test results
> > 
> > Change-Id: I73c74000df80a1b46c31d35fd29c7fea0a9142bb
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1962365
> > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> 
> TBR=szuend@chromium.org,tvanderlippe@chromium.org
> 
> Change-Id: I70b7e10ddfac7eafa61599181f5103c84ace6a4d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1971410
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>

TBR=szuend@chromium.org,tvanderlippe@chromium.org

Change-Id: I33d08cf54dd0b414a6bc59703ee9dec238d31292
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1971415
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-12-17 10:41:08 +00:00
Simon Zünd 647f5e462f Revert "Let console asserts show up in the test results" 
This reverts commit 1320cca621.

Reason for revert: Blocks the roll currently by causing layout
tests to fail on Mac OS:
https://ci.chromium.org/p/chromium/builders/try/mac-rel/262024

Failing layout test:
https://test-results.appspot.com/data/layout_results/mac-rel/262024/webkit_layout_tests%20%28retry%20shards%20with%20patch%29/layout-test-results/results.html

Original change's description:
> Let console asserts show up in the test results
> 
> Change-Id: I73c74000df80a1b46c31d35fd29c7fea0a9142bb
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1962365
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=szuend@chromium.org,tvanderlippe@chromium.org

Change-Id: I70b7e10ddfac7eafa61599181f5103c84ace6a4d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1971410
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2019-12-17 08:44:58 +00:00
Paul Lewis 9950e186c4 Migrates internal refs of ui/ to esm 
Please note: ESLint and Closure have different opinions on the
necessity of imports, thus // eslint-disable-line no-unused-vars
was added to imports used only for Closure types.

Bug: 1006759
Change-Id: Idd32e12d23a636f1e0fdcb90742e4b706e3cef77
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1967134
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-12-16 16:52:27 +00:00
Tim van der Lippe 1320cca621 Let console asserts show up in the test results 
Change-Id: I73c74000df80a1b46c31d35fd29c7fea0a9142bb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1962365
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-12-16 16:28:37 +00:00
Connor Clark 37fc8b16fc Audits tests: dump settings in state 
Change-Id: I9265c4d270ae1b95b4b0483ad54e853d434a4a35
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1962536
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
 2019-12-12 22:53:46 +00:00
Connor Clark c4d8f8121c Audits: fix exporting as HTML. 
This also adds a test.

Bug: 1033368
Change-Id: I33243c8df41f61e223b724716b14a805358afd2f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1963363
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
 2019-12-12 22:36:16 +00:00
Jack Lynch 8a344769f6 Improve keyboard/screenreader experience in DOM breakpoints 
Currently, there is no intuitive way to navigate the DOM breakpoints
pane by keyboard. This change refactors the DOM breakpoints pane to use
UI.ListControl to manage keyboard navigation, in response to feedback
here [3] about code duplication. Using ListControl also makes it easier
to manage an accessible description on breakpoint elements so that
screen reader users are informed about the checked state of breakpoints
and whether the page is currently paused on them.

Focusing the list items, before/after:
https://gyazo.com/5edc75de0c0e9d7f968f49e114cec324
https://gyazo.com/c3efc3322783f3505bc4dde3edabbf13

This CL breaks a web test, so [1] must be merged first to disable it.
[2] Fixes and reenables it.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1893960
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1644461
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1644461/14/third_party/blink/renderer/devtools/front_end/browser_debugger/DOMBreakpointsSidebarPane.js#141

Bug: 963183
Change-Id: I41e2e8b73baa7ae3e6169163785e245493ab4ba7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1889352
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
 2019-12-12 03:34:36 +00:00