zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-05 19:41:12 +08:00
Code Issues Packages Projects Releases Wiki Activity
11,483 Commits 43 Branches 79 Tags
67872d6878d653f8c310cfecde9a5f080db20021
Commit Graph
1150 Commits
Author SHA1 Message Date
Tim van der Lippe 67872d6878 Remove entrypoints/node_app/node_app.json 
This CL does a couple of things to preserve the current behavior:
- It folds `node_main` into `node_app`, since we no longer require that
distinction (this was only required prior where we used `autostart` for
`node_main`, which we no longer do)
- It removes as much side-effect instantiation from various modules and
moves them into `node_app.ts`. The order is a bit awkward, but the calls
at the end of `node_app.ts` is the order of side-effect calls as it
exists currently. After we cleaned up all entrypoints, we can remove
some of the calls and clean it up further, but let's keep them here
explicitly to ensure we retain existing behavior.
- Folds `node_app-meta.ts` into `node_app.ts` for simplicity
- We now roll up everything into `node_app.ts` directly, rather than
having a separate meta script. Since this is an entrypoint, we can do
that here. Since the entrypoint will always eagerly load, we don't need
an explicit difference between the meta file and the module
implementation.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Ida1cee76ae04b3d590dcd16d0225f65852bce5a5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306499
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-30 14:32:54 +00:00
Tim van der Lippe 19b714a693 Remove entrypoints/shell/shell.json 
Shell no longer has any content, so we can remove it from all
entrypoints. We still want to share the contents of the meta files and
all, so keep these in. However, since we are no longer processing the
`shell.js` file `build_release_applications`, we can now fold in
`shell-meta-files.ts` into `shell.js`.

Ideally, we also change `shell` to be TypeScript-authored, but we can
only do that after all entrypoints that import it (in their respective
`.js` files) are TypeScript. So we will have to do that last.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I47239286f6f1dbff63ce69cf8ca4c78bd4761030
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306497
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-29 15:55:52 +00:00
Danil Somsikov e2e1bdae2a Don't add payoad tab twice 
Bug: 1273972
Change-Id: I9bf27d223398c4d7511178d3403f9dff4b79fb4f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3304173
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-29 11:27:20 +00:00
Jack Franklin f47f3975e0 Enable l10n_filename_matches rule to have its root dir configured 
This means if we are to re-use this rule we can configure it to have a
custom root directory to validate and check all the paths against.

Bug: 1187014
Change-Id: I2ab5f921030cb41a024250ac29dd1c1c868f5454
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3302739
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-26 13:10:30 +00:00
Takuto Ikuta 0319fe0978 DEPS: use python3 
Bug: chromium:1208028
Change-Id: I409b42bd5e6297242d37cc3e88a532107222b77b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3301348
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
 2021-11-25 07:54:05 +00:00
Tim van der Lippe c4035e3b0d Update TypeScript to 4.5.2 
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I24da805038bd5d1d88dfad689f7a4ccf894af904
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3297838
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-24 12:24:53 +00:00
Tim van der Lippe c581bb8fad Update marked to 4.0.4 
DISABLE_THIRD_PARTY_CHECK=Have to update both @types/marked and marked
R=szuend@chromium.org

Bug: none
Change-Id: I1030c1d11f329bbb4b28566921efff0fd439b6de
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3297844
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-24 06:28:40 +00:00
Tim van der Lippe 0124c686d3 Update ESLint packages 
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I156623832abc081748ee50fed0ce93d864e54a67
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3297836
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-23 15:41:49 +00:00
Tim van der Lippe adf814f1f3 Remove unit test folder exemption 
Previously, we exempted our unit tests from importing only entrypoints.
However, we later realized that we always have to import the entrypoint
to avoid build non-determinism problems. Therefore, remove these exemptions,
which incidentally caught some existing violations.

The ColorUtils file is special in inspector_overlay, so we can safely
exempt that one as a one-off. The e2e-test need to import the helpers
as all other e2e-tests do. The hello-world is an example, so let's ignore
that one for now.

R=jacktfranklin@chromium.org

Bug: 1271490
Change-Id: Ib05d799b547e46cde4349b8738a5ecd63d50f3e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3291160
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-19 14:44:06 +00:00
Tim van der Lippe 6470244157 Remove panels/layers/module.json 
R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Id0995ea16b142ffd956c93a45753f6ded213ddce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3289767
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-18 15:32:56 +00:00
Tim van der Lippe 379c288384 Allow meta-files to import relative entrypoints 
We previously disabled this rule in a lot of places to workaround the
fact that the rule wasn't adhering to importing entrypoints in meta
files. Instead, let's update the rule to make it clear that this pattern
is expected and fine.

R=alexrudenko@chromium.org

Bug: 1271490
Change-Id: Idd139b42d9bb27f1f20e573b31bcd5efff8815af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3289221
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-18 14:53:06 +00:00
Tim van der Lippe cd385c2f28 Remove resources from ui/legacy/module.json 
This moves all ui/legacy stylesheets to the .css.legacy.js format. By
doing so, we can remove the module.json in a follow-up CL.

R=jacktfranklin@chromium.org

Bug: 1190991
Change-Id: I23b590845ae27880058b2ab02da8edf378ae8232
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3284811
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-16 16:47:21 +00:00
Tim van der Lippe 1b5567f78a Remove resources from perf_ui 
To remove the module.json file in perf_ui, we need to migrate the
resources to the new `generate_css` template. However, perf_ui is a bit
special, in that it doesn't properly use the widget structure. As such,
it sometimes injects CSS in places where there is no clear shadowRoot
available. Therefore, it is not possible to migrate to CSSStyleSheet in
combination with adoptedStylesheets.

As a workaround (to unblock the module.json removal), we augment
`generate_css` to add legacy file generation. All remaining resources in
DevTools will migrate to these `.css.legacy.js` files. That's because
these resources either are special (perf_ui) or are used in the
`device_mode_emulation_frame` which can't use `CSSStyleSheet` itself.

The files export an object, rather than a plain string. That's because
we need to be able to distinguish what string is referencing a CSS file
path and which strings contain the actual CSS styles. By using an
object, we can remain using the `typeof` check for string in the legacy
CSS infrastructure and otherwise destructure the object.

After this, we can remove perf_ui from the module.json structure and
properly bundle+minify the CSS resources.

R=jacktfranklin@chromium.org

Bug: 1190991, 1127902
Change-Id: I7523333e8025ae5fe5ed74b99b4e45907ff9ad97
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3275787
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-12 15:25:03 +00:00
Tim van der Lippe 0fb47801b6 Upgrade ESLint 
This pulls in version 8, which covers numerous breaking changes. Most
notably, the `CLIEngine` class has been removed, for which we should now
use `ESLint`.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: I3b64600e690f073d4db19fb34539db7200f3b561
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3268298
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-11 09:11:25 +00:00
Tim van der Lippe f9e565ef89 Add new run_lint_check_js.mjs 
ESLint 8 removed CLIEngine. Therefore, we need to migrate away from
CLIEngine to the main ESLint class (which already exists in ESLint 7).
However, that class is based on promises, which means we can't use them
in a CommonJS context.

Therefore, introduce a new `.mjs` version that uses ES modules (which
can do as we are on a recent version of Node) and use the promise
versions. There are no other functional changes compared to the old
`.js` script.

The reason that we first have to add this file here, is that our CQ
directly refers to the `.js` version. That means we first land this CL,
we update our CQ configuration and only then can we remove the `.js`
file from our repository.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Iad3656931ae09eb7f9f23b3e6ad7d39c8a761a31
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3268299
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-09 10:25:30 +00:00
Tim van der Lippe 6ddb01d4f5 Upgrade typescript-eslint 
This also includes some fixes in the rule implementations that are
required for the 5.0.0 breaking change as documented in
https://github.com/typescript-eslint/typescript-eslint/releases/tag/v5.0.0
which lists the AST-Spec changes. Specifically, `ClassProperty`
was renamed to `PropertyDefinition`.

DISABLE_THIRD_PARTY_CHECK=Requires AST changes in ESLint rules
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I1d107b071fa265af8e178ee5e229f4a9d2f00d75
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3268295
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-08 16:19:39 +00:00
Tim van der Lippe bc3a0b7a2b Upgrade eslint-plugin-import 
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I0ad7ba9133af3db19c448a284d79bdfc08101dea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3268294
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-08 16:05:33 +00:00
Tim van der Lippe 10714b5729 Upgrade eslint-plugin-lit-a11y 
This pulls in the fix for https://github.com/open-wc/open-wc/issues/2206
which reduces the size of our node_modules significantly.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Id19be5e7ed6398ffd2edb1d08b4752ef6a1d6b17
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3268293
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-08 15:56:59 +00:00
Tim van der Lippe 16b822804c Reland "Reland "Update stylelint to 14.0.1"" 
This reverts commit 2b4a9df2d9.

Reason for revert: subsequent presubmit uploads should be fixed now.

Original change's description:
> Revert "Reland "Update stylelint to 14.0.1""
>
> This reverts commit f2ea2c940d.
>
> Reason for revert: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8831129368825517985/overview
>
> Original change's description:
> > Reland "Update stylelint to 14.0.1"
> >
> > This reverts commit 6c0f161c95.
> >
> > Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed
> >
> > Original change's description:
> > > Revert "Update stylelint to 14.0.1"
> > >
> > > This reverts commit 1e08ee816b.
> > >
> > > Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview
> > >
> > > Original change's description:
> > > > Update stylelint to 14.0.1
> > > >
> > > > This also upgrades PostCSS to 8.3.11.
> > > >
> > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> > > > R=​szuend@chromium.org
> > > >
> > > > Bug: none
> > > > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
> > > > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > >
> > > Bug: none
> > > Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Owners-Override: Alex Rudenko <alexrudenko@chromium.org>
> > > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
> >
> > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> >
> > Bug: none
> > Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
>
> Bug: none
> Change-Id: Idc6c9f5cc1e225c752799461eb0344e94b4ad1e5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264222
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration

Bug: none
Change-Id: I609941d48b46bfcf454b03dcc75a76d460fbe674
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264223
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-08 14:47:39 +00:00
Tim van der Lippe 2b4a9df2d9 Revert "Reland "Update stylelint to 14.0.1"" 
This reverts commit f2ea2c940d.

Reason for revert: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8831129368825517985/overview

Original change's description:
> Reland "Update stylelint to 14.0.1"
>
> This reverts commit 6c0f161c95.
>
> Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed
>
> Original change's description:
> > Revert "Update stylelint to 14.0.1"
> >
> > This reverts commit 1e08ee816b.
> >
> > Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview
> >
> > Original change's description:
> > > Update stylelint to 14.0.1
> > >
> > > This also upgrades PostCSS to 8.3.11.
> > >
> > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> > > R=​szuend@chromium.org
> > >
> > > Bug: none
> > > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
> > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
> > > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> >
> > Bug: none
> > Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Owners-Override: Alex Rudenko <alexrudenko@chromium.org>
> > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
>
> DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
>
> Bug: none
> Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>

Bug: none
Change-Id: Idc6c9f5cc1e225c752799461eb0344e94b4ad1e5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264222
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2021-11-08 12:59:31 +00:00
Tim van der Lippe f2ea2c940d Reland "Update stylelint to 14.0.1" 
This reverts commit 6c0f161c95.

Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed

Original change's description:
> Revert "Update stylelint to 14.0.1"
>
> This reverts commit 1e08ee816b.
>
> Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview
>
> Original change's description:
> > Update stylelint to 14.0.1
> >
> > This also upgrades PostCSS to 8.3.11.
> >
> > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> > R=​szuend@chromium.org
> >
> > Bug: none
> > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
>
> Bug: none
> Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Owners-Override: Alex Rudenko <alexrudenko@chromium.org>
> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>

DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration

Bug: none
Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-08 11:24:28 +00:00
Tim van der Lippe e096798938 Fix eslint tests for Windows 
The error messages should use the proper file path format, so manually
replace the Windows folder separators with the UNIX path separators.

R=andoli@chromium.org

Fixed: 1266413
Change-Id: I499e79e857eaf97eb65faf1cb180479f08b1ee69
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259535
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-11-05 15:29:59 +00:00
Alex Rudenko 6c0f161c95 Revert "Update stylelint to 14.0.1" 
This reverts commit 1e08ee816b.

Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview

Original change's description:
> Update stylelint to 14.0.1
>
> This also upgrades PostCSS to 8.3.11.
>
> DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> R=​szuend@chromium.org
>
> Bug: none
> Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

Bug: none
Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-05 06:32:31 +00:00
Tim van der Lippe 1e08ee816b Update stylelint to 14.0.1 
This also upgrades PostCSS to 8.3.11.

DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
R=szuend@chromium.org

Bug: none
Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-04 20:20:31 +00:00
Andres Olivares c860fe1985 Introduce describe.skipOnPlatforms mocha extension 
NOPRESUBMIT=true
Bug: none
Change-Id: If0e96e43aa13a2fa557a075975c2e7f365db930a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3258130
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-03 20:44:06 +00:00
Andres Olivares 8388f33735 Use case sensitive look up in build scripts to copy file contents. 
These scripts check if a file exists and whether its content is
different from a source file before copying it. However the file look up
done with fs.existsSync() could be case-insensitive depending on the
underlying file system.

This CL implements the a case-sensitive file look up to compare against
the exact path name of the file being copied.

Bug: none
Change-Id: I0dc175c2292b3caea541a585562e8e25db637340
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3256666
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2021-11-02 15:57:40 +00:00
Alex Rudenko 273b9aa203 ESLint: ban <a> tags in lit-html templates 
NOPRESUBMIT=true
Bug: 1264796
Change-Id: I58b7e01d4232e93fc08f12fa2f9173e1c6c07060
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253322
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-10-29 13:47:02 +00:00
Mathias Bynens 4c6e92b7b8 Avoid collapsing inline tag whitespace 
This patch ensures we collapse spaces between DOM nodes
into a single space rather than removing the space entirely.
This prevents issues with missing spaces in UI text, and
generally makes the HTML minification step more safe.

Bug: chromium:1264791
Change-Id: Ib8dfaa58e973ee8682a1f43226db9f9483d9606b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252958
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2021-10-29 12:24:12 +00:00
Tim van der Lippe b1953da009 Do not include generated CSS files in code coverage report 
These are auto-generated and we don't need to know the code coverage for
these files.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Ieaaed88a3752a755e4f5e30495e38434330c7263
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3222663
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-14 10:46:49 +00:00
Tim van der Lippe 286bd5c44a Stop renaming properties in comments 
This can break automation such as the localization collection script and
the license headers, as these are sensitive to specific references in
the comments themselves. It is probably safer to not change any of the
comments anyways.

R=jacktfranklin@chromium.org

Bug: 1222126
Change-Id: Ib5223559abc215dee0f4ac16b3a3269ee827702c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3219238
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-13 11:48:33 +00:00
Tim van der Lippe 7008714d9a Add bash script to automate more tasks 
To make sure we always perform the replace and to format automatically,
as well as making sure that the build actually works.

R=jacktfranklin@chromium.org

Bug: 1222126
Change-Id: I83d44282024f9ffa33a345e05b8c1a5c48923068
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3219235
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-12 16:27:10 +00:00
Tim van der Lippe 0404c7edc0 Automatically replace delete statements for private class fields 
Delete statements are disallowed for private class fields. Previously, I
used regexes to replace these, but we can implement it safely in the
migration script itself.

R=jacktfranklin@chromium.org

Bug: 1222126
Change-Id: Icab2cdaca290d40ea7d50710209cc84ea27208ba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3219231
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-12 15:55:27 +00:00
Mathias Bynens b1b64fc1be Fix broken paths in NativeFunctions.js generator 
`scripts/javascript_natives/index.js` expects `NativeFunctions.js` to
reside at a specific path, and broke when a CL [1] moved it to another
location, and broke (in another way) when the DevTools front-end
codebase moved to a separate repository. Similarly, the script expects
a Chromium checkout at a specific location relative to itself, which
hasn’t been correct since the DevTools front-end codebase moved to a
separate repository.

This patch updates the expected locations, but does not re-generate
the output since the script requires additional follow-up fixes.

[1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2814662

Bug: chromium:1255619
Change-Id: I066fb4349f045df5a12edd1378d7acdaa733a61b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3201677
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2021-10-08 12:40:54 +00:00
Tim van der Lippe 59f68132b1 Make lighthouse_worker a proper entrypoint 
This entrypoint was still being copied over, due to techdebt we
had before. The techdebt has since been removed, so we can now
properly use `devtools_{module,entrypoint}` to process these files.

R=jacktfranklin@chromium.org

Fixed: 1248392
Change-Id: I8c7394c62c21b9b73e259fd9206510c92203ad0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3158384
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-04 16:25:42 +00:00
Tim van der Lippe e2c9f764dd Add migration script for private class fields 
To make sure we track it somewhere. I already tested the script
on `sdk/`, and the script is also based on the earlier scripts
that Jan used during the underscore migration.

R=aerotwist@chromium.org

Bug: 1222126
Change-Id: I50589f6ae4084322f04c49ef81d2bc88d2ca2544
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3201674
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-10-04 12:34:45 +00:00
Jack Franklin fc6226b017 Update Rollup and terser 
This pulls in the bugfix for mangling private class fields
reported in https://github.com/terser/terser/issues/1067

DISABLE_THIRD_PARTY_CHECK=Fix rollup config
R=jacktfranklin@chromium.org

Bug: 1222126
Change-Id: I77a1ddc3697498829e595cead728479e81e7889c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3158385
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-09-21 12:28:03 +00:00
Kriti Sapra afc5528f54 Added line in css generating script to say the file is auto generated 
Bug: 1106746
Change-Id: I7452b10640b0f0efaf273f1c950190d6b2a45008
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3164343
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kriti Sapra <kritisapra@google.com>
 2021-09-17 07:39:56 +00:00
Jack Franklin d9172b6d0c Reland "Add mocha-fgrep flag to run_test_suite.js" 
This relands the original change with a fix to avoid the issue where
we'd run Mocha with `--fgrep=undefined`, causing no tests to run...

Bug: none
Change-Id: I4df53a935fe5c4359e5c35f56db4f9c133e7603f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3162062
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-09-15 16:04:20 +00:00
Jack Franklin 634ddfed43 Revert "Add mocha-fgrep flag to run_test_suite.js" 
This reverts commit 348a89db15.

Reason for revert: broke interaction and e2e test runs

Original change's description:
> Add mocha-fgrep flag to run_test_suite.js
>
> This CL adds the ability to filter the tests via Mocha's `fgrep` flag,
> giving us the ability to run a subset of the tests if we wish in the
> future.
>
> Fixed: 1249000
> Change-Id: I3379f6f0f60fc97d8af6b019761cfb31dda8afd2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3162297
> Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>

Change-Id: Ie1e1999f60f3b144665083e0103a786cfb22906e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3162060
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2021-09-15 14:35:50 +00:00
Jack Franklin 348a89db15 Add mocha-fgrep flag to run_test_suite.js 
This CL adds the ability to filter the tests via Mocha's `fgrep` flag,
giving us the ability to run a subset of the tests if we wish in the
future.

Fixed: 1249000
Change-Id: I3379f6f0f60fc97d8af6b019761cfb31dda8afd2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3162297
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-09-15 11:53:07 +00:00
Tim van der Lippe 8fc2d46d56 Update types and typescript packages 
- Update all `@types` packages to the latest version
- Updates TypeScript to 4.4.3

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Ia6482e6d53428f962cec2561823d2db66631f4e8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3158342
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-09-13 15:44:39 +00:00
Tim van der Lippe fe1b426acc Update Istanbul packages and configuration 
- Update istanbul-lib-instrument (breaking change is not affecting us)
- Explicitly update @istanbuljs/schema to 0.1.3. This directly instructs
Babel to accept top-level await. As such, we can remove our special
configuration for our `ui/components/docs` folder, which we can now
safely preprocess.

DISABLE_THIRD_PARTY_CHECK=Karma fix
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I0e96dce0117550f1a2db6a93654d8862d9cae95a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3158226
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-09-13 14:22:17 +00:00
Tim van der Lippe a66194127a Update linter packages 
- Update ESLint
- Update typescript-eslint
- Update eslint-plugin-import
- Update Stylelint standard config

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=ESLint fix

Bug: none
Change-Id: Ic1efac8b4f7b085b8f2b792a76b8b99b9f583da3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3158225
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-09-13 13:34:28 +00:00
Tim van der Lippe 61fe685814 Update various test packages 
- Update Sinon (breaking change does not affect us)
- Update Mocha
- Update Karma

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Ieb50ba55ce7a9e01e32ee553a6741e6323fcaaab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3158223
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-09-13 12:55:26 +00:00
Simon Zünd fda9300884 Upgrade TypeScript to 4.4.2 
DISABLE_THIRD_PARTY_CHECK=Upgrade requires some compatability changes
R=tvanderlippe@chromium.org

Fixed: 1247593
Change-Id: I78ffad8d969e043952555cac813ac803f2561bb5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3147890
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-09-13 06:41:11 +00:00
Jack Franklin cbd5ee57f9 Add ESLint rule for enforcing {host: this} in LitHtml.render calls 
Bug: 1247969
Change-Id: I567dac5d9bb97f3b2b4de77a06e45d7e4cac6cbd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3150282
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-09-09 12:39:57 +00:00
Tim van der Lippe 8eade7fa60 Remove special-casing for utils 
Historically, we special-cased importing the legacy utils, as
Rollup would eagerly roll them up in a single bundle. However,
since then we changed the Rollup heuristic to always assume that
a different folder is a different entrypoint, including sub-folders.
As such, we are no longer including entrypoints of sub-folders in
parent folders.

However, utils was special-cased and was importing the direct files.
This normally isn't a problem, except for the fact that the
devtools_entrypoint of `ui/legacy:bundle` would now bundle the sources
of `ui/legacy/utils`, but wasn't rebuilding when it needed to.

Therefore, change the utils to a proper sub-folder and avoid the
special-casing. Since we no longer have a circular dependency
between the utils and `ui/legacy`, we can safely make this change.

The ESLint rule has also been updated to make sure we don't regress
in this area again.

R=victorporof@chromium.org

Fixed: 1148274
Change-Id: I020622c5790041d5f676bee2ef883ff0ece76695
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3148370
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Victor Porof <victorporof@chromium.org>
Reviewed-by: Victor Porof <victorporof@chromium.org>
 2021-09-08 14:34:10 +00:00
Kim-Anh Tran 9a4c4db18b [server] Add binary encoding for DWARF object+package files 
Bug: chromium:1245963
Change-Id: I4e7a61c404fdee794e35a51fd64261017b42e3c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3138079
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2021-09-07 08:56:53 +00:00
Jack Franklin 734befd5a7 Fix ESLint component naming check with multiple components 
This CL updates the check_component_naming rule to make it deal with a
file that has multiple components defined; something that would
previously cause the rule to fail and hence it was disabled in some
files.

Fixed: 1226741
Change-Id: I3eb282182c10e3faf120d6bcd2d0846667524861
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3141471
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-09-03 13:44:37 +00:00
Jack Franklin cc1f192ca1 Add autofix ability to static_custom_event_names ESLint rule 
Bug: chromium:1229172
Change-Id: I80d1fcb1432a79a0682ed92ff6335571a62bba55
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3122649
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-09-01 08:34:04 +00:00