Commit Graph
226 Commits
Author SHA1 Message Date
Alex Rudenko e0be4d513a Deduplicate ws by installing the latest version
Bug: none
Change-Id: I716886b779aa2766a4290bada004dc5553c376a9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5463339
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2024-04-18 11:02:18 +00:00
Alex Rudenko 484fb519dc Fix node_modules owners
folder names in OWNERS do not actually work so
we need a file in node_modules

Bug: None
Change-Id: Ieb639375ef1d8b8b6ed3ad3ed30e7c0ba559746d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5463980
Owners-Override: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
2024-04-18 08:19:16 +00:00
Alex Rudenko 6a564d1135 Recover deleted README and define owners by filename
https://crrev.com/c/5458178 deleted the OWNERS file
and the readme in node_modules by accident.

Bug: none
Change-Id: If1af2296995574333012fe3ad3a1486d3186bdcf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5463581
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
2024-04-18 06:35:25 +00:00
Alex Rudenko 5fda646af7 Update puppeteer to 22.6.5
Bug: none
Change-Id: Iadbc26a9d0c35e599c3adbbd13dea9fce1963ca0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5458178
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2024-04-17 12:53:02 +00:00
Alex Rudenko 6abfa37a65 Fix socket.io-parser lock to resolve to 4.2.4
Bug: none
Change-Id: I58fab347c8ee39412d79696762e72dd16b74c15a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5454234
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2024-04-16 08:48:36 +00:00
Benedikt Meurer 11565081e8 [chai] Improve types for assert functions.
This CL adds `asserts` to various `assert` functions provided by Chai,
and massages some parts of the code base to still typecheck correctly.
This is in preparation for removing a bunch of homegrown helpers, but
also as proof-of-concept for upstreaming these to DefinitelyTyped
once battle-tested in DevTools.

The following functions now have `asserts`:

- `assert()`
- `assert.isOk()` and `assert.ok()`
- `assert.isTrue()` and `assert.isNotTrue()`
- `assert.isFalse()` and `assert.isNotFalse()`
- `assert.isNull()` and `assert.isNotNull()`
- `assert.exists()` and `assert.notExists()`
- `assert.isDefined()` and `assert.isUndefined()`
- `assert.instanceOf()`

Bug: 333520272
Change-Id: I852edd4fc579b0d9f9b6a347502d64ea3d12dc46
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5444833
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
2024-04-12 07:32:43 +00:00
Alex Rudenko 7042abca0b Update mocha to 9.2.2
- fixes a vulnerable dependency
- sorts devDependencies in asc order (done by npm)
- manage_node_deps should --save-exact version by default

Fixed: 333413840
Change-Id: Iaa670259db9771dab89c72214c17d0420e02eaa3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5439476
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2024-04-10 05:58:47 +00:00
Alex Rudenko 5f94f8281d Adopt the npm audit mirror
manage_node_deps.py still used to update dependencies but the registry has been updated to https://npm.skia.org/chrome-devtools for extra security and license checks.

Bug: chromium:331331303
Change-Id: I006567562a6fc762f5abdfe10b3d34fa796c7748
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5400698
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2024-04-04 10:17:22 +00:00
Simon Zünd 5c0e0d8abb [deps] Upgrade TypeScript from 5.2.2 to 5.4.2
DISABLE_THIRD_PARTY_CHECK=Requires fixing up front_end files
R=alexrudenko@chromium.org

Bug: None
Change-Id: If7cd9777abc1daf8af48cf006576e39d5d57ce94
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5365623
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2024-03-12 12:35:14 +00:00
Simon Zünd d03865b108 Revert "Add @webgpu/types"
This reverts commit 067c706e79.

Reason for revert: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5076956
is abandoned

DISABLE_THIRD_PARTY_CHECK=Has ts_library.py change

Original change's description:
> Add @webgpu/types
>
> DISABLE_THIRD_PARTY_CHECK=Add @webgpu/types
> No-Presubmit: true
> Bug: 1506431
> Change-Id: I06f8d3758110f19298965e84e15f33c02bf4fbda
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5081999
> Commit-Queue: Fr <beaufort.francois@gmail.com>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

No-Presubmit: true
Bug: 1506431
Change-Id: Id19766f75d97b8339058fb51693747a47a4b6312
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5335357
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2024-03-04 08:12:37 +00:00
Alex Rudenko d04dd4506b [test] Update Puppeteer to v22.3.0
Drive-by: remove @puppeteer/replay that is not used in tests
Bug: none
Change-Id: I512794442c43cddd8a40b7816d3fc31f398251d2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5318365
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2024-02-27 09:00:14 +00:00
Alex Rudenko af11b7ca25 [test] Update Puppeteer to v22
DISABLE_THIRD_PARTY_CHECK=updating deps

Bug: none
Change-Id: I12b06b26f0bb0b938666c7748198187259fcd9fc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5268589
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
2024-02-07 07:11:54 +00:00
François Beaufort 067c706e79 Add @webgpu/types
DISABLE_THIRD_PARTY_CHECK=Add @webgpu/types
No-Presubmit: true
Bug: 1506431
Change-Id: I06f8d3758110f19298965e84e15f33c02bf4fbda
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5081999
Commit-Queue: Fr <beaufort.francois@gmail.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2023-12-04 08:36:30 +00:00
Randolf Jung 396cfd4bc9 Update TypeScript to 5.2.2
DISABLE_THIRD_PARTY_CHECK=Types are broken and need to be changed

Bug: none
Change-Id: Ie683d4800b614f7b82b5f5c35a717fe70112bcec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5033665
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
2023-11-16 13:02:28 +00:00
Philip Pfaffe 9f9b531a71 Revert "Update esbuild"
This reverts commit 556d230a0e.

Reason for revert: Breaks the build on windows.

Original change's description:
> Update esbuild
>
> DISABLE_THIRD_PARTY_CHECK=DEPS needs to be updated together
>
> Bug: none
> Change-Id: I6af5660c313d5d998b320f688a36a1f3de5beb03
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5025093
> Commit-Queue: Randolf Jung <jrandolf@chromium.org>
> Reviewed-by: Danil Somsikov <dsv@chromium.org>

Bug: none
Change-Id: I331613611d0b8bd56a96a5eff50e452213f6f14b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5033272
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
2023-11-16 07:34:14 +00:00
Randolf Jung 556d230a0e Update esbuild
DISABLE_THIRD_PARTY_CHECK=DEPS needs to be updated together

Bug: none
Change-Id: I6af5660c313d5d998b320f688a36a1f3de5beb03
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5025093
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
2023-11-15 15:27:58 +00:00
Alex Rudenko f7ea7ab986 Update pptr to 21.4.1
DISABLE_THIRD_PARTY_CHECK=roll of Puppeteer and removal of the Puppeteer flag.

Fixed: 1484476
Change-Id: I98425afe43878948983dba94bda362aa6681d603
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4968458
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2023-10-24 10:11:59 +00:00
Vidal Guillermo Diazleal Ortega 5151f41f3f npm package security updates (babel/traverse)
I ran the following script to update @babel/traverse from 7.15.4 to 7.23.2 packages
to address the security issue tracked in crbug.com/1493744:

`npm run install-deps audit fix --audit-level=critical`

Bug: 1493744
Change-Id: Ie3fa0dc0527b6fa9e4b7906ee2034b95900c6033
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4953413
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
2023-10-20 17:29:27 +00:00
Alex Rudenko eba2e5aa86 Update Chrome (for Testing) PIN
Chromium pin updated to 120.0.6061.0

Roll created at https://cr-buildbucket.appspot.com/build/8767442795318961393

DISABLE_THIRD_PARTY_CHECK=hotfix Puppeteer to unblock Chrome roll as making a Puppeteer release will take some time (upstream fix https://github.com/puppeteer/puppeteer/pull/11142)

Bug: chromium:1492122
Change-Id: I427df7f777cdf24b50e3e4532d9230fa0a04ae84
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4934291
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2023-10-12 14:46:33 +00:00
Alex Rudenko 5fe99f864f Update puppeteer in node_modules to 21.3.8
Bug: none
Change-Id: Ic4140d2e69ff70ee049ddf4d419c866c35dc58c2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4916662
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
2023-10-06 13:40:42 +00:00
Alex Rudenko b013f87a99 Update puppeteer and puppeteer-core in node_modules
DISABLE_THIRD_PARTY_CHECK=fixes for the roll

Bug: 1484476
Change-Id: I0d0b5288bd860d24923802042e091551ff4cdeea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4898119
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2023-09-29 07:14:02 +00:00
Alex Rudenko 662ce9cbd7 [node_modules] Update Puppeteer to 21.1.1
Bug: none
Change-Id: Ifd4f7ac9dfb1527edd1e59f4afb4debe9d2a3860
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4821548
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2023-08-29 09:38:42 +00:00
Simon Zünd 3502cdcf8c [build] Remove 'minify-html-template-literals' plugin from node_modules
DISABLE_THIRD_PARTY_CHECK=Removing a npm package.

R=alexrudenko@chromium.org

Bug: 1213034
Change-Id: I1546dfe1a1c74d44d02cae35e0334c8463790233
Fixed: 1471374
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4762688
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2023-08-09 08:54:29 +00:00
Randolf Jung 3e52631076 Update "puppeteer" to 21.0.1
Bug: none
Change-Id: I7b92e1d3c7e14729d99fb8b540d93d9d0be0ecba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4756724
Auto-Submit: Randolf Jung <jrandolf@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2023-08-08 08:05:41 +00:00
Philip Pfaffe ead3f105e7 node_modules: Add emscripten types and rollup node plugin
Includes a rerun of install-deps which updates some unrelated packages.

Bug: 1454724
Change-Id: I29651314ac40c985f42a3fb2bce73ece20b7236a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4632539
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Kshitij Pancholi <panchok@google.com>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
2023-07-28 09:28:45 +00:00
Simon Zünd cba2ac9e1c [deps] Update 'terser' to 5.19.1
The update contains a bug fix that improves the quality for DevTools
release source maps.

The update also seems to stop minifiying certain names in the overlay
bundle so we had to slightly bump the limit.

  * Old size: 69660
  * New size: 71295

DISABLE_THIRD_PARTY_CHECK=Bump overlay size limit
R=alexrudenko@chromium.org

Bug: 1459146
Change-Id: I3036787bbb3ba8d28669b9aaab9c29c5f5581e55
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4693881
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
2023-07-18 09:44:36 +00:00
Guangyue Xu 2314ddcbfe npm pakage security updates
Ran the following script to update engine.io and socket.io-parser
package from 4.2.1 to 4.2.4 to address the security issue tracked
in crbug.com/1464405:

`npm run install-deps audit fix --audit-level=critical`

Bug:1464405
Change-Id: I40f54d721642ad124b81a2df1307ab1d2dfecbdc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4682214
Commit-Queue: Guangyue Xu <guangyue.xu@microsoft.com>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
2023-07-13 17:37:54 +00:00
Alex Rudenko 763f344894 Update puppeteer to 20.8.2 (node_modules)
Bug: 1464324
Change-Id: Ifc3aadbadb7ee1feabb9559bc7746a987441f91a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4679117
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
2023-07-13 09:44:16 +00:00
Alex Rudenko 1552f2b3ac Update puppeteer in node_modules
Bug: none
Change-Id: I47c32ffa1ee9f34bdfccb930d288a364afaa280f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4675897
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2023-07-11 12:54:29 +00:00
Randolf Jung bcb3bc8d41 Update puppeteer and @puppeteer/replay
- puppeteer replaced with puppeteer-core (20.7.3). DevTools does not actually need puppeteer as it downloads the browsers on its own. PUPPETEER_SKIP_CHROMIUM_DOWNLOAD is not needed too.
- @puppeteer/replay upgraded to 2.11.2

DISABLE_THIRD_PARTY_CHECK=requires code updates for puppeteer-core
Bug: none
Change-Id: I173c228d766681a1a8a9ada3fcf17525cd191726
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4640022
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
2023-06-26 18:05:57 +00:00
Jack Franklin b6e869c1ff Update @typescript-eslint/* deps
Following the update to TS 5.1.3, updating the ESLint plugins too.
Includes a couple of small fixes where more floating promises are now
detected.

DISABLE_THIRD_PARTY_CHECK=source file changes to fix issues

Bug: none
Change-Id: Ia4b346ded7a63abed3dfc08db5f7b15baf6a40c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4584591
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
2023-06-02 14:33:49 +00:00
Jack Franklin 98d9d46d28 Upgrade TypeScript to 5.1.3
DISABLE_THIRD_PARTY_CHECK=TS upgrade and source code changes.

Bug: none
Change-Id: I21244e75a24e8e323ef40c696254e552f3956e6d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4583215
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2023-06-02 13:05:48 +00:00
Guangyue Xu bffee6084d npm pakage security updates
Ran the following script to update engine.io and socket.io packages
to address the security issue tracked in crbug.com/1447254:

`npm run install-deps audit fix --audit-level=critical`

Bug: 1447254
Change-Id: Ia617b76882259bdab5259855029353701ff0bc1e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4551951
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Brandon Walderman <brwalder@microsoft.com>
Commit-Queue: Guangyue Xu <guangyue.xu@microsoft.com>
2023-05-23 16:50:12 +00:00
Randolf Jung 0849e8636c Update puppeteer to 20.1.2
Bug: none
Change-Id: Ic54abd3e326a08c473ee20245e62f84365036676
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4519845
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2023-05-10 13:31:14 +00:00
Randolf Jung 95337a1834 Update puppeteer to 19.11.1
Bug: none
Change-Id: I8cc107acb06ac82bb6c6b060c86a6346a09d464a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4475485
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
Auto-Submit: Randolf Jung <jrandolf@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2023-04-25 16:12:28 +00:00
Simon Zünd 1bd98ee250 [deps] Add 'rollup-plugin-sourcemaps' intended for release builds
We plan to enable source maps for release builds behind a GN flag. For
this to work rollup needs to consume the source maps already generated
by tsc and merge it with its own source map. Rollup can't do this
natively so this CL adds a plugin that can.

R=jacktfranklin@chromium.org

Bug: 1430396
Change-Id: Ibb38c7892326907431e54b7c7dbd7b912b59ccb9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4397707
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2023-04-04 13:31:33 +00:00
Randolf Jung b08370d389 Update puppeteer to 19.8.3
Bug: none
Change-Id: I415f90baf38a8b48751df16d6f7f374bcbab1865
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4394482
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
2023-04-03 09:36:19 +00:00
Randolf 554314669d Update puppeteer to 19.8.2
Bug: none
Change-Id: I96924a43c609487123c25470fde2fc2618d19e27
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4381385
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2023-03-30 06:02:42 +00:00
Simon Zünd 0cc29a70d1 [deps] Update @types/codemirror for tsc 5.0 compatibility
DISABLE_THIRD_PARTY_CHECK=We need to remove a @ts-expect-error in the
formatter

Bug: 1412307
Change-Id: Ic130c0db4f879ec4e53b5ea31ba034aa880779a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4358158
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
2023-03-22 06:31:16 +00:00
Simon Zünd d04cab149b [typescript] Update tsc to 5.0.2
DISABLE_THIRD_PARTY_CHECK=Requires some changes to make tsc happy
R=jacktfranklin@chromium.org

Fixed: 1412307
Change-Id: Iee6ff440fdb346defa901435f490009f44a7a142
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4352530
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2023-03-20 10:01:07 +00:00
Randolf b0fe9c160b Update puppeteer to 19.7.3
Bug: none
Change-Id: I7e8ef149b66c6376ee728df1ee4b7c8c14803a78
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4311823
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
2023-03-06 20:09:06 +00:00
Randolf 51ffdadc72 Update @puppeteer/replay to 2.9.0
Bug: none
Change-Id: I0372a04e8714f11338d7df7c2b2ce21b24f3048a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4226464
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Randolf Jung <jrandolf@chromium.org>
2023-02-07 04:50:44 +00:00
Randolf 3ec89ccf6b Add @puppeteer/replay to test dependencies
This PR adds @puppeteer/replay for dogfooding in replay E2E test.

Bug: 1411188
Change-Id: I4c65fce494df70c01d862e99c5f355d578ae0bfa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4206547
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2023-01-31 12:47:43 +00:00
Randolf cc8925401c Update puppeteer to 19.6.2
DISABLE_THIRD_PARTY_CHECK=Files need updating

Bug: 1410437
Change-Id: I510c33a2435e03a6d0bcc389b062741490161083
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4196856
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2023-01-28 00:27:27 +00:00
Simon Zünd 9e2c759bea Revert "Update puppeteer to v19.5.0"
This reverts commit 7f8017513a.

Reason for revert: Suspected to increase overall flakiness of our e2e suite. As a precaution we'll roll back and get the tree into a green state first.

Original change's description:
> Update `puppeteer` to v19.5.0
>
> DISABLE_THIRD_PARTY_CHECK=Need to patch files for update
>
> Bug: none
> Change-Id: I6bbde8b41ba99bfb797a03595a709d56d95cb04d
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4146170
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Randolf Jung <jrandolf@chromium.org>

Bug: none
Change-Id: Ic1fb9df3a160f553e62f1df2ade6e0ba523663c5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4172908
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2023-01-17 08:05:38 +00:00
Randolf 7f8017513a Update puppeteer to v19.5.0
DISABLE_THIRD_PARTY_CHECK=Need to patch files for update

Bug: none
Change-Id: I6bbde8b41ba99bfb797a03595a709d56d95cb04d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4146170
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
2023-01-16 21:08:51 +00:00
Jack Franklin fd72c071cc Enforce alignment of JSDoc comments
This CL adds the eslint-plugin-jsdoc plugin and enables just one rule,
`jsdoc/check-alignment`, which ensures that all the lines in a comment
are correctly aligned. For example:

```
/**
* foo
 * bar
*/
```

Would fail the check and be corrected to:

```
/**
 * foo
 * bar
 */
```

DISABLE_THIRD_PARTY_CHECK=deliberate install + use of
eslint-plugin-jsdoc node_module

Bug: none
Change-Id: I969983cd550653654a334ede3409b8c850467245
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4110906
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2022-12-21 12:30:47 +00:00
Jack Franklin a682d93584 Re-enable cssnano with "lite" preset
We had to disable CSSNano because it was causing broken fonts in release
builds (exact reason TBC). This CL installs the `cssnano-preset-lite`
package which applies only the following optimisations:

1. remove whitespace
2. remove empty rules (e.g. `div{}`).
3. remove comments

This should be far less risky and unlikely to cause unexpected
breakages.

DISABLE_THIRD_PARTY_CHECK=installed & used cssnano-preset-lite in the
same CL.

Bug: 1399763
Change-Id: I7fdd8b70b02a2c1a5e1c71a87c7ba145114e6e4b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4111923
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2022-12-16 12:38:30 +00:00
Jack Franklin b57f569bc2 Remove clean-css from manage_node_deps
Bug: 1399763
Change-Id: If226ddc2469fbd3c65e3b71e50003b99f08f8bf0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4092735
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2022-12-12 10:58:53 +00:00
Jack Franklin a5fd0a412d Add cssnano
The CSS minifier we currently use (clean-css) is not maintained and
lacks support for new CSS features. CSSNano is a replacement that
supports features we need (primarily container queries).

This CL only adds the relevant dependencies, and does not use it. I will
do that (and remove clean-css) in a follow-up.

Bug: 1399763
Change-Id: I899ecc4482164404dd5ac2fd13f92fb797978e29
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4092305
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
2022-12-09 12:08:23 +00:00