zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-03 02:21:05 +08:00
Code Issues Packages Projects Releases Wiki Activity
2,268 Commits 43 Branches 79 Tags
74cb8b70d83f368dbe0a6c766cc8fe949da228ff
Commit Graph
212 Commits
Author SHA1 Message Date
Paul Lewis 853bb7e903 Restores .only PRESUBMIT check 
TBR=tvanderlippe@chromium.org
Bug: 1009443
Change-Id: I99cd8a7526e24d57d07175c280d31420a59249fb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2046552
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-10 19:11:30 +00:00
Tim van der Lippe 90c7bd3fe9 Fix e2e typescript configuration 
There were multiple issues:
1. The e2e project was accidentally recompiling the shared files again,
thus we needed to use project references for that
2. There was a difference in configuration of the root project and the
e2etests. As such, make sure to extend the root config.
3. The code was being transpiled down to es5, which is not necessary as
we run a recent version of Node. Thus, we can use `esnext` instead.
Debugging scripts should now be a lot easier, especially as
`async-await` are no longer transpiled.

For now, strict is turned off, as there are various errors that pop up.
I will clean that up in a follow-up CL.

Bug: 1044632
Change-Id: Ie0cf29a1ddd1e027bcc107d2567283eaaaa7fead
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2047183
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-10 14:44:40 +00:00
Tim van der Lippe 1e74ce74a9 Add e2etest for Last-Modified parsing in network tab 
It uses a `.rawresponse` file that forcibly sets the `Last-Modified`
header. We then open the network panel, add the `Last-Modified` column
to the data-grid and then introspect its values.

As part of this patch, each context submenu now gets an `aria-label`.
These attributes are redundant here, since they mirror the computed
accessible name of these elements. The reason they're added is that we
use this label in the selectors of the end-to-end test.

This replaces
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/devtools/startup/resources/cached-resource-metadata.html;drc=77578ccb4082ae20a9326d9e673225f1189ebb63?originalUrl=https:%2F%2Fcs.chromium.org%2F
as an e2etest.

Bug: 1047671
Change-Id: I89efc145c915f1a083dbcfb3765674122d9748fe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2039270
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-02-07 12:55:30 +00:00
Yang Guo fa34ae8b22 chmod +x scripts/test/run_e2e.py 
So that it's consistent with the other test runners.

R=aerotwist@chromium.org

Change-Id: I8be3664055d1ad398f0633ea17815d325ea0b560
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2042618
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-02-07 11:58:50 +00:00
Paul Lewis 24dcb2c127 Updates 403 message in Hosted Mode server 
TBR=tvanderlippe@chromium.org

Change-Id: Iccc270640c1449dd48ef1e8e84228f26be8aa2f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2042614
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-02-07 09:21:20 +00:00
Eric Leese c43516c5f8 e2e test for wasm raw debugging 
Adds a test that breaks with a wasm call frame and verifies
that the correct line in the wasm disassembly is highlighted.

Bug: chromium:1045573
Change-Id: Ibf68063d947fec0ba178ab8ec7e5137fec6ebaa6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2038701
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
 2020-02-07 09:04:30 +00:00
Liviu Rau 73f1b60756 Whitespace to trigger builders 
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I4b57a2304ef72650264ec3e6867ae447e9633937
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2042103
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
 2020-02-06 16:48:47 +00:00
Paul Lewis 96a0b3c224 [e2e] Performs cleaner shutdown 
Bug: 1044632
Change-Id: I86252d31a411e82e44bbf902e65501e9f6807939
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2042090
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
 2020-02-06 16:08:27 +00:00
Yang Guo 49346f1e67 Remove experiments query param from scripts 
R=mathias@chromium.org

Bug: 1048124
Change-Id: I4bbd6b9566c6687a2bda2258969025bc53f69a32
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2041430
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-02-06 11:54:17 +00:00
Paul Lewis bd88d7fb19 [e2e] Moves hosted mode server to JS side 
Change-Id: I864dba4c988716215d18cb32b59c539d966cb9fb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2037997
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-05 17:11:13 +00:00
Paul Lewis 32473f08f9 [e2e] Moves shared logic out of e2e 
We plan to have multiple suites using the same machinery that currently
runs the e2e. This CL moves that machinery out to a shared folder and
remaps the e2e code to use everything in the new locations.

Future CLs will introduce additional suites for capturing traces,
screenshots, and other artifact.

Change-Id: I452424d8f65fb03897f5a59606c592be996e91ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2035949
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-02-05 16:01:03 +00:00
Paul Lewis 285715ec7b [e2e] Fix exit code and paths for bots. 
TBR=tvanderlippe@chromium.org
Change-Id: I23c5ed10eb5561129d249c6d16da2781f5f18c06
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2037485
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-05 15:43:33 +00:00
Philip Pfaffe 422e2f6cd7 Report the content type for wasm modules in hosted mode 
In the hosted_mode server, set the appropriate content type when serving
wasm modules.

Change-Id: I9ce8ed32804b0b0afe0a2110faedae6ce51f4478
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2035795
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2020-02-03 16:10:49 +00:00
Tim van der Lippe 1418552cad Remove bundled Runtime.js 
After
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2030781
all entrypoints properly import the Runtime.js. As such, we no longer
need to force-bundle the Runtime in any entrypoint.

Bug: 1046596, 1006759
Change-Id: I0b1d14f3857b4c9511e14f416ddf7774e7d0071b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2031122
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-03 13:50:28 +00:00
Christy Chen 1ab87e04c9 Fixed localization presubmit command line too long error 
In presubmit.py, _CheckDevtoolsLocalization() gets all the paths of affected files and pass those in as arguments when running run_localization_check.py. When a lot of files need to be scanned, it casus the issue where character number exceed the limit of CreateProcess on Windows.

This PR changes the _CheckDevtoolsLocalization() to create a temp file that contains the affected file paths, and have the validation step read the affected file paths from the temp file.


Bug: 941561
Change-Id: I698e5064287eee8a8a3aca0682e3ab3521eb63d1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2032086
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Christy Chen <chrche@microsoft.com>
 2020-01-31 23:01:04 +00:00
Tim van der Lippe 912cec0c68 Add istanbul-diff to node_modules 
DISABLE_THIRD_PARTY_CHECK=Adding istanbul-diff to node_modules

Bug: chromium:1044881
Change-Id: Ia80f499622132ce9b2c0890147fecdd4530886c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2024871
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-01-28 15:21:23 +00:00
Brandon Goddard 53faba1c7d Reland "Add script that checks license headers of JavaScript files" 
This reverts commit 27f15d113a.

Reason for revert: script is fixed on Windows

Original change's description:
> Revert "Add script that checks license headers of JavaScript files"
>
> This reverts commit 6122ebd2f9.
>
> Reason for revert: Presubmit fails on windows due to relative
> path comparison with excluded files
>
> Original change's description:
> > Add script that checks license headers of JavaScript files
> >
> > The script checks if the license header is the BSD-3 license header that
> > DevTools is licensed under. It excludes files that have license headers
> > that reference non-Google/non-Chromium authors or are third_party
> > bundles that are checked into a non-third_party folder.
> >
> > Change-Id: I35f78036b48d3d7b7dcb9db1e070691282e27a02
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016747
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Liviu Rau <liviurau@chromium.org>
> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
>
> TBR=bmeurer@chromium.org,aerotwist@chromium.org,tvanderlippe@chromium.org,liviurau@chromium.org
>
> Change-Id: Idc27e9b78d5ac314176c71f8f4a7a2257da08be9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019019
> Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
> Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>

TBR=bmeurer@chromium.org,aerotwist@chromium.org,lomitch@microsoft.com,brgoddar@microsoft.com,tvanderlippe@chromium.org,liviurau@chromium.org

Change-Id: I191665c8e3fdbee7f3c5c312b5ba00513502e080
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019021
Reviewed-by: Fabio Rocha <fabio.rocha@microsoft.com>
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
 2020-01-24 18:16:35 +00:00
Brandon Goddard 27f15d113a Revert "Add script that checks license headers of JavaScript files" 
This reverts commit 6122ebd2f9.

Reason for revert: Presubmit fails on windows due to relative
path comparison with excluded files

Original change's description:
> Add script that checks license headers of JavaScript files
> 
> The script checks if the license header is the BSD-3 license header that
> DevTools is licensed under. It excludes files that have license headers
> that reference non-Google/non-Chromium authors or are third_party
> bundles that are checked into a non-third_party folder.
> 
> Change-Id: I35f78036b48d3d7b7dcb9db1e070691282e27a02
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016747
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Liviu Rau <liviurau@chromium.org>
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>

TBR=bmeurer@chromium.org,aerotwist@chromium.org,tvanderlippe@chromium.org,liviurau@chromium.org

Change-Id: Idc27e9b78d5ac314176c71f8f4a7a2257da08be9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019019
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
 2020-01-24 16:50:05 +00:00
Tim van der Lippe 22a64d3fe4 Update replace-internal-references to accept multiple folders 
This allows us to specify multiple folders at the same time, doing only
1 pass per folder.

Bug: 1006759
Change-Id: I522249c3490f36c7d856a56c992d0393cc9738e4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2018945
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-24 13:46:38 +00:00
Tim van der Lippe 64a94d8105 Migrate object_ui/ to import cross-module 
Bug: 1006759
Change-Id: Ic6a53e6183e3621771c019c4c9692c072f812736
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019123
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-24 12:13:48 +00:00
Tim van der Lippe 6122ebd2f9 Add script that checks license headers of JavaScript files 
The script checks if the license header is the BSD-3 license header that
DevTools is licensed under. It excludes files that have license headers
that reference non-Google/non-Chromium authors or are third_party
bundles that are checked into a non-third_party folder.

Change-Id: I35f78036b48d3d7b7dcb9db1e070691282e27a02
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016747
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2020-01-24 11:51:49 +00:00
Mandy Chen 40720b1f80 Fix type checking script on windows 
On windows, result of path.join() contains double back slashes, e.g.
>>> path.join('sdk', '../SupportedCSSProperties.js')
'sdk\\../SupportedCSSProperties.js'
But in run_type_check.py, it expects paths to contain forward slashes.
This CL updates the equlity checks to call path.join() as well so the
script works on windows.

Change-Id: Id2e9bca6e2f11403f5520892581eaaa8392613da
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2017917
Reviewed-by: Fabio Rocha <fabio.rocha@microsoft.com>
Reviewed-by: Brian Cui <brcui@microsoft.com>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
 2020-01-24 02:30:57 +00:00
Tim van der Lippe 0c42b5bb12 Add recast to node_modules/ 
It will be used in a check to enforce license headers

DISABLE_THIRD_PARTY_CHECK=Adds recast to node_modules

Change-Id: I822a368d9ba22058ac2586ea3638089a2f5b1d18
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016746
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-23 13:38:45 +00:00
Tim van der Lippe ddbec81f2d Map imports to Protocol to ProtocolModule 
There is a name-clash on the Closure type-defs generated from CDP, which
also use the Protocol namespace. Therefore, for es-imports we should use
`import * as ProtocolModule` instead.

Bug: 1006759
Change-Id: I1e7e92825fdafe56c4f5274e520650001789014c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016755
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-23 13:22:20 +00:00
Tim van der Lippe 4d1ddf7f73 Migrates protocol/ to ESM internally 
Bug: 1006759
Change-Id: I99743fcf3d33bc1e5a3b729c2c544826e1d8e923
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2013156
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-23 13:19:20 +00:00
Mathias Bynens b0693f217f Improve npm run debug-test output 
Previous output:

```
Running web tests with args: ~/projects/chromium/src/third_party/blink/tools/run_web_tests.py,inspector*,http/tests/inspector*,http/tests/devtools,--build-directory,~/projects/chromium/src/out,--target,Release,--additional-driver-flag=--debug-devtools,--additional-driver-flag=--remote-debugging-port=9222,--time-out-ms=6000000,runtime/runtime-evaluate-bad-unicode.js
```

This patch changes the output to:

```
Running web tests with args: ~/projects/chromium/src/third_party/blink/tools/run_web_tests.py inspector* http/tests/inspector* http/tests/devtools --build-directory ~/projects/chromium/src/out --target Release --additional-driver-flag=--debug-devtools --additional-driver-flag=--remote-debugging-port=9222 --time-out-ms=6000000 runtime/runtime-evaluate-bad-unicode.js
```

This way, the output contains the actual command that's being run, making it more readable and copy-paste friendly.

Change-Id: Ib5341514f3802937a052f1c5d257e45ee64c17a9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016751
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-23 12:34:31 +00:00
Paul Lewis b8b3801b10 Adds e2e scripts and 'Hello, World' test 
Bug: 1044632
Change-Id: I1f6c75c0c03f7f03cb2e8e92e8766af0c8444057
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2007505
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-01-22 17:23:15 +00:00
Paul Lewis 2e45f00d36 Fix JS config script 
Change-Id: I5cec137f40e4c3decf9ac9723054220d85d6926b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2014920
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-22 16:40:54 +00:00
Tim van der Lippe e4974ddc4c Remove whitespace at the end of the package.json lines 
json.dump appears to add extraneous spaces before newline characters. By
specifying the separators option, we can remove these whitespaces,
reducing the diff noise. Solution taken from
https://stackoverflow.com/questions/16311562/python-json-without-whitespaces

DISABLE_THIRD_PARTY_CHECK=Fix whitespace in node_modules

Change-Id: I26556e5053f19a9021ad41779319bdfe3f8c2b6c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2013154
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-01-22 15:17:25 +00:00
Tim van der Lippe 6d1e03c598 Reland "Migrate accessibility/ to ESM internally" 
This reverts commit 5a8f4d89e1.

Reason for revert: Use fix as we did for CSSProperties

Original change's description:
> Revert "Migrate accessibility/ to ESM internally"
>
> This reverts commit 785c6a4f1c.
>
> Reason for revert: Suspected to break "run_type_check.py" on the bot.
> https://ci.chromium.org/p/chromium/builders/try/linux-rel/279842
>
> Original change's description:
> > Migrate accessibility/ to ESM internally
> >
> > Bug: 1006759
> > Change-Id: I9d801349fd73a06d7f72933acfa65b103531a278
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991511
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
>
> TBR=aerotwist@chromium.org,tvanderlippe@chromium.org
>
> Change-Id: Ie4fe54b84cf91cd034bfdb21c20b97eaacdb3599
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1006759
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994960
> Commit-Queue: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

Bug: 1006759
Change-Id: I7e3b3eafd608aa2fa7d05319a9ff0d4947a2dc88
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2013148
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-22 14:48:24 +00:00
Paul Lewis 7b1e0f41ab Adds Puppeteer types 
DISABLE_THIRD_PARTY_CHECK=Updates the deps list as well as the node_modules

Change-Id: Ia9a6d26a89d85c0ca24253892ec3aa2858fe034a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2009108
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-20 14:02:00 +00:00
Tim van der Lippe bcf142a3e1 Update TypeScript to latest version 
DISABLE_THIRD_PARTY_CHECK=Updates the deps list as well as the node_modules

Bug: 1011811
Change-Id: I09c38caa2b60f8f291695a908a3363dd870f5625
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2009109
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-01-20 11:58:10 +00:00
Tim van der Lippe 9293af7230 Migrate sdk/ to ESM internally 
Bug: 1006759
Change-Id: I2bb0c8eaa4fdc89edd8da2b12d9fd0e08d427174
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2003327
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-17 15:17:17 +00:00
Tim van der Lippe f86acf8203 Remove Puppeteer installation 
We can set the PUPPETEER_SKIP_CHROMIUM_DOWNLOAD environment variable to
not install a local Chromium installation. Update the preinstall script
to verify that this variable is set. If you want to update the deps, you
can now run `npm run install-deps` to get the update.

DISABLE_THIRD_PARTY_CHECK=Fixing node_modules

Change-Id: I6d77a77f343f8869a17434e7b83951b6380444d0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2003319
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-16 13:32:46 +00:00
Tim van der Lippe 399a956776 Reland "Use typescript-eslint instead of tslint" 
This reverts commit 72da1a51cb.

Reason for revert: Buildbots in Chromium no longer run the linter checks.

Original change's description:
> Revert "Use typescript-eslint instead of tslint"
> 
> This reverts commit d0e22da4db.
> 
> Reason for revert: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8891272266464063200/+/steps/devtools_lint_check__with_patch_/0/stdout
> 
> Original change's description:
> > Use typescript-eslint instead of tslint
> >
> > This will update our eslint configuration to use @typescript-eslint to
> > parse and lint TypeScript files. It integrates with the existing
> > infrastructure to lint our files
> >
> > Fixed: 1041811
> > Change-Id: I29f49a57229e3ee17524045b3905b9cc835271ab
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1998771
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> 
> TBR=aerotwist@chromium.org,tvanderlippe@chromium.org
> 
> Change-Id: Ic0dfc585cd0ac08f1f4a72ce19d0bebc74f9cdb5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2000795
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=aerotwist@chromium.org,tvanderlippe@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I623c9b873ac0af3157ff3b73c91e006f7db58e1e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2003315
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-16 10:58:49 +00:00
Tim van der Lippe 0cfd3dc2af Update remove global scripts to run on legacy files 
Also make sure we take into account the layout tests

Bug: 1006759
Change-Id: I6b819876034aae7019e62b1b34ca6adeb50326b1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2002606
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-16 10:35:44 +00:00
Tim van der Lippe e6a9868686 Migrate javascript_metadata/ to ESM internally 
Bug: 1006759
Change-Id: Ibb7c4fb15197431c37c485bd1a05b20acf2bf098
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994967
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-15 15:27:13 +00:00
Tim van der Lippe 72da1a51cb Revert "Use typescript-eslint instead of tslint" 
This reverts commit d0e22da4db.

Reason for revert: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8891272266464063200/+/steps/devtools_lint_check__with_patch_/0/stdout

Original change's description:
> Use typescript-eslint instead of tslint
>
> This will update our eslint configuration to use @typescript-eslint to
> parse and lint TypeScript files. It integrates with the existing
> infrastructure to lint our files
>
> Fixed: 1041811
> Change-Id: I29f49a57229e3ee17524045b3905b9cc835271ab
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1998771
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Paul Lewis <aerotwist@chromium.org>

TBR=aerotwist@chromium.org,tvanderlippe@chromium.org

Change-Id: Ic0dfc585cd0ac08f1f4a72ce19d0bebc74f9cdb5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2000795
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-14 17:57:10 +00:00
Paul Lewis 21fb34999d Adds PRESUBMIT check for .only calls in Karma tests 
Change-Id: I9355592d74777c9136eb50edd3fd08bc1b9e2c3c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2000786
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-01-14 15:37:28 +00:00
Tim van der Lippe d0e22da4db Use typescript-eslint instead of tslint 
This will update our eslint configuration to use @typescript-eslint to
parse and lint TypeScript files. It integrates with the existing
infrastructure to lint our files

Fixed: 1041811
Change-Id: I29f49a57229e3ee17524045b3905b9cc835271ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1998771
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-14 13:32:48 +00:00
Tim van der Lippe 984c7d7608 Add typescript-eslint to node_modules 
Bug: 1041811
Change-Id: Id9820054e67f8402a4a1220035d8789f7cff5a0b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1998769
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-14 12:34:56 +00:00
Tim van der Lippe 383de766af Fix check for nested directories in check_gn 
Any module.json that was listed in a nested folder (for example in
third_party/) was not properly being checked in the check_gn script. We
should traverse not only the direct directories of `front_end/`, but
also recurse into any of its subdirectories.

Bug: 1041415
Change-Id: I6c4adbf4315c30b3d90361329d726323020308a7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1997352
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
 2020-01-14 10:20:07 +00:00
Rob Paveza 41120592d3 Refactor of the 'copy_all_modules' build step 
I've sporadically seen the same CreateProcess failure in ninja recently
that we'd been seeing for the GRD script [1]. This failure is related to
the copy_devtools_modules script.

As part of this change I've also corrected some linting errors that I
had made with the previous fix.

[1] The previous fix can be found at
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1992319

Change-Id: Ic9a66160acddfc929fdd43f20572435ceff3724c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1997723
Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-13 19:07:47 +00:00
Simon Zünd 5a8f4d89e1 Revert "Migrate accessibility/ to ESM internally" 
This reverts commit 785c6a4f1c.

Reason for revert: Suspected to break "run_type_check.py" on the bot.
https://ci.chromium.org/p/chromium/builders/try/linux-rel/279842

Original change's description:
> Migrate accessibility/ to ESM internally
> 
> Bug: 1006759
> Change-Id: I9d801349fd73a06d7f72933acfa65b103531a278
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991511
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=aerotwist@chromium.org,tvanderlippe@chromium.org

Change-Id: Ie4fe54b84cf91cd034bfdb21c20b97eaacdb3599
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1006759
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994960
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-01-10 06:01:18 +00:00
Paul Lewis b4e2a0741b Check for self.X = self.X || {} in migration script 
Bug: 1006759
Change-Id: I741093c412e6ef47b0154b0202bda56ffd07328c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993460
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-01-09 17:11:01 +00:00
Paul Lewis 785c6a4f1c Migrate accessibility/ to ESM internally 
Bug: 1006759
Change-Id: I9d801349fd73a06d7f72933acfa65b103531a278
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991511
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-09 17:06:11 +00:00
Tim van der Lippe 472675db85 Migrate data_grid/ to ESM internally 
Bug: 1006759
Change-Id: Idb20304bcf3e72e4a0bba242e847e90ff9b8a8c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993342
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-09 15:04:51 +00:00
Liviu Rau e5cecd6c52 Revert "Whitespace to trigger builders" 
This reverts commit 3aa0411a4c.

Reason for revert: To trigger builders

Original change's description:
> Whitespace to trigger builders
> 
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: I96ea4d7ba12b5b5e884f2fb7f5781afa4a9c1564
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991505
> Commit-Queue: Liviu Rau <liviurau@chromium.org>
> Reviewed-by: Liviu Rau <liviurau@chromium.org>

TBR=machenbach@chromium.org,sigurds@chromium.org,mathias@chromium.org,liviurau@chromium.org

Change-Id: I133c6f3e3bdb86884c13ab41b6c82be3064d882d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991509
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
 2020-01-09 12:05:43 +00:00
Liviu Rau 3aa0411a4c Whitespace to trigger builders 
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I96ea4d7ba12b5b5e884f2fb7f5781afa4a9c1564
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991505
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
 2020-01-09 11:35:52 +00:00
Rob Paveza 4947355c94 Fix for too-long length of command line in Windows build. 
Apparently related to the changes to ESM, the Windows build command
line has started to exceed 32kb. This is running into a fault within
ninja in which the call to CreateProcess fails as a result of the
command line being an invalid parameter.

This fix addresses it by dumping the file list into a GN "response
file" which is then fed into the corresponding Python script, as
indicated by the GN docs. See:
https://gn.googlesource.com/gn/+/master/docs/reference.md#var_response_file_contents

Bug: 1040233
Change-Id: Ie421a09d2a23756e9195e3ad84b941187de6e3c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1992319
Reviewed-by: John Emau <John.Emau@microsoft.com>
Reviewed-by: Mike Jackson <mjackson@microsoft.com>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>
 2020-01-08 22:17:55 +00:00