zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-02 18:11:04 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,387 Commits 43 Branches 79 Tags
7a2ead3d36199afe275fd166a151ec39b930f24e
Commit Graph
70 Commits
Author SHA1 Message Date
Christy Chen 7a2ead3d36 [Loc] Migrate browser_debugger to localization V2 
Migrate brwoser_debugger
Tested with en-XL: https://imgur.com/a/61y0spd


Bug: 1136655
Change-Id: Ie9a831313a8d47a3b370b2248948a65881ab6685
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2667107
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-02-02 13:37:58 +00:00
vidorteg 8847361583 [Loc] Migrate accessibility to Localization V2 
- Migrate accessibility to use Localization V2 APIs.
- Removed accessibility grdps

Tested with en-XL.json
https://imgur.com/a/guNtgie

Bug: 1136655
Change-Id: Id963e8eed6c8d11fd70662737f24196295f48975
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2654078
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-29 17:47:58 +00:00
Christy Chen 5a52125b2e [Loc] Migrate timeline_model to localization V2 
Migrate timeline_model directory


Bug: 1136655
Change-Id: Ie7023acf9d3625e26bcae542c47172bb88995bc0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2651413
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-28 12:32:27 +00:00
Christy Chen e936c00ec7 [Loc] Migrate source_frame to localization V2 
Migrate source_frame directory
en-XL: https://imgur.com/a/WOKixNs


Bug: 1136655
Change-Id: I9266985045a7068b0d1ae8a8a371f7e84a5171b7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2648577
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-01-27 07:55:44 +00:00
Peter Marshall e1829f8d12 [l10n] Make sure we check subdirs in localization checks 
Previously we did not iterate subdirectories which meant we missed
folders like ui/components. Now the script complains that there is no
appropriate .grdp file for the strings it finds in e.g. SurveyLink.ts.

Also add the missing strings for SurveyLink.ts as the script now finds
them.

Bug: 1169118
Change-Id: I0e4793dc8581cd439f103632e60e9b8088a529a1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2644811
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-26 10:07:08 +00:00
Christy Chen e4593a52d0 [Loc] Migrate object_ui to localization V2 
Migrate object_ui directory


Bug: 1136655
Change-Id: I06f52c5f12638b1bb120988fbd210bbc00797fb6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2646142
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-26 09:57:48 +00:00
Christy Chen e3eccbb247 [Loc] Migrate console_counter to localization V2 
Migrate console_counter directory
Tested with en-XL: https://imgur.com/a/11ZT5gp


Bug: 1136655
Change-Id: I2da3c600d8794dda7149bc42ab1be4530c08a34d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2642464
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-01-25 10:07:33 +00:00
Christy Chen 59f6cf5697 [Loc] Migrate browser_sdk to localization V2 
Migrate browser_sdk directory


Bug: 1136655
Change-Id: Ied83b93ee62b4e3d85799c0518b006f97066087a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2644600
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-01-25 07:35:53 +00:00
vidorteg fa8efd973e [Loc] Migrate color picker pane to Localization V2 
- Migrate color picker to use Localization V2 APIs.
- Removed color picker grdps

Tested with en-XL.json
https://imgur.com/a/OfMtEEN

Bug: 1136655
Change-Id: I79806c1222c836ccd623bbe4ddb3dad8ab864d8e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2643999
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-22 18:24:03 +00:00
Christy Chen b6e28b60de [Loc] Migrate css_overview to localization V2 
Migrate css_overview directory
Tested with en-XL: https://imgur.com/a/A5wDgqt


Bug: 1136655
Change-Id: I4de99a8504fff0a6c866e2f5079535ed4d3e65dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2644596
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Christy Chen <chrche@microsoft.com>
 2021-01-22 09:15:52 +00:00
vidorteg 7c153a21c2 [Loc] Migrate profiler to Localization V2 
- Migrate profiler to use Localization V2 APIs.
- Import the strings declared in the heap_snapshot_worker
- Removed event_listener grdps

Tested with en-XL.json:
https://imgur.com/MoxBmKK
https://imgur.com/cW0nelm
https://imgur.com/A99ofNG

Bug: 1136655
Change-Id: I282ff0a8ccd374dab95412eda1c974a587d1c78a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2632164
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-01-21 21:39:48 +00:00
vidorteg 8d1dafc6c2 [Loc] Migrate heap_snapshot_worker to Localization V2 
- As this is a web worker with it's own memory space strings are not
  displayed inside but serialized and send over the profiler to be
  displayed.
- Removed event_listener grdps

Tested with en-XL.json
https://imgur.com/a/TdtQcnl

Bug: 1136655
Change-Id: I87365b50ecf2d3539504950d6ad6c391731bec54
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631106
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-01-21 17:27:18 +00:00
Christy Chen f9033fa039 [Loc] Migrate perf_ui to localization V2 
Migrate perf_ui

Bug: 1136655
Change-Id: I000de6662e48aa7e8e236c550584a1e5947dbad7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2641894
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Christy Chen <chrche@microsoft.com>
 2021-01-21 11:51:33 +00:00
Christy Chen 10e970269b [Loc] Migrate inline_editor to localization V2 
Migrate inline_editor directory
Tested with en-XL: https://imgur.com/a/1bw3coo


Bug: 1136655
Change-Id: I33979b0612219cdaf83b6e66e5055b0504dc7920
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2591889
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-01-20 13:17:30 +00:00
vidorteg 1502a9ec07 [Loc] Migrate event_listener pane to Localization V2 
- Migrate event_listener to use Localization V2 APIs.
- Removed event_listener grdps

Tested with en-XL.json
https://imgur.com/a/hm7nJ9k

Bug: 1136655
Change-Id: I401023ddda8c557732cc25943b6062f59f1b6ca8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2632158
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-15 17:20:09 +00:00
vidorteg 18a45a67b2 [Loc] Migrate screencast panel to Localization V2 
- Migrate screencast to use Localization V2 APIs.
- Removed screencast grdps

Tested with en-XL.json
https://imgur.com/a/0i8xOyL

Bug: 1136655
Change-Id: I71fcaca0426e116a4466cc4f78b11bce8d692a44
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2628579
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-01-14 20:27:27 +00:00
Christy Chen 9d7f897b22 [Loc] Migrate recorder to localization V2 
Migrate recorder tool
Tested with en-XL: https://imgur.com/a/LcyPbpt

Bug: 1136655
Change-Id: I308e11313d5be94a59f9a9b8df3d38e5ca81597d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2597799
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-04 22:06:09 +00:00
Christy Chen ae8efc5c4e [Loc] Migrate persistence to localization V2 
Migrate persistence
Tested with en-XL: https://imgur.com/a/nreUeRP


Bug: 1136655
Change-Id: I8eaf5d830a411d75182b5a7f642ad5ca559c781a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2591893
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-15 17:02:38 +00:00
Christy Chen 3e5de8a135 [Loc] Migrate components to Localization V2 
Bug: 1136655
Change-Id: I69678b0f06027cd0b4b3715d959a41fa592a60bb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2585954
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-11 19:25:57 +00:00
Christy Chen 393c680774 [Loc] Migrate node_debugger to Localization V2 
Bug: 1136655
Change-Id: I080bf2712871e5174873c418ad193bb82c4e543b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2580845
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-12-11 18:06:07 +00:00
Christy Chen a09a090c7a [Loc] Migrate js_profiler to Localization V2 
Bug: 1136655
Change-Id: I4f1e47cc0aff903545187ea387c24af507e5e5e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2583063
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-12-11 18:00:17 +00:00
Christy Chen b5da31f172 [Loc] Migrate cookie_table to Localization V2 
Test with en-XL: https://imgur.com/a/Rzfcxzc

Bug: 1136655
Change-Id: Iad51c1ef4f6225c8600bfa722cb39ea50f265f7a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2582699
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-10 18:05:54 +00:00
vidorteg 3c56ca23d9 [Loc] Migrate node_main panel to Localization V2 
- Migrate node_main to use Localization V2 APIs.
- Removed node_main grdps

Tested with en-XL.json
https://imgur.com/a/fky46TA

Bug: 1136655
Change-Id: I6fcb6328a8a053b084f094ac0c5b1f7e98449992
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2578185
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-12-10 00:10:57 +00:00
vidorteg 768ced1d57 [Loc] Migrate mobile throttling setting panel to Localization V2 
- Migrate mobile throttling setting panel to use Localization V2 APIs.
- Removed media grdps

Tested with en-XL.json
https://imgur.com/a/PfBEBxD

Bug: 1136655
Change-Id: Ic8729040a89baa7c0d860724e7e3b8146194160f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2572862
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-09 22:32:37 +00:00
Christy Chen 87d9ffc323 [Loc] Migrate input to Localization V2 
Bug: 1136655
Change-Id: I7d8b1c34aaea07b896ec913faf141381422c3bd6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2580848
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-09 17:59:07 +00:00
Christy Chen 19739b881b [Loc] Migrate help to localization V2 
migrate help directory

Bug: 1136655
Change-Id: Ib361747d53faa0a5cc860d331238e08d327031cc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577943
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-12-08 21:25:02 +00:00
Christy Chen cebafe7ed6 [Loc] Migrate workspace to localization V2 
Bug: 1136655
Change-Id: Ia6a4ff1c043f1b02656a9d7edf640f04f2f1e9a1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577936
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-08 20:19:22 +00:00
Christy Chen b97d85b7ca [Loc] Migrate protocol monitor tool to localization V2 
Migrate protocol monitor tool
Tested with en-XL: https://imgur.com/a/IPT8ly2


Bug: 1136655
Change-Id: I538590b76e8511cc539d3b4770790db34c2ec5f9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2572872
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-12-04 22:22:17 +00:00
vidorteg d083f4ab10 [Loc] Migrate media panel to Localization V2 
- Migrate media panel to use Localization V2 APIs.
- Removed media grdps

Tested with en-XL.json
https://imgur.com/a/j3MxnLu

Bug: 1136655
Change-Id: Iebcce7e991db19cda8477f75b180390e1e7f5a78
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2570496
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
 2020-12-03 17:28:01 +00:00
Christy Chen 5d7848d54d Reland "[Loc] Migrate changes tool to localization V2" 
This reverts commit 9e5ab71e50.

Reason for revert: The Cl was reverted due to devtools pak file limitation. That issue has been fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2558341

Original change's description:
> Revert "[Loc] Migrate changes tool to localization V2"
>
> This reverts commit abcb8f7aa8.
>
> Reason for revert: Consistently causing autoroll issues when rolling devtools-frontend into Chromium - see https://chromium-review.googlesource.com/c/chromium/src/+/2554521 for an example.
>
> To recreate this, do a debug build of Chromium with this patch applied to DevTools. It's causing an issue with duplicate keys in the pak files. No DevTools Frontend builds do a debug build of Chromium with the DevTools frontend patch applied so our CQ will be green despite causing an issue.
>
> You can run this locally in Chromium to reproduce via:
>
> autoninja -C out/Default chrome:packed_resources_extra
>
> Which will show the error. 
>
> Original change's description:
> > [Loc] Migrate changes tool to localization V2
> >
> > Migrate changes tool
> > Tested with en-XL: https://imgur.com/a/hFDBjQV
> >
> >
> > Bug: 1136655
> > Change-Id: Ic434c3085b9e2f2cf44583cca7ee1ce8f1d412f2
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548688
> > Commit-Queue: Christy Chen <chrche@microsoft.com>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
>
> TBR=szuend@chromium.org,chrche@microsoft.com
>
> Change-Id: I94b27434562f6a6bff3be381ab8a5802bd8b03f9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1136655
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2557044
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>

TBR=szuend@chromium.org,chrche@microsoft.com,jacktfranklin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1136655
Change-Id: I35166a6f4f38462073b933c01c169b3c8d14311b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567344
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Christy Chen <chrche@microsoft.com>
Commit-Queue: Christy Chen <chrche@microsoft.com>
 2020-12-02 06:13:17 +00:00
Kalon Hinds de5da1203d [Loc] Migrate snippets to Localization V2 
Bug: 1136655
Change-Id: I724747d248b047ce85761b9ec7c6ae512c939ddb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548691
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-01 21:54:27 +00:00
Kalon Hinds 1f437b9488 [Loc] Migrate performance_monitor to Localization V2 
Bug: 1136655
Change-Id: I281da13c70cc56a92679064d122873b406d54377
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2553935
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-11-25 08:31:14 +00:00
Jack Franklin 9e5ab71e50 Revert "[Loc] Migrate changes tool to localization V2" 
This reverts commit abcb8f7aa8.

Reason for revert: Consistently causing autoroll issues when rolling devtools-frontend into Chromium - see https://chromium-review.googlesource.com/c/chromium/src/+/2554521 for an example.

To recreate this, do a debug build of Chromium with this patch applied to DevTools. It's causing an issue with duplicate keys in the pak files. No DevTools Frontend builds do a debug build of Chromium with the DevTools frontend patch applied so our CQ will be green despite causing an issue.

You can run this locally in Chromium to reproduce via:

autoninja -C out/Default chrome:packed_resources_extra

Which will show the error. 

Original change's description:
> [Loc] Migrate changes tool to localization V2
>
> Migrate changes tool
> Tested with en-XL: https://imgur.com/a/hFDBjQV
>
>
> Bug: 1136655
> Change-Id: Ic434c3085b9e2f2cf44583cca7ee1ce8f1d412f2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548688
> Commit-Queue: Christy Chen <chrche@microsoft.com>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

TBR=szuend@chromium.org,chrche@microsoft.com

Change-Id: I94b27434562f6a6bff3be381ab8a5802bd8b03f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1136655
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2557044
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-11-24 10:54:09 +00:00
Christy Chen abcb8f7aa8 [Loc] Migrate changes tool to localization V2 
Migrate changes tool
Tested with en-XL: https://imgur.com/a/hFDBjQV


Bug: 1136655
Change-Id: Ic434c3085b9e2f2cf44583cca7ee1ce8f1d412f2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548688
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-11-23 18:46:16 +00:00
vidorteg 068400262b [Loc] Migrate lighthouse panel to Localization V2 
- Migrate lighthouse panel to use Localization V2 APIs.
- Does not migrate lighthouse-worker yet (which builds the report)
- Removed lighthouse grdps

Tested with en-XL.json
https://imgur.com/a/sjbn3C5

Bug: 1136655
Change-Id: Ib55fabf941e4c0ae7ef5e1beb3cf4726b836386e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548696
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-11-21 05:39:03 +00:00
vidorteg af634bcc6c [Loc] Migrate animation panel to Localization V2 
- Migrate animation panel to use Localization V2 APIs.
- Removed animation grdps

Tested with en-XL.json
https://imgur.com/a/eVERZjZ

Bug: 1136655
Change-Id: I71fdcff68757b13ed72d735644ef09c6609f54d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548263
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-11-21 02:28:13 +00:00
Kalon Hinds 361d02972a [Loc] Migrate developer_resources to Localization V2 
Bug: 1136655
Change-Id: I01278b1c215dd7efa7255223a520df3524c53897
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2552105
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-11-20 19:47:24 +00:00
Christy Chen d0b25f6e31 [Loc] Migrate search to localization V2 
Migrate search tool
Tested with en-XL: https://imgur.com/a/3Nv2hWE


Bug: 1136655
Change-Id: Icd29a61f4bc7df220a03f3d17c2a2f79c0ba0572
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548220
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-11-19 19:21:46 +00:00
Christy Chen 0a48864e1e [Loc] Migrate text_editor to localization V2 
Migrate text_editor folder


Bug: 1136655
Change-Id: Ib67eb334eaf4cf25cc07b077ce6aa7c9b29e77f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548275
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-11-19 18:13:13 +00:00
Kalon Hinds 438d44197a [Loc] Migrate security to Localization V2 
Bug: 1136655
Change-Id: I77e776f00249eb97f49e24681d19722f500c4c86
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2546327
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-11-19 01:34:11 +00:00
vidorteg 5c2ea4d80c [Loc] Migrate layer_viewer to Loc V2 
- Migrate layer_viewer panel to use Localization V2 APIs.
- Removed layer_viewer grdps

Tested with en-XL.json
https://imgur.com/a/nYe4KRL

Bug: 1136655
Change-Id: Iebcb0c125a73b6eab6a24ff91f2a39440155e768
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2546322
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-11-18 20:04:22 +00:00
vidorteg 0527ac564a [Loc] Migrate layers to Loc V2 
- Migrate layers panel to use Localization V2 APIs.
- Removed layers grdps

Tested with en-XL.json
https://imgur.com/a/13R1mXF

Bug: 1136655
Change-Id: I255b1edbc265aab11728f78905c55d77a5fb3bb9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2543113
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-11-17 20:02:06 +00:00
Christy Chen 14a913c836 [Loc] Migrate webauthn to localization V2 
Migrate webAuthn tool
Tested with en-XL: https://imgur.com/a/medKsEq


Bug: 1136655
Change-Id: Id44fc298fb38f09467eedb77a3a2d50493462ac1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2543102
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-11-17 19:02:27 +00:00
Christy Chen 598b98fe2b [Loc] Migrate web_audio to localization V2 
Migrate web_audio tool
Tested with en-XL: https://imgur.com/0eEBFqM

Bug: 1136655
Change-Id: Ibef905a1302eb807de78296bccaadc1559d5f642
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2538490
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-11-16 19:32:49 +00:00
Christy Chen ea635f12e8 [Loc] Migrate devices directory 
Migrate Remote Devices tool (devices directory)

(Note: this is a deprecated panel, and it's currently blank, so couldnt test with en-XL)

Bug: 1136655
Change-Id: I8e24de06c295ef8886b788dcacea106be0cb33ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2521685
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-11-11 23:52:09 +00:00
Christy Chen 2e411e2f84 [Loc] Migrate coverage to Loc V2 
- Migrate coverage panel to use LocV2 apis.
- Removed unused grdps

Tested with en-XL.json
https://imgur.com/a/61yoUNo

Bug: 1136655
Change-Id: Ie5de60d4e62a1496f9642d8eeed0e326727f17d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2504408
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
 2020-11-03 17:06:17 +00:00
vidorteg c1aeb6318c Reland "Localization: Migrating Settings Folder" 
Relanding the migration of the settings folder that was reverted in here:
2479923: Revert "Localization: Migrating Settings Folder" | https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2479923

Also including this fix that is required but was also reverted here:
2476336: Fix missing settings/ModuleUIStrings.js in build config | https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2476336

Change-Id: Ie2335e8943e8be3f8363a45d14c93f3b695222e4
Bug: 1136655
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2481510
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Christy Chen <chrche@microsoft.com>
 2020-10-22 16:18:20 +00:00
vidorteg 6d2775c5ef Modifying scripts for i18nString localization call 
Modifying some scripts that verify the shape of localization calls
to work with the i18nString shorthand:

const i18nString = i18.i18n.getLocalizedString.bind(undefined, str_);

Bug: 1136655
Change-Id: I09a961136dd89e8af11ab33f413f315e61184078
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2469903
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Christy Chen <chrche@microsoft.com>
 2020-10-14 21:12:22 +00:00
Christy Chen 5a23b94362 Fixing two localization presubmit issues 
1. Don't generate grdp strings if they are in ModuleUIString.js
2. Use path.basename instead of index slicing when getting the directory name for a filepath

Bug: 1136655
Change-Id: I828461a4be2dbeaecd4db76eeb13fce53871d16f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2461794
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Christy Chen <chrche@microsoft.com>
 2020-10-09 17:20:24 +00:00
vidorteg ca8fc9b475 Removing check_localizability.js verification 
The current behavior enforces that the second argument passed to all
i18n.getLocalizedString is part of UIStrings structure, this is not
possible to enforce in the current shape as a reference is also a valid
scenario

--------  e.g-----------

const title1 = UIStrings.title1;
const title2 = UIStrings.title2;

function render(title) { i18n.getLocalizedString(str, title) }

--------  end e.g-----------

Also minor fix in the naming convention of the file (localizationV2checks)

Change-Id: I9e7536850f7bbb73b2e27f5906343b3b1dbfd82d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2451369
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
 2020-10-07 16:46:15 +00:00