Commit Graph
13 Commits
Author SHA1 Message Date
Kateryna Prokopenko 7cf65bb57a Type all path and URL vars in ScriptSnippetFileSystem to Branded Types
Bug: 1299786
Change-Id: I52abcc9290cc9a4c55e3aabc6c056a60da54a20a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3484204
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
2022-03-22 12:17:59 +00:00
Kateryna Prokopenko ac21da4db6 Type path in createFile as EncodedPathString
Bug: 1253323
Change-Id: Icc520f383e032a8a6be8cbaffded2d2896ac4d37
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3470238
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
2022-03-14 13:04:15 +00:00
Kateryna Prokopenko 43b58939ab Remove casts to EncodedPathString from ScriptSnippetFileSystem
Bug: 1299786
Change-Id: I8b874211d44bc203391819a4653447a67b8c2fe1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3470236
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
2022-03-14 09:33:46 +00:00
Kateryna Prokopenko abbbc28fe8 Remove casts to UrlString from several files
Bug: 1253323
Change-Id: Id5ec0639de629e0b08c6e7cc8137b0ce5f5253fa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3468520
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
2022-03-07 15:54:30 +00:00
Kateryna Prokopenko 8458f0d859 Remove casts to UrlString from IsolatedFileSystem
Bug: 1253323
Change-Id: If6086cef3428d5388430a367ef29e6e289c5b697
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3420338
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
2022-02-16 08:03:01 +00:00
Kateryna Prokopenko 3671fa6556 Fix path encodings
Bug: 1253323
Change-Id: Iefa0517bb39d2f000f5abf1f184887325702c52a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3344916
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
2022-02-14 08:10:56 +00:00
Kateryna Prokopenko cae13bb94a Remove all DevToolsPath types as some of them might be incorrect
In order to avoid additional difficulties when typing paths in DevTools
discard the previous (possibly incorrect).

Bug: 1253323
Change-Id: Id4076900a44e9f06440cbfb4b99bed90f1ceb1f0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3297832
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
2021-11-24 08:51:25 +00:00
Kateryna Prokopenko 6cb5aade43 Remove casts to UrlString from PlatformFileSystem
Bug: 1253323
Change-Id: Ib1ba79a859cee257a1b88069506f0ec0745e3cd1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3220642
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-14 12:31:17 +00:00
Jan Scheffler 57bf6a47a6 [Underscore Migration] Migrate panels/snippets
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

R=tvanderlippe@chromium.org

Bug:chromium:1207342
Change-Id: I79f33458a855c726f672068da81a20fce06f9e71
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3079533
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-08-09 12:25:49 +00:00
Sigurd Schneider 6cf1fdb535 Use options bag for ConsoleMessage constructor
Depends on test update CLs:
Disable tests in https://crrev.com/c/2988019
Update and reenable tests: https://crrev.com/c/2988020

Bug: chromium:1213393
Change-Id: I12478e4906e31226e2fc31696f8f03c01dd02a9b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987959
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2021-06-25 10:11:17 +00:00
Tim van der Lippe 229a54f7ea Import protocol types in panels/
R=jacktfranklin@chromium.org

Bug: 1208357
Change-Id: I465ecb09674ecceed40effe5381f17cbf04f9c72
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897517
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-05-17 10:43:32 +00:00
Tim van der Lippe eb876c6b1e Generate const enums in protocol.d.ts
Some files currently rely on the Protocol to be available on the
global scope. However, the Protocol definitions are defined in
a .d.ts file, which isn't available on runtime. Therefore,
attempting to import Protocol with non-type imports would retain
the imports in the `.js` files and break on runtime.

Since the only usages of the Protocol on runtime are the enums,
we can make them const, such that they get inlined as intended.
Then, `import * as` will work again, as the enums are inlined and
the import is removed from the `.js` file.

DISABLE_THIRD_PARTY_CHECK=Protocol update
R=jacktfranklin@chromium.org

Bug: 1208357
Change-Id: I749e57c9f51596866b61cab686c59f00bc8a8eb4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897277
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-05-14 15:51:00 +00:00
Tim van der Lippe eb75111549 Move snippets to panels/snippets
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I5c9c27398f331fb853eabfe6c278ddc4cc306034
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831971
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-19 12:49:39 +00:00