Commit Graph
7 Commits
Author SHA1 Message Date
Jack Franklin d460818725 Fix focus border cut off on element breadcrumbs
Before: https://imgur.com/djJHSb2
After: https://imgur.com/xTPNk75

Bug: 1066415
Change-Id: I3ac9eebfd45eacf90c178321ec8fdffb304eda4a
Fixed: 1129385
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2429946
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
2020-09-25 09:27:06 +00:00
Andres Olivares b850e12b0b Fix bug causing 'Computed frames' move slightly towards right side when checking/unchecking the 'Show all' check box.
The disappearance of the scrollbar of the styles pane caused the component to offset to the right. The 'overflow'property in the style of the component was set to 'scroll' so the bar will always show.

Fixed: 1112681
Change-Id: Ic84c4deaff914be6c68b2b4ce1ce223c67352f2f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2367354
Auto-Submit: Andres Olivares <andoli@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-08-27 05:22:05 +00:00
Patrick Brosset d996f5589a Allow horizontal scrolling in the Elements tree
The Elements tree does not scroll horizontally for now.
In most cases, it's good, because some nodes tend to be quite long, and
it's better to have them wrap on multiple lines so you can still see
everything at once without constantly scrolling left and right (which,
depending on the mouse/trackpad device you use, can be difficult).

However, we often run in cases where the lack of horizontal scrollbar is
a problem:
- long attribute values, such as urls wrap in places where it doesn't
make much sense and are harder to read
- more importantly: some web pages have deeply nested DOM trees, so much
that after a point, the nodes have so much left indentation that they
have no space left to the right to display any content. So you can be in
situations where a node is displayed 1 character at a time, over many
lines. Or even worse, certain nodes are not visible anymore.

This change removes the overflow-x:hidden CSS property so the Elements
panel can scroll if needed.
The change still retains the nodes' abilities to wrap (using
word-break: normal; make them wrap at word boundaries only) so in a lot
of cases, nothing will change for users.
However, this also introduces a minimum width for every node in the tree
which will force the horizontal scrollbar to appear after a point, and
will make sure each node has at least that much horizontal space to
display content.

Before/after example screenshot: https://imgur.com/MPO04CU.jpg

Bug: 880265
Change-Id: Ia3bfc1476868ce31ab8ac2f0d8adc59c61894d90
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2366972
Reviewed-by: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
2020-08-24 20:04:26 +00:00
Sigurd Schneider 4c05d754a0 Fix stylelint-config-standard issues in elements/elementsPanel.css
R=mathias@chromium.org

Bug: chromium:1083142
Change-Id: If62e8ecc3c3a181980851e8aae49dff7cb11edc1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2264122
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2020-06-24 15:14:19 +00:00
Mathias Bynens b0c1f4bce2 Fix stylelint-config-standard violations
Bug: chromium:1083142
Change-Id: I5ea4cc5d0f83e52856383ba37a47472e33eb19a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2204113
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
2020-05-15 17:05:27 +00:00
Joel Einbinder 89d7c6a99c DevTools: Prevent horizontal scrolling in computed style sidebar
Bug: 829244
Change-Id: Idc426e6f0963a30340569c2d2835266d325f290e
Reviewed-on: https://chromium-review.googlesource.com/1079719
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#567866}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bf750effb690148e74dfda76d2ce8fefdd0c8e44
2018-06-16 02:42:42 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2.
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00