zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-05 11:31:31 +08:00
Code Issues Packages Projects Releases Wiki Activity
23,653 Commits 43 Branches 79 Tags
902078271ed28fa858ffedabfb3628aa039fe160
Commit Graph
1580 Commits
Author SHA1 Message Date
Jack Franklin 4a23e068bd Add some types to AI Assistance script 
I was making them to aid my debugging as I was getting familiar with the
code, and thought we might as well land some to help others too.

Bug: 704639063
Change-Id: Ia4678cc136e6414438d19c7652fd9f5b390c0cae
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6085698
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-12-11 11:32:14 +00:00
Jayson Chen 2e999d1495 Add wicg scheduling API definition 
window.scheduler.postTask and .yield are originally not available in the devtools-frontend codebase. This CL added the type definition so Typescript recognizes the API

Bug: 383240467
Change-Id: I4a395aca4e3956ceaa08053dcded5017f0ed10b1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6081857
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Jayson Chen <jaysonchen@microsoft.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-12-10 20:09:10 +00:00
Adam Raine 61007ff654 [RPP Observations] Update definition of "field data" in translation contexts 
Bug: None
Change-Id: I6f3cf66452585df8d909ac3c38a5592638ebcb4c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6079049
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2024-12-10 15:56:53 +00:00
Alex Rudenko 786bd42909 [AI Assistance] Renames and refactorings 
Fixed: 380044548
Change-Id: I0c71417a8189a728ff10e9b6504a9887e3f26652
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6080811
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-12-10 11:47:32 +00:00
Alex Rudenko 789751e321 Revert "[cleanup] Remove dead code" 
This reverts commit 26bc275ce1.

Reason for revert: used in devtools-internal so breaks the roll

Original change's description:
> [cleanup] Remove dead code
>
> The infra now all uses `npm run lint` for linting.
> Moves a common function to the only place it's used.
>
> Bug: none
> Change-Id: Ibcf86daa95e33d8b313efe76a6173436769786d5
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6070376
> Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
> Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>

Bug: none
Change-Id: I090c1750ec1ada53df22c443253922162f41e271
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6072803
Reviewed-by: Simon Zünd <szuend@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-12-05 07:06:18 +00:00
Nikolay Vitkov 26bc275ce1 [cleanup] Remove dead code 
The infra now all uses `npm run lint` for linting.
Moves a common function to the only place it's used.

Bug: none
Change-Id: Ibcf86daa95e33d8b313efe76a6173436769786d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6070376
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2024-12-04 15:44:37 +00:00
Ergun Erdogmus a416dab924 [FreestylerEval] Use current_message for request input 
After changing the request shape we send, we needed to update
eval UI to use the new structure.

Bug: none
Change-Id: Ie19fa03d9ec521a36de18cfb1643c0b8166bf27e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6063637
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-12-03 16:19:43 +00:00
Nikolay Vitkov 8962d5956d Fix check_experiments.js import 
After the @typescript/eslint update their resolution does not include
CJS so the import fails. The files are still have CJS support
so import the file directly.

Bug: none
Change-Id: I84ad3164fc1046b616d99fe0c196f93f2523fcfd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6059977
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2024-11-29 15:53:12 +00:00
Liviu Rau bec18e2c02 Replace deprecated gsutil cli with gcloud storage 
Bug: 380123202
Change-Id: I4d957387c063b57b635f1e6f9ad36dd2304cca5f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6038616
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
 2024-11-21 12:28:54 +00:00
Alex Rudenko bf9bcbf328 A helper script to convert to tsv 
Bug: 379059135
Change-Id: I555f763d2123f1cb1b39fd3ae9468bb0f69613f1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6038154
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
 2024-11-21 12:27:51 +00:00
Alex Rudenko 16f5a6c244 [FreestylerEval] test using UI 
We now know that the hanging issue was due to code generated by the
LLM hanging and therefore the workaround to use a special event
was not actually helping.

Bug: 362730981
Change-Id: I4f70eae7aec05812922ba1035eb8a14bf831abfc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5832744
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-11-20 19:19:03 +00:00
Dirk Pranke a2674c024e Fix Python SyntaxWarning in //scripts/build/wasm-as.py. 
In Python 3.12, unrecognized escape character sequences in a string
produce a "SyntaxWarning" log message when the file is parsed. The
fix is (usually) to change the string from a regular string to a raw
string, by putting an "r" in front of the leading quote.

Bug: 376746798
Change-Id: Ie888a8de6ae42c4daae6fa5028134722634d70c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5981155
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
 2024-11-13 17:20:36 +00:00
Eric Leese 983e380a4e Remove documentation of fictional describe.skipOnPlatforms 
Bug: None
Change-Id: I1ce59f5aa9c3f99a7be0e6b4c114df5b6e7fe0ee
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6004728
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-11-08 11:23:16 +00:00
Simon Zünd abf0cd1847 [deps] Update rollup to 4.24.3 (and update plugins) 
Since we have the major version jump, we needed to update quite
a few things to make this work:

  1. rollup4 ships with native binaries. We can't check them into
     our node_modules for all platforms. Luckily they also ship a
     a wasm version. This requires us to adjust the 'binary' path
     to `node_modules/@rollup/wasm-node/dist/bin/rollup` instead.

  2. rollup4 is more strict when it comes to ES modules vs
     CommonJS. We adjust this by renaming the rollup config files.

  3. Some plugins got deprecated so we had to replace them with
     the newer versions (source maps and terser).

Bug: None
Change-Id: If13d590c8185db6ad85b3992d0a869111909dc8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5999255
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-11-07 05:25:54 +00:00
Nikolay Vitkov cd5440fbdc [lint] Fix Stylelint not running 
Node syncSpawn can be promisified, and never runs the following
scripts, but it somehow closes the process afterwards.
Marking no presubmit as it fails on windows if you change lint rules

No-Presubmit: true
Bug: none
Change-Id: I08fdc3174fe542a5f824239b085d3433e5a24573
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5999261
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2024-11-06 15:43:19 +00:00
Liviu Rau 1c8dc082a7 Update builder name prefix for screenshot collectors 
Bug: 376446538
Change-Id: I64d31b001f74e74950bdd0bfc5e4be72e7d5a83d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5986493
Auto-Submit: Liviu Rau <liviurau@google.com>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alexander Schulze <alexschulze@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2024-11-04 11:24:16 +00:00
Simon Zünd 235aa05d64 [build] Fix esbuild bundling on windows 
R=kprokopenko@chromium.org

Bug: None
Change-Id: I19a809628072e94d96a35d04ec8615412b5b68ba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5961818
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-10-24 09:52:50 +00:00
Benedikt Meurer 0d4dbaeca9 [lint] Read lit-analyzer options from toplevel tsconfig.json. 
This way the config is in a central place and can be reused for
ts-lit-plugin.

Bug: 375149136
Change-Id: Ic3805b059b5c9b0d103a152e1ff36b3c9c5245b6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5953717
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2024-10-23 14:10:30 +00:00
Benedikt Meurer a75ec1d5d6 [cleanup] Remove rules/lit_html_data_as_type ESLint rule. 
Bug: 375114000
Change-Id: I73e1f7b44733cbd98ad4565dc8e68a88596a3e0e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5953150
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2024-10-23 12:23:29 +00:00
Jack Franklin dd7b7212cf Lint itScreenshot.skip like we lint other skip calls 
Fixed: 373791684
Change-Id: If9729360cf7260b9cbf068b9cfa5f6876a60cada
No-Presubmit: True
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5933853
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2024-10-16 10:09:51 +00:00
Nikolay Vitkov 60a23c771c [Lint] Fix issue with window 
Windows max line argument is around 8000, if you pass that the command
will fail, we need to split the LitAnalyzer files when we spawn it.

No-Presubmit: true
Bug: none
Change-Id: I68dd71228b02a8ae01555b23a229f5fcc69b2a11
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5923563
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2024-10-15 11:11:02 +00:00
Danil Somsikov 6806877859 Use type-only import where possible. 
Not only this is shorter, it also allows having a side-effect import in addition to the type-only
import and is properly understood by lit-analyzer.

No-Presubmit: true
Bug: 370734442
Change-Id: I32f0a6198e8de8175201d8ce576a63a9ce25806f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5921081
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2024-10-11 20:29:33 +00:00
Joshua Thomas e2625e34dc Fix node path for arm macs 
Bug: 370734442
Change-Id: Ia3a0f63970e302a735b507467e843846a2159f98
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5920518
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Shuran Huang <shuuran@chromium.org>
Commit-Queue: Joshua Thomas <masnoble@chromium.org>
 2024-10-10 17:33:29 +00:00
Nikolay Vitkov a4e79c12f1 Add fixer for assert equal rule 
We currently only report an error, but we can auto fix in the
general use cases where we can deduce the expected type.

No-Presubmit: true
Bug: none
Change-Id: Icb0b8857664f94da6a2f60cbf1862e788e7a4d9c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5917832
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-10-10 13:19:02 +00:00
Danil Somsikov 29e865259c Report lit-analyzer status correctly so that it can break presubmit 
No-Presubmit: true
Bug: none
Change-Id: I1d360f85a3551e6d9d28030007e502d5ce204d83
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5920706
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-10-10 10:21:05 +00:00
Danil Somsikov 868ff924c5 Lint rule enforcing the use of unqalified html template tag. 
lit-analyzer only inspects html`...` not LitHtml.html`...`

No-Presubmit: true
Bug: 370734442
Change-Id: I2ea66f5b0847ce9f04880389fa0197d57aabb0b7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5921258
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-10-10 05:40:41 +00:00
Alex Rudenko c8ad1e5573 [AutoFreestyler] Basic side-by-side view for eval 
Two column layout can be improved but it would require more
changes to how rendering works.

Bug: none
Change-Id: Iccceb1f53d406dcac767e2599b5d39da3c4b6750
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5920235
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-10-09 14:36:30 +00:00
Jack Franklin b055020953 Fix use_theme_colors check with outline properties 
Fixed: 371989111
Change-Id: Ib05081d71f93fa4ebb7fd787b6067ac30154a479
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5912682
Commit-Queue: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2024-10-08 16:53:37 +00:00
Danil Somsikov d74dc865b3 Remove check_component_naming and ban_literal_devtools_component_tag_names eslint rules. 
These are superceeded by the lit-analyzer

No-Presubmit: true
Bug: 301364727
Change-Id: If14f928e9bff3fe5d3cdfe9b7b94adc2887aa43c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5915494
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2024-10-08 08:40:20 +00:00
Danil Somsikov 058b9d879d Add lit-analyzer and run it as a part of lint check 
Bug: 370734442
No-Presubmit: true
Change-Id: I7021b801e5bacd4ed33643651a53b8db20ccf8b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5898986
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-10-07 12:41:05 +00:00
Danil Somsikov dc5df3fd69 Remove custom_element_definitions_location lint rule. 
It is hard to justify this requiement in the light of UI engineering
approach we are taking.

Bug: 301364727
Change-Id: I9f8f42255aab5dd41858e5840e048e47719f8520
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5899035
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2024-10-01 16:29:08 +00:00
Nikolay Vitkov 0ceb32a42f Fix lint rule for multiline props 
In some cases the formatter won't complain about the multiline cases,
but this rule won't pick it up correctly erroring as the `.exec`
returns `null`, fixed with a check.
Also update the RegEx to support multiline CSS and parse them
accordingly.

Bug: none
Change-Id: Ie961e66fce1ff517605d98a14c71086612e61692
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5891590
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2024-09-26 08:54:41 +00:00
Nikolay Vitkov 2709fa7447 [Freestyler] Rename to AI assistance 
Update strings to match new name

Bug: 369535878
Change-Id: Id331ad023eced745d2ae8ef9b09e807e12e31779
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5890171
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2024-09-25 17:53:57 +00:00
Jack Franklin df21499a0d Add default-import-name rule to eslint 
And enable it; we are using this to enforce the name used when the
TraceEngine is imported. The rule is configurable so we can extend it to
check more instances if required.

Bug: 368562239
Change-Id: Ic9b61d981ea32b4549853cdfee78c6e53e9443c6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5882693
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2024-09-23 19:03:04 +00:00
Jack Franklin 2d72d76e3a ESLint: fix formatting of eslint files 
Applies the `quote-props` rule and unignores the front_end/.eslintrc.js
file from ESLint so we consistently lint them all.

Bug: none
Change-Id: I65343550386c762467f41077b1d4dff869dae39d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5882053
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2024-09-23 11:47:40 +00:00
Philip Pfaffe a9900b6f46 [testing] Support running inside of a chromium checkout on mac/win 
Fix the lookup path for the chromium binary

Drive-by: Also check if there's a build.ninja inside the target
directory.

Bug: none
Change-Id: Ib97e278e75892e7e4f67e58996307f131426a26b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5872494
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
 2024-09-19 11:13:16 +00:00
Ergun Erdogmus 3a9b57fa14 [FreestylerEval] Export evaluations as CSV 
Bug: none
Change-Id: I4765f5b77cb099107d38a1053fa1f78ae37e8399
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5865670
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-16 13:48:01 +00:00
Connor Clark 2b55515d9d Add some additional help to snapshot documentation 
Bug: None
Change-Id: I65d0b95e7de7c70b17523830a7eff8c1245d583d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5846631
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-09-10 09:11:47 +00:00
Paul Irish 9657a01fb6 [eslint] enable object-shorthand, no-useless-rename 
Bug: none
Change-Id: I055b1743d105e2e3f5b95e150dbf687531317d57
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5838137
Auto-Submit: Paul Irish <paulirish@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-09-05 15:44:34 +00:00
Alex Rudenko cb4b9688d4 Remove coverage 
Infra change: https://chromium-review.googlesource.com/c/chromium/tools/build/+/5833493

Bug: 364237269
Change-Id: Iebc847a3a3644b5538771b94128943da588910a7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5830445
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-05 11:38:42 +00:00
Benedikt Meurer 67b69bf002 [cleanup] Remove "Highlight important DOM properties in the Object Properties viewer" experiment. 
This feature never made it past the experiment stage and while we believe
that it's beneficial to highlight important DOM properties, we aren't
convinced that this approach is the right one. Since we have no capacity
or intention to work on this experiment, we are removing the code now.

Doc: http://go/pinned-properties
Bug: 40267030, 40840064
Change-Id: Ib2d0f287834ca9ee87d957bd64f77a450c322f46
Fixed: 315126594
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5836838
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Victor Porof <victorporof@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2024-09-04 14:40:11 +00:00
Nikolay Vitkov 47310242ac [Cleanup] Enable EsLint quote-props 
Enable a EsLint rule to enforce code-style

Bug: none
Change-Id: I4fa6d09a744999dc2967fe989a2339423bb78c86
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5833497
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2024-09-04 11:57:11 +00:00
Alex Rudenko b35651707c [FreestylerEval] fix issue with multiline inputs 
Join with space instead of newline. Sending
a newline will result in immediate form submission.

Bug: 362730981
Change-Id: I2f82fcd737efbab2ec963e93f15255b52a1b915b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5829216
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-09-03 11:17:14 +00:00
Jack Franklin 0560bc9af5 Remove clang-format line from generated CSS 
A leftover from when we thought clang-format was incorrectly formatting
this file, which we now know to not be the case.

Bug: none
Change-Id: Ieefa6eea00c64f930727e1cc8dfd669f629dd6e9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5830499
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2024-09-03 11:16:05 +00:00
Alex Rudenko 4d982f5fa2 [FreestylerEval] Support shadow roots 
Bug: 362730981
Change-Id: I7c8142f9a430951657c2843a28ea4673b43db019
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5829407
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-09-03 09:40:01 +00:00
Ergun Erdogmus 5f96b3cd26 [FreestylerEval] Sort examples in the UI 
Drive-by: Remove "Fix this issue" default query and add a flag to control it

Bug: 362730981
Change-Id: I26ea3bd0dba746d8559e8c9c38f8e987c163d5c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5831211
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-03 05:38:23 +00:00
Jack Franklin 2f408ac801 Roll browser-protocol 
This roll requires a manual review. See http://go/reviewed-rolls for guidance.

In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.

Roll created at https://cr-buildbucket.appspot.com/build/8737908188620784401

R=devtools-waterfall-sheriff-onduty@rotations.google.com

This CL also updates ESLint to disable formatting the Generated CSS
properties file; this is causing issues on Windows PRESUBMIT where
ESLint formatting fails for currently unknown reasons. Whilst we
investigate this disabling of ESLint unblocks us landing
browser-protocol rolls.

Bug: none
Change-Id: I79c0166add6d8f0748df54e979e76ce32db04e51
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5829947
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-09-03 04:32:34 +00:00
Ergun Erdogmus da928f8049 [FreestylerEval] Format errors better with cause 
Bug: 362730981
Change-Id: I899c8e764648f182bdb639544422fb77b90cd695
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5831428
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-09-02 13:09:49 +00:00
Ergun Erdogmus fb908db79e [FreestylerEval] Fix example change through selector 
Bug: 362730981
Change-Id: If4066c118a2f8035a5759e0c432ff5bfbb807d60
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5831424
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-02 13:04:46 +00:00
Ergun Erdogmus 2eb0b6f300 [FreestylerEval] Fix arrow navigation not workign correctly in eval tool 
Bug: 362730981
Change-Id: If5ed13a33fce9cd106664e9355792babf3ff9188
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5828829
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-02 10:56:15 +00:00