zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-13 01:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity
3,193 Commits 45 Branches 79 Tags
aa800780e6563cfef4b076c8015bceed4a8945ee
Commit Graph
51 Commits
Author SHA1 Message Date
Philip Pfaffe a63b9e9d60 Land symbol server backend 
Bug: chromium:1013513
Change-Id: I9dee892cc591081c51ed2a094dcfef63e4386c48
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2157027
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2020-04-30 17:56:46 +00:00
Mathias Bynens 8555df09c4 Make scripts/deps/*.py executable 
This patch makes `scripts/deps/*.py` executable so that they can be
invoked directly without the need to explicitly invoke Python.

TBR=mathias@chromium.org,changhaohan@chromium.org,alexrudenko@chromium.org

No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165756
Change-Id: Ifeda6045b366a90bae5be1d43373e512e8c22197
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165796
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-04-27 14:43:36 +00:00
Mathias Bynens e231df478c Revert "Roll deps" 
This reverts commit 99d87e940b.

Reason for revert: https://ci.chromium.org/p/devtools-frontend/builders/ci/Stand-alone%20Linux/1355?

Original change's description:
> Roll deps
> 
> This patch includes some manual changes to the MediaModel, in order
> to support the new playerMessagesLogged and playerErrorsRaised events
> which are added in the roll.
> 
> The patch also includes the result of:
> 
>     scripts/deps/roll_deps.py $CHROMIUM_SRC_DIR $DEVTOOLS_FRONTEND_DIR
> 
> As a drive-by, this patch also makes `scripts/deps/*.py` executable so
> that they can be invoked directly without the need to explicitly invoke
> Python.
> 
> DISABLE_THIRD_PARTY_CHECK=see above
> 
> No-Presubmit: true
> Bug: chromium:1075437
> Change-Id: I794006f5a2077c8929f7d28bdd3f7b308603b6d9
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165756
> Commit-Queue: Mathias Bynens <mathias@chromium.org>
> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>

TBR=mathias@chromium.org,changhaohan@chromium.org,alexrudenko@chromium.org

Change-Id: If8c4886b61ef1200bdcd2e93604f7d67c57235ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1075437
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2167397
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-04-27 11:48:48 +00:00
Mathias Bynens 99d87e940b Roll deps 
This patch includes some manual changes to the MediaModel, in order
to support the new playerMessagesLogged and playerErrorsRaised events
which are added in the roll.

The patch also includes the result of:

    scripts/deps/roll_deps.py $CHROMIUM_SRC_DIR $DEVTOOLS_FRONTEND_DIR

As a drive-by, this patch also makes `scripts/deps/*.py` executable so
that they can be invoked directly without the need to explicitly invoke
Python.

DISABLE_THIRD_PARTY_CHECK=see above

No-Presubmit: true
Bug: chromium:1075437
Change-Id: I794006f5a2077c8929f7d28bdd3f7b308603b6d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165756
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-04-27 11:13:45 +00:00
Benedikt Meurer 3244d968e1 [CodeMirror] roll CodeMirror to 5.53.2 
Also fix instructions and roll_codemirror.py script, and add the
new `wast.js` web mode for WebAssembly disassembly (which is going
to be hooked up in a follow up CL).

Bug: chromium:1042721
Change-Id: I2f14934b48528439b707538a64dfff4c2ac846e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2159505
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2020-04-23 10:11:09 +00:00
Tim van der Lippe ef991621e0 Update Karma to 5.0.1 
The breaking changes listed in
https://github.com/karma-runner/karma/releases/tag/v5.0.0 do not
apply to us.

This should also include support for Edgium per
https://github.com/karma-runner/karma/pull/3440

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Update karma

Bug: 1068145
Change-Id: I7567b2db14dbf59aaf9c091220157bf55d155810
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2144050
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-15 08:03:17 +00:00
Tim van der Lippe dfd18c4e75 Remove istanbul-diff from node_modules 
The package is unused at the moment. It was originally added in
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2024871
to enable karma-coverage support. However, istanbul-diff itself
is not required for that process, as we still generate the
karma-coverage report without it.

R=liviurau@chromium.org
DISABLE_THIRD_PARTY_CHECK=Remove istanbul-diff

Bug: 1068145
Change-Id: I38df9ebdfeb5232f013ea45b4a596239bfd63d7b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2137391
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-14 11:21:15 +00:00
Tim van der Lippe c27927c22e Remove esprima 
Esprima is an older parser that does not support modern JavaScript
features. Moreover, we are no longer this parser in either the
ESLint pipeline nor the localization pipeline. Therefore, we can
remove our mirror on GitHub and delete it from node_modules.

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Remove esprima

Change-Id: I372b66c973424752bcd487954504c20b2282d0d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2140940
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-09 11:42:50 +00:00
Tim van der Lippe 597193051b Use karma-coverage in favor of community-maintained packages 
We were using community-maintained for integrating Istanbul with
Karma. However, there appears to be an official karma-coverage
plugin that is maintained by the Karma team. Moreover, the latest
changes on that plugin have removed dependencies on packages
that have reported vulnerabilities.

Therefore, use karma-coverage and remove the old community-maintained
packages to significantly reduce the amount of vulnerable NPM
packages.

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Remove old community-maintained packages

Bug: 1068145
Change-Id: Ie81c185155db6598fc0cd05d9405670a0568c1c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2140942
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-09 11:34:20 +00:00
Tim van der Lippe ccf7258887 Remove explicit dependency on handlebars 
We don't explicitly depend on handlebars in any of our scripts.
Instead, it is a sub-dependency for one of our dependencies.

To make sure we don't pin to an old version of Handlebars,
remove the explicit dependency for now.

R=jacktfranklin@chromium.org

Bug: 1068145
Change-Id: I63b7ef882b7a23c52e17a3e5bc5c1e22b5300e00
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2139975
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-08 08:16:15 +00:00
Tim van der Lippe 99190c9d94 Update Mocha to 7.1.1 
None of the breaking changes listed in
https://github.com/mochajs/mocha/releases/tag/v7.0.0
appear to be relevant for us.

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Update Mocha

Bug: 1068145
Change-Id: I4aec1e775595a0cfcfaa307a8aad7fc9abad22ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2137392
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-07 16:05:24 +00:00
Tim van der Lippe a4e6e7642d Update karma-typescript to 5.0.2 
There don't appear to be any relevant breaking changes in
https://github.com/monounity/karma-typescript/releases/tag/v5.0.0

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Update karma-typescript

Bug: 1068145
Change-Id: I780d8c572bbfc4253f3ff5e52a33c23733d4262a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2137388
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-07 14:47:34 +00:00
Tim van der Lippe fdbd42e2f8 Add eslint-import-plugin to node_modules 
Will be used to make sure no default exports are in DevTools.

The PRESUBMIT.py has been updated to skip running the formatting check
if node_modules files are affected, to workaround crbug.com/1068198.

DISABLE_THIRD_PARTY_CHECK=Add plugin to node_modules

Bug: 1068198
Change-Id: I04d4dc813daa01099f21d40edf47aaefcc0b045f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2135610
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-07 14:27:34 +00:00
Tim van der Lippe be2d34de7a Update Rollup to 2.3.3 
I have checked https://github.com/rollup/rollup/releases/tag/v2.0.0
and none of the breaking changes appear to be applicable to us.

I have manually confirmed that with this build on a production bundle
of DevTools, the output is okay and the build is working as intended.

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Update rollup

Bug: 1068145
Change-Id: I6a7ce6eaacb29fdfd1462642c976b81ce9c20e03
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2137385
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-06 13:56:18 +00:00
Tim van der Lippe c8f6ffd7c3 Update ESLint to 6.8.0 
Also update the PRESUBMIT linter configuration to make sure
it actually runs the linter when updating ESLint. Otherwise,
it would not properly do the full linter check.

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Update ESLint

Bug: 1068145
Change-Id: Ibf2de156366dc64c90ee1aced5537d2038e7a268
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2137384
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-06 13:52:18 +00:00
Tim van der Lippe 35cca41271 Allow manage_node_deps to run custom npm commands 
This allows us to execute the following:

npm run install-deps -- outdated

Which is equivalent to `npm outdated`, although it will run on the
actual node_modules output (that we can verify is unchanged).

Most of the npm commands require the private information to exist.
Therefore, if we run a custom command we first have to install with
`npm ci` to get the private information. Then we have to execute
the command, perform the cleanup and only after that finisht the
script. If we would bail out right after executing the custom command,
the private information would remain in the repository.

R=jacktfranklin@chromium.org

Fixed: 1068132
Change-Id: I50d3538a7115783dea19e1899faf17b1622f22ff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2137381
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-06 13:01:08 +00:00
Tim van der Lippe 1511efc125 Write .clang-format when updating node_modules 
This makes sure that whenever `npm run install-deps` is run, the
.clang-format file is also written (as we don't want clang-format
to format the node_modules folder).

R=aerotwist@chromium.org,jacktfranklin@chromium.org

Change-Id: I4d3d1f7241833f622575ae237792fbacdc6e02ea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2112366
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-03-20 12:11:07 +00:00
Tim van der Lippe 8fa65441f9 Add filesystem TypeScript types 
We use these types for all of our interactions with the local filesystem
API's and they don't normally ship with TypeScript library definitions.

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Add node_module

Bug: 1011811
Change-Id: I41ae8faf8cce289c86a6795ff76d8a10b5b3609d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2108760
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-18 17:58:39 +00:00
Jack Franklin 02d03f4ef2 Revert "Add tsickle as a node dep" 
This reverts commit 82dc0cef49.

Reason for revert: We don't think that we're going to use tsickle yet. Apologies - I made this CL a little hastily in hindsight.
Original change's description:
> Add tsickle as a node dep
> 
> We need it to convert from TypeScript to Closure to generate bridges
> whilst we migrate from Closure to TS.
> 
> DISABLE_THIRD_PARTY_CHECK=adding tsickle
> 
> Change-Id: I0bb28ecd6f5f6f131a59a02c8833aebd7ae92471
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107215
> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=tvanderlippe@chromium.org,jacktfranklin@chromium.org

Change-Id: Iee3631911650c03df4c18d07969b94b2d797cb5a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107530
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-03-18 11:15:28 +00:00
Jack Franklin 82dc0cef49 Add tsickle as a node dep 
We need it to convert from TypeScript to Closure to generate bridges
whilst we migrate from Closure to TS.

DISABLE_THIRD_PARTY_CHECK=adding tsickle

Change-Id: I0bb28ecd6f5f6f131a59a02c8833aebd7ae92471
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107215
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-17 11:40:19 +00:00
Tim van der Lippe 455069ae90 Add karma-sourcemap-loader to node_modules 
This will be used to load sourcemap files for TypeScript unittests.

R=aerotwist@chromium.org,jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Add node_module

Bug: 1061125
Change-Id: I13cfdbe078402b02563e7843595016a14bf93617
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2105436
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-16 16:40:16 +00:00
Jack Franklin 8297869795 Generate protocol.d.ts files in devtools-frontend 
We need this to be able to migrate parts of the frontend over to
TypeScript that use the Protocol.

We can generate this automatically via a script [1] from the
devtools-protocol repository on GitHub that we've pulled into our repo
and tweaked slightly.

The files are commited and can be easily re-generated should the PDL
files be updated.

DISABLE_THIRD_PARTY_CHECK=expected ts_library changes

[1]: https://github.com/ChromeDevTools/devtools-protocol/tree/master/scripts

Change-Id: I7115fdf109487a82edcaaf7f9984e8ec587d8b04
Bug: 1011811
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2096703
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-12 15:18:42 +00:00
Tim van der Lippe 835724b419 Add eslint-plugin-rulesdir to node_modules 
This plugin needs to be used to write our own custom ESLint plugins that
live in our repository. It replaces the `rulesdir` CLI option, as the
solution of putting it in `.eslintrc.js` is compatible with code editor
plugins.

I also discovered that we were incorrectly running clang-format on
`node_modules`, as I recently fixed the PRESUBMIT. To make sure that
doens't happen again, add a `.clang-format` that disables the formatting
in that folder.

DISABLE_THIRD_PARTY_CHECK=Add new node_module

Bug: 1060123
Change-Id: Ib2c0d23f499604deeea51cb06192bce3a7aa89af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2096449
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-10 17:20:54 +00:00
Jack Franklin 9d8c9bf34d Remove Sinon and associated deps 
We thought we'd use Sinon for spying but we've since moved away from
that as an approach.

DISABLE_THIRD_PARTY_CHECK=removing sinon, changes expected

Change-Id: I47f652b6ba6d08b0d3e53dfc2a1a8ee79535901d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2091447
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-03-06 14:33:13 +00:00
Tim van der Lippe b0d65f1b3c Extract protocol generation to separate script 
This allows us to add an npm command that does the same thing. This is
necessary to support the workflow of making changes in the pdl during
development.

You can regenerate the relevant protocol files with
`npm run generate-protocol-resources`. Note that the files it generates
are not formatted, but on presubmit it will both format and lint the
files to the correct notation. However, that should not impact the
workflow of making changes to the protocol files and testing their
behavior.

R=sigurds@chromium.org

Change-Id: I87c06183c8842d8643c4647cb1519850d75bd46d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2088093
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-03-05 12:21:12 +00:00
Liviu Rau d7c0713855 Exception cannot be converted to string 
Follow-up: https://crrev.com/c/2083313

Retry failure: https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket.appspot.com/8886854665998526416/+/steps/gclient_runhooks/0/stdout

Bug: chromium:1057642
Change-Id: I6f624eb3491734836e0d5bc3b028fb42ab3238ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2084572
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
 2020-03-03 12:26:53 +00:00
Liviu Rau 0e7703e1d8 Retry rmtree on windows 
The dryrun on patch 1 shows that after a retry we are actually able to download the chrome binary.
https://ci.chromium.org/p/devtools-frontend/builders/try/dtf_presubmit_win64/b8886927360883830992

https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket.appspot.com/8886927360883830992/+/steps/gclient_runhooks/0/stdout

The second patch improves the feedback, but we cannot see the initial problem manifesting anymore. We were dealing with a flaky bug anyway.


Bug: chromium:1057642
Change-Id: Icb74acf3ec742b6880a521edcde442cd984dd8d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2083313
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
 2020-03-03 10:40:03 +00:00
Tim van der Lippe 62e4435627 Update TypeScript to 3.8.3 
This includes the fix for
https://github.com/microsoft/TypeScript/issues/36989 which was blocking
the typescript-ification of `host`.

R=szuend@chromium.org
DISABLE_THIRD_PARTY_CHECK=Update typescript

Bug: 1011811
Change-Id: I637861d247ce4b696b0177e0bd8cd31243a47f98
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2083148
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-02 18:16:46 +00:00
Tim van der Lippe 00e15811f5 Update TypeScript to 3.8.1RC 
This fixes an issue where property assignments to static methods (please
don't ask me why we have them) would erroneously omit the static method
from the declaration file.

This is fixed in the latest version of TypeScript, most likely as part
of https://github.com/microsoft/TypeScript/issues/36270

DISABLE_THIRD_PARTY_CHECK=Updating TypeScript

Bug: 1011811
Change-Id: I2744ef44c040fdf001f6b0be9e64a164510e0fea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2064668
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-20 12:04:17 +00:00
Paul Lewis ed36b86660 Updates node_modules to remove resemblejs 
DISABLE_THIRD_PARTY_CHECK=Updating node_modules requires changing package.json and manage_node_deps.py

Change-Id: I08d05d8c92e501baeb0780ee06cea9b12887ee57
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2056474
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-02-14 12:21:53 +00:00
Jack Franklin 8b9aa2fca6 Prefer eslint-mocha for linting .only in tests 
DISABLE_THIRD_PARTY_CHECK=new npm module causes package-lock change

We can get rid of a custom script and use ESLint for these rules.

Additionally this means editors will highlight the issue in the editor.

Change-Id: I552b52e7f07b4e7430b3f685dbc3b5fad36ffff2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2052167
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-02-12 18:12:22 +00:00
Paul Lewis ea0d7566dc [tests] Adds resemblejs and rimraf to node_modules 
This CL adds deps that are necessary for comparing images in node, which
will be part of screenshot testing.

DISABLE_THIRD_PARTY_CHECK=Changes to deps require updating package-lock.json

Change-Id: I3b6266e7a8a6042cb14f1f6bfa40ca5a921592f2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2050781
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-02-12 13:59:13 +00:00
Paul Lewis dac9b5e74f Adds karma-sinon to DEPS 
R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Changes to deps require updating package-lock.json

Change-Id: Ic83355b2d873f0690d4c357bdd42a4833946f594
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2050776
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-02-12 09:54:22 +00:00
Jack Franklin 1a165367ec Add @types/sinon as a dependency. 
Such that we get nice TS checks when using Sinon in our unit tests.

DISABLE_THIRD_PARTY_CHECK=the package-lock has to change when we install
a new NPM module.

Change-Id: I99d72b526028c473993ff7be8632100046b92681
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2050234
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-02-11 15:07:41 +00:00
Jack Franklin b5bbcc0078 Add sinonjs@8.1.1 dependency 
This will be used to build out mocking in the devtools frontend unit tests.

DISABLE_THIRD_PARTY_CHECK=message doesn't apply with this change (checked with aerotwist@).

Change-Id: Ie623b4fb35677c8c4a5e52d5e75180346da6e3fd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2050225
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-11 14:49:21 +00:00
Tim van der Lippe 912cec0c68 Add istanbul-diff to node_modules 
DISABLE_THIRD_PARTY_CHECK=Adding istanbul-diff to node_modules

Bug: chromium:1044881
Change-Id: Ia80f499622132ce9b2c0890147fecdd4530886c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2024871
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-01-28 15:21:23 +00:00
Tim van der Lippe 0c42b5bb12 Add recast to node_modules/ 
It will be used in a check to enforce license headers

DISABLE_THIRD_PARTY_CHECK=Adds recast to node_modules

Change-Id: I822a368d9ba22058ac2586ea3638089a2f5b1d18
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016746
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-23 13:38:45 +00:00
Tim van der Lippe e4974ddc4c Remove whitespace at the end of the package.json lines 
json.dump appears to add extraneous spaces before newline characters. By
specifying the separators option, we can remove these whitespaces,
reducing the diff noise. Solution taken from
https://stackoverflow.com/questions/16311562/python-json-without-whitespaces

DISABLE_THIRD_PARTY_CHECK=Fix whitespace in node_modules

Change-Id: I26556e5053f19a9021ad41779319bdfe3f8c2b6c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2013154
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-01-22 15:17:25 +00:00
Paul Lewis 7b1e0f41ab Adds Puppeteer types 
DISABLE_THIRD_PARTY_CHECK=Updates the deps list as well as the node_modules

Change-Id: Ia9a6d26a89d85c0ca24253892ec3aa2858fe034a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2009108
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-20 14:02:00 +00:00
Tim van der Lippe bcf142a3e1 Update TypeScript to latest version 
DISABLE_THIRD_PARTY_CHECK=Updates the deps list as well as the node_modules

Bug: 1011811
Change-Id: I09c38caa2b60f8f291695a908a3363dd870f5625
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2009109
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-01-20 11:58:10 +00:00
Tim van der Lippe f86acf8203 Remove Puppeteer installation 
We can set the PUPPETEER_SKIP_CHROMIUM_DOWNLOAD environment variable to
not install a local Chromium installation. Update the preinstall script
to verify that this variable is set. If you want to update the deps, you
can now run `npm run install-deps` to get the update.

DISABLE_THIRD_PARTY_CHECK=Fixing node_modules

Change-Id: I6d77a77f343f8869a17434e7b83951b6380444d0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2003319
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-16 13:32:46 +00:00
Tim van der Lippe 984c7d7608 Add typescript-eslint to node_modules 
Bug: 1041811
Change-Id: Id9820054e67f8402a4a1220035d8789f7cff5a0b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1998769
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-14 12:34:56 +00:00
Paul Lewis e184c4c207 Adds license checker 
This CL adds license-checker to manage_node_deps.

Change-Id: Ia525e9c2380fc2654e9903ecc7fd4e94cdce1f9a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1944866
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-12-02 12:39:54 +00:00
Paul Lewis 66e1206c8b Updates manage_node_deps to install missing deps; adds yargs 
The `npm ci` call in the script will fail due to any mismatch between
the DEPS declared and those listed in the package-lock.json file.

This CL updates the script to install any missing deps by comparing the
list in package-lock.json with the DEPS, and adding any that are
missing.

Yargs is needed for the boot perf benchmark, so adding its DEP here
and will update the node_modules directly in a future CL.

Bug: 1027519
Change-Id: Ifbc69b242d0cfc4d79d23f756f267a5a2f45039f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1944861
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-12-02 12:09:24 +00:00
Paul Lewis d903909f9c Updates deps script; adds Puppeteer 
This is a prequisite for loading DevTools in hosted mode and track how
long it takes for the FE to boot up. This CL adds Puppeteer to the deps
as well as tidying the manage_node_deps script some.

Bug: 1027519
Change-Id: Ie5f3ef47f481972c721f7382f9b0ed99d287d07c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1939800
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2019-11-28 10:40:33 +00:00
Andrey Kosyakov fff69a79f9 Reland "Update roll & type check scripts with new browser_protocol.pdl location" 
This reverts commit db38f98828.

Reason for revert: re-landing as upstream change appears to stick this time.

Original change's description:
> Revert "Update roll & type check scripts with new browser_protocol.pdl location"
> 
> This reverts commit a4d8446198.
> 
> Reason for revert: Upstream change that this depends on got reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1935479
> 
> Original change's description:
> > Update roll & type check scripts with new browser_protocol.pdl location
> > 
> > This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1898538
> > to update the location of the browser_protocol.pdl.
> > 
> > NOPRESUBMIT=true
> > Bug: https://crbug.com/1018108
> > Change-Id: Id21b5bc65d6af472b55151a458beca34dabc6d1d
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1904098
> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> > Reviewed-by: Yang Guo <yangguo@chromium.org>
> 
> TBR=caseq@chromium.org,yangguo@chromium.org
> 
> Change-Id: I276ca14aa57ed6dcfd76946c8bee9ea580643b6b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: https://crbug.com/1018108
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1936211
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>

TBR=caseq@chromium.org,yangguo@chromium.org

Change-Id: Icb1d908317514f15a80fb8edc84974045309487e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://crbug.com/1018108
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1938351
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
 2019-11-27 01:32:58 +00:00
Yang Guo db38f98828 Revert "Update roll & type check scripts with new browser_protocol.pdl location" 
This reverts commit a4d8446198.

Reason for revert: Upstream change that this depends on got reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1935479

Original change's description:
> Update roll & type check scripts with new browser_protocol.pdl location
> 
> This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1898538
> to update the location of the browser_protocol.pdl.
> 
> NOPRESUBMIT=true
> Bug: https://crbug.com/1018108
> Change-Id: Id21b5bc65d6af472b55151a458beca34dabc6d1d
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1904098
> Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>

TBR=caseq@chromium.org,yangguo@chromium.org

Change-Id: I276ca14aa57ed6dcfd76946c8bee9ea580643b6b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://crbug.com/1018108
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1936211
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2019-11-26 09:37:09 +00:00
Andrey Kosyakov a4d8446198 Update roll & type check scripts with new browser_protocol.pdl location 
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1898538
to update the location of the browser_protocol.pdl.

NOPRESUBMIT=true
Bug: https://crbug.com/1018108
Change-Id: Id21b5bc65d6af472b55151a458beca34dabc6d1d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1904098
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2019-11-26 00:34:04 +00:00
Yang Guo 0802bf5001 Fix running unit tests on Win and Mac 
Change-Id: Ie87490a21cc0af5188d31a1a89c567895f925372
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1908568
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>
 2019-11-11 14:46:05 +00:00
Yang Guo 9117835a2a Move deps related scripts to scripts/deps 
Change-Id: I283d589c92a813daa484f5c7fe83ee16e285f275
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891416
Auto-Submit: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-11-04 11:53:25 +00:00