4 Commits

Include renames

Author	SHA1	Message	Date
vidorteg	6d2775c5ef	Modifying scripts for i18nString localization call ... Modifying some scripts that verify the shape of localization calls to work with the i18nString shorthand: const i18nString = i18.i18n.getLocalizedString.bind(undefined, str_); Bug: 1136655 Change-Id: I09a961136dd89e8af11ab33f413f315e61184078 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2469903 Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Christy Chen <chrche@microsoft.com>	2020-10-14 21:12:22 +00:00
vidorteg	ca8fc9b475	Removing check_localizability.js verification ... The current behavior enforces that the second argument passed to all i18n.getLocalizedString is part of UIStrings structure, this is not possible to enforce in the current shape as a reference is also a valid scenario -------- e.g----------- const title1 = UIStrings.title1; const title2 = UIStrings.title2; function render(title) { i18n.getLocalizedString(str, title) } -------- end e.g----------- Also minor fix in the naming convention of the file (localizationV2checks) Change-Id: I9e7536850f7bbb73b2e27f5906343b3b1dbfd82d Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2451369 Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Christy Chen <chrche@microsoft.com> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>	2020-10-07 16:46:15 +00:00
Christy Chen	5fc363ed10	[Loc] Presubmit#3: LocV2 Checking the shape of localization API calls ... Checking the shape of localization API calls: if the node is Common.i18n.getLocalizedString, 1. There should be at least two arguments 2. The first argument should be the string instance function 'str_', 3. The second argument should reference the UIStrings object like 'UIStrings.url' The code would look like: i18n.i18n.getLocalizedString(str_, UIStrings.url); Bug: 941561 Change-Id: I1336867b06dd727f5164e6b1d7ac7ae6ed6ea446 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2245769 Commit-Queue: Christy Chen <chrche@microsoft.com> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org>	2020-09-09 16:40:02 +00:00
Christy Chen	23909d8cfc	[Loc] Presubmit performance improvement ... The current Loc presubmit are doing two checks: check_localizable_resources and check_localizability (Details of what they are checking: https://docs.google.com/document/d/1L6TkT2-42MMQ72ZSBMFwUaq7M6mDgA2X0x8oHHKaV_U/edit#heading=h.w1no7qaa0mi0) This CL merge two checks into one single check. check_localizability are modified into a utils file, and check_localizable_resources will also run those localizability checks when the files are visited. By doing this, we avoid the extra call to node during presubmit, and all files and nodes will only be visited once. Also adding these fixes https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2370103 Fix: - Pass the fullpath for comparison.(itemPath) - Normalize comparison between paths - using native fs.promises instead of promisify (https://github.com/nodejs/node/pull/26581) Bug: 1116989 Change-Id: I054040d83a65b5f798a21c040096422e287bc799 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2381320 Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Christy Chen <chrche@microsoft.com>	2020-09-04 05:07:07 +00:00