Commit Graph
193 Commits
Author SHA1 Message Date
Randolf Jung 0849e8636c Update puppeteer to 20.1.2
Bug: none
Change-Id: Ic54abd3e326a08c473ee20245e62f84365036676
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4519845
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2023-05-10 13:31:14 +00:00
Randolf Jung 95337a1834 Update puppeteer to 19.11.1
Bug: none
Change-Id: I8cc107acb06ac82bb6c6b060c86a6346a09d464a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4475485
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
Auto-Submit: Randolf Jung <jrandolf@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2023-04-25 16:12:28 +00:00
Simon Zünd 1bd98ee250 [deps] Add 'rollup-plugin-sourcemaps' intended for release builds
We plan to enable source maps for release builds behind a GN flag. For
this to work rollup needs to consume the source maps already generated
by tsc and merge it with its own source map. Rollup can't do this
natively so this CL adds a plugin that can.

R=jacktfranklin@chromium.org

Bug: 1430396
Change-Id: Ibb38c7892326907431e54b7c7dbd7b912b59ccb9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4397707
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2023-04-04 13:31:33 +00:00
Randolf Jung b08370d389 Update puppeteer to 19.8.3
Bug: none
Change-Id: I415f90baf38a8b48751df16d6f7f374bcbab1865
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4394482
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
2023-04-03 09:36:19 +00:00
Randolf 554314669d Update puppeteer to 19.8.2
Bug: none
Change-Id: I96924a43c609487123c25470fde2fc2618d19e27
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4381385
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2023-03-30 06:02:42 +00:00
Simon Zünd 0cc29a70d1 [deps] Update @types/codemirror for tsc 5.0 compatibility
DISABLE_THIRD_PARTY_CHECK=We need to remove a @ts-expect-error in the
formatter

Bug: 1412307
Change-Id: Ic130c0db4f879ec4e53b5ea31ba034aa880779a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4358158
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
2023-03-22 06:31:16 +00:00
Simon Zünd d04cab149b [typescript] Update tsc to 5.0.2
DISABLE_THIRD_PARTY_CHECK=Requires some changes to make tsc happy
R=jacktfranklin@chromium.org

Fixed: 1412307
Change-Id: Iee6ff440fdb346defa901435f490009f44a7a142
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4352530
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2023-03-20 10:01:07 +00:00
Randolf b0fe9c160b Update puppeteer to 19.7.3
Bug: none
Change-Id: I7e8ef149b66c6376ee728df1ee4b7c8c14803a78
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4311823
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
2023-03-06 20:09:06 +00:00
Randolf 51ffdadc72 Update @puppeteer/replay to 2.9.0
Bug: none
Change-Id: I0372a04e8714f11338d7df7c2b2ce21b24f3048a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4226464
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Randolf Jung <jrandolf@chromium.org>
2023-02-07 04:50:44 +00:00
Randolf 3ec89ccf6b Add @puppeteer/replay to test dependencies
This PR adds @puppeteer/replay for dogfooding in replay E2E test.

Bug: 1411188
Change-Id: I4c65fce494df70c01d862e99c5f355d578ae0bfa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4206547
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2023-01-31 12:47:43 +00:00
Randolf cc8925401c Update puppeteer to 19.6.2
DISABLE_THIRD_PARTY_CHECK=Files need updating

Bug: 1410437
Change-Id: I510c33a2435e03a6d0bcc389b062741490161083
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4196856
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2023-01-28 00:27:27 +00:00
Simon Zünd 9e2c759bea Revert "Update puppeteer to v19.5.0"
This reverts commit 7f8017513a.

Reason for revert: Suspected to increase overall flakiness of our e2e suite. As a precaution we'll roll back and get the tree into a green state first.

Original change's description:
> Update `puppeteer` to v19.5.0
>
> DISABLE_THIRD_PARTY_CHECK=Need to patch files for update
>
> Bug: none
> Change-Id: I6bbde8b41ba99bfb797a03595a709d56d95cb04d
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4146170
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Randolf Jung <jrandolf@chromium.org>

Bug: none
Change-Id: Ic1fb9df3a160f553e62f1df2ade6e0ba523663c5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4172908
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2023-01-17 08:05:38 +00:00
Randolf 7f8017513a Update puppeteer to v19.5.0
DISABLE_THIRD_PARTY_CHECK=Need to patch files for update

Bug: none
Change-Id: I6bbde8b41ba99bfb797a03595a709d56d95cb04d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4146170
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
2023-01-16 21:08:51 +00:00
Jack Franklin fd72c071cc Enforce alignment of JSDoc comments
This CL adds the eslint-plugin-jsdoc plugin and enables just one rule,
`jsdoc/check-alignment`, which ensures that all the lines in a comment
are correctly aligned. For example:

```
/**
* foo
 * bar
*/
```

Would fail the check and be corrected to:

```
/**
 * foo
 * bar
 */
```

DISABLE_THIRD_PARTY_CHECK=deliberate install + use of
eslint-plugin-jsdoc node_module

Bug: none
Change-Id: I969983cd550653654a334ede3409b8c850467245
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4110906
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2022-12-21 12:30:47 +00:00
Jack Franklin a682d93584 Re-enable cssnano with "lite" preset
We had to disable CSSNano because it was causing broken fonts in release
builds (exact reason TBC). This CL installs the `cssnano-preset-lite`
package which applies only the following optimisations:

1. remove whitespace
2. remove empty rules (e.g. `div{}`).
3. remove comments

This should be far less risky and unlikely to cause unexpected
breakages.

DISABLE_THIRD_PARTY_CHECK=installed & used cssnano-preset-lite in the
same CL.

Bug: 1399763
Change-Id: I7fdd8b70b02a2c1a5e1c71a87c7ba145114e6e4b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4111923
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2022-12-16 12:38:30 +00:00
Jack Franklin b57f569bc2 Remove clean-css from manage_node_deps
Bug: 1399763
Change-Id: If226ddc2469fbd3c65e3b71e50003b99f08f8bf0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4092735
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2022-12-12 10:58:53 +00:00
Jack Franklin a5fd0a412d Add cssnano
The CSS minifier we currently use (clean-css) is not maintained and
lacks support for new CSS features. CSSNano is a replacement that
supports features we need (primarily container queries).

This CL only adds the relevant dependencies, and does not use it. I will
do that (and remove clean-css) in a follow-up.

Bug: 1399763
Change-Id: I899ecc4482164404dd5ac2fd13f92fb797978e29
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4092305
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
2022-12-09 12:08:23 +00:00
Jack Franklin 5ee20e32de Revert "Update ESBuild to 0.15.16"
This reverts commit 4b5ea512d3.

Reason for revert: causing failures on waterfall

Original change's description:
> Update ESBuild to 0.15.16
>
> A reland of my failed CL yesterday that caused issues; these were caused
> by me updating the DEPS version but not the node_modules version, which
> I have now updated in this CL.
>
> DISABLE_THIRD_PARTY_CHECK=purposeful update of ESBuild in two places.
>
> Bug: none
> Change-Id: I0a59296d7ad7a276e7f807d8154eb68a05d75451
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4061716
> Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
> Reviewed-by: Liviu Rau <liviurau@google.com>
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>

Bug: none
Change-Id: Ia26c87ec87a6160f268c2e7455621099b4c2784e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4067325
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2022-12-01 10:38:13 +00:00
Jack Franklin 4b5ea512d3 Update ESBuild to 0.15.16
A reland of my failed CL yesterday that caused issues; these were caused
by me updating the DEPS version but not the node_modules version, which
I have now updated in this CL.

DISABLE_THIRD_PARTY_CHECK=purposeful update of ESBuild in two places.

Bug: none
Change-Id: I0a59296d7ad7a276e7f807d8154eb68a05d75451
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4061716
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Liviu Rau <liviurau@google.com>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2022-12-01 09:52:59 +00:00
Brandon Walderman f64f77e749 Update node_modules to address security vulnerabilities
This change addresses 2 issues in uglify-js and socket.io-parser. See
reports below for details:
- https://www.mend.io/vulnerability-database/CVE-2022-37598
- https://nvd.nist.gov/vuln/detail/CVE-2022-2421

The socket.io-parser issue was addressed by running npm audit via the
following command:

`npm run install-deps audit fix --audit-level=critical`

Since audit didn't recognize the uglify-js issue, I updated uglify-js
to version 3.13.10 "manually" by adding an entry in
manage_node_deps.py. running install-deps to update package-lock.json
and then removing the entry from manage_node_deps.py.

Bug: None
Change-Id: I29238b14773a1b94b973886b0bb700f50e45cfa9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4061168
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Brandon Walderman <brwalder@microsoft.com>
2022-11-30 15:19:46 +00:00
Jack Franklin 2703ce56ba Upgrade @typescript-eslint packages
After upgrading TS to 4.9, we need to upgrade these packages so they can
parse the new TS features (such as the `satisfies` keyword).

Bug: 1392651
Change-Id: I85466727628e37b5b63c0f1e45484324fd05b8fb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4046522
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
2022-11-28 11:31:39 +00:00
Nancy Li 6403713b4d Update types
- Update `@types/node` packages to the latest version

Bug: none
Change-Id: I0caaa8c1a889e0ce593da6458563e305101e44af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4048320
Auto-Submit: Nancy Li <nancyly@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
2022-11-22 16:47:17 +00:00
Jack Franklin 2204d75049 Upgrade TS to 4.9
DISABLE_THIRD_PARTY_CHECK=TS upgrade.

Bug: 1392092
Change-Id: I3a5f352b12914ea6f908118fe6fda8ca3286cae5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4041404
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2022-11-21 15:14:06 +00:00
Chris Harrelson c6dd1d6e31 Remove remaining references to zoom-for-dsf.
Change-Id: Icf9bbb592e5e3ecceba0a6172db67464ed7457bf
Bug: 1110668
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3927915
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2022-09-29 20:05:51 +00:00
Jack Franklin 5445f5cf5f Update eslint node_module
Bug: none
Change-Id: I07591be5189d93085d49ace61ec030291af12b9f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3757654
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
2022-07-15 09:09:49 +00:00
Jack Franklin e7a4dd0e8a Upgrade ESLint+TypeScript node_modules
Bug: none
Change-Id: I1f99b10bc418d589cb11adba64ef2211bede5cd8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3757653
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
2022-07-13 11:51:00 +00:00
Jack Franklin 061f09c304 Upgrade TypeScript to 4.7.4
There are a couple of code changes for us that are relevant:

1.The accuracy of `lib.d.ts` (DOM definitions) has improved, so we have
  to update a type in `Button.ts`. This changes the type from
  `X|undefined` to `X|null` so this is very minor.

2. TypeScript got better at understanding conditionals that will always
  return `true`, and caught a case where we were doing:

  ```
  addEventListener(e => e.key === 'Enter' && Common.Revealer.reveal(...)
  && false)
  ```

  TS errored because the `reveal()` call is a promise and therefore will
  always return true, causing the entire expression to return the final
  `false`. Returning `false` from an event listener doesn't do anything,
  so I've removed it.

DISABLE_THIRD_PARTY_CHECK=required updates to land TS upgrade

Bug: none
Change-Id: I89ab2ad730d40308da173bd7788c17daf0b4a511
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3757623
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
2022-07-12 15:22:50 +00:00
Jack Franklin 8f8ec22bb3 Update karma to 6.4.0
No changes in the changelog
(https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) to
concern ourselves about, but one useful change is they upgraded the
log4js dependency which was spitting out console messages on each test
run. This is fixed with this version of Karma.

Bug: none
Change-Id: Ic49618cbda7a079cacb9813f5129692a83508a92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3745621
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
2022-07-05 10:46:37 +00:00
Victor Porof 6e09692deb Add @webref/idl dependency
Signed-off-by: Victor Porof <victorporof@chromium.org>
Bug: 1325812
Change-Id: I044170880d20ce0402062755787cccafd63c6a42
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3695370
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2022-06-13 10:23:45 +00:00
Randolf J 5cbcb68e9a Update puppeteer from 13.1.1 to 14.0.0
Bug: none
Change-Id: I157e7f5ddff43eb17fe371cc1437a636ad42cd4f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3641417
Commit-Queue: Randolf Jung <jrandolf@google.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2022-05-11 13:38:33 +00:00
Jack Franklin 3710bbf933 Upgrade eslint to 8.13.0
Bug: none
Change-Id: I438ea7b8e1c69e85939b1ed60578aa10fe87b821
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3598874
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2022-04-21 10:20:38 +00:00
Brandon Walderman 110d5929d1 Upgrade minimist to 1.2.6
This CL updates minimist to 1.2.6 to fix a critical security
vulnerability: https://nvd.nist.gov/vuln/detail/CVE-2021-44906

The fix was made by running:
`npm run install-deps audit fix --audit-level=critical`

Bug: none
Change-Id: I51103b525d9969e03000d55af86cebdabc7e0366
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3591079
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Brandon Walderman <brwalder@microsoft.com>
2022-04-20 06:33:45 +00:00
Simon Zünd 7a5852438e Update @typescript-eslint/plugin to 5.20.0
Our current @typescript-eslint version does not support TypeScript 4.6.
The update fixes that.

.eslintrc.js changes taken from https://crrev.com/c/3583292.

DISABLE_THIRD_PARTY_CHECK="Update contains a breaking change. Requires
updated config"

Bug: None
Change-Id: Id1d9f4f073f068ec95af6632a6d061adbee63cca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3592593
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2022-04-19 07:12:14 +00:00
Chris Harrelson bbbd73c0dd Clean up stale references to the now-deleted zoom-for-dsf flag
Change-Id: I38df98beb93f4c89365d85bd6fce598b5780bbd7
Bug: 1296791
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3579858
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
2022-04-18 19:01:20 +00:00
Jack Franklin 85ad87189b Upgrade eslint to 8.11
Bug: none
Change-Id: I27c4a453180acadf8935ab3f766751245bc2963b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3550273
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
2022-03-25 12:36:13 +00:00
Tim van der Lippe 30e0d8719a Update to TypeScript 4.6.2
There was only 1 fix required in InspectorView where `DisplayNames.of`
can also return `undefined`. Default to "English" (which I don't think
can ever happen, but alas) is the safest option. Other than that, no
problems with the upgrade 🎉

DISABLE_THIRD_PARTY_CHECK=TypeScript fix
R=szuend@chromium.org

Fixed: 1304218
Change-Id: Ie3c61858259b325f465062aec9dbaf34492a6e00
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3509848
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
2022-03-09 11:15:43 +00:00
Tim van der Lippe ece3c51ea2 Fix install deps script on Python 3
We ran into "RuntimeError: OrderedDict mutated during iteration" when
running this script. The problem was that we were mutating the
`pkg_data` while also iterating over it. Per
https://stackoverflow.com/a/52549728 the fix is to copy the package data
and pop from there.

R=jacktfranklin@chromium.org

Bug: 1304218
Change-Id: Ibaeb3f1e26ca346c794984311c082bb2f9e672c9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3509847
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2022-03-08 15:43:11 +00:00
Johan Bay 986acd0681 Add dependencies for js signature generation to top-level node_modules
This change makes it easier to run the script from directly
`roll_py.deps` without having to fetch the dependencies first. This also
makes it easier to track which dependencies our tooling have.

Change-Id: I1ce55074ee6a1fffa6f2a2f05a56d0d74b4aca90
Bug: 1255619
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3431346
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
2022-02-02 17:33:42 +00:00
Takuto Ikuta 2e08a7d1fc npm: add esbuild
This is extracted from https://crrev.com/c/3401984/30

Bug: 1278663
Change-Id: Icddd2af2ce157cc3877bcdc84653fb639f44c083
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3419383
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
2022-01-27 10:33:05 +00:00
Alex Rudenko b6331edcbd Update Puppeteer to v13.1.1
This CL contains the result of running `scripts/deps/manage_node_deps.py`
after changing the version of Puppeteer to v13.1.1.

Bug: none
Change-Id: I13154143f1247dc836079f25676775227385c0fe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3397928
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2022-01-18 13:32:16 +00:00
Tim van der Lippe b693eb34d5 Update remaining NPM dependencies
DISABLE_THIRD_PARTY_CHECK=NPM fix
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I41baa3294f88b7e4463fdc580c050932c5abe40e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372932
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
2022-01-07 14:42:53 +00:00
Tim van der Lippe 4cb097430f Update Stylelint and Postcss
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I961be18530d3ccbc4efed0c2cda9bd603b14e27b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372931
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
2022-01-07 14:36:30 +00:00
Tim van der Lippe 0150c2a641 Update build packages
Updates TypeScript and @types packages, as well as Rollup + terser.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Id8c4d360be486a703d51a937302c894de3a44fe9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372930
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
2022-01-07 14:33:50 +00:00
Tim van der Lippe 953e537f89 Update typescript-eslint
DISABLE_THIRD_PARTY_CHECK=ESLint fix
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I3c9830be1bf007e8443d1664d3979625d175248d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372929
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
2022-01-07 14:30:30 +00:00
Tim van der Lippe d3425b95d0 Update unit test NPM dependencies
Updates Karma, Mocha and Sinon.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Ia93cdafc646e4d3277e7ce869a7a8b5e66a13f0d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372928
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
2022-01-07 14:26:50 +00:00
Tim van der Lippe 0ceb465d1c Update ESLint and plugin packages
R=jacktfranklin@chromium.org

Bug: none
Change-Id: If1b2420ba6e1c100c3d6b2013815ff1a555ea987
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3369367
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2022-01-06 15:06:40 +00:00
Johan Bay 72ea2d5c4b Revert "Update NPM dependencies"
This reverts commit 192c3d4ee1.

Reason for revert: Puppeteer's types.d.ts is broken.
See crrev.com/c/3320453.

Original change's description:
> Update NPM dependencies
>
> Update puppeteer to version 12.0.1
>
> Change-Id: I8f2b0378458ba9867bf58c4c49c7202b8fc2a302
> Bug: none
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3317578
> Commit-Queue: Johan Bay <jobay@chromium.org>
> Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>

Bug: none
Change-Id: Ia73b4360e062e5cfb932ae4af96d28af32c79973
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3320462
Auto-Submit: Johan Bay <jobay@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
2021-12-08 11:13:19 +00:00
Johan Bay 192c3d4ee1 Update NPM dependencies
Update puppeteer to version 12.0.1

Change-Id: I8f2b0378458ba9867bf58c4c49c7202b8fc2a302
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3317578
Commit-Queue: Johan Bay <jobay@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
2021-12-07 09:32:13 +00:00
Tim van der Lippe c4035e3b0d Update TypeScript to 4.5.2
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I24da805038bd5d1d88dfad689f7a4ccf894af904
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3297838
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2021-11-24 12:24:53 +00:00
Tim van der Lippe c581bb8fad Update marked to 4.0.4
DISABLE_THIRD_PARTY_CHECK=Have to update both @types/marked and marked
R=szuend@chromium.org

Bug: none
Change-Id: I1030c1d11f329bbb4b28566921efff0fd439b6de
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3297844
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-11-24 06:28:40 +00:00