zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-30 01:43:36 +08:00
Code Issues Packages Projects Releases Wiki Activity
15,004 Commits 43 Branches 79 Tags
bf8e3bda617e1cc98c2daf33ef8868bbfd019521
Commit Graph
26 Commits
Author SHA1 Message Date
Jack Franklin fd72c071cc Enforce alignment of JSDoc comments 
This CL adds the eslint-plugin-jsdoc plugin and enables just one rule,
`jsdoc/check-alignment`, which ensures that all the lines in a comment
are correctly aligned. For example:

```
/**
* foo
 * bar
*/
```

Would fail the check and be corrected to:

```
/**
 * foo
 * bar
 */
```

DISABLE_THIRD_PARTY_CHECK=deliberate install + use of
eslint-plugin-jsdoc node_module

Bug: none
Change-Id: I969983cd550653654a334ede3409b8c850467245
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4110906
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-12-21 12:30:47 +00:00
Jack Franklin 3a80260722 Inline type imports in front_end 
This CL enables the `inline_type_imports` rule for devtools-frontend,
and is the result of running the auto-fixer to update all imports
accordingly.

Bug: 1319340
Change-Id: I303256476fd4e94f4505bbf4355c0070ac101aa9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3752799
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-07-13 09:26:00 +00:00
Kateryna Prokopenko 684d26dccd Type all path and URL variables in models/persistence to Branded Types 
Bug: 1299776
Change-Id: I7fa3cc202a2d230e6fbde6c0472ab6750012fa49
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3542251
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-03-28 12:00:19 +00:00
Kateryna Prokopenko 639a9de9d1 Type all URL and path variables in UISourceCode to Branded Types 
Bug: 1299780
Change-Id: I133ae77524d058cddcecb220fec1f7bd52116183
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3484202
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-03-22 11:27:28 +00:00
Kateryna Prokopenko ac21da4db6 Type path in createFile as EncodedPathString 
Bug: 1253323
Change-Id: Icc520f383e032a8a6be8cbaffded2d2896ac4d37
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3470238
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-03-14 13:04:15 +00:00
Kateryna Prokopenko 43b58939ab Remove casts to EncodedPathString from ScriptSnippetFileSystem 
Bug: 1299786
Change-Id: I8b874211d44bc203391819a4653447a67b8c2fe1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3470236
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-03-14 09:33:46 +00:00
Kateryna Prokopenko d2d0313dfb Remove some casts to UrlString and move some up the call stack 
Bug: 1253323
Change-Id: I7a6d5eb0c67436814c434538df73397c89d2341d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3467974
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-02-17 08:25:14 +00:00
Kateryna Prokopenko 8458f0d859 Remove casts to UrlString from IsolatedFileSystem 
Bug: 1253323
Change-Id: If6086cef3428d5388430a367ef29e6e289c5b697
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3420338
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-02-16 08:03:01 +00:00
Kateryna Prokopenko 3671fa6556 Fix path encodings 
Bug: 1253323
Change-Id: Iefa0517bb39d2f000f5abf1f184887325702c52a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3344916
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-02-14 08:10:56 +00:00
Mathias Bynens 46ea9672dc Clean up redundant Promise.resolve() in IsolatedFileSystem 
Bug: chromium:1161501
Change-Id: Ic699f43498f2b8244b48f15fc598772c931ca544
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3428449
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Randolf Jung <jrandolf@chromium.org>
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
 2022-02-01 10:38:30 +00:00
Kateryna Prokopenko 3c05b39ed1 Add special character encoding and decoding to conversions 
between RawPathString and UrlString

Bug: 1253323
Change-Id: Ibb9184ed098067cea7369b04984a7a02e305b919
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3344913
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3412773
 2022-01-25 11:27:21 +00:00
Alex Rudenko 0177fa7791 Revert "Add special character encoding and decoding to conversions" 
This reverts commit a89353f5ce.

Reason for revert: speculative revert due to roll failures https://chromium-review.googlesource.com/c/chromium/src/+/3398829

Original change's description:
> Add special character encoding and decoding to conversions
> between RawPathString and UrlString
>
> Bug: 1253323
> Change-Id: I6a774eb7129189a8c71b42c18d0a4d28e01d62e3
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3344913
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>

Bug: 1253323
Change-Id: I4781755fc6d757277c5f6de4ef3998ca5cd13724
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3398899
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Owners-Override: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Nancy Li <nancyly@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2022-01-18 18:30:26 +00:00
Kateryna Prokopenko a89353f5ce Add special character encoding and decoding to conversions 
between RawPathString and UrlString

Bug: 1253323
Change-Id: I6a774eb7129189a8c71b42c18d0a4d28e01d62e3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3344913
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-01-18 12:38:55 +00:00
Tim van der Lippe 2d9a95ce7b Suppress all existing promise races 
To suppress the races, we mark these invocations with `void` per
the instructions of `no-floating-promises`. This explicitly marks
these statements as side-effect promises.

Engineers can later analyze these void statements and determine
whether the promise races are intentional or accidental.

R=jacktfranklin@chromium.org

Bug: 1239617
Change-Id: I6b7a24cf21029d6ff73b112b3e8255ebab8c60ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3366467
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-04 16:08:08 +00:00
Kateryna Prokopenko 5404c44e77 Remove casts to RawPathString from IsolatedFileSystem 
Bug: 1253323
Change-Id: I29cb4699b202f5f5c162a8da057c5e457d71cb27
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3297840
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-24 09:06:44 +00:00
Kateryna Prokopenko cae13bb94a Remove all DevToolsPath types as some of them might be incorrect 
In order to avoid additional difficulties when typing paths in DevTools
discard the previous (possibly incorrect).

Bug: 1253323
Change-Id: Id4076900a44e9f06440cbfb4b99bed90f1ceb1f0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3297832
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2021-11-24 08:51:25 +00:00
Kateryna Prokopenko 6b831e3f67 Retype incorrect types from UrlString to RawPathString 
Bug: 1253323
Change-Id: Ie1c0504db44583b39d3c9df4cb971e573f6d332f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3229762
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2021-10-19 09:36:51 +00:00
Kateryna Prokopenko 6cb5aade43 Remove casts to UrlString from PlatformFileSystem 
Bug: 1253323
Change-Id: Ib1ba79a859cee257a1b88069506f0ec0745e3cd1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3220642
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-10-14 12:31:17 +00:00
Kateryna Prokopenko e8dd4366cd Remove casts to UrlString from IsolatedFileSystem 
Bug: 1253323
Change-Id: I6ba5af6be48dc09be14d2e623fc58d78ce7ea4ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3220641
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2021-10-14 11:10:57 +00:00
Kateryna Prokopenko 57b140e9e9 Rename and use type-safe argument and return type 
for (previously) urlToPlatformPath

Bug: 1253323
Change-Id: I667d26e266146d110cf3696b66096487a37f38f8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3217629
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2021-10-13 09:42:02 +00:00
Kateryna Prokopenko 732e0dba6b Rename and use type-safe argument and return type for (previously) platformPathToURL 
Bug: 1253323
Change-Id: I3e68f083971d47e90dbb1fcfb3798d283924a0c6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3217628
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2021-10-13 09:00:14 +00:00
Jan Scheffler f48d9074d5 [Underscore Migration] Migrate models/persistence 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

Bug:chromium:1207342
Change-Id: I59012578cbd78ff062ce9390c4434334c29280d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3077898
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-07 14:12:06 +00:00
Alex Rudenko 7332106189 Tighten types that i18n library accepts 
With this CL, only string|boolean|number are allowed.

Bug: chromium:1224278
Change-Id: I1c33c1f628882b2d591283ba90e0b32024533cff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2988311
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-07-06 07:33:36 +00:00
Jan Scheffler 3d889a2069 [Underscore Migration] Prework on Progress.ts 
This patch renames Progress.worked to Progress.incrementWork
to better convey what it does.

Bug:chromium:1207342
Change-Id: I48088bf7cce017ba4899729ea8fa7a9a8f51c0e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2969424
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
 2021-06-17 15:52:58 +00:00
Tim van der Lippe fca98ed75d Move text_utils to models/text_utils 
R=jacktfranklin@chromium.org

No-Presubmit: true
Bug: 1187573
Change-Id: I53965f7fac3f0f932ebb73fb0e38d28831451532
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2815016
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-08 16:07:22 +00:00
Tim van der Lippe 22d1903d32 Move persistence to models/persistence 
R=jacktfranklin@chromium.org

Bug: 1187573
Change-Id: I890a9fceb3441a8377c90faf47fb94d80d9f9398
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2815014
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-08 15:33:22 +00:00