zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-30 01:43:36 +08:00
Code Issues Packages Projects Releases Wiki Activity
15,004 Commits 43 Branches 79 Tags
bf8e3bda617e1cc98c2daf33ef8868bbfd019521
Commit Graph
12 Commits
Author SHA1 Message Date
Jack Franklin fd72c071cc Enforce alignment of JSDoc comments 
This CL adds the eslint-plugin-jsdoc plugin and enables just one rule,
`jsdoc/check-alignment`, which ensures that all the lines in a comment
are correctly aligned. For example:

```
/**
* foo
 * bar
*/
```

Would fail the check and be corrected to:

```
/**
 * foo
 * bar
 */
```

DISABLE_THIRD_PARTY_CHECK=deliberate install + use of
eslint-plugin-jsdoc node_module

Bug: none
Change-Id: I969983cd550653654a334ede3409b8c850467245
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4110906
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-12-21 12:30:47 +00:00
Kateryna Prokopenko 684d26dccd Type all path and URL variables in models/persistence to Branded Types 
Bug: 1299776
Change-Id: I7fa3cc202a2d230e6fbde6c0472ab6750012fa49
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3542251
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-03-28 12:00:19 +00:00
Kateryna Prokopenko ac21da4db6 Type path in createFile as EncodedPathString 
Bug: 1253323
Change-Id: Icc520f383e032a8a6be8cbaffded2d2896ac4d37
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3470238
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-03-14 13:04:15 +00:00
Kateryna Prokopenko 43b58939ab Remove casts to EncodedPathString from ScriptSnippetFileSystem 
Bug: 1299786
Change-Id: I8b874211d44bc203391819a4653447a67b8c2fe1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3470236
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-03-14 09:33:46 +00:00
Kateryna Prokopenko 8458f0d859 Remove casts to UrlString from IsolatedFileSystem 
Bug: 1253323
Change-Id: If6086cef3428d5388430a367ef29e6e289c5b697
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3420338
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-02-16 08:03:01 +00:00
Kateryna Prokopenko 3671fa6556 Fix path encodings 
Bug: 1253323
Change-Id: Iefa0517bb39d2f000f5abf1f184887325702c52a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3344916
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-02-14 08:10:56 +00:00
Kateryna Prokopenko cae13bb94a Remove all DevToolsPath types as some of them might be incorrect 
In order to avoid additional difficulties when typing paths in DevTools
discard the previous (possibly incorrect).

Bug: 1253323
Change-Id: Id4076900a44e9f06440cbfb4b99bed90f1ceb1f0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3297832
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2021-11-24 08:51:25 +00:00
Kateryna Prokopenko 6cb5aade43 Remove casts to UrlString from PlatformFileSystem 
Bug: 1253323
Change-Id: Ib1ba79a859cee257a1b88069506f0ec0745e3cd1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3220642
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-10-14 12:31:17 +00:00
Kateryna Prokopenko e8dd4366cd Remove casts to UrlString from IsolatedFileSystem 
Bug: 1253323
Change-Id: I6ba5af6be48dc09be14d2e623fc58d78ce7ea4ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3220641
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2021-10-14 11:10:57 +00:00
Jan Scheffler f48d9074d5 [Underscore Migration] Migrate models/persistence 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

Bug:chromium:1207342
Change-Id: I59012578cbd78ff062ce9390c4434334c29280d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3077898
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-07 14:12:06 +00:00
Tim van der Lippe fca98ed75d Move text_utils to models/text_utils 
R=jacktfranklin@chromium.org

No-Presubmit: true
Bug: 1187573
Change-Id: I53965f7fac3f0f932ebb73fb0e38d28831451532
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2815016
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-08 16:07:22 +00:00
Tim van der Lippe 22d1903d32 Move persistence to models/persistence 
R=jacktfranklin@chromium.org

Bug: 1187573
Change-Id: I890a9fceb3441a8377c90faf47fb94d80d9f9398
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2815014
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-08 15:33:22 +00:00