Commit Graph
2 Commits
Author SHA1 Message Date
Yang Guo 23dd4bcf0e Reduce uses of cursor: pointer
DevTools UI should behave like browser UI. Therefore interactive UI
elements should not need to change the mouse cursor to a hand with
pointing finger.

In particular, this CL removes `cursor: pointer` for

 - toolbar icons
 - buttons
 - panel tabs (vertical and horizontal)
 - issues hint icon
 - computed styles
 - Trust token delete button
 - adorners
 - data grid header for sorting
 - code folding marker in CodeMirror
 - animation previews
 - DOM tree guttor '...' menu
 - elements bread crumbs overflow buttons
 - color blocks in CSS Overview
 - device preset bars
 - devices list items
 - network request header and payload views
 - Media panel
 - delete buttons for watch expression and event listeners

Bug: 1291516
Change-Id: I182c43a43b94de31d1d8f2db4cd7831e82c535bb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3447411
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
2022-02-11 12:29:34 +00:00
Jack Franklin 6697bbd492 [CSS Migration] migrate TrustTokensView
There were two parts to this file:

1. Create `trustTokensView.css` which houses the main styles.
2. The delete button needs to be its own stylesheet due to the fact
   that it gets rendered from within the data grid (e.g. in a
   different shadow DOM) so I pulled that out into its own component.

I also discovered the ESLint component naming rule breaks with
multiple components in one file which I'd like to fix, so I've
disabled the rule and filed a bug for that.

Additionally there was no component doc for the TrustTokensView
component so I added one.

Bug: 1106746, 1226741
Change-Id: Ia1e79adff77c831adec5a28331f9019176ef9977
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3008035
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-07-06 15:22:16 +00:00