Commit Graph
7 Commits
Author SHA1 Message Date
Jack Franklin 603f51d19e Remove UNIFIED_TOOLBAR variant.
The work to build a new unified toolbar has been deprioritised and no
one is using this variant, so let's remove it to avoid confusion. We can
always restore it in the future if we need to.

Bug: none
Change-Id: I7a6c8f1f9b7e66b509fa4ef08c30186b06d9949d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4037665
Commit-Queue: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
2022-11-18 14:03:34 +00:00
Jack Franklin 98adbb535c Add temporary UNIFIED_TOOLBAR variant to Button
The new toolbar's icons are 16px, not 18px (temporarily until we roll
out new icons), and as such we unfortunately need a new variant within
the Button component.

Bug: 1344101
Change-Id: I5a3ffb54971ac8ddeaa3f899aceb0c69b89b3d2c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3757652
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2022-07-13 11:31:16 +00:00
Alex Rudenko 351e6f2956 Improve integration of the Button component with forms
By using the formAssociated property and internals API,
we can properly handle buttons which are part of the form
including implicit form submissions.

Bug: none
Change-Id: Iace39464a972671ebedcc407850ed8e08111266e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3301381
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-11-25 10:05:04 +00:00
Alex Rudenko 1bef13ab30 Implement disabled state for buttons
This CL implements disabled state for the standard
buttons according to the design spec.

Screenshot: https://i.imgur.com/RzdbcbN.png
Bug: none
Change-Id: I59cc06ed38a156194ddee54828aeec43f481139f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3229503
Reviewed-by: Peter Müller <petermueller@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2021-10-19 10:53:42 +00:00
Alex Rudenko e6ba35247d Button: add a toolbar button
This CL implements a toolbar button that is a square
icon only button to be used in toolbar contexts. Drive-by: fixes
the wrong 25px height that was a Figma problem.

Screenshots: https://imgur.com/a/XqmpBEm
Bug: none
Change-Id: I91763c2bc997e709c56db8cc6c821fc909abff86
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3211732
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-10-15 06:56:52 +00:00
Alex Rudenko 1a41fb4faf Button: implement button sizes
Currently, we only have two sizes: medium and small.

Screenshot: https://i.imgur.com/aCsYDi7.png
Bug: none
Change-Id: Id7c05d3bb98aa1a12bea065f860bc0d18cf55fba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3195732
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Peter Müller <petermueller@chromium.org>
2021-09-30 10:12:52 +00:00
Alex Rudenko e4465d16bf Create Button component
This component wraps around a <button> element and implements
common DevTools styles for primary and secondary buttons as
well as a button with an icon and text. Hover/focus/pressed
states are still in progress in the designs and the component
will be updated in the follow-ups to include those styles.

Screenshot: https://i.imgur.com/5EHND1v.png
Bug: none
Change-Id: Id0d11e49e678e1de007025b548fa1357f86ba8f2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3071224
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Peter Müller <petermueller@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2021-08-09 14:12:06 +00:00