Weizhong Xia
83e600431e
Move devtools generic baselines back to test folder
...
This is to align with change at web_tests side. Now generic baselines
are put side to side to the tests.
Bug: 1299834
Change-Id: I13f70725a1d50d94b3fd1689c02edf0be7d91649
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3864001
Commit-Queue: Weizhong Xia <weizhong@google.com >
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org >
2022-08-31 17:48:58 +00:00
Simon Zünd
36c54939b9
[web tests] Move expected files to the new location
...
Expectation files moved upstream in Chromium so we also have to
mirror the new structure in DevTools.
R=alexrudenko@chromium.org
Bug: None
Change-Id: I934d40bf371c3155ff013d3fc3be59ff734ce51e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3643856
Commit-Queue: Simon Zünd <szuend@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
2022-05-12 10:41:03 +00:00
Tim van der Lippe
d8c23debbe
Fix clang-format configuration
...
The configuration was only including files that were in a commit diff.
This causes issues where we generate sources during the PRESUBMIT (which
are not in the git diff at that point in time) and don't format.
At the same time, we remove the complicated logic to reuse the
`.eslintignore` for clang-format purposes and use the correct
`.clang-format` "DisableFormat" options to disable formatting in various
directories.
Roll CodeMirror: ignore
Change-Id: I21b95a6e09c5d6bf036bf1aace103d6c26823ecc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2091445
Reviewed-by: Changhao Han <changhaohan@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2020-03-06 12:06:33 +00:00
Tim van der Lippe
05361f5ce9
Reland "Let console asserts show up in the test results"
...
This reverts commit 647f5e462f .
Reason for revert: Failing assertions have been added to test expectations
Original change's description:
> Revert "Let console asserts show up in the test results"
>
> This reverts commit 1320cca621 .
>
> Reason for revert: Blocks the roll currently by causing layout
> tests to fail on Mac OS:
> https://ci.chromium.org/p/chromium/builders/try/mac-rel/262024
>
> Failing layout test:
> https://test-results.appspot.com/data/layout_results/mac-rel/262024/webkit_layout_tests%20%28retry%20shards%20with%20patch%29/layout-test-results/results.html
>
> Original change's description:
> > Let console asserts show up in the test results
> >
> > Change-Id: I73c74000df80a1b46c31d35fd29c7fea0a9142bb
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1962365
> > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
> > Reviewed-by: Simon Zünd <szuend@chromium.org >
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
>
> TBR=szuend@chromium.org ,tvanderlippe@chromium.org
>
> Change-Id: I70b7e10ddfac7eafa61599181f5103c84ace6a4d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1971410
> Reviewed-by: Simon Zünd <szuend@chromium.org >
> Commit-Queue: Simon Zünd <szuend@chromium.org >
TBR=szuend@chromium.org ,tvanderlippe@chromium.org
Change-Id: I33d08cf54dd0b414a6bc59703ee9dec238d31292
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1971415
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2019-12-17 10:41:08 +00:00
Simon Zünd
647f5e462f
Revert "Let console asserts show up in the test results"
...
This reverts commit 1320cca621 .
Reason for revert: Blocks the roll currently by causing layout
tests to fail on Mac OS:
https://ci.chromium.org/p/chromium/builders/try/mac-rel/262024
Failing layout test:
https://test-results.appspot.com/data/layout_results/mac-rel/262024/webkit_layout_tests%20%28retry%20shards%20with%20patch%29/layout-test-results/results.html
Original change's description:
> Let console asserts show up in the test results
>
> Change-Id: I73c74000df80a1b46c31d35fd29c7fea0a9142bb
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1962365
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
> Reviewed-by: Simon Zünd <szuend@chromium.org >
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
TBR=szuend@chromium.org ,tvanderlippe@chromium.org
Change-Id: I70b7e10ddfac7eafa61599181f5103c84ace6a4d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1971410
Reviewed-by: Simon Zünd <szuend@chromium.org >
Commit-Queue: Simon Zünd <szuend@chromium.org >
2019-12-17 08:44:58 +00:00
Tim van der Lippe
1320cca621
Let console asserts show up in the test results
...
Change-Id: I73c74000df80a1b46c31d35fd29c7fea0a9142bb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1962365
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2019-12-16 16:28:37 +00:00