- Add Performance panel to node_app & js_app, and put behind experiments
How to test (this CL needs to be tested with the parent CL):
1) run `deno run --inspect-brk --allow-read --allow-net https://deno.land/std@v0.50.0/http/file_server.ts`
2) Open devtools and then click the green icon at top-right corner. Or go to chrome://inspect and click "inpect" or " Open dedicated DevTools for Node".
3) Click the three-dot menu at the top-right corner, and choose the "More tools" > "Performance"
4) Record in "Performance" tab
Bug: 1362840
Change-Id: Idac53a90016bbdd7ff1dfd093c715caf659b2c4a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3892770
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
This CL does a couple of things to preserve the current behavior:
- It folds `node_main` into `node_app`, since we no longer require that
distinction (this was only required prior where we used `autostart` for
`node_main`, which we no longer do)
- It removes as much side-effect instantiation from various modules and
moves them into `node_app.ts`. The order is a bit awkward, but the calls
at the end of `node_app.ts` is the order of side-effect calls as it
exists currently. After we cleaned up all entrypoints, we can remove
some of the calls and clean it up further, but let's keep them here
explicitly to ensure we retain existing behavior.
- Folds `node_app-meta.ts` into `node_app.ts` for simplicity
- We now roll up everything into `node_app.ts` directly, rather than
having a separate meta script. Since this is an entrypoint, we can do
that here. Since the entrypoint will always eagerly load, we don't need
an explicit difference between the meta file and the module
implementation.
R=jacktfranklin@chromium.org
Bug: 1127902
Change-Id: Ida1cee76ae04b3d590dcd16d0225f65852bce5a5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306499
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Andrés Olivares