This CL makes use of the BreakpointsView in order
to show breakpoints if the experiment is enabled, see:
'Enable re-design Breakpoint Sidebar Pane in the Sources
Panel'
How to reproduce:
* Enable experiment
* Navigate to Sources Panel
* Set a breakpoint in a source file
Limitations:
Currently all interaction within the panel are not
forwarded to the internal logic. This CL is only
for showing the new pane.
Drive-by: CSS padding fix
Before/After: https://imgur.com/a/mKKOvYs
Doc: https://bit.ly/3pa4y92
Bug: 1346231, 1324904
Change-Id: Ia209b6d395e79a47696c659ad14eff3076cf5541
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3858290
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
This CL removes the contentEncoded property from ContentProvider. The
information is redundant and already contained in the content that is
provided.
Drive-by: Simplify the content provider implementation in Script.
Bug: none
Change-Id: I99749a2000c353aabfb894b1bcb6a334f0be9bd7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3802968
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Content type includes whether the script is from source maps,
so this is sufficient to prevent a script from source maps from
conflicting with a deployed script.
ID for deduplication is now distinct from url for history tracking,
as we may want the former to change when updating the content but
not the latter.
Bug: 1335076
Change-Id: I72d916045b40adb999dccbe87f1c5a69feb1ee98
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3698000
Reviewed-by: Victor Porof <victorporof@chromium.org>
Commit-Queue: Victor Porof <victorporof@chromium.org>
- adds a menu item to change the sources tree layout to group
authored content from source maps under a separate subtree
to make it easier to find sources likely to be of interest
- default remains unchanged
- legacy Treeoutline now supports new Icon component so that
new icons do not need to be added to legacy icon sheets
- lays groundwork for future changes to script identity for
source deduplication, as we may now need to deduplicate
sources in the tree view that would previously only have
been deduplicated when opening source tabs
Bug: 960909
Change-Id: I2fcee95eb5cb1da5a7725301e72e67df42bf3f11
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3653566
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Victor Porof <victorporof@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
One can change the file type of a file in the local overrides folder by
renaming the file. Such a rename can cause a different viewer to be
more appropriate for handling this file (e.g. when renaming a html-file
into a jpg, the file should now be handled by an image viewer). This CL
makes sure that in this scenario, the existing editor tab is closed and
a new one with an editor of the correct type is opened.
Unsaved changes in the file are not lost and it is ensured that there
is no unnecessary dialog popping up with a warning about external
changes to the file.
Bug: 1297532
Change-Id: I95098e15455c2ca328be00515941fe0950e5e3e0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3468521
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
This changes updates the Linkifier with an option to include the column
number in the link text if available. Also taking the opportunity to
remove some run-time type checks that are no longer needed thanks to the
TypeScript migration.
Including the column number in source links helps developers who are
looking at a performance profile "offline" find the function that was
called within the source file. When only a line number is given, this
is more difficult, especially for minified JavaScript files where there
may be many function definitions on the same line.
Bug: 1252049
Change-Id: I1e33583010c8f5d62789e4341ca5b4f6b2c9cd58
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3176625
Commit-Queue: Brandon Walderman <brwalder@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Kim-Anh Tran