Wolfgang Beyer
b2da5bb358
Allow removal of entries from UMA enums
...
`recordEnumeratedHistogram()` needs both the actual bucket and the total
number of buckets. The total number of buckets was previously determined
by `Object.keys(someMap).length`. This prevented us from ever removing
keys from `someMap` since its length would change.
By explicitly adding a `LastValidEnumPosition` we can now safely remove
keys.
Bug: 1278403
Change-Id: Ib256fc2cf54123f596aa9c5525cce2aabe28bec0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3329541
Reviewed-by: Simon Zünd <szuend@chromium.org >
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org >
2021-12-21 08:42:54 +00:00
Jan Scheffler
d5bf879558
[Underscore Migration] Migrate entrypoints
...
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.
Bug:chromium:1207342
Change-Id: Iec114859ae3f46457bafa2d823e11add202c6eb2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3077887
Commit-Queue: Jan Scheffler <janscheffler@chromium.org >
Auto-Submit: Jan Scheffler <janscheffler@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2021-08-07 15:52:16 +00:00
Kriti Sapra
56daf78ddb
Updated no-multiple-empty-lines to only have 1 as max
...
DISABLE_THIRD_PARTY_CHECK=updated linting formatting
Bug: 1106746
Change-Id: I371bca95b7cf1e8b7eaa4f9e7c3860af4eedee3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3057042
Commit-Queue: Kriti Sapra <kritisapra@google.com >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
2021-07-28 14:10:15 +00:00
Sigurd Schneider
6fdf2da9db
Teach check_experiments.js to recognize Root.Runtime.ExperimentName
...
This modifies check_experiments.js such that it recognizes the use
of Root.Runtime.ExperimentName enum members, e.g. it allows to
write
Root.Runtime.experiments.register(
Root.Runtime.ExperimentName.LOCALIZED_DEVTOOLS,
'Enable localized DevTools');
Bug: chromium:1226082
Change-Id: Iac0bd394a739562df7e7ce0b06f0a8ede3fdfbd7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3003255
Commit-Queue: Sigurd Schneider <sigurds@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2021-07-05 14:31:23 +00:00
Christy Chen
ab9a44d9de
Fix devtools experiment UserMetrics and presubmit check
...
There are missing entries for DevTools experiment in the UserMetrics emun, and the presubmit check has been broken so the issue didnt get caught.
This CL fix the DevTools experiment userMetrics and presubmit check
Bug: 1226082
Change-Id: I881a846b3d988746fb96ffd91eb16789198c2e3a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3002943
Reviewed-by: Sigurd Schneider <sigurds@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Sigurd Schneider <sigurds@chromium.org >
2021-07-05 13:19:15 +00:00
Jan Scheffler
b4eb22da3a
[JSDOC2TS]: Migrate main
...
Bug: chromium:1158760
Change-Id: Ibe9b0fe480794bb788253a3b9902d4cc42a5ca2e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2789347
Commit-Queue: Jan Scheffler <janscheffler@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2021-04-05 21:15:07 +00:00
Tim van der Lippe
e0247311ec
Move host to core/host
...
R=aerotwist@chromium.org
No-Presubmit: true
Bug: 1187573
Change-Id: I836c98bbd5b05f4595e28cedfaf957a6f47c7807
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2799755
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2021-04-01 15:00:23 +00:00
Jan Scheffler
9aca8c7402
[JSDOC2TS]: Migrate host
...
Bug: chromium:1158760
Change-Id: I86a4477d44617adac598f107755fbd3db49d7bf2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2718291
Commit-Queue: Jan Scheffler <janscheffler@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2021-02-26 17:18:55 +00:00
Brandon Goddard
331043706c
Add Presubmit for Devtools Experiment Telemetry
...
This CL adds a new Presubmit check that ensures that all devtools
experiemnts that are registered in MainImpl.js are also placed
in the UserMetrics.js file so that they have telemetry registered.
Explainer:
https://docs.google.com/document/d/1pcvN11C4onSXqOE0dTjUUHodMj55bRVl_5_e3kMg_rs/edit?ts=5f2329dc#heading=h.ezo3vjjctj8w
Bug: 1107636
Change-Id: If7ca22ef641b037717b808b7c57cc57c6f502536
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2341797
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com >
Reviewed-by: Kalon Hinds <kahinds@microsoft.com >
Reviewed-by: Peter Marshall <petermarshall@chromium.org >
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com >
2020-08-13 16:10:50 +00:00
Wolfgang Beyer