zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 12:33:47 +08:00
Code Issues Packages Projects Releases Wiki Activity
11,144 Commits 43 Branches 79 Tags
c976246734afddd6fbc35ae93ea4a004f642d678
Commit Graph
1123 Commits
Author SHA1 Message Date
Mathias Bynens 4c6e92b7b8 Avoid collapsing inline tag whitespace 
This patch ensures we collapse spaces between DOM nodes
into a single space rather than removing the space entirely.
This prevents issues with missing spaces in UI text, and
generally makes the HTML minification step more safe.

Bug: chromium:1264791
Change-Id: Ib8dfaa58e973ee8682a1f43226db9f9483d9606b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252958
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2021-10-29 12:24:12 +00:00
Tim van der Lippe b1953da009 Do not include generated CSS files in code coverage report 
These are auto-generated and we don't need to know the code coverage for
these files.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Ieaaed88a3752a755e4f5e30495e38434330c7263
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3222663
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-14 10:46:49 +00:00
Tim van der Lippe 286bd5c44a Stop renaming properties in comments 
This can break automation such as the localization collection script and
the license headers, as these are sensitive to specific references in
the comments themselves. It is probably safer to not change any of the
comments anyways.

R=jacktfranklin@chromium.org

Bug: 1222126
Change-Id: Ib5223559abc215dee0f4ac16b3a3269ee827702c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3219238
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-13 11:48:33 +00:00
Tim van der Lippe 7008714d9a Add bash script to automate more tasks 
To make sure we always perform the replace and to format automatically,
as well as making sure that the build actually works.

R=jacktfranklin@chromium.org

Bug: 1222126
Change-Id: I83d44282024f9ffa33a345e05b8c1a5c48923068
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3219235
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-12 16:27:10 +00:00
Tim van der Lippe 0404c7edc0 Automatically replace delete statements for private class fields 
Delete statements are disallowed for private class fields. Previously, I
used regexes to replace these, but we can implement it safely in the
migration script itself.

R=jacktfranklin@chromium.org

Bug: 1222126
Change-Id: Icab2cdaca290d40ea7d50710209cc84ea27208ba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3219231
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-12 15:55:27 +00:00
Mathias Bynens b1b64fc1be Fix broken paths in NativeFunctions.js generator 
`scripts/javascript_natives/index.js` expects `NativeFunctions.js` to
reside at a specific path, and broke when a CL [1] moved it to another
location, and broke (in another way) when the DevTools front-end
codebase moved to a separate repository. Similarly, the script expects
a Chromium checkout at a specific location relative to itself, which
hasn’t been correct since the DevTools front-end codebase moved to a
separate repository.

This patch updates the expected locations, but does not re-generate
the output since the script requires additional follow-up fixes.

[1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2814662

Bug: chromium:1255619
Change-Id: I066fb4349f045df5a12edd1378d7acdaa733a61b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3201677
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2021-10-08 12:40:54 +00:00
Tim van der Lippe 59f68132b1 Make lighthouse_worker a proper entrypoint 
This entrypoint was still being copied over, due to techdebt we
had before. The techdebt has since been removed, so we can now
properly use `devtools_{module,entrypoint}` to process these files.

R=jacktfranklin@chromium.org

Fixed: 1248392
Change-Id: I8c7394c62c21b9b73e259fd9206510c92203ad0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3158384
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-04 16:25:42 +00:00
Tim van der Lippe e2c9f764dd Add migration script for private class fields 
To make sure we track it somewhere. I already tested the script
on `sdk/`, and the script is also based on the earlier scripts
that Jan used during the underscore migration.

R=aerotwist@chromium.org

Bug: 1222126
Change-Id: I50589f6ae4084322f04c49ef81d2bc88d2ca2544
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3201674
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-10-04 12:34:45 +00:00
Jack Franklin fc6226b017 Update Rollup and terser 
This pulls in the bugfix for mangling private class fields
reported in https://github.com/terser/terser/issues/1067

DISABLE_THIRD_PARTY_CHECK=Fix rollup config
R=jacktfranklin@chromium.org

Bug: 1222126
Change-Id: I77a1ddc3697498829e595cead728479e81e7889c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3158385
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-09-21 12:28:03 +00:00
Kriti Sapra afc5528f54 Added line in css generating script to say the file is auto generated 
Bug: 1106746
Change-Id: I7452b10640b0f0efaf273f1c950190d6b2a45008
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3164343
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kriti Sapra <kritisapra@google.com>
 2021-09-17 07:39:56 +00:00
Jack Franklin d9172b6d0c Reland "Add mocha-fgrep flag to run_test_suite.js" 
This relands the original change with a fix to avoid the issue where
we'd run Mocha with `--fgrep=undefined`, causing no tests to run...

Bug: none
Change-Id: I4df53a935fe5c4359e5c35f56db4f9c133e7603f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3162062
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-09-15 16:04:20 +00:00
Jack Franklin 634ddfed43 Revert "Add mocha-fgrep flag to run_test_suite.js" 
This reverts commit 348a89db15.

Reason for revert: broke interaction and e2e test runs

Original change's description:
> Add mocha-fgrep flag to run_test_suite.js
>
> This CL adds the ability to filter the tests via Mocha's `fgrep` flag,
> giving us the ability to run a subset of the tests if we wish in the
> future.
>
> Fixed: 1249000
> Change-Id: I3379f6f0f60fc97d8af6b019761cfb31dda8afd2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3162297
> Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>

Change-Id: Ie1e1999f60f3b144665083e0103a786cfb22906e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3162060
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2021-09-15 14:35:50 +00:00
Jack Franklin 348a89db15 Add mocha-fgrep flag to run_test_suite.js 
This CL adds the ability to filter the tests via Mocha's `fgrep` flag,
giving us the ability to run a subset of the tests if we wish in the
future.

Fixed: 1249000
Change-Id: I3379f6f0f60fc97d8af6b019761cfb31dda8afd2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3162297
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-09-15 11:53:07 +00:00
Tim van der Lippe 8fc2d46d56 Update types and typescript packages 
- Update all `@types` packages to the latest version
- Updates TypeScript to 4.4.3

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Ia6482e6d53428f962cec2561823d2db66631f4e8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3158342
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-09-13 15:44:39 +00:00
Tim van der Lippe fe1b426acc Update Istanbul packages and configuration 
- Update istanbul-lib-instrument (breaking change is not affecting us)
- Explicitly update @istanbuljs/schema to 0.1.3. This directly instructs
Babel to accept top-level await. As such, we can remove our special
configuration for our `ui/components/docs` folder, which we can now
safely preprocess.

DISABLE_THIRD_PARTY_CHECK=Karma fix
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I0e96dce0117550f1a2db6a93654d8862d9cae95a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3158226
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-09-13 14:22:17 +00:00
Tim van der Lippe a66194127a Update linter packages 
- Update ESLint
- Update typescript-eslint
- Update eslint-plugin-import
- Update Stylelint standard config

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=ESLint fix

Bug: none
Change-Id: Ic1efac8b4f7b085b8f2b792a76b8b99b9f583da3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3158225
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-09-13 13:34:28 +00:00
Tim van der Lippe 61fe685814 Update various test packages 
- Update Sinon (breaking change does not affect us)
- Update Mocha
- Update Karma

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Ieb50ba55ce7a9e01e32ee553a6741e6323fcaaab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3158223
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-09-13 12:55:26 +00:00
Simon Zünd fda9300884 Upgrade TypeScript to 4.4.2 
DISABLE_THIRD_PARTY_CHECK=Upgrade requires some compatability changes
R=tvanderlippe@chromium.org

Fixed: 1247593
Change-Id: I78ffad8d969e043952555cac813ac803f2561bb5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3147890
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-09-13 06:41:11 +00:00
Jack Franklin cbd5ee57f9 Add ESLint rule for enforcing {host: this} in LitHtml.render calls 
Bug: 1247969
Change-Id: I567dac5d9bb97f3b2b4de77a06e45d7e4cac6cbd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3150282
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-09-09 12:39:57 +00:00
Tim van der Lippe 8eade7fa60 Remove special-casing for utils 
Historically, we special-cased importing the legacy utils, as
Rollup would eagerly roll them up in a single bundle. However,
since then we changed the Rollup heuristic to always assume that
a different folder is a different entrypoint, including sub-folders.
As such, we are no longer including entrypoints of sub-folders in
parent folders.

However, utils was special-cased and was importing the direct files.
This normally isn't a problem, except for the fact that the
devtools_entrypoint of `ui/legacy:bundle` would now bundle the sources
of `ui/legacy/utils`, but wasn't rebuilding when it needed to.

Therefore, change the utils to a proper sub-folder and avoid the
special-casing. Since we no longer have a circular dependency
between the utils and `ui/legacy`, we can safely make this change.

The ESLint rule has also been updated to make sure we don't regress
in this area again.

R=victorporof@chromium.org

Fixed: 1148274
Change-Id: I020622c5790041d5f676bee2ef883ff0ece76695
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3148370
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Victor Porof <victorporof@chromium.org>
Reviewed-by: Victor Porof <victorporof@chromium.org>
 2021-09-08 14:34:10 +00:00
Kim-Anh Tran 9a4c4db18b [server] Add binary encoding for DWARF object+package files 
Bug: chromium:1245963
Change-Id: I4e7a61c404fdee794e35a51fd64261017b42e3c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3138079
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2021-09-07 08:56:53 +00:00
Jack Franklin 734befd5a7 Fix ESLint component naming check with multiple components 
This CL updates the check_component_naming rule to make it deal with a
file that has multiple components defined; something that would
previously cause the rule to fail and hence it was disabled in some
files.

Fixed: 1226741
Change-Id: I3eb282182c10e3faf120d6bcd2d0846667524861
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3141471
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-09-03 13:44:37 +00:00
Jack Franklin cc1f192ca1 Add autofix ability to static_custom_event_names ESLint rule 
Bug: chromium:1229172
Change-Id: I80d1fcb1432a79a0682ed92ff6335571a62bba55
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3122649
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-09-01 08:34:04 +00:00
Jack Franklin 392f476825 Fix check_component_naming rule when litTagName is not LitHtml.literal 
Fixed: 1241067
Change-Id: I4e5dbc68f874c27e5cd810e9ca3a47d1b671dff7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3121432
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-26 12:27:05 +00:00
Jack Franklin 6584d42b63 Add deprecated note to run_test_suite.py 
Bug: chromium:1186163
Change-Id: I03a271c232f1f4fdf9f33682d75520f39b593af1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3121429
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-08-26 11:16:14 +00:00
Jack Franklin 65832d9e01 ESLint rule for enforcing custom event name pattern 
This CL adds a rule (but does not enable it) for enforcing the custom
event names as discussed in this design doc:

https://docs.google.com/document/d/1UREbYIcjP9pZWW1mLase4uGDHmUNa1cQXkc3Mfw8nLI

Bug: chromium:1229172
Change-Id: I843cbe9bf172544e2b5b907991d6792d6033b5b8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3118371
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-25 14:54:25 +00:00
Jack Franklin 2b6063995b Fix path to locales file in component-server 
Bug: none
Change-Id: I7e47b1d8dc3ccafad980bcbae09d3083472a50a3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3110432
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-20 15:04:51 +00:00
Jack Franklin 2ef4d05706 [ComponentServer] load locale from sharedResourcesBase 
The locale is considered a shared resource, so when we load it we should
use the sharedResourcesBase argument that can be supplied when
instantiating the server.

Bug: none
Change-Id: Ic89b27bcd12b514e3efbef20a550062fcd871680
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3109847
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-08-20 13:21:17 +00:00
Sigurd Schneider 49556e02b5 Heuristically identify identifier types in CDP 
This CL uses a heuristic to classify identifier types:
If the type ends with Id or ID it is considered an
identifier type. The CL also introduces an override
in protocol_dts_generator.ts which can be used to
add more types, or disable the heuristic for specific
types.

DISABLE_THIRD_PARTY_CHECK=disable

Fixed: chromium:1226471
Change-Id: I4696463622ef026c48e1abeefd48aa438f9d11f6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3110425
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-20 13:12:48 +00:00
Sigurd Schneider 76240a3faa Type annotate IO.StreamHandle 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: Id7479a3d8d371bf5dbaac02a89d0d49de9ae0983
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3109532
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-08-20 12:18:58 +00:00
Tim van der Lippe 58df6650e1 Update timestamps for devtools_modules only 
The previous attempt was wrong, as it wasn't correctly rebuilding
dependents if a breaking TypeScript API change was made. The root
cause for that is the split of `devtools_entrypoint` and
`devtools_module`, which we need for bundling. Unfortunately, we
also can't introduce granular GN targets for only `.d.ts` files,
since TypeScript generates all outputs in 1 go. Therefore, it is not
possible to split that up into multiple scripts, which is required
if we want to introduce targets with outputs for only `.d.ts`.

Instead, we should still reset timestamps for `devtools_module`,
but then we always rebuild `devtools_entrypoint`. By doing that,
a breaking API change in a `devtools_module` would trigger its
corresponding `devtools_entrypoint` to change, which will ensure
that all its dependents also change. However, the next layer of
`devtools_module` will then detect that it doesn't change, hence
introducing the performance improvement.

So while we are still doing a bit too much work in theory, in practice
this change already removes a whole bunch of unnecessary work. I
think that is a step in the right direction and this should result
in deterministic builds as well.

DISABLE_THIRD_PARTY_CHECK=Update TypeScript infrastructure
R=jacktfranklin@chromium.org
CC=marijnh@gmail.com

Bug: 1237438
Change-Id: Ib8ea10ee8df263f0dddf0918bc1732fd696f1105
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3107130
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-08-19 15:04:34 +00:00
Sigurd Schneider 8cdc7310d3 Type annotate Runtime.RemoteObjectId 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: If9c171471a6b7320fbc2c09764b44faa5502d74c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3104558
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-19 14:23:34 +00:00
Sigurd Schneider 676c94480d Type annotate HeapProfiler.HeapSnapshotObjectId 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I4aa826df54644ded10c65d7ec80234826947455c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3104554
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-08-19 13:47:54 +00:00
Sigurd Schneider 14953ec447 Type annotate Debugger.CallFrameId 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I3c0ea9a7c6d500b66a274218a097a03151fdfd5e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3104551
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-08-19 10:35:31 +00:00
Sigurd Schneider 1259c0f055 Type annotate more protocol identifiers 
This CL type annotates
  Debugger.BreakpointId
  LayerTree.SnapshotId
  Page.ScriptIdentifier

DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I307a6a6705653c18ca2f5b4afa2ce83fe3ca9049
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3104549
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-08-19 10:17:43 +00:00
Sigurd Schneider 2a3e642670 Type annotate more protocol identifiers 
This CL adds type annotations for
  DOM.SnapshotId
  Runtime.ExecutionContextId
  Runtime.UniqueDebuggerId

DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I41ca383b6145351d238ba9ae7bf9a4182f502e84
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3103787
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-19 05:56:11 +00:00
Sigurd Schneider 171b7961d5 Type annotate ScriptId 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I22b69f920789a9eb0516de2bc86d0e05dd0454da
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3103235
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-18 15:40:31 +00:00
Sigurd Schneider a5dcab9a8e Type annotate Database.DatabaseId 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I3e03fdbf5de9e78135a90c07b9029735997011fb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3103233
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-08-18 11:55:54 +00:00
Kriti Sapra 2d85f889eb [CSS]: panels/network 
Bug: 1106746
Change-Id: Ia9a56e2a4e30308e474c323f473b3f63a68a993f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3097671
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-08-18 10:01:01 +00:00
Changhao Han 5b178291bc Disable flaky test in memory e2e tests 
Bug: chromium:1239550
Change-Id: I57010905189ac8233f42e1871b173d3d147f16b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3093153
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2021-08-13 17:31:50 +00:00
Sigurd Schneider 19b55237a3 Type annotate with Page.FrameId consistently 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I76ece085a7e448558f1f2553179c42b1188888d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3083710
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-13 17:28:44 +00:00
Philip Pfaffe ff75ee8dfe [deps] Update download_chromium after crashpad_handler got renamed 
Bug: none
Change-Id: Ia3cf276afcea276197ab45977dc6b3db4e3e2e87
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3085183
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2021-08-12 09:25:13 +00:00
Alex Rudenko f1182e24da Fix missing os import in run_test_suite.js 
Probably broken in crrev.com/c/3080314

Bug: chromium:1186163
Change-Id: I0478b7f137d80e1a1aad13e81579c1cc67b40cdf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3083705
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-08-10 07:01:00 +00:00
Sigurd Schneider b5657ef670 Type annotate with CSS.StyleSheetId consistently 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I1ad6cf3c9d21251b8719010319f6b4e1ba8f24f9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3080313
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-10 06:15:19 +00:00
Jack Franklin 841587771d [TestRunner] allow --node-modules-path to be multiple paths. 
Bug: chromium:1186163
Change-Id: I63a88cc94403983b1cead1d8ac54bc04469e1b03
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3080314
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-09 16:03:08 +00:00
Sigurd Schneider 02626e4afc Type-annotate ServiceWorker.RegistrationID consistently 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I0b0cfe44753123be4a4baa6142724d56b8166655
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3080315
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-09 15:15:47 +00:00
Jack Franklin 9f22436c08 Revert "[TestRunner] remove run_test_suite.py" 
This reverts commit 92000f342d.

Reason for revert: broke some places where we still rely on this script

Original change's description:
> [TestRunner] remove run_test_suite.py
>
> The CQ bots all run run_test_suite.js, and all our local `npm run X`
> scripts have run run_test_suite.js for many months now. I think we are
> now safe to remove the Python run_test_suite.py script, as all use cases
> are covered by the new JS runner.
>
> Bug: 1186163
> Change-Id: Ie8b5fd52e0934176a7da61d61fb9624b87ed764b
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3075181
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>

Bug: 1186163
Change-Id: I12505c1bc0c98c81b1de3c242f1ab7f234e6e06d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3080311
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2021-08-09 13:44:47 +00:00
Jack Franklin e716e01269 Allow run_test_suite.js not to run a server 
This CL updates run_test_suite.js to allow the user to explicitly pass
in `none` for the test server type, rather than currently where the
runner basically forces you to run either the hosted mode server or the
component docs server.

Bug: chromium:1186163
Change-Id: Ib01f31f3f7ccfb4956c0c42a8deed035454e0d84
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3080310
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-09 13:32:27 +00:00
Sigurd Schneider 16cc89e295 Consistently type Target.{SessionID,TargetID} 
This uncovered a bug where we used a targetID to as a sessionID,
which is fixed in this CL. The bug caused target information to
not get updated and the fix should increase target information
accuracy.

DISABLE_THIRD_PARTY_CHECK=<reason>

Bug: chromium:1226471
Change-Id: I89e461381443617d96ae06d5775038cd32ad8dd1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3080308
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-09 11:42:37 +00:00
Sigurd Schneider e195fd2829 Consistently type several protocol identifier types 
This CL ensures consistent typing for the following protocol
types:
  Browser.BrowserContextID
  Browser.WindowID
  LayerTree.LayerId
  Security.CertificateId

DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I42f27da00d20b428cce3ff1a7a53a3a397f36f39
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3080301
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-08-09 10:38:47 +00:00