zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-19 13:04:39 +08:00
Code Issues Packages Projects Releases Wiki Activity
3,465 Commits 45 Branches 79 Tags
ca9fa2d73f1b15c7bf558715decd8e132ceeec36
Commit Graph
8 Commits
Author SHA1 Message Date
Mathias Bynens ca9fa2d73f Consistently format CSS color and opacity values 
- Prefer the modern comma-free CSS color function syntax over the
  legacy syntax. [1]
- Explicitly use the `deg` suffix for angle values in colors, to
  clarify the range.
- Explicitly use the `%` suffix for percentages instead of formatting
  the value as a number, again to clarify the range.

[1]: https://twitter.com/mathias/status/1253242715304857601
[2]: https://goo.gle/devtools-css-color

Bug: chromium:1083142
Fixed: chromium:1073885
Change-Id: I8e1582a2dee3553a61df88564051ea84c2011d76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2209091
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
 2020-05-19 16:50:26 +00:00
Mathias Bynens b0c1f4bce2 Fix stylelint-config-standard violations 
Bug: chromium:1083142
Change-Id: I5ea4cc5d0f83e52856383ba37a47472e33eb19a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2204113
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-05-15 17:05:27 +00:00
Kham Udom e991071f67 High contrast work on Sources debugger panel 
The changes fixes the hover and and keyboard focus on the panel. The
header gets a focus ring and when hovering or focusing the content
item, the background and foreground changes.

Before: https://imgur.com/a/gZD8xLg
After: https://imgur.com/a/LVruJ6P

Bug: 1048378
Change-Id: If697639f8a5b7d73844e1aab63c9bb2db884b295
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2055546
Commit-Queue: Kham Udom <khamu@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-02-14 16:06:43 +00:00
Jack Lynch 7cd600f9d2 Reland: Make call stack keyboard navigable 
This is a reland of https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880515,
which was reverted at https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1961190
due to test failures that do not repro or appear to be related.

This PR makes the call stack sidebar pane in the Sources panel more
accessible by:
  - enabling keyboard navigation of the call frame list by managing call
  frame selection outside of ListControl as suggested by Joel in [2]
  - adding the aria-disabled attribute to unselectable call frames
  - adding an aria description to blackboxed call frames

This will break several web tests, so [3] must be merged first to
disable them.
Originally reviewed in [1], where the web test fixes for this CL now
live.

Video showing navigation: https://i.imgur.com/55tJy2k.mp4

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1715121
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1690089/11#message-3e9e158cce4628b01398d9cf84e37550b55b14c6
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1893117

Bug: 963183
Change-Id: I826e1c5c2f78c235823a71c956fde6ef73bcccac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1965855
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
 2020-01-13 23:13:35 +00:00
Simon Zünd 36acd549ae Revert "Make call stack keyboard navigable" 
This reverts commit 4c4f65cb9d.

Reason for revert: Suspected to causes layout tests to fail. Found via
a local bisect of the first failing roll CL: https://crrev.com/c/1961233
Example failure: https://ci.chromium.org/p/chromium/builders/try/linux-rel/264054 

Original change's description:
> Make call stack keyboard navigable
> 
> This PR makes the call stack sidebar pane in the Sources panel more
> accessible by:
>   - enabling keyboard navigation of the call frame list by managing call
>   frame selection outside of ListControl as suggested by Joel in [2]
>   - adding the aria-disabled attribute to unselectable call frames
>   - adding an aria description to blackboxed call frames
> 
> This will break several web tests, so [3] must be merged first to
> disable them.
> Originally reviewed in [1], where the web test fixes for this CL now
> live.
> 
> 
> Video showing navigation: https://i.imgur.com/55tJy2k.mp4
> 
> [1] https://chromium-review.googlesource.com/c/chromium/src/+/1715121
> [2] https://chromium-review.googlesource.com/c/chromium/src/+/1690089/11#message-3e9e158cce4628b01398d9cf84e37550b55b14c6
> [3] https://chromium-review.googlesource.com/c/chromium/src/+/1893117
> 
> Change-Id: I4b3f56fc300a2cd381798650c61afd1062430e57
> Bug: 963183
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880515
> Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
> Commit-Queue: Jack Lynch <jalyn@microsoft.com>

TBR=lomitch@microsoft.com,jalyn@microsoft.com

Change-Id: I3698f0eea8bcc00a092ce47eccb2d649169b8a32
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 963183
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1961190
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2019-12-11 09:02:14 +00:00
Jack Lynch 4c4f65cb9d Make call stack keyboard navigable 
This PR makes the call stack sidebar pane in the Sources panel more
accessible by:
  - enabling keyboard navigation of the call frame list by managing call
  frame selection outside of ListControl as suggested by Joel in [2]
  - adding the aria-disabled attribute to unselectable call frames
  - adding an aria description to blackboxed call frames

This will break several web tests, so [3] must be merged first to
disable them.
Originally reviewed in [1], where the web test fixes for this CL now
live.


Video showing navigation: https://i.imgur.com/55tJy2k.mp4

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1715121
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1690089/11#message-3e9e158cce4628b01398d9cf84e37550b55b14c6
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1893117

Change-Id: I4b3f56fc300a2cd381798650c61afd1062430e57
Bug: 963183
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880515
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
 2019-12-10 23:50:30 +00:00
Paul Irish 25e30d83df DevTools: Improved dark mode colors for blackboxing msg 
Change-Id: If3ca6a8deb29680e213e151ab7aa91ddec1c19e3
Reviewed-on: https://chromium-review.googlesource.com/1144449
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#576743}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e216c1974f9883e4408b65ac518976440f9d25fd
 2018-07-20 01:08:05 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2. 
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
 2018-04-07 15:32:37 +00:00