Commit Graph
9 Commits
Author SHA1 Message Date
Paul Lewis 4da3b30c38 Migrates css_overview/ to esm
Bug: 1006759
Change-Id: Idf78688fa354b7e169edd508667dd2e298eacea4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1928914
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2019-11-21 14:37:54 +00:00
Paul Lewis 7d10a733de [CSS Overview] Adds font info
Change-Id: Ia7ed1eccd6a3440e3dbf5b1e98b887ffdaf2b574
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1901387
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
2019-11-07 11:04:05 +00:00
Paul Lewis ed808ce4cf [CSS Overview] Updates UI
Change-Id: Ifdc7645399b9a5b8dd5d13c8d4dacaf8a67fc5bd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1899518
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2019-11-06 14:44:25 +00:00
Paul Lewis 8aef901f3f [CSSOverview] Add unused rules
This is the first pass at adding unused rules to the CSS Overview.
The CL adds support for checking width & height to inline elements
as well as position values to static elements. Further CLs will
add additional checks for other cases, e.g. the use of flex or grid
values against non-flex and non-grid elements respectively.

Change-Id: I2fb4fd557d67065a5753587624195920c22b3edc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1886818
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2019-10-29 14:36:57 +00:00
Paul Lewis 12bc63edcd [CSS Overview] Adds support for fill and border colors.
Change-Id: Iea5c20d1a7b6c3ae6673053e05ff52faee48e69f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1875709
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
2019-10-23 12:00:20 +00:00
Paul Lewis de0224ccdd [CSS Overview] Uses snapshot; adds element highlight
Change-Id: If58dd20c6f4b3c8f730b39c48c14826e402018a0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1873759
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
2019-10-23 09:55:00 +00:00
Paul Lewis ebc4719819 [DevTools] Adds media queries to CSS Overview
Bug: 1007284
Change-Id: I8c24adddf91da3bd621b61db6eac49233b8a1db4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849671
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#704192}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 193ed603a6eaec431f9d0f339f697ab03f99c838
2019-10-09 15:06:41 +00:00
Tim van der Lippe 1d6e57a0e3 Always add braces to single-line if-statements
The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.

This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.

Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9
2019-09-30 11:55:34 +00:00
Paul Lewis 8cddf9931f [DevTools] Adds CSS Overview Panel
Creates a panel that steps through the page to build statistics on CSS
used, such as colors, fonts, specificity, and other items of note.

Note: this is a DevTools experiment.

Bug: 1007284
Change-Id: Ib8d8b2af6bb65d6ff4816ca23b48b76980cd80db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806736
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#700745}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0e4a3c81f343d15e2121280d332659778ad07323
2019-09-27 16:40:07 +00:00