Tim van der Lippe
daf16278b1
Migrate persistence/ to ESM
...
- Rename Persistence.js to PersistenceImpl to avoid a name clash with
the namespace
Bug: 1006759
Change-Id: I330bd680c8a92984c4a75a0614efa78b4f1e1ea2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845715
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#704200}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c68c13c0d5c1a780340192be5d722dc7715b4bbc
2019-10-09 15:43:43 +00:00
Tim van der Lippe
1d6e57a0e3
Always add braces to single-line if-statements
...
The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.
This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.
Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Yang Guo <yangguo@chromium.org >
Reviewed-by: Jeff Fisher <jeffish@microsoft.com >
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9
2019-09-30 11:55:34 +00:00
John Emau
ade5e12529
DevTools: Add error messages to workspace settings
...
This change adds two error messages to the EditFileSystemView:
- When a user inputs a duplicate excluded folder path, show:
"Enter a unique path"
- When a user inputs an empty excluded folder path, show:
"Enter a path"
This meets ARIA WCAG 3.3.1 Error Identification and
3.3.3 Error Suggestion. See:
- https://www.w3.org/WAI/WCAG21/quickref/#error-identification
- https://www.w3.org/WAI/WCAG21/quickref/#error-suggestion
Note that the EditFileSystemView is only used by the Workspace settings
tab.
Screenshot: https://i.imgur.com/2W4dhpi.png
Bug: 963183
Change-Id: I57582ae536c34ecf9bdef8e8f80e422f663664f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688649
Commit-Queue: John Emau <johnemau@microsoft.com >
Reviewed-by: Joel Einbinder <einbinder@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#678873}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 637194282f814df711643259ce7f517e78a9b82b
2019-07-18 22:38:05 +00:00
John Emau
bdff85bff2
DevTools: Remove unnecessary tab stop on workspace mapping
...
Removed tabindex from EditFileSystemViews because the stop did not
provide any value after receiving focus.
WCAG 2.7.4 Focus order:
https://www.w3.org/WAI/WCAG21/quickref/#focus-order
NVDA screenshot of removed tab stop:
https://i.imgur.com/sskc4Ac.png
Bug: 963183
Change-Id: Iad7ea3e7a00f44478fbff080e747e110d4615e1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658631
Reviewed-by: Joel Einbinder <einbinder@chromium.org >
Commit-Queue: John Emau <johnemau@microsoft.com >
Cr-Original-Commit-Position: refs/heads/master@{#674321}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b4769fb4adc31f8b1a0b5bb66d17fb68d7cdcb86
2019-07-03 01:19:10 +00:00
Amanda Baker
ca50282159
DevTools: Provide error message for Devices Settings Pane (ListWidget)
...
This change provides the infrastructure to give the user an error
message whenever they enter invalid input into one of the fields of the
ListWidget.Editor.
It also provides the specific error message for the Devices Settings
pane.
Screenshot of error message dialogue: https://imgur.com/a/wD4akTa
This work was originally part of https://chromium-review.googlesource.com/c/chromium/src/+/1562830
Bug: 963183
Change-Id: Ie984366f5f85880cacaaeaea69f5187c5313ac6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629757
Commit-Queue: Amanda Baker <ambake@microsoft.com >
Reviewed-by: Joel Einbinder <einbinder@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#673884}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c346cec0ac5cf9dd2c32acdc44a16d241a9375dd
2019-07-02 00:01:28 +00:00
Blink Reformat
4c46d0969f
The Great Blink mv for source files, part 2.
...
Move and rename files.
NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true
Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org >
Commit-Queue: Blink Reformat <blink-reformat@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00
Tim van der Lippe
