Commit Graph
5 Commits
Author SHA1 Message Date
Tim van der Lippe 1d6e57a0e3 Always add braces to single-line if-statements
The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.

This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.

Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9
2019-09-30 11:55:34 +00:00
Joey Arhar a6abfa2519 [DevTools] Do not debug worker shadow pages
This change breaks pausing on start when inspecting a shared worker that
gets reloaded. More detail here: crbug.com/987024

Bug: 882467
Change-Id: I074b547996fd7f11d835fcebfdae32a4f7063a9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636110
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#685152}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5dc1be4c957563e073c462b39a934f23d02461d0
2019-08-08 12:23:00 +00:00
Sergey Poromov 47ac039a86 Revert "[DevTools] Await clearing methods in ClearStorageView"
This reverts commit fd3d8cadb7971e2934bd98130335d789398ac139.

Reason for revert: http/tests/devtools/indexeddb/live-update-indexeddb-content.js is flaky.

Findit suspects this CL to be the reason for the recent test flakiness. See the bug for more information.

Bug: 979503

Original change's description:
> [DevTools] Await clearing methods in ClearStorageView
> 
> Part 1 of adding garbage collection after clearing is done.
> 
> Change-Id: I7022c1d6d0d3c8cfabce7f57ba5f689c135b6395
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669175
> Reviewed-by: Erik Luo <luoe@chromium.org>
> Commit-Queue: Harley Li <hhli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#673083}

TBR=luoe@chromium.org,hhli@chromium.org

Change-Id: I5849695b3e5d2c3646303c2f49a801ffbc3ee15f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679704
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#673265}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5a63d041f4c585eaa540963686cc894a342e5de9
2019-06-28 09:28:22 +00:00
Harley Li 29943fa5b5 [DevTools] Await clearing methods in ClearStorageView
Part 1 of adding garbage collection after clearing is done.

Change-Id: I7022c1d6d0d3c8cfabce7f57ba5f689c135b6395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669175
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Harley Li <hhli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#673083}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fd3d8cadb7971e2934bd98130335d789398ac139
2019-06-27 22:13:31 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2.
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00